[Bug 1880701] Review Request: python-hangups - Python instant messaging client for Hangouts
https://bugzilla.redhat.com/show_bug.cgi?id=1880701 Andy Mender changed: What|Removed |Added Flags||needinfo?(mail@fabian-affol ||ter.ch) --- Comment #3 from Andy Mender --- Any updates on this ticket perhaps? :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1880701] Review Request: python-hangups - Python instant messaging client for Hangouts
https://bugzilla.redhat.com/show_bug.cgi?id=1880701 Bug 1880701 depends on bug 1880697, which changed state. Bug 1880697 Summary: Review Request: python-mechanicalsoup - Python library for automating interaction with websites https://bugzilla.redhat.com/show_bug.cgi?id=1880697 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1880701] Review Request: python-hangups - Python instant messaging client for Hangouts
https://bugzilla.redhat.com/show_bug.cgi?id=1880701 Bug 1880701 depends on bug 1880695, which changed state. Bug 1880695 Summary: Review Request: python-readlike - Readline-like line editing module https://bugzilla.redhat.com/show_bug.cgi?id=1880695 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1880701] Review Request: python-hangups - Python instant messaging client for Hangouts
https://bugzilla.redhat.com/show_bug.cgi?id=1880701 Bug 1880701 depends on bug 1880694, which changed state. Bug 1880694 Summary: Review Request: python-reparser - Simple regex-based lexer/parser for inline markup https://bugzilla.redhat.com/show_bug.cgi?id=1880694 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1880701] Review Request: python-hangups - Python instant messaging client for Hangouts
https://bugzilla.redhat.com/show_bug.cgi?id=1880701
--- Comment #2 from Andy Mender ---
All of the dependencies have been reviewed.
> BuildRequires: (python3dist(protobuf) >= 3.1 with python3dist(protobuf) <
> 3.12)
This fails on Fedora 33 and 34 (Rawhide), because the version in both is
already 3.12.6. Also, Fedora 32 ships python-protobuf 3.11.2:
Available Packages
Name : python3-protobuf
Version : 3.11.2
Release : 2.fc32
Architecture : noarch
Size : 590 k
Source : protobuf-3.11.2-2.fc32.src.rpm
Repository : fedora
Summary : Python 3 bindings for Google Protocol Buffers
URL : https://github.com/protocolbuffers/protobuf
License : BSD
Description : This package contains Python 3 libraries for Google Protocol
Buffers
I would recommend the following if possible:
> BuildRequires: python3dist(protobuf)
Then, the build succeeds:
https://copr.fedorainfracloud.org/coprs/andymenderunix/python-iot/build/1678713/
However, this output from fedora-review worries me a bit (see the protobuf
version restrictions):
> Requires
>
> python3-hangups (rpmlib, GLIBC filtered):
> (python3.9dist(aiohttp) < 4 with python3.9dist(aiohttp) >= 3.3)
> (python3.9dist(appdirs) < 1.5 with python3.9dist(appdirs) >= 1.4)
> (python3.9dist(async-timeout) < 4 with python3.9dist(async-timeout) >= 2)
> (python3.9dist(protobuf) < 3.12 with python3.9dist(protobuf) >= 3.1)
> (python3.9dist(requests) < 3 with python3.9dist(requests) >= 2.6)
> /usr/bin/python3
> python(abi)
> python3.9dist(configargparse)
> python3.9dist(mechanicalsoup)
> python3.9dist(readlike)
> python3.9dist(reparser)
> python3.9dist(setuptools)
> python3.9dist(urwid)
I reviewed the fixed version. Everything looks okay. However, before I approve
this, please have a look at the situation with protobuf to make sure that
python-hangups really is compatible with python-protobuf >= 3.12.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/
- Package must not depend on deprecated() packages.
Note: python3-pytest4 is deprecated, you must not depend on it.
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/deprecating-packages/
= MUST items =
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Expat License", "Unknown or generated". 34 files have unknown
license. Detailed output of licensecheck in
/home/amender/rpmbuild/SPECS/python-hangups/copr-build-1678713/review-
python-hangups/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description
[Bug 1880701] Review Request: python-hangups - Python instant messaging client for Hangouts
https://bugzilla.redhat.com/show_bug.cgi?id=1880701 --- Comment #1 from Andy Mender --- I'm going to review this one and the dependencies, and add them to the python IoT COPR project: https://copr.fedorainfracloud.org/coprs/andymenderunix/python-iot/packages/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1880701] Review Request: python-hangups - Python instant messaging client for Hangouts
https://bugzilla.redhat.com/show_bug.cgi?id=1880701 Andy Mender changed: What|Removed |Added Status|NEW |ASSIGNED CC||andymenderu...@gmail.com Assignee|nob...@fedoraproject.org|andymenderu...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1880701] Review Request: python-hangups - Python instant messaging client for Hangouts
https://bugzilla.redhat.com/show_bug.cgi?id=1880701 Fabian Affolter changed: What|Removed |Added Blocks||1269538 (IoT) Depends On||1880697, 1880694, 1880695 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1269538 [Bug 1269538] Tracker for IoT on Fedora https://bugzilla.redhat.com/show_bug.cgi?id=1880694 [Bug 1880694] Review Request: python-reparser - Simple regex-based lexer/parser for inline markup https://bugzilla.redhat.com/show_bug.cgi?id=1880695 [Bug 1880695] Review Request: python-readlike - Readline-like line editing module https://bugzilla.redhat.com/show_bug.cgi?id=1880697 [Bug 1880697] Review Request: python-mechanicalsoup - Python library for automating interaction with websites -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
