[Bug 1904739] Review Request: python-xbout - reading and analysing BOUT++ simulations
https://bugzilla.redhat.com/show_bug.cgi?id=1904739 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-12-31 02:02:42 --- Comment #8 from Fedora Update System --- FEDORA-2020-ce2431c598 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1904739] Review Request: python-xbout - reading and analysing BOUT++ simulations
https://bugzilla.redhat.com/show_bug.cgi?id=1904739 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System --- FEDORA-2020-ce2431c598 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-ce2431c598 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-ce2431c598 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1904739] Review Request: python-xbout - reading and analysing BOUT++ simulations
https://bugzilla.redhat.com/show_bug.cgi?id=1904739 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #6 from Fedora Update System --- FEDORA-2020-ce2431c598 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-ce2431c598 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1904739] Review Request: python-xbout - reading and analysing BOUT++ simulations
https://bugzilla.redhat.com/show_bug.cgi?id=1904739 --- Comment #5 from Andy Mender --- Awesome! Enjoy the package! Everything I need is usually in the repositories, but thanks :). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1904739] Review Request: python-xbout - reading and analysing BOUT++ simulations
https://bugzilla.redhat.com/show_bug.cgi?id=1904739 --- Comment #4 from david08...@gmail.com --- Thanks for both quick reviews :-) I have addressed the comments raise. Let me know if you need something reviewed in return. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1904739] Review Request: python-xbout - reading and analysing BOUT++ simulations
https://bugzilla.redhat.com/show_bug.cgi?id=1904739 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-xbout -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1904739] Review Request: python-xbout: reading and analysing BOUT++ simulations
https://bugzilla.redhat.com/show_bug.cgi?id=1904739
Andy Mender changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #2 from Andy Mender ---
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=56908762
> BuildRequires: python3-setuptools_scm_git_archive
> BuildRequires: python3-natsort
> BuildRequires: python3-dask+array
> BuildRequires: python3-netcdf4
> BuildRequires: python3-animatplot
> BuildRequires: python3-xarray
> BuildRequires: python3-pillow
> BuildRequires: python3-bout++
Python BuildRequires and Requires should use the format "python3dist(foo)".
> %package -n python3-%{pypi_name}
> Summary:%{summary}
> %{?python_provide:%python_provide python3-%{pypi_name}}
The %py_provides macro should be used here instead.
> %package -n python-%{pypi_name}-doc
> Summary:xBOUT documentation
> %description -n python-%{pypi_name}-doc
> Documentation for xBOUT
Not a hard requirement, but I think it might make sense to add a Requires for
the main package to the -doc subpackage.
> %check
> export PYTHONPATH=%{buildroot}/%{python3_sitelib}
> pytest --pyargs xbout
Please use the %pytest macro instead. Also, not sure if the PYTHONPATH export
is needed, since:
> [amender@localhost python-xbout]$ rpm --eval %pytest
> \
> CFLAGS="${CFLAGS:-${RPM_OPT_FLAGS}}" LDFLAGS="${LDFLAGS:-${RPM_LD_FLAGS}}"\
>
> PATH="/home/amender/rpmbuild/BUILDROOT/%{NAME}-%{VERSION}-%{RELEASE}.x86_64/usr/bin:$PATH"\
>
> PYTHONPATH="${PYTHONPATH:-/home/amender/rpmbuild/BUILDROOT/%{NAME}-%{VERSION}-%{RELEASE}.x86_64/usr/lib64/python3.8/site-packages:/home/amender/rpmbuild/BUILDROOT/%{NAME}-%{VERSION}-%{RELEASE}.x86_64/usr/lib/python3.8/site->
> packages}"\
> PYTHONDONTWRITEBYTECODE=1\
> /usr/bin/pytest
These are minor issues, however and you can fix them on package import.
Approved. Full review below:
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Apache License 2.0". 59 files have
unknown license. Detailed output of licensecheck in
/data/rpmbuild/SPECS/python-xbout/python-xbout/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on
[Bug 1904739] Review Request: python-xbout: reading and analysing BOUT++ simulations
https://bugzilla.redhat.com/show_bug.cgi?id=1904739 Andy Mender changed: What|Removed |Added Status|NEW |ASSIGNED CC||andymenderu...@gmail.com Assignee|nob...@fedoraproject.org|andymenderu...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1904739] Review Request: python-xbout: reading and analysing BOUT++ simulations
https://bugzilla.redhat.com/show_bug.cgi?id=1904739 david08...@gmail.com changed: What|Removed |Added Doc Type|--- |If docs needed, set a value --- Comment #1 from david08...@gmail.com --- I found some issues (FTI, License) that are now fixed: Spec URL: https://download.copr.fedorainfracloud.org/results/davidsch/testing/fedora-rawhide-x86_64/01816376-python-xbout/python-xbout.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/davidsch/testing/fedora-rawhide-x86_64/01816376-python-xbout/python-xbout-0.2.3-0.2.fc34.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
