https://bugzilla.redhat.com/show_bug.cgi?id=2274028
Fedora Update System changed:
What|Removed |Added
Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2274028
Fedora Update System changed:
What|Removed |Added
Status|POST|MODIFIED
--- Comment #24 from
https://bugzilla.redhat.com/show_bug.cgi?id=2274028
Fedora Admin user for bugzilla script actions
changed:
What|Removed |Added
Status|ASSIGNED|POST
https://bugzilla.redhat.com/show_bug.cgi?id=2274028
Sandro Bonazzola changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--
You are
https://bugzilla.redhat.com/show_bug.cgi?id=2274028
--- Comment #22 from Sandro Bonazzola ---
Thanks Fabio for your time reviewing this!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2274028
--- Comment #21 from Fabio Valentini ---
:thumbsup:
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2274028
Dorinda changed:
What|Removed |Added
Comment|0 |updated
--- Comment #0 has been edited ---
https://bugzilla.redhat.com/show_bug.cgi?id=2274028
--- Comment #20 from Dorinda ---
Ok Thanks, I updated the spec file now to have the skipped test in one line.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product
https://bugzilla.redhat.com/show_bug.cgi?id=2274028
Fabio Valentini changed:
What|Removed |Added
Flags|needinfo?(decathorpe@gmail. |
|com)
https://bugzilla.redhat.com/show_bug.cgi?id=2274028
Dorinda changed:
What|Removed |Added
Flags||needinfo?(decathorpe@gmail.
https://bugzilla.redhat.com/show_bug.cgi?id=2274028
--- Comment #17 from Dorinda ---
Hi, Fabio do you mind to take a look? Thank you.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2274028
--- Comment #16 from Dorinda ---
ok noted, I updated the spec file
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2274028
Dorinda changed:
What|Removed |Added
Comment|0 |updated
--- Comment #0 has been edited ---
https://bugzilla.redhat.com/show_bug.cgi?id=2274028
--- Comment #15 from Fabio Valentini ---
> do you think it's better to put it all in one line?
Not sure if it's still necessary in some cases, but in the past this used to be
necessary to work around issues with RPM's macro handling.
--
https://bugzilla.redhat.com/show_bug.cgi?id=2274028
--- Comment #14 from Dorinda ---
(In reply to Fabio Valentini from comment #13)
> Looks OK to me - just replace "i386 i686" with "%{ix86}".
>
Ok thanks
> Also assuming that the syntax for skipping tests works as espected - in the
> past
https://bugzilla.redhat.com/show_bug.cgi?id=2274028
Fabio Valentini changed:
What|Removed |Added
Flags|needinfo?(decathorpe@gmail. |
|com)
https://bugzilla.redhat.com/show_bug.cgi?id=2274028
Sandro Bonazzola changed:
What|Removed |Added
Flags||needinfo?(decathorpe@gmail.
https://bugzilla.redhat.com/show_bug.cgi?id=2274028
Dorinda changed:
What|Removed |Added
Comment|0 |updated
--- Comment #0 has been edited ---
https://bugzilla.redhat.com/show_bug.cgi?id=2274028
--- Comment #11 from Dorinda ---
I updated the spec file following changes were made
1: skipped build on 32 bit architectures because upstream does not allow 32 bit
compilation.
2: Updated reasons why test are skipped, also sent PR upstream
https://bugzilla.redhat.com/show_bug.cgi?id=2274028
--- Comment #10 from Fabio Valentini ---
> I added that line because the code still failed on i386 in copr
Makes sense then. I could have sworn that I checked whether an additional cast
was needed, but I apparently missed this.
> Noted, I
https://bugzilla.redhat.com/show_bug.cgi?id=2274028
--- Comment #9 from Dorinda ---
(In reply to Fabio Valentini from comment #8)
> Thank you! Looks much better now, just three minor things left from my side:
>
> 1. I wonder why you added "as i32" in the first line of the patch compared
> to
https://bugzilla.redhat.com/show_bug.cgi?id=2274028
Fabio Valentini changed:
What|Removed |Added
Flags|needinfo?(decathorpe@gmail. |
|com)
https://bugzilla.redhat.com/show_bug.cgi?id=2274028
Dorinda changed:
What|Removed |Added
Comment|0 |updated
--- Comment #0 has been edited ---
https://bugzilla.redhat.com/show_bug.cgi?id=2274028
Dorinda changed:
What|Removed |Added
Flags||needinfo?(decathorpe@gmail.
https://bugzilla.redhat.com/show_bug.cgi?id=2274028
Fabio Valentini changed:
What|Removed |Added
CC||decatho...@gmail.com
--- Comment
https://bugzilla.redhat.com/show_bug.cgi?id=2274028
--- Comment #5 from Dorinda ---
(In reply to blinxen from comment #2)
> I took a quick peek and have the following comments:
>
> * Both patches ("ignore-pw-server-test.patch" and
> "build-fix-for-alsa-test.patch") simply add the `ignore`
https://bugzilla.redhat.com/show_bug.cgi?id=2274028
--- Comment #4 from Sandro Bonazzola ---
I might misunderstand the purpose of the devel packages with rust language as I
don't know the language at all.
But from a package named
`rust-vhost-device-sound+pw-devel-0.1.0-1.fc41.x86_64.rpm` I
https://bugzilla.redhat.com/show_bug.cgi?id=2274028
Dorinda changed:
What|Removed |Added
Comment|0 |updated
--- Comment #0 has been edited ---
https://bugzilla.redhat.com/show_bug.cgi?id=2274028
Dorinda changed:
What|Removed |Added
Flags|needinfo?(dbas...@redhat.co |
|m)
https://bugzilla.redhat.com/show_bug.cgi?id=2274028
blinxen changed:
What|Removed |Added
CC||h-k...@hotmail.com
--- Comment #2 from
https://bugzilla.redhat.com/show_bug.cgi?id=2274028
Sandro Bonazzola changed:
What|Removed |Added
Flags||needinfo?(dbas...@redhat.co
31 matches
Mail list logo
