[Bug 2324911] Review Request: fheroes2 - Free implementation of the popular game engine
https://bugzilla.redhat.com/show_bug.cgi?id=2324911 --- Comment #29 from Fedora Update System --- FEDORA-2024-ce9cc2ecb3 (fheroes2-1.1.4-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202324911%23c29 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2324911] Review Request: fheroes2 - Free implementation of the popular game engine
https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Fedora Update System changed: What|Removed |Added Resolution|--- |ERRATA Status|ON_QA |CLOSED Last Closed||2024-12-06 01:36:40 --- Comment #28 from Fedora Update System --- FEDORA-2024-18baeff1d0 (fheroes2-1.1.4-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202324911%23c28 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2324911] Review Request: fheroes2 - Free implementation of the popular game engine
https://bugzilla.redhat.com/show_bug.cgi?id=2324911 --- Comment #27 from Fedora Update System --- FEDORA-2024-ce9cc2ecb3 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-ce9cc2ecb3` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-ce9cc2ecb3 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202324911%23c27 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2324911] Review Request: fheroes2 - Free implementation of the popular game engine
https://bugzilla.redhat.com/show_bug.cgi?id=2324911 --- Comment #26 from Fedora Update System --- FEDORA-2024-18baeff1d0 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-18baeff1d0` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-18baeff1d0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202324911%23c26 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2324911] Review Request: fheroes2 - Free implementation of the popular game engine
https://bugzilla.redhat.com/show_bug.cgi?id=2324911 --- Comment #25 from Fedora Update System --- FEDORA-2024-da9fb9a657 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-da9fb9a657 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-da9fb9a657 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202324911%23c25 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2324911] Review Request: fheroes2 - Free implementation of the popular game engine
https://bugzilla.redhat.com/show_bug.cgi?id=2324911 --- Comment #24 from Fedora Update System --- FEDORA-2024-b5f63443ae has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-b5f63443ae \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-b5f63443ae See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202324911%23c24 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2324911] Review Request: fheroes2 - Free implementation of the popular game engine
https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #23 from Fedora Update System --- FEDORA-2024-4217b165ca has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-4217b165ca \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-4217b165ca See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202324911%23c23 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2324911] Review Request: fheroes2 - Free implementation of the popular game engine
https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Fedora Update System changed: What|Removed |Added Status|RELEASE_PENDING |MODIFIED --- Comment #20 from Fedora Update System --- FEDORA-2024-da9fb9a657 (fheroes2-1.1.3-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-da9fb9a657 --- Comment #21 from Fedora Update System --- FEDORA-2024-4217b165ca (fheroes2-1.1.3-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-4217b165ca -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202324911%23c21 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2324911] Review Request: fheroes2 - Free implementation of the popular game engine
https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Fedora Update System changed: What|Removed |Added Status|RELEASE_PENDING |MODIFIED --- Comment #20 from Fedora Update System --- FEDORA-2024-da9fb9a657 (fheroes2-1.1.3-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-da9fb9a657 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202324911%23c20 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2324911] Review Request: fheroes2 - Free implementation of the popular game engine
https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Fedora Update System changed: What|Removed |Added Status|RELEASE_PENDING |MODIFIED --- Comment #20 from Fedora Update System --- FEDORA-2024-da9fb9a657 (fheroes2-1.1.3-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-da9fb9a657 --- Comment #21 from Fedora Update System --- FEDORA-2024-4217b165ca (fheroes2-1.1.3-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-4217b165ca --- Comment #22 from Fedora Update System --- FEDORA-2024-b5f63443ae (fheroes2-1.1.3-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-b5f63443ae -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202324911%23c22 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2324911] Review Request: fheroes2 - Free implementation of the popular game engine
https://bugzilla.redhat.com/show_bug.cgi?id=2324911 --- Comment #18 from Peter Lemenkov --- (In reply to Benson Muite from comment #17) > Thanks. Approved. Thank you! > Review of one of > Skia (requires some interaction with upstream to set soname) - > https://bugzilla.redhat.com/show_bug.cgi?id=2325835 > > cproc - https://bugzilla.redhat.com/show_bug.cgi?id=2325154 > chibicc - https://bugzilla.redhat.com/show_bug.cgi?id=2325026 > > would be appreciated if time allows. On my way! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202324911%23c18 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2324911] Review Request: fheroes2 - Free implementation of the popular game engine
https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Fedora Admin user for bugzilla script actions changed: What|Removed |Added Status|POST|RELEASE_PENDING --- Comment #19 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/fheroes2 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202324911%23c19 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2324911] Review Request: fheroes2 - Free implementation of the popular game engine
https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Benson Muite changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #17 from Benson Muite --- Thanks. Approved. Review of one of Skia (requires some interaction with upstream to set soname) - https://bugzilla.redhat.com/show_bug.cgi?id=2325835 cproc - https://bugzilla.redhat.com/show_bug.cgi?id=2325154 chibicc - https://bugzilla.redhat.com/show_bug.cgi?id=2325026 would be appreciated if time allows. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202324911%23c17 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2324911] Review Request: fheroes2 - Free implementation of the popular game engine
https://bugzilla.redhat.com/show_bug.cgi?id=2324911 --- Comment #16 from Peter Lemenkov --- (In reply to Peter Lemenkov from comment #11) > (In reply to Benson Muite from comment #10) > > Comments: ... > > h) Is there a license for > > https://github.com/ihhub/fheroes2/blob/master/files/data/resurrection.h2d > > I guess the same GPLv2 since it was added in this PR: > > * https://github.com/ihhub/fheroes2/pull/3828/ > * > https://github.com/ihhub/fheroes2/pull/3828/commits/ > a8e84e32f307f858e171b4bbea7cacb2debdadf6 > > I asked upstream about the status of this particular data artifact - > https://github.com/ihhub/fheroes2/issues/9267. Upstream confirmed that this blob is licensed under GPL-2.0-or-later as the source code. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202324911%23c16 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2324911] Review Request: fheroes2 - Free implementation of the popular game engine
https://bugzilla.redhat.com/show_bug.cgi?id=2324911 --- Comment #15 from Peter Lemenkov --- (In reply to Benson Muite from comment #14) > Chromium does put locale files in a different location: > https://src.fedoraproject.org/rpms/chromium/blob/rawhide/f/chromium. > spec#_1821 > > Maybe the guidelines need an update? We have more locale offenders - vim-enhanced for example. But I don't think we need to fix guidelines. Much better to propose a change to upstream eventually. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202324911%23c15 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2324911] Review Request: fheroes2 - Free implementation of the popular game engine
https://bugzilla.redhat.com/show_bug.cgi?id=2324911 --- Comment #14 from Benson Muite --- Chromium does put locale files in a different location: https://src.fedoraproject.org/rpms/chromium/blob/rawhide/f/chromium.spec#_1821 Maybe the guidelines need an update? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202324911%23c14 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2324911] Review Request: fheroes2 - Free implementation of the popular game engine
https://bugzilla.redhat.com/show_bug.cgi?id=2324911 --- Comment #12 from Fedora Review Service --- Created attachment 2057058 --> https://bugzilla.redhat.com/attachment.cgi?id=2057058&action=edit The .spec file difference from Copr build 8238163 to 8241593 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202324911%23c12 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2324911] Review Request: fheroes2 - Free implementation of the popular game engine
https://bugzilla.redhat.com/show_bug.cgi?id=2324911 --- Comment #13 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8241593 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2324911-fheroes2/fedora-rawhide-x86_64/08241593-fheroes2/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202324911%23c13 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2324911] Review Request: fheroes2 - Free implementation of the popular game engine
https://bugzilla.redhat.com/show_bug.cgi?id=2324911
--- Comment #11 from Peter Lemenkov ---
(In reply to Benson Muite from comment #10)
> Comments:
> a) To ensure directory ownership, please add
> Requires: hicolor-icon-theme
Done.
> b) Please validate the appdata file, see
> https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/
> #_app_data_validate_usage
> add
> BuildRequires: libappstream-glib
> appstream-util validate-relax --nonet
> %{buildroot}%{_metainfodir}/*.metainfo.xml
Done.
> c) Please use the %find_lang for translation files, see:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/
> #handling_locale_files
...
> d) Ideally translation files should be in
> %{_datadir}/locale/a%{locale}/LC_MESSAGES/%{name}.mo
>
> My need patches for
> https://github.com/ihhub/fheroes2/blob/master/src/fheroes2/system/settings.
> cpp#L525
> https://github.com/ihhub/fheroes2/blob/master/CMakeLists.txt#L87-L96
> Not sure if a blocker though, coupled to point c.
Yeah, a way of dealing with locale data in this game engine is not entirely
standard. I'll try to convince upstream to move them into common directories
(```/usr/share/locale```). Meanwhile maybe it's better to keep it as is?
> e) Can a man page be generated:
> https://github.com/ihhub/fheroes2/blob/master/docs/fheroes2.6.in
Done.
Thanks for pointing me out! I was not aware of this one.
> f) Maybe add a smoke test
> fheros2 --version
Requires display and working keyboard and mice.
> g) Does the license file
> https://github.com/ihhub/fheroes2/blob/master/files/soundfonts/GeneralUser-
> GS-LICENSE.txt
> also need to be indicated?
I don't think so - it is a requirement for Windows installer. We have working
SDL_Mixer and we're good.
> h) Is there a license for
> https://github.com/ihhub/fheroes2/blob/master/files/data/resurrection.h2d
I guess the same GPLv2 since it was added in this PR:
* https://github.com/ihhub/fheroes2/pull/3828/
*
https://github.com/ihhub/fheroes2/pull/3828/commits/a8e84e32f307f858e171b4bbea7cacb2debdadf6
I asked upstream about the status of this particular data artifact -
https://github.com/ihhub/fheroes2/issues/9267.
New package, the same links:
Spec URL: https://peter.fedorapeople.org/packages/fheroes2.spec
SRPM URL: https://peter.fedorapeople.org/packages/fheroes2-1.1.3-1.fc41.src.rpm
Koji scratch build for Rawhide:
* https://koji.fedoraproject.org/koji/taskinfo?taskID=125746117
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2324911
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202324911%23c11
--
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 2324911] Review Request: fheroes2 - Free implementation of the popular game engine
https://bugzilla.redhat.com/show_bug.cgi?id=2324911
--- Comment #10 from Benson Muite ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[ ]: Package does not contain kernel modules.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU General Public License v2.0 or
later", "GNU General Public License, Version 2", "*No copyright* GNU
General Public License, Version 2", "ISC License", "*No copyright* ISC
License", "GNU Lesser General Public License, Version 2.1", "GNU
Lesser General Public License v2.1 or later", "*No copyright* Apache
License 2.0". 331 files have unknown license. Detailed output of
licensecheck in
/home/FedoraPackaging/reviews/fheroes2/2324911-fheroes2/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[ ]: Package must own all directories that it creates.
Note: Directories without known owners:
/usr/share/icons/hicolor/128x128, /usr/share/icons/hicolor,
/usr/share/icons/hicolor/128x128/apps
[x]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 152527 bytes in 2 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides
[Bug 2324911] Review Request: fheroes2 - Free implementation of the popular game engine
https://bugzilla.redhat.com/show_bug.cgi?id=2324911 --- Comment #9 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8238163 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2324911-fheroes2/fedora-rawhide-x86_64/08238163-fheroes2/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202324911%23c9 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2324911] Review Request: fheroes2 - Free implementation of the popular game engine
https://bugzilla.redhat.com/show_bug.cgi?id=2324911 --- Comment #8 from Fedora Review Service --- Created attachment 2056809 --> https://bugzilla.redhat.com/attachment.cgi?id=2056809&action=edit The .spec file difference from Copr build 8235859 to 8238163 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202324911%23c8 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2324911] Review Request: fheroes2 - Free implementation of the popular game engine
https://bugzilla.redhat.com/show_bug.cgi?id=2324911 --- Comment #7 from Peter Lemenkov --- Improved licensing information, the same links: Spec URL: https://peter.fedorapeople.org/packages/fheroes2.spec SRPM URL: https://peter.fedorapeople.org/packages/fheroes2-1.1.3-1.fc41.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202324911%23c7 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2324911] Review Request: fheroes2 - Free implementation of the popular game engine
https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Benson Muite changed: What|Removed |Added Assignee|nob...@fedoraproject.org|benson_mu...@emailplus.org CC||benson_mu...@emailplus.org Status|NEW |ASSIGNED Flags||fedora-review? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2324911 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2324911] Review Request: fheroes2 - Free implementation of the popular game engine
https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Fedora Review Service changed: What|Removed |Added Keywords||AutomationTriaged --- Comment #6 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8235859 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2324911-fheroes2/fedora-rawhide-x86_64/08235859-fheroes2/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202324911%23c6 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2324911] Review Request: fheroes2 - Free implementation of the popular game engine
https://bugzilla.redhat.com/show_bug.cgi?id=2324911 --- Comment #5 from Fedora Review Service --- Created attachment 2056696 --> https://bugzilla.redhat.com/attachment.cgi?id=2056696&action=edit The .spec file difference from Copr build 8235829 to 8235859 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202324911%23c5 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2324911] Review Request: fheroes2 - Free implementation of the popular game engine
https://bugzilla.redhat.com/show_bug.cgi?id=2324911 --- Comment #4 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8235829 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2324911-fheroes2/fedora-rawhide-x86_64/08235829-fheroes2/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202324911%23c4 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2324911] Review Request: fheroes2 - Free implementation of the popular game engine
https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Fedora Review Service changed: What|Removed |Added URL||https://github.com/ihhub/fh ||eroes2 --- Comment #2 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8235819 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2324911-fheroes2/fedora-rawhide-x86_64/08235819-fheroes2/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202324911%23c2 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2324911] Review Request: fheroes2 - Free implementation of the popular game engine
https://bugzilla.redhat.com/show_bug.cgi?id=2324911 --- Comment #3 from Peter Lemenkov --- Validated desktop-file, the same links: Spec URL: https://peter.fedorapeople.org/packages/fheroes2.spec SRPM URL: https://peter.fedorapeople.org/packages/fheroes2-1.1.3-1.fc41.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202324911%23c3 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2324911] Review Request: fheroes2 - Free implementation of the popular game engine
https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Peter Lemenkov changed: What|Removed |Added Doc Type|--- |If docs needed, set a value --- Comment #1 from Peter Lemenkov --- Updated package, the same links: Spec URL: https://peter.fedorapeople.org/packages/fheroes2.spec SRPM URL: https://peter.fedorapeople.org/packages/fheroes2-1.1.3-1.fc41.src.rpm Koji scratch build for Rawhide: * https://koji.fedoraproject.org/koji/taskinfo?taskID=125672450 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2324911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202324911%23c1 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
