[Bug 2399600] Review Request: sol2 - a C++ <-> Lua API wrapper with advanced features and top notch performance
https://bugzilla.redhat.com/show_bug.cgi?id=2399600 Fedora Admin user for bugzilla script actions changed: What|Removed |Added Status|ASSIGNED|RELEASE_PENDING --- Comment #28 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/sol2 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2399600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202399600%23c28 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2399600] Review Request: sol2 - a C++ <-> Lua API wrapper with advanced features and top notch performance
https://bugzilla.redhat.com/show_bug.cgi?id=2399600
Fedor Vorobev changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
|needinfo?(solomoncyj@gmail. |
|com)|
|needinfo?(solomoncyj@gmail. |
|com)|
|needinfo?(solomoncyj@gmail. |
|com)|
--- Comment #27 from Fedor Vorobev ---
LGTM.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT License", "Unknown or generated", "Boost Software License
1.0". 303 files have unknown license. Detailed output of licensecheck
in /home/fvorobev/Work/reviews/2399600-sol2/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries or specifies bundled libraries
with Provides: bundled() if unbundling is not possible.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.Tested
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
sol2-devel , sol2-devel-docs
NOTE: There's only a -devel package and sol2-devel-docs is a noarch
package, so not applicable.
[x]: Package functions as described.
NOTE: Tested a sample program from the upstream README.md.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[Bug 2399600] Review Request: sol2 - a C++ <-> Lua API wrapper with advanced features and top notch performance
https://bugzilla.redhat.com/show_bug.cgi?id=2399600 --- Comment #26 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/9975852 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2399600-sol2/fedora-rawhide-x86_64/09975852-sol2/fedora-review/review.txt Found issues: - License file licenses.rst.txt is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text - Documentation size is 3337676 bytes in 201 files. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2399600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202399600%23c26 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2399600] Review Request: sol2 - a C++ <-> Lua API wrapper with advanced features and top notch performance
https://bugzilla.redhat.com/show_bug.cgi?id=2399600 --- Comment #25 from Fedora Review Service --- Created attachment 2121213 --> https://bugzilla.redhat.com/attachment.cgi?id=2121213&action=edit The .spec file difference from Copr build 9975182 to 9975852 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2399600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202399600%23c25 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2399600] Review Request: sol2 - a C++ <-> Lua API wrapper with advanced features and top notch performance
https://bugzilla.redhat.com/show_bug.cgi?id=2399600 --- Comment #24 from [email protected] --- Spec URL: https://solomoncyj.fedorapeople.org/reviews/sol2/sol2.spec SRPM URL: https://solomoncyj.fedorapeople.org/reviews/sol2/sol2-3.5.0-1.fc43.src.rpm - Uncommitted changes -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2399600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202399600%23c24 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2399600] Review Request: sol2 - a C++ <-> Lua API wrapper with advanced features and top notch performance
https://bugzilla.redhat.com/show_bug.cgi?id=2399600 Fedor Vorobev changed: What|Removed |Added Flags||needinfo?(solomoncyj@gmail. ||com) --- Comment #23 from Fedor Vorobev --- Can confirm the sample program now compiles and runs successfully with `g++ -llua main.cpp`. Hopefully last thing to change: could you remove the sphinx doc build leftovers before packaging -docs? .buildinfo and .doctrees. Comes from rpmlint warnings: sol2-devel-docs.noarch: W: python-sphinx-doctrees-leftover /usr/share/doc/sol2/sphinx/.doctrees sol2-devel-docs.noarch: W: hidden-file-or-dir /usr/share/doc/sol2/sphinx/.buildinfo sol2-devel-docs.noarch: W: hidden-file-or-dir /usr/share/doc/sol2/sphinx/.doctrees sol2-devel-docs.noarch: W: hidden-file-or-dir /usr/share/doc/sol2/sphinx/.doctrees -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2399600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202399600%23c23 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2399600] Review Request: sol2 - a C++ <-> Lua API wrapper with advanced features and top notch performance
https://bugzilla.redhat.com/show_bug.cgi?id=2399600 --- Comment #21 from Fedora Review Service --- Created attachment 2121195 --> https://bugzilla.redhat.com/attachment.cgi?id=2121195&action=edit The .spec file difference from Copr build 9975161 to 9975182 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2399600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202399600%23c21 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2399600] Review Request: sol2 - a C++ <-> Lua API wrapper with advanced features and top notch performance
https://bugzilla.redhat.com/show_bug.cgi?id=2399600 --- Comment #22 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/9975182 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2399600-sol2/fedora-rawhide-x86_64/09975182-sol2/fedora-review/review.txt Found issues: - License file licenses.doctree is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text - Documentation size is 5328319 bytes in 278 files. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2399600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202399600%23c22 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2399600] Review Request: sol2 - a C++ <-> Lua API wrapper with advanced features and top notch performance
https://bugzilla.redhat.com/show_bug.cgi?id=2399600 --- Comment #20 from [email protected] --- Spec URL: https://solomoncyj.fedorapeople.org/reviews/sol2/sol2.spec SRPM URL: https://solomoncyj.fedorapeople.org/reviews/sol2/sol2-3.5.0-1.fc43.src.rpm - Uncommitted changes -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2399600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202399600%23c20 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2399600] Review Request: sol2 - a C++ <-> Lua API wrapper with advanced features and top notch performance
https://bugzilla.redhat.com/show_bug.cgi?id=2399600 --- Comment #18 from Fedora Review Service --- Created attachment 2121193 --> https://bugzilla.redhat.com/attachment.cgi?id=2121193&action=edit The .spec file difference from Copr build 9975069 to 9975161 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2399600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202399600%23c18 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2399600] Review Request: sol2 - a C++ <-> Lua API wrapper with advanced features and top notch performance
https://bugzilla.redhat.com/show_bug.cgi?id=2399600 --- Comment #19 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/9975161 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2399600-sol2/fedora-rawhide-x86_64/09975161-sol2/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2399600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202399600%23c19 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2399600] Review Request: sol2 - a C++ <-> Lua API wrapper with advanced features and top notch performance
https://bugzilla.redhat.com/show_bug.cgi?id=2399600 --- Comment #17 from [email protected] --- Spec URL: https://solomoncyj.fedorapeople.org/reviews/sol2/sol2.spec SRPM URL: https://solomoncyj.fedorapeople.org/reviews/sol2/sol2-3.5.0-1.fc44.src.rpm - Uncommitted changes -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2399600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202399600%23c17 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2399600] Review Request: sol2 - a C++ <-> Lua API wrapper with advanced features and top notch performance
https://bugzilla.redhat.com/show_bug.cgi?id=2399600 --- Comment #16 from Fedor Vorobev --- Also, just to satisfy the rpmlint warnings, maybe consider deleting the sphinx cache leftovers from the -docs package. sol2-devel-docs.x86_64: W: python-sphinx-doctrees-leftover /usr/share/doc/sol2/sphinx/.doctrees sol2-devel.x86_64: W: only-non-binary-in-usr-lib sol2-devel-docs.x86_64: W: hidden-file-or-dir /usr/share/doc/sol2/sphinx/.buildinfo sol2-devel-docs.x86_64: W: hidden-file-or-dir /usr/share/doc/sol2/sphinx/.doctrees sol2-devel-docs.x86_64: W: hidden-file-or-dir /usr/share/doc/sol2/sphinx/.doctrees -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2399600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202399600%23c16 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2399600] Review Request: sol2 - a C++ <-> Lua API wrapper with advanced features and top notch performance
https://bugzilla.redhat.com/show_bug.cgi?id=2399600
Fedor Vorobev changed:
What|Removed |Added
Flags||needinfo?(solomoncyj@gmail.
||com)
--- Comment #15 from Fedor Vorobev ---
I was trying to test a code snippet from the upstream repository for sanity,
and ran into the following issue when trying to compile a program using the
produced package:
===
In file included from /usr/include/sol/optional.hpp:33,
from /usr/include/sol/types.hpp:28,
from /usr/include/sol/trampoline.hpp:27,
from /usr/include/sol/stack.hpp:27,
from /usr/include/sol/sol.hpp:52,
from main.cpp:1:
/usr/include/sol/optional_implementation.hpp: In member function ‘T&
sol::optional::emplace(Args&& ...)’:
/usr/include/sol/optional_implementation.hpp:2194:31: error: ‘class
sol::optional’ has no member named ‘construct’ [-Wtemplate-body]
2194 | this->construct(std::forward(args)...);
===
for the following program:
===
#include
#include
int main() {
sol::state lua;
int x = 0;
lua.set_function("beep", [&x]{ ++x; });
lua.script("beep()");
assert(x == 1);
}
===
Found this issue that's related: https://github.com/ThePhD/sol2/issues/1617
Considering the 3.3.0 release is fairly old at this point, you might want to
apply patches or use the tags instead of the release.
(It appears there are tags for v3.5.0 in the repo.)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2399600
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202399600%23c15
--
___
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 2399600] Review Request: sol2 - a C++ <-> Lua API wrapper with advanced features and top notch performance
https://bugzilla.redhat.com/show_bug.cgi?id=2399600 --- Comment #14 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/9975069 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2399600-sol2/fedora-rawhide-x86_64/09975069-sol2/fedora-review/review.txt Found issues: - License file licenses.doctree is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text - Documentation size is 5327120 bytes in 278 files. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2399600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202399600%23c14 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2399600] Review Request: sol2 - a C++ <-> Lua API wrapper with advanced features and top notch performance
https://bugzilla.redhat.com/show_bug.cgi?id=2399600 --- Comment #13 from Fedora Review Service --- Created attachment 2121176 --> https://bugzilla.redhat.com/attachment.cgi?id=2121176&action=edit The .spec file difference from Copr build 9602338 to 9975069 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2399600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202399600%23c13 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2399600] Review Request: sol2 - a C++ <-> Lua API wrapper with advanced features and top notch performance
https://bugzilla.redhat.com/show_bug.cgi?id=2399600 --- Comment #12 from [email protected] --- Spec URL: https://solomoncyj.fedorapeople.org/reviews/sol2/sol2.spec SRPM URL: https://solomoncyj.fedorapeople.org/reviews/sol2/sol2-3.3.0-1.fc44.src.rpm - Uncommitted changes -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2399600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202399600%23c12 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2399600] Review Request: sol2 - a C++ <-> Lua API wrapper with advanced features and top notch performance
https://bugzilla.redhat.com/show_bug.cgi?id=2399600
Fedor Vorobev changed:
What|Removed |Added
Flags||needinfo?(solomoncyj@gmail.
||com)
--- Comment #11 from Fedor Vorobev ---
Issues:
===
- Could you mark the -docs package as noarch? (see EXTRA section)
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries or specifies bundled libraries
with Provides: bundled() if unbundling is not possible.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
NOTE: The package provides development files only. The base package
contains nothing.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
NOTE: Upstream does not provide signatures.
[x]: Package should compile and build into binary rpms on all supported
architectures.Could you mark the -docs package as noarch?
NOTE: https://koji.fedoraproject.org/koji/taskinfo?taskID=140761336
[-]: %check is present and all tests pass.
NOTE: Tests are disabled and there's a justifying comment for that.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot
[Bug 2399600] Review Request: sol2 - a C++ <-> Lua API wrapper with advanced features and top notch performance
https://bugzilla.redhat.com/show_bug.cgi?id=2399600 [email protected] changed: What|Removed |Added Flags|needinfo?(solomoncyj@gmail. | |com)| --- Comment #10 from [email protected] --- i am using cmake to install as i want the .cmake files -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2399600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202399600%23c10 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2399600] Review Request: sol2 - a C++ <-> Lua API wrapper with advanced features and top notch performance
https://bugzilla.redhat.com/show_bug.cgi?id=2399600 --- Comment #9 from [email protected] --- Spec URL: https://solomoncyj.fedorapeople.org/reviews/sol2/sol2.spec SRPM URL: https://solomoncyj.fedorapeople.org/reviews/sol2/sol2-3.3.0-1.fc43.src.rpm build docs -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2399600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202399600%23c9 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2399600] Review Request: sol2 - a C++ <-> Lua API wrapper with advanced features and top notch performance
https://bugzilla.redhat.com/show_bug.cgi?id=2399600 Fedor Vorobev changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2399600 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2399600] Review Request: sol2 - a C++ <-> Lua API wrapper with advanced features and top notch performance
https://bugzilla.redhat.com/show_bug.cgi?id=2399600 Fedor Vorobev changed: What|Removed |Added QA Contact|[email protected] |[email protected] Assignee|[email protected]|[email protected] -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2399600 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2399600] Review Request: sol2 - a C++ <-> Lua API wrapper with advanced features and top notch performance
https://bugzilla.redhat.com/show_bug.cgi?id=2399600 Fedor Vorobev changed: What|Removed |Added CC||[email protected] QA Contact|[email protected] |[email protected] Flags||fedora-review? ||needinfo?(solomoncyj@gmail. ||com) --- Comment #8 from Fedor Vorobev --- A couple of questions/remarks: - If only headers are packaged and tests are disabled, what does CMake even do there? Just installs the files? - Why depend on `pkgconfig(lua)` and not `lua-devel`? CMake uses its own find_package() scripts to find Lua and not pkgconfig. - Consider building and packaging the API documentation included in the sources. Other than that looks fine to me. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2399600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202399600%23c8 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2399600] Review Request: sol2 - a C++ <-> Lua API wrapper with advanced features and top notch performance
https://bugzilla.redhat.com/show_bug.cgi?id=2399600 Ben Beasley changed: What|Removed |Added Assignee|[email protected] |[email protected] Status|ASSIGNED|NEW Flags|fedora-review? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2399600 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2399600] Review Request: sol2 - a C++ <-> Lua API wrapper with advanced features and top notch performance
https://bugzilla.redhat.com/show_bug.cgi?id=2399600 Ben Beasley changed: What|Removed |Added CC||[email protected] Assignee|[email protected]|[email protected] Flags||fedora-review? Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2399600 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2399600] Review Request: sol2 - a C++ <-> Lua API wrapper with advanced features and top notch performance
https://bugzilla.redhat.com/show_bug.cgi?id=2399600 --- Comment #7 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/9602338 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2399600-sol2/fedora-rawhide-x86_64/09602338-sol2/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2399600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202399600%23c7 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2399600] Review Request: sol2 - a C++ <-> Lua API wrapper with advanced features and top notch performance
https://bugzilla.redhat.com/show_bug.cgi?id=2399600 --- Comment #6 from Fedora Review Service --- Created attachment 2107628 --> https://bugzilla.redhat.com/attachment.cgi?id=2107628&action=edit The .spec file difference from Copr build 9602278 to 9602338 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2399600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202399600%23c6 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2399600] Review Request: sol2 - a C++ <-> Lua API wrapper with advanced features and top notch performance
https://bugzilla.redhat.com/show_bug.cgi?id=2399600 --- Comment #5 from [email protected] --- Spec URL: https://solomoncyj.fedorapeople.org/reviews/sol2/sol2.spec SRPM URL: https://solomoncyj.fedorapeople.org/reviews/sol2/sol2-3.3.0-1.fc44.src.rpm - Uncommitted changes -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2399600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202399600%23c5 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2399600] Review Request: sol2 - a C++ <-> Lua API wrapper with advanced features and top notch performance
https://bugzilla.redhat.com/show_bug.cgi?id=2399600 --- Comment #1 from [email protected] --- Spec URL: https://solomoncyj.fedorapeople.org/reviews/sol2/sol2.spec SRPM URL: https://solomoncyj.fedorapeople.org/reviews/sol2/sol2-3.3.0-1.fc44.src.rpm - Uncommitted changes -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2399600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202399600%23c1 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2399600] Review Request: sol2 - a C++ <-> Lua API wrapper with advanced features and top notch performance
https://bugzilla.redhat.com/show_bug.cgi?id=2399600 --- Comment #4 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/9602278 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2399600-sol2/fedora-rawhide-x86_64/09602278-sol2/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2399600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202399600%23c4 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2399600] Review Request: sol2 - a C++ <-> Lua API wrapper with advanced features and top notch performance
https://bugzilla.redhat.com/show_bug.cgi?id=2399600 --- Comment #2 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/9602272 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2399600-sol2/fedora-rawhide-x86_64/09602272-sol2/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2399600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202399600%23c2 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2399600] Review Request: sol2 - a C++ <-> Lua API wrapper with advanced features and top notch performance
https://bugzilla.redhat.com/show_bug.cgi?id=2399600 --- Comment #3 from Fedora Review Service --- Created attachment 2107627 --> https://bugzilla.redhat.com/attachment.cgi?id=2107627&action=edit The .spec file difference from Copr build 9602272 to 9602278 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2399600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202399600%23c3 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2399600] Review Request: sol2 - a C++ <-> Lua API wrapper with advanced features and top notch performance
https://bugzilla.redhat.com/show_bug.cgi?id=2399600 [email protected] changed: What|Removed |Added Blocks||2398039 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=2398039 [Bug 2398039] Review Request: chatterino2 - Chat client for https://twitch.tv -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2399600 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
