[Bug 2432007] Review Request: gweather-locations - The GWeather locations database
https://bugzilla.redhat.com/show_bug.cgi?id=2432007 Fedora Admin user for bugzilla script actions changed: What|Removed |Added Status|ASSIGNED|RELEASE_PENDING --- Comment #14 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/gweather-locations -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2432007 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432007%23c14 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
[Bug 2432007] Review Request: gweather-locations - The GWeather locations database
https://bugzilla.redhat.com/show_bug.cgi?id=2432007 --- Comment #13 from Michael Catanzaro --- Still need to fix: gweather-locations.src: E: description-line-too-long The GWeather locations database contains a list of locations used by GWeather library gweather-locations.x86_64: E: description-line-too-long The GWeather locations database contains a list of locations used by GWeather library Anyway, I'll approve this now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2432007 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432007%23c13 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
[Bug 2432007] Review Request: gweather-locations - The GWeather locations database
https://bugzilla.redhat.com/show_bug.cgi?id=2432007 Michael Catanzaro changed: What|Removed |Added Flags|fedora-review- |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2432007 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
[Bug 2432007] Review Request: gweather-locations - The GWeather locations database
https://bugzilla.redhat.com/show_bug.cgi?id=2432007 --- Comment #12 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/10082128 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2432007-gweather-locations/fedora-rawhide-x86_64/10082128-gweather-locations/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2432007 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432007%23c12 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
[Bug 2432007] Review Request: gweather-locations - The GWeather locations database
https://bugzilla.redhat.com/show_bug.cgi?id=2432007 --- Comment #11 from Fedora Review Service --- Created attachment 2127561 --> https://bugzilla.redhat.com/attachment.cgi?id=2127561&action=edit The .spec file difference from Copr build 10047372 to 10082128 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2432007 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432007%23c11 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
[Bug 2432007] Review Request: gweather-locations - The GWeather locations database
https://bugzilla.redhat.com/show_bug.cgi?id=2432007 --- Comment #10 from Jan Horak --- [fedora-review-service-build] -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2432007 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432007%23c10 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
[Bug 2432007] Review Request: gweather-locations - The GWeather locations database
https://bugzilla.redhat.com/show_bug.cgi?id=2432007 --- Comment #9 from Michael Catanzaro --- (In reply to Jan Horak from comment #8) > I'm not sure if I need to add dependency on the main package as you've > mentioned for the -devel. For -common you surely need the opposite: the main package should depend on the -common subpackage, right? > Also the /usr/share/locale, if that should also be > part of the noarch subpackage. Eh, I'm not sure, but I'd say it's simpler to leave it as-is. We don't need to go out of the way to force everything possible into the noarch package. P.S. You'll remove the - from the end of the file before uploading the package, right? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2432007 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432007%23c9 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
[Bug 2432007] Review Request: gweather-locations - The GWeather locations database
https://bugzilla.redhat.com/show_bug.cgi?id=2432007 --- Comment #8 from Jan Horak --- Thanks for stepping in Michael. I presume that the package cannot be noarch, since the msgfmt used to generate binary file set the endlessness to the platform. I've moved the Location.xml and .dtd into the noarch subpackage. I'm not sure if I need to add dependency on the main package as you've mentioned for the -devel. Also the /usr/share/locale, if that should also be part of the noarch subpackage. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2432007 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432007%23c8 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
[Bug 2432007] Review Request: gweather-locations - The GWeather locations database
https://bugzilla.redhat.com/show_bug.cgi?id=2432007
Michael Catanzaro changed:
What|Removed |Added
Flags|fedora-review? |fedora-review-
--- Comment #7 from Michael Catanzaro ---
I see four things to fix:
- devel subpackage needs to require the main package: Requires:
%{name}%{?_isa} = %{version}-%{release}
- Need to own %dir %{_libdir}/gweather-locations
- Large data in /usr/share should live in a noarch subpackage if package is
arched.
- Need to shorten description to placate rpmlint E: description-line-too-long
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[!]: License file installed when any subpackage combination is installed.
Note: Devel subpackage does not Requires: the main package
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/lib64/gweather-locations
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib64/gweather-locations
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries or specifies bundled libraries
with Provides: bundled() if unbundling is not possible.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[!]: Package does not generate any conflict.
Note: will conflict with older libgweather, which is expected
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[!]: Requires correct, justified where necessary.
-devel subpackage should Requires the main package
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 1158 bytes in 2 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[ ]: Reviewer should test that the package builds in mock.
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[!]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
gweather-locations-devel
[ ]: Package functions as described.
[x]: Latest version is packaged.
Note: upstream seems
[Bug 2432007] Review Request: gweather-locations - The GWeather locations database
https://bugzilla.redhat.com/show_bug.cgi?id=2432007 Michael Catanzaro changed: What|Removed |Added Assignee|[email protected] |[email protected] CC||[email protected] --- Comment #6 from Michael Catanzaro --- I'll steal this from Neal, because he is traveling this week. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2432007 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432007%23c6 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
[Bug 2432007] Review Request: gweather-locations - The GWeather locations database
https://bugzilla.redhat.com/show_bug.cgi?id=2432007 --- Comment #4 from Fedora Review Service --- Created attachment 2123250 --> https://bugzilla.redhat.com/attachment.cgi?id=2123250&action=edit The .spec file difference from Copr build 10047323 to 10047372 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2432007 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432007%23c4 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2432007] Review Request: gweather-locations - The GWeather locations database
https://bugzilla.redhat.com/show_bug.cgi?id=2432007 Fedora Review Service changed: What|Removed |Added Keywords||AutomationTriaged --- Comment #5 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/10047372 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2432007-gweather-locations/fedora-rawhide-x86_64/10047372-gweather-locations/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2432007 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432007%23c5 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2432007] Review Request: gweather-locations - The GWeather locations database
https://bugzilla.redhat.com/show_bug.cgi?id=2432007 --- Comment #3 from Jan Horak --- [fedora-review-service-build] -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2432007 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432007%23c3 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2432007] Review Request: gweather-locations - The GWeather locations database
https://bugzilla.redhat.com/show_bug.cgi?id=2432007 Fedora Review Service changed: What|Removed |Added URL||https://gitlab.gnome.org/GN ||OME/gweather-locations --- Comment #2 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/10047323 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2432007-gweather-locations/fedora-rawhide-x86_64/10047323-gweather-locations/fedora-review/review.txt Found issues: - Not a valid SPDX expression 'GNU General Public License version 2.0'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2432007 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432007%23c2 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2432007] Review Request: gweather-locations - The GWeather locations database
https://bugzilla.redhat.com/show_bug.cgi?id=2432007 Neal Gompa changed: What|Removed |Added Assignee|[email protected]|[email protected] Flags||fedora-review? CC||[email protected] Status|NEW |ASSIGNED --- Comment #1 from Neal Gompa --- Taking this review. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2432007 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432007%23c1 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
