[Bug 2432458] Review Request: gstr - Single-header UTF-8 grapheme string library for C
https://bugzilla.redhat.com/show_bug.cgi?id=2432458 --- Comment #7 from Edward J Edmonds --- Checking in on the status of this - is there anything else I need to do? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2432458 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432458%23c7 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
[Bug 2432458] Review Request: gstr - Single-header UTF-8 grapheme string library for C
https://bugzilla.redhat.com/show_bug.cgi?id=2432458
--- Comment #6 from Edward J Edmonds ---
Thank you for the review, Artur. I addressed your suggestions in 2.0.2-3:
- Moved BuildArch: noarch from the main package to %package devel so koji will
build and test on all architectures
- Added %global debug_package %{nil} since the header-only library produces no
compiled binaries (without this, the build fails on empty
debugsourcefiles.list)
- Moved the longer description with the full function listing to %description
devel
- Added %{optflags} to the gcc invocation in %check
Updated spec and SRPM on Copr:
https://copr.fedorainfracloud.org/coprs/build/10116374 — builds and tests pass
on all chroots.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2432458
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432458%23c6
--
___
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it:
https://forge.fedoraproject.org/infra/tickets/issues/new
[Bug 2432458] Review Request: gstr - Single-header UTF-8 grapheme string library for C
https://bugzilla.redhat.com/show_bug.cgi?id=2432458 Artur Frenszek-Iwicki changed: What|Removed |Added CC||[email protected] --- Comment #5 from Artur Frenszek-Iwicki --- > BuildArch: noarch > BuildRequires: gcc You should remove the "BuildArch: noarch" bit here and move it to be a property of the devel sub-package. The way it is now, koji (the Fedora build system) will see that the package is noarch, pick a random builder of a random architecture, and build it there. This means that tests will be ran only on a single architecture. If you keep the main package archful and mark the devel sub-package as noarch, then koji will build it (and hence, test it) on all architectures. This will still produce only a single devel.noarch package. > %description > ... > %description devel Since the main package is empty, building this spec will produce only the devel subpackage. As such, you may consider moving the longer and more descriptive description to the devel subpackage. > %check > gcc -Wall -Wextra -I include -o test_gstr test/test_gstr.c You should add %{optflags} (or ${CFLAGS}) to the invocation to ensure that Fedora's compiler flags are used when building the test suite. Alternatively, since the upstream repo contains a Makefile, you could add "BuildRequires: make" and just run "%make_build test" here. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2432458 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432458%23c5 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
[Bug 2432458] Review Request: gstr - Single-header UTF-8 grapheme string library for C
https://bugzilla.redhat.com/show_bug.cgi?id=2432458 Edward J Edmonds changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2432458 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2432458] Review Request: gstr - Single-header UTF-8 grapheme string library for C
https://bugzilla.redhat.com/show_bug.cgi?id=2432458 --- Comment #4 from Edward J Edmonds --- The spelling errors are API function names (e.g., gstrlen mirrors strlen) and the package builds successfully in Copr on all enabled chroots. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2432458 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432458%23c4 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2432458] Review Request: gstr - Single-header UTF-8 grapheme string library for C
https://bugzilla.redhat.com/show_bug.cgi?id=2432458 Fedora Review Service changed: What|Removed |Added URL||https://github.com/edwarded ||monds/gstr Keywords||AutomationTriaged --- Comment #3 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/10051484 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2432458-gstr/fedora-rawhide-x86_64/10051484-gstr/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2432458 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432458%23c3 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2432458] Review Request: gstr - Single-header UTF-8 grapheme string library for C
https://bugzilla.redhat.com/show_bug.cgi?id=2432458 --- Comment #2 from Edward J Edmonds --- SRPM URL: https://download.copr.fedorainfracloud.org/results/edwardjedmonds/gstr/fedora-rawhide-x86_64/10051096-gstr/gstr-2.0.2-1.fc44.src.rpm Spec URL: https://download.copr.fedorainfracloud.org/results/edwardjedmonds/gstr/fedora-rawhide-x86_64/10051096-gstr/gstr.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2432458 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432458%23c2 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2432458] Review Request: gstr - Single-header UTF-8 grapheme string library for C
https://bugzilla.redhat.com/show_bug.cgi?id=2432458 --- Comment #1 from Fedora Review Service --- There seems to be some problem with the following file. SRPM URL: https://download.copr.fedorainfracloud.org/results/edwardjedmonds/gstr/fedora-rawhide-x86_64/10050975-gstr/gstr-2.0.2-1.fc44.src.rpm Fetching it results in a 404 Not Found error. Please make sure the URL is correct and publicly available. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2432458 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432458%23c1 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
