[Bug 2432587] Review Request: bstring - A string abstraction data type for the C language
https://bugzilla.redhat.com/show_bug.cgi?id=2432587 Fedora Update System changed: What|Removed |Added Resolution|--- |ERRATA Status|ON_QA |CLOSED Last Closed||2026-02-04 02:09:15 --- Comment #14 from Fedora Update System --- FEDORA-2026-b7bee5dbcb (bstring-1.0.3-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2432587 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432587%23c14 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
[Bug 2432587] Review Request: bstring - A string abstraction data type for the C language
https://bugzilla.redhat.com/show_bug.cgi?id=2432587 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System --- FEDORA-2026-b7bee5dbcb has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-b7bee5dbcb` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-b7bee5dbcb See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2432587 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432587%23c13 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
[Bug 2432587] Review Request: bstring - A string abstraction data type for the C language
https://bugzilla.redhat.com/show_bug.cgi?id=2432587 Fedora Update System changed: What|Removed |Added Status|RELEASE_PENDING |MODIFIED --- Comment #12 from Fedora Update System --- FEDORA-2026-b7bee5dbcb (bstring-1.0.3-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2026-b7bee5dbcb -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2432587 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432587%23c12 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2432587] Review Request: bstring - A string abstraction data type for the C language
https://bugzilla.redhat.com/show_bug.cgi?id=2432587 Fedora Admin user for bugzilla script actions changed: What|Removed |Added Status|POST|RELEASE_PENDING --- Comment #11 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/bstring -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2432587 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432587%23c11 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2432587] Review Request: bstring - A string abstraction data type for the C language
https://bugzilla.redhat.com/show_bug.cgi?id=2432587 --- Comment #10 from Andrew Bauer --- Updated Spec URL: https://download.copr.fedorainfracloud.org/results/kni/bstring/fedora-rawhide-x86_64/10062273-bstring/bstring.spec Updated SRPM URL: https://download.copr.fedorainfracloud.org/results/kni/bstring/fedora-rawhide-x86_64/10062273-bstring/bstring-1.0.3-1.fc44.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2432587 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432587%23c10 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2432587] Review Request: bstring - A string abstraction data type for the C language
https://bugzilla.redhat.com/show_bug.cgi?id=2432587
Benson Muite changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #9 from Benson Muite ---
Seems good. A couple suggestions:
a) Please change
%{_libdir}/lib%{name}.so.*
to
%{_libdir}/lib%{name}.so.1{,.*}
sonames should not be globbed.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files
b) Consider also packaging the GPL-2 license text:
https://github.com/msteinert/bstring/pull/120
see
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text
c) Approved. Please fix (a) before import. Please fix (b), as a choice of
licenses are allowed,
will not block on GPL-2-only as the BSD-3-Clause could be the only one that is
used in Fedora
d) Review of:
https://bugzilla.redhat.com/show_bug.cgi?id=2432752
would be appreciated if time allows.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2432587
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432587%23c9
--
___
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 2432587] Review Request: bstring - A string abstraction data type for the C language
https://bugzilla.redhat.com/show_bug.cgi?id=2432587 --- Comment #8 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/10056653 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2432587-bstring/fedora-rawhide-x86_64/10056653-bstring/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2432587 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432587%23c8 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2432587] Review Request: bstring - A string abstraction data type for the C language
https://bugzilla.redhat.com/show_bug.cgi?id=2432587 --- Comment #7 from Fedora Review Service --- Created attachment 2123747 --> https://bugzilla.redhat.com/attachment.cgi?id=2123747&action=edit The .spec file difference from Copr build 10056606 to 10056653 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2432587 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432587%23c7 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2432587] Review Request: bstring - A string abstraction data type for the C language
https://bugzilla.redhat.com/show_bug.cgi?id=2432587 --- Comment #6 from Andrew Bauer --- Aw hang on. Doc files were being installed into /usr/share/help/en/bstring/html rather than /usr/share/help/en/bstring. This has been fixed. Updated Spec URL: https://download.copr.fedorainfracloud.org/results/kni/bstring/fedora-rawhide-x86_64/10056651-bstring/bstring.spec Updated SRPM URL: https://download.copr.fedorainfracloud.org/results/kni/bstring/fedora-rawhide-x86_64/10056651-bstring/bstring-1.0.3-1.fc44.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2432587 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432587%23c6 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2432587] Review Request: bstring - A string abstraction data type for the C language
https://bugzilla.redhat.com/show_bug.cgi?id=2432587 --- Comment #4 from Fedora Review Service --- Created attachment 2123735 --> https://bugzilla.redhat.com/attachment.cgi?id=2123735&action=edit The .spec file difference from Copr build 10054760 to 10056606 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2432587 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432587%23c4 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2432587] Review Request: bstring - A string abstraction data type for the C language
https://bugzilla.redhat.com/show_bug.cgi?id=2432587 --- Comment #5 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/10056606 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2432587-bstring/fedora-rawhide-x86_64/10056606-bstring/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2432587 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432587%23c5 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2432587] Review Request: bstring - A string abstraction data type for the C language
https://bugzilla.redhat.com/show_bug.cgi?id=2432587 --- Comment #3 from Andrew Bauer --- Thanks for the feedback. I changed the license to "BSD-3-Clause OR GPL-2.0-only" based on feedback from upstream here: https://github.com/msteinert/bstring/issues/116#issuecomment-3797097138 Let me know if you agree. I like your idea about switching from html -> docbook. I spent far more time futzing with this than I'd like to admit, but I am sitting inside after an epic snowstorm ...so I've got the time. Updated Spec URL: https://download.copr.fedorainfracloud.org/results/kni/bstring/fedora-rawhide-x86_64/10056597-bstring/bstring.spec Updated SRPM URL: https://download.copr.fedorainfracloud.org/results/kni/bstring/fedora-rawhide-x86_64/10056597-bstring/bstring-1.0.3-1.fc44.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2432587 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432587%23c3 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2432587] Review Request: bstring - A string abstraction data type for the C language
https://bugzilla.redhat.com/show_bug.cgi?id=2432587 Benson Muite changed: What|Removed |Added Assignee|[email protected]|[email protected] Status|NEW |ASSIGNED Flags||fedora-review? CC||[email protected] --- Comment #2 from Benson Muite --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD 3-Clause License", "Unknown or generated", "*No copyright* BSD 3-Clause License", "BSD 3-Clause License and/or GNU General Public License, Version 2", "*No copyright* BSD 3-Clause License and/or GNU General Public License, Version 2". 26 files have unknown license. Detailed output of licensecheck in /home/fedora- packaging/reviews/bstring/2432587-bstring/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/doc/bstring [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled() if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 5093 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/loc
[Bug 2432587] Review Request: bstring - A string abstraction data type for the C language
https://bugzilla.redhat.com/show_bug.cgi?id=2432587 Fedora Review Service changed: What|Removed |Added URL||https://github.com/msteiner ||t/bstring Keywords||AutomationTriaged --- Comment #1 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/10054760 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2432587-bstring/fedora-rawhide-x86_64/10054760-bstring/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2432587 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432587%23c1 -- ___ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
