Re: [PacketFence-devel] small patches for Ruckus controllers

2017-08-01 Thread Diego Garcia del Rio 
Ok. git is not my biggest friend... for some reason my PR is showing tons
of changed files, so I'll look a bit into more detail



On Tue, Aug 1, 2017 at 5:45 PM, Louis Munro  wrote:

>
>
> On Aug 1, 2017, at 16:30, Diego Garcia del Rio  wrote:
>
> PS, I guess I should submit the patch against the devel branch?
>
>
> That's correct.
> We do all development work in that branch and fork it when it comes time
> to release.
>
> Regards,
> --
> Louis Munro
> lmu...@inverse.ca  ::  www.inverse.ca
> +1.514.447.4918 x125  :: +1 (866) 353-6153 x125
> Inverse inc. :: Leaders behind SOGo (www.sogo.nu) and PacketFence (
> www.packetfence.org)
>
> 
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> PacketFence-devel mailing list
> PacketFence-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/packetfence-devel
>
>
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
PacketFence-devel mailing list
PacketFence-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/packetfence-devel

Re: [PacketFence-devel] small patches for Ruckus controllers

2017-08-01 Thread Louis Munro 


> On Aug 1, 2017, at 16:30, Diego Garcia del Rio  wrote:
> 
> PS, I guess I should submit the patch against the devel branch?
> 

That's correct.
We do all development work in that branch and fork it when it comes time to 
release.

Regards,
--
Louis Munro
lmu...@inverse.ca   ::  www.inverse.ca 
 
+1.514.447.4918 x125  :: +1 (866) 353-6153 x125
Inverse inc. :: Leaders behind SOGo (www.sogo.nu ) and 
PacketFence (www.packetfence.org )--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
PacketFence-devel mailing list
PacketFence-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/packetfence-devel

Re: [PacketFence-devel] small patches for Ruckus controllers

2017-08-01 Thread Diego Garcia del Rio 
PS, I guess I should submit the patch against the devel branch?


On Tue, Aug 1, 2017 at 5:28 PM, Diego Garcia del Rio 
wrote:

> Thanks Louis,
>
> I have a few small other patches (for google oauth, for example, to
> restrict the login options to a single google-apps domain). I will post
> other comments on the list for those as well.
>
> Best Regards,
>
> On Tue, Aug 1, 2017 at 3:03 PM, Louis Munro  wrote:
>
>> Hi Diego,
>> That's interesting.
>> Please do submit a PR.
>>
>> We'll take a look at it and if there's no problem we can include it in
>> 7.3.
>>
>> Thank you for your contribution and best regards from Inverse.
>> --
>> Louis Munro
>> lmu...@inverse.ca  ::  www.inverse.ca
>> +1.514.447.4918 x125  :: +1 (866) 353-6153 x125
>> Inverse inc. :: Leaders behind SOGo (www.sogo.nu) and PacketFence (
>> www.packetfence.org)
>>
>> On Aug 1, 2017, at 13:54, Diego Garcia del Rio  wrote:
>>
>> Hello everyone,
>>
>> I have been playing the last few weeks with PF integrating it with a
>> Ruckus zone-director controller and google-apps authentication.
>>
>> I have a some patches to submit on various small details, the first one
>> giving the ability to use roles in PF that can be mapped to Rucku's roles
>> so as to be able to do RBAC, set bandwidth limitations, etc. This adds the
>> "Ruckus-User-Group" radius attributes as well as enables the
>> wireless-mac-authentication.
>>
>> I have extensive experience with radius and Ruckus equipment as well as
>> access to both zoneDirector and SmartZone controllers so I can do some
>> further testing.
>>
>> I can submit a PR from my github repo.
>>
>> The patch in question is the following
>> https://github.com/garci66/packetfence/commit/d3d4dc0661f08a
>> 474de2c37d31b339ac5ee62ae7
>>
>> Thanks!
>> 
>> --
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot__
>> _
>> PacketFence-devel mailing list
>> PacketFence-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/packetfence-devel
>>
>>
>>
>> 
>> --
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> ___
>> PacketFence-devel mailing list
>> PacketFence-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/packetfence-devel
>>
>>
>
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
PacketFence-devel mailing list
PacketFence-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/packetfence-devel

Re: [PacketFence-devel] small patches for Ruckus controllers

2017-08-01 Thread Diego Garcia del Rio 
Thanks Louis,

I have a few small other patches (for google oauth, for example, to
restrict the login options to a single google-apps domain). I will post
other comments on the list for those as well.

Best Regards,

On Tue, Aug 1, 2017 at 3:03 PM, Louis Munro  wrote:

> Hi Diego,
> That's interesting.
> Please do submit a PR.
>
> We'll take a look at it and if there's no problem we can include it in 7.3.
>
> Thank you for your contribution and best regards from Inverse.
> --
> Louis Munro
> lmu...@inverse.ca  ::  www.inverse.ca
> +1.514.447.4918 x125  :: +1 (866) 353-6153 x125
> Inverse inc. :: Leaders behind SOGo (www.sogo.nu) and PacketFence (
> www.packetfence.org)
>
> On Aug 1, 2017, at 13:54, Diego Garcia del Rio  wrote:
>
> Hello everyone,
>
> I have been playing the last few weeks with PF integrating it with a
> Ruckus zone-director controller and google-apps authentication.
>
> I have a some patches to submit on various small details, the first one
> giving the ability to use roles in PF that can be mapped to Rucku's roles
> so as to be able to do RBAC, set bandwidth limitations, etc. This adds the
> "Ruckus-User-Group" radius attributes as well as enables the
> wireless-mac-authentication.
>
> I have extensive experience with radius and Ruckus equipment as well as
> access to both zoneDirector and SmartZone controllers so I can do some
> further testing.
>
> I can submit a PR from my github repo.
>
> The patch in question is the following
> https://github.com/garci66/packetfence/commit/
> d3d4dc0661f08a474de2c37d31b339ac5ee62ae7
>
> Thanks!
> 
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot__
> _
> PacketFence-devel mailing list
> PacketFence-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/packetfence-devel
>
>
>
> 
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> PacketFence-devel mailing list
> PacketFence-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/packetfence-devel
>
>
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
PacketFence-devel mailing list
PacketFence-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/packetfence-devel

Re: [PacketFence-devel] small patches for Ruckus controllers

2017-08-01 Thread Louis Munro 
Hi Diego,
That's interesting.
Please do submit a PR.

We'll take a look at it and if there's no problem we can include it in 7.3.

Thank you for your contribution and best regards from Inverse.
--
Louis Munro
lmu...@inverse.ca   ::  www.inverse.ca 
 
+1.514.447.4918 x125  :: +1 (866) 353-6153 x125
Inverse inc. :: Leaders behind SOGo (www.sogo.nu ) and 
PacketFence (www.packetfence.org )

> On Aug 1, 2017, at 13:54, Diego Garcia del Rio  wrote:
> 
> Hello everyone,
> 
> I have been playing the last few weeks with PF integrating it with a Ruckus 
> zone-director controller and google-apps authentication.
> 
> I have a some patches to submit on various small details, the first one 
> giving the ability to use roles in PF that can be mapped to Rucku's roles so 
> as to be able to do RBAC, set bandwidth limitations, etc. This adds the 
> "Ruckus-User-Group" radius attributes as well as enables the 
> wireless-mac-authentication.
> 
> I have extensive experience with radius and Ruckus equipment as well as 
> access to both zoneDirector and SmartZone controllers so I can do some 
> further testing.
> 
> I can submit a PR from my github repo.
> 
> The patch in question is the following
> https://github.com/garci66/packetfence/commit/d3d4dc0661f08a474de2c37d31b339ac5ee62ae7
>  
> 
> 
> Thanks!
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! 
> http://sdm.link/slashdot___
> PacketFence-devel mailing list
> PacketFence-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/packetfence-devel

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
PacketFence-devel mailing list
PacketFence-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/packetfence-devel