Re: [pacman-dev] [PATCH] libalpm/sync.c: restrict alpm_sync_newversion by USAGE_UPGRADE

2018-07-24 Thread Eli Schwartz
On 07/24/2018 09:23 PM, Morgan Adamiec wrote: > On Tue, 24 Jul 2018 at 20:40, Andrew Gregory > wrote: >> Based on how it's used, I'd say it should be SEARCH; it's being used >> as a filter for -Q and no upgrade transaction is being performed, or >> even prepared. >> >> Really, though, I'd say thi

Re: [pacman-dev] [PATCH] libalpm/sync.c: restrict alpm_sync_newversion by USAGE_UPGRADE

2018-07-24 Thread Eli Schwartz
On 07/24/2018 02:48 PM, Dave Reisner wrote: > On Tue, Jul 24, 2018 at 05:53:00PM +0100, morganamilo wrote: >> Commit 106d0fc54 Added the usage option for databases and >> alpm_sync_newversion was restricted by USAGE_SEARCH instead of >> USAGE_UPGRADE. > > I don't recall exactly what my thinking wa

Re: [pacman-dev] [PATCH] libalpm/sync.c: restrict alpm_sync_newversion by USAGE_UPGRADE

2018-07-24 Thread Morgan Adamiec
On Wed, 25 Jul 2018 at 02:28, Andrew Gregory wrote: > It makes no mention of upgrading either It is called alpm_sync_*newversion* >How is that different from just putting that repo below the one you want it to use normally? pacman -S pkg should return an error. These packages are not in any oth

Re: [pacman-dev] [PATCH] libalpm/sync.c: restrict alpm_sync_newversion by USAGE_UPGRADE

2018-07-24 Thread Andrew Gregory
On 07/25/18 at 02:23am, Morgan Adamiec wrote: > On Tue, 24 Jul 2018 at 20:40, Andrew Gregory > wrote: > > Based on how it's used, I'd say it should be SEARCH; it's being used > > as a filter for -Q and no upgrade transaction is being performed, or > > even prepared. > > > > Really, though, I'd sa

Re: [pacman-dev] [PATCH] libalpm/sync.c: restrict alpm_sync_newversion by USAGE_UPGRADE

2018-07-24 Thread Morgan Adamiec
On Tue, 24 Jul 2018 at 20:40, Andrew Gregory wrote: > Based on how it's used, I'd say it should be SEARCH; it's being used > as a filter for -Q and no upgrade transaction is being performed, or > even prepared. > > Really, though, I'd say this is a great example as to why usages > should have been

Re: [pacman-dev] [PATCH] libalpm/sync.c: restrict alpm_sync_newversion by USAGE_UPGRADE

2018-07-24 Thread Andrew Gregory
On 07/24/18 at 02:48pm, Dave Reisner wrote: > On Tue, Jul 24, 2018 at 05:53:00PM +0100, morganamilo wrote: > > Commit 106d0fc54 Added the usage option for databases and > > alpm_sync_newversion was restricted by USAGE_SEARCH instead of > > USAGE_UPGRADE. > > I don't recall exactly what my thinking

Re: [pacman-dev] [PATCH] libalpm/sync.c: restrict alpm_sync_newversion by USAGE_UPGRADE

2018-07-24 Thread Morgan Adamiec
On Tue, 24 Jul 2018 at 20:24, Erich Eckner wrote: > > On 24.07.2018 20:48, Dave Reisner wrote: > > On Tue, Jul 24, 2018 at 05:53:00PM +0100, morganamilo wrote: > >> Commit 106d0fc54 Added the usage option for databases and > >> alpm_sync_newversion was restricted by USAGE_SEARCH instead of > >> US

Re: [pacman-dev] [PATCH] libalpm/sync.c: restrict alpm_sync_newversion by USAGE_UPGRADE

2018-07-24 Thread Erich Eckner
On 24.07.2018 20:48, Dave Reisner wrote: > On Tue, Jul 24, 2018 at 05:53:00PM +0100, morganamilo wrote: >> Commit 106d0fc54 Added the usage option for databases and >> alpm_sync_newversion was restricted by USAGE_SEARCH instead of >> USAGE_UPGRADE. > > I don't recall exactly what my thinking was w

Re: [pacman-dev] [PATCH] libalpm/sync.c: restrict alpm_sync_newversion by USAGE_UPGRADE

2018-07-24 Thread Dave Reisner
On Tue, Jul 24, 2018 at 05:53:00PM +0100, morganamilo wrote: > Commit 106d0fc54 Added the usage option for databases and > alpm_sync_newversion was restricted by USAGE_SEARCH instead of > USAGE_UPGRADE. I don't recall exactly what my thinking was when I wrote this patch, but looking at 'pacman -Qu

[pacman-dev] [PATCH] libalpm/sync.c: restrict alpm_sync_newversion by USAGE_UPGRADE

2018-07-24 Thread morganamilo
Commit 106d0fc54 Added the usage option for databases and alpm_sync_newversion was restricted by USAGE_SEARCH instead of USAGE_UPGRADE. USAGE_UPGRADE should be used instead. This means packages only show up in commands such as `pacman -Qu` if the database Has the Upgrade option. Signed-off-by: mo