Re: [pacman-dev] [PATCH v2] libalpm: process needed before group selection

2018-10-17 Thread Andrew Gregory
On 10/17/18 at 04:40pm, morganamilo wrote: > When --needed is used, up to date packages are now filtered out > before showing the group select. > > Fixes FS#22870. > > Signed-off-by: morganamilo > --- > v2: Changed per Andrew's feedback. I wasn't concerned about the misleading message for this

[pacman-dev] [PATCH v2] libalpm: process needed before group selection

2018-10-17 Thread morganamilo
When --needed is used, up to date packages are now filtered out before showing the group select. Fixes FS#22870. Signed-off-by: morganamilo --- v2: Changed per Andrew's feedback. diff --git a/lib/libalpm/sync.c b/lib/libalpm/sync.c index b6ae7b72..05f58fad 100644 --- a/lib/libalpm/sync.c +++

[pacman-dev] [PATCH v2] alpm: Fix SIGINT handling re: aborting download

2018-10-17 Thread Olivier Brunel
Upon receiving SIGINT a flag is set to abort the (curl) download. However, since it was never reset/initialized, if a front-end doesn't actually exit on SIGINT, and later tries any operation that needs to perform a new download, said download would always get aborted right away due to the flag not

Re: [pacman-dev] [PATCH] alpm: Do not raise SIGINT when filesize goes over limit

2018-10-17 Thread Andrew Gregory
On 10/09/18 at 06:29pm, Olivier Brunel wrote: > Variable dload_interrupted is used both to abort a download because > SIGINT was caught, and when a file limit is reached. But raising SIGINT > is only meant to happen in the first case. > > Signed-off-by: Olivier Brunel > --- ACK.

Re: [pacman-dev] [PATCH] alpm: Fix SIGINT handling re: aborting download

2018-10-17 Thread Andrew Gregory
On 10/09/18 at 06:29pm, Olivier Brunel wrote: > Upon receiving SIGINT a flag is set to abort the (curl) download. > However, since it was never reset/initialized, if a front-end doesn't > actually exit on SIGINT, and later tries any operation that needs to > perform a new download, said download

Re: [pacman-dev] [PATCH] libalpm: process needed before group selection

2018-10-17 Thread Andrew Gregory
On 09/22/18 at 05:24pm, morganamilo wrote: > When --needed is used, up to date packages are now filtered out > before showing the group select. > > Signed-off-by: morganamilo > --- > > This patch set is currently incomplete. There is a problem where if every > package in the group is already

Re: [pacman-dev] [PATCH 1/2] Port pactest to python3

2018-10-17 Thread Andrew Gregory
On 09/20/18 at 05:43am, Dave Reisner wrote: > Use BytesIO instead of StringIO, and ensure that we unicode-encode data > where needed. > --- Any particular reason for the bump or just dropping the (allegedly) dead python2? I've held off from doing this so far because asciidoc is python2, hoping