Re: [pacman-dev] [PATCH 1/2] libalpm: Add dlclientcert and dlclientkey options.

2018-11-27 Thread Allan McRae
On 15/11/18 2:37 am, Maarten de Vries wrote: > These patches add support for client certificates to alpm and pacman. > > This can already be achieved currently by setting an XferCommand, > but doing so significantly reduces the quality of the feedback pacman > gives during the downloads.

[pacman-dev] [PATCH] libmakepkg/executable: don't rely on scoped value of $ret to flag outcomes

2018-11-27 Thread Eli Schwartz
Elsewhere, we return 1 if a library dropin fails, and when running functions in a loop, we use `|| ret=1` to preserve scope. This ensures the return value of the function remains useful in isolation. Do the same thing here as well. Drop trivial function which wraps a dropin that also uses $ret,

Re: [pacman-dev] [PATCH v2 1/2] makepkg: add internal variable to track when we're building a package

2018-11-27 Thread Allan McRae
On 28/11/18 1:46 am, Eli Schwartz wrote: > On 11/27/18 6:33 AM, Allan McRae wrote: >> On 14/11/18 11:55 am, Eli Schwartz wrote: >>> There are state variables for everything else, and we use them to do >>> conditional checks on things, but it's currently a bit difficult to test >>> whether a

Re: [pacman-dev] [PATCH v2 1/2] makepkg: add internal variable to track when we're building a package

2018-11-27 Thread Eli Schwartz
On 11/27/18 6:33 AM, Allan McRae wrote: > On 14/11/18 11:55 am, Eli Schwartz wrote: >> There are state variables for everything else, and we use them to do >> conditional checks on things, but it's currently a bit difficult to test >> whether a package is being built, as it's the default action if

[pacman-dev] [PATCH v3 2/2] Split prepare_buildenv() to libmakepkg

2018-11-27 Thread Que Quotion
From: Que Quotion Thank you for the assistance, and the merges. I triple checked these patches before sending them. I might have extremely early onset Alzheimer's. ¯\_(ツ)_/¯

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-67-g44cfc095

2018-11-27 Thread Allan McRae
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via 44cfc09511aa7c67eb09ee5ceec5cf6f23f7f9c9 (commit)

[pacman-dev] [PATCH] Remove Doxyfile from EXTRA_DIST

2018-11-27 Thread Allan McRae
We generate this now, so no need to distribute. Fixes "make dist". Signed-off-by: Allan McRae --- doc/Makefile.am | 1 - 1 file changed, 1 deletion(-) diff --git a/doc/Makefile.am b/doc/Makefile.am index 711921fd..4bb0f01b 100644 --- a/doc/Makefile.am +++ b/doc/Makefile.am @@ -65,7 +65,6 @@

Re: [pacman-dev] [PATCH v2 1/2] makepkg: add internal variable to track when we're building a package

2018-11-27 Thread Allan McRae
On 14/11/18 11:55 am, Eli Schwartz wrote: > There are state variables for everything else, and we use them to do > conditional checks on things, but it's currently a bit difficult to test > whether a package is being built, as it's the default action if *no* > options are specified. > >

Re: [pacman-dev] [PATCH] check localdb before upgrading package

2018-11-27 Thread Allan McRae
On 17/11/18 1:47 pm, Andrew Gregory wrote: > Commit 2ee7a8d89ad693617307260604e1d58757fd2978 replaced a manual check > for a local package with a check for the "oldpkg" member, which gets set > at the beginning of the transaction. If the package was also in the > remove list, such as when a

Re: [pacman-dev] [PATCH 1/3] add specific error for missing gpg support

2018-11-27 Thread Allan McRae
On 25/11/18 9:56 am, Andrew Gregory wrote: > "wrong or NULL argument passed" is a useless error for end users. > > Fixes FS#60880. > > Signed-off-by: Andrew Gregory > --- This patch series looks good to me. Allan

Re: [pacman-dev] [PATCH v3 2/2] Split prepare_buildenv() to libmakepkg

2018-11-27 Thread Allan McRae
On 27/11/18 7:23 pm, Que Quotion wrote: > From: Que Quotion > > This opens the door for third parties to provide libmakepkg > extentions for the purpose of altering the build environment. > > See makepkg-optimize in the AUR for examples. > > Signed-off-by: Que Quotion > --- OK. Caught a

Re: [pacman-dev] [PATCH v3 1/2] Split check_software() to libmakepkg

2018-11-27 Thread Allan McRae
On 27/11/18 7:23 pm, Que Quotion wrote: > From: Que Quotion > > This opens the door for third parties who provide extensions to > libmakepkg to supply scripts that confirm the presence of their > dependant executables. > > See makepkg-optimize in the AUR for examples. > > Signed-off-by: Que

[pacman-dev] [PATCH v3 2/2] Split prepare_buildenv() to libmakepkg

2018-11-27 Thread Que Quotion
From: Que Quotion This opens the door for third parties to provide libmakepkg extentions for the purpose of altering the build environment. See makepkg-optimize in the AUR for examples. Signed-off-by: Que Quotion --- scripts/Makefile.am | 6 +++

[pacman-dev] [PATCH v3 1/2] Split check_software() to libmakepkg

2018-11-27 Thread Que Quotion
From: Que Quotion This opens the door for third parties who provide extensions to libmakepkg to supply scripts that confirm the presence of their dependant executables. See makepkg-optimize in the AUR for examples. Signed-off-by: Que Quotion --- Split v2 patch into two patches as requested.