[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.2.0-8-gae5cf26b

2019-10-29 Thread Allan McRae
ow. - Log - commit ae5cf26b5b5b92c9f68b5b29787e7d636f334c12 Author: Allan McRae Date: Thu Oct 24 23:38:50 2019 +1000 Fix segfault importing PGP key for pacman -U operations Use after free. Signed-off-by: Allan McRa

Re: [pacman-dev] Alternatives system brainstorm

2019-10-28 Thread Allan McRae
On 28/10/19 8:30 pm, Daan van Rossum wrote: > * on Thursday, 2019-10-24 10:10 +1000, Allan McRae > wrote: > >> Compare that to the complexity of the original proposal example for python2: > > In this design, will /usr/bin/python be owned by a package like in the >

Re: [pacman-dev] [MAKEPKG][PATCH] makepkg-do-not-count-hard-links-multiple-times (INODESIZECMD) + meson

2019-10-28 Thread Allan McRae
On 28/10/19 3:01 am, la.l...@free.fr wrote: > Uses stat -c '%i %s' and sort -u to count hardlink one time. > Gives same result than cat | wc -c without harlinks and good result with > hardlinks. > Doesn't use filenames > Forwarding to the pacman-dev list. My concern is that this is using the

Re: [pacman-dev] [MAKEPKG][PATCH] makepkg-do-not-count-hard-links-multiple-times

2019-10-27 Thread Allan McRae
On 27/10/19 10:26 pm, la.l...@free.fr wrote: > Uses stat -c '%i %s' and sort -u to count hardlink one time. > Gives same result than cat | wc -c without harlinks and good result with > hardlinks. > Doesn't use filenames > > >>From cf4ef0333ccc6f080882ee9f3c27049be41bce67 Mon Sep 17 00:00:00

Re: [pacman-dev] [PATCH 2/2] makepkg: do not count hard linked file sizes multiple times

2019-10-26 Thread Allan McRae
On 27/10/19 1:11 pm, Ronan Pigott wrote: > From: Ronan Pigott > > --- > scripts/makepkg.sh.in | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in > index 997c8668..0725f582 100644 > --- a/scripts/makepkg.sh.in > +++

[pacman-dev] [PATCH] makepkg: do not count hard links multiple times when calculating pkg size

2019-10-26 Thread Allan McRae
Keeps track of file inodes that we have already counted using the same strategy as we do for zipman. Still uses "cat | wc -c" to calculate file sizes as it is the only thing guaranteed to be consistent. Signed-off-by: Allan McRae --- scripts/Makefile.am | 1

[pacman-dev] [PATCH] Fix segfault importing PGP key for pacman -U operations

2019-10-24 Thread Allan McRae
Use after free. Signed-off-by: Allan McRae --- lib/libalpm/be_package.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/libalpm/be_package.c b/lib/libalpm/be_package.c index 0f45c331..73d466de 100644 --- a/lib/libalpm/be_package.c +++ b/lib/libalpm/be_package.c @@ -759,7

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.2.0-6-gf37a3752

2019-10-24 Thread Allan McRae
--- commit f37a3752b38473236720e01230392377a42249e6 Author: Allan McRae Date: Wed Oct 23 21:11:43 2019 +1000 Update copyright years make update-copyright OLD=2018 NEW=2019 Signed-off-by: Allan McRae commit a9835a38a38e0045e13b68fe6d486b4ffebe6d79 Author: Allan McRae Date:

Re: [pacman-dev] Alternatives system brainstorm

2019-10-23 Thread Allan McRae
On 24/10/19 12:31 am, Daan van Rossum wrote: > * on Wednesday, 2019-10-23 22:05 +1000, Allan McRae > wrote: > >> Now, ignoring my comment about not commenting... My design principle for >> additions to makepkg is an addition should be mostly straight forward to >> a

Re: [pacman-dev] [PATCH] libmakepkg: add optional argument support to parseopts

2019-10-23 Thread Allan McRae
It is right... On 24/10/19 7:53 am, Ethan Sommer wrote: <- HERE > Signed-off-by: Ethan Sommer ... where you provide context for what the patch is implementing. What does it do and why? Allan

[pacman-dev] [PATCH] Update copyright years

2019-10-23 Thread Allan McRae
make update-copyright OLD=2018 NEW=2019 Signed-off-by: Allan McRae --- doc/index.asciidoc| 2 +- lib/libalpm/add.c | 2 +- lib/libalpm/add.h | 2 +- lib/libalpm

Re: [pacman-dev] [PATCH 1/2] Update completion for -F changes

2019-10-23 Thread Allan McRae
On 23/10/19 9:56 pm, Bruno Pagani wrote: > Le 23/10/2019 à 11:41, Allan McRae a écrit : >> - files=('list machinereadable owns search refresh regex' 'l o s x y') >> + files=('list machinereadablerefresh regex' 'l x y') > > Missing white space? > . > Thanks - fixed. A

Re: [pacman-dev] Alternatives system brainstorm

2019-10-23 Thread Allan McRae
On 23/10/19 9:35 pm, Daan van Rossum wrote: > * on Sunday, 2019-10-20 21:05 +1000, Allan McRae wrote: > >> It is constructive, but I don't think is necessarily relevant. Pacman >> is a system package manager, not a userspace software manager. >> >> The H

[pacman-dev] [PATCH 2/2] Remove --force from completion

2019-10-23 Thread Allan McRae
Signed-off-by: Allan McRae --- scripts/completion/bash_completion.in | 4 ++-- scripts/completion/zsh_completion.in | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/scripts/completion/bash_completion.in b/scripts/completion/bash_completion.in index 129a87aa..4e63aef9

[pacman-dev] [PATCH 1/2] Update completion for -F changes

2019-10-23 Thread Allan McRae
Signed-off-by: Allan McRae --- scripts/completion/bash_completion.in | 3 +-- scripts/completion/zsh_completion.in | 2 -- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/scripts/completion/bash_completion.in b/scripts/completion/bash_completion.in index 915004e2..129a87aa 100644

Re: [pacman-dev] [PATCH] makepkg: don't warn when PACKAGER is unset

2019-10-22 Thread Allan McRae
On 22/10/19 8:39 pm, morganamilo wrote: > makepkg now complains when PACKAGER is not in the format > "name ". > > Hide this warning when PACKAGER is unset but still warn if it is set to > something out of format. > That seems like a good exception to make. Pulled to my queue. Allan > diff

[pacman-dev] [PATCH] Fix compression of package databases with zstd

2019-10-22 Thread Allan McRae
From: Nick Cao Commit 7afe51171 attempted to add zstd compression support to repo-add, but failed... FS#64213 Signed-off-by: Allan McRae --- scripts/repo-add.sh.in | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/scripts/repo-add.sh.in b/scripts/repo-add.sh.in

[pacman-dev] [PATCH] Fix distribution of meson files

2019-10-21 Thread Allan McRae
Signed-off-by: Allan McRae --- Also caught not distributing source for one of the man pages... I would have expected people that are interested in meson to have tested the patch that ensured these files were distributed! doc/Makefile.am | 1 + scripts/Makefile.am | 4 +++- 2 files changed

[pacman-dev] [GIT] The official pacman repository annotated tag, v5.2.0, created. v5.2.0

2019-10-21 Thread Allan McRae
d6a19 (tag) tagging 8ce20d3754769845f0b3452b06db2e1792108ec9 (commit) replaces v5.1.1 tagged by Allan McRae on Mon Oct 21 19:54:32 2019 +1000 - Log - Deltas were overrated -BEGIN PGP

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-242-g8ce20d37

2019-10-21 Thread Allan McRae
ow. - Log - commit 8ce20d3754769845f0b3452b06db2e1792108ec9 Author: Allan McRae Date: Mon Oct 21 17:56:25 2019 +1000 Release v5.2.0 Signed-off-by: Allan McRae commit de24f644f4d2cbd874a511389e83a3fdd39c1773 Author: Allan McRae Date:

Re: [pacman-dev] Alternatives system brainstorm

2019-10-20 Thread Allan McRae
On 20/10/19 7:52 pm, Daan van Rossum wrote: > * on Sunday, 2019-10-20 14:24 +1000, Allan McRae wrote: > >> That is on the cards. I had the example of the lua include directory >> in the first email, but did not explicitly specify that we could symlink >> dire

Re: [pacman-dev] Alternatives system brainstorm

2019-10-19 Thread Allan McRae
On 20/10/19 10:15 am, Levente Polyak wrote: > On October 20, 2019 2:10:44 AM GMT+02:00, Andrew Gregory > wrote: >> >> So the features I think would be useful are: >> 1) the ability to select alternatives per-file >> 2) the ability to select alternatives per-package >> 3) the ability to group

Re: [pacman-dev] Alternatives system brainstorm

2019-10-19 Thread Allan McRae
On 19/10/19 10:41 pm, Allan McRae wrote: > On 19/10/19 10:38 pm, Allan McRae wrote: >> On 19/10/19 10:24 pm, Andrew Gregory wrote: >>> On 10/19/19 at 10:15pm, Allan McRae wrote: >>>> On 19/10/19 9:57 pm, Daan van Rossum wrote: >>>>> * on Saturday, 2019

Re: [pacman-dev] Alternatives system brainstorm

2019-10-19 Thread Allan McRae
On 19/10/19 10:38 pm, Allan McRae wrote: > On 19/10/19 10:24 pm, Andrew Gregory wrote: >> On 10/19/19 at 10:15pm, Allan McRae wrote: >>> On 19/10/19 9:57 pm, Daan van Rossum wrote: >>>> * on Saturday, 2019-10-19 18:15 +1000, Allan McRae >>>> wrote: >

Re: [pacman-dev] Alternatives system brainstorm

2019-10-19 Thread Allan McRae
On 19/10/19 10:24 pm, Andrew Gregory wrote: > On 10/19/19 at 10:15pm, Allan McRae wrote: >> On 19/10/19 9:57 pm, Daan van Rossum wrote: >>> * on Saturday, 2019-10-19 18:15 +1000, Allan McRae >>> wrote: >>> >>>> /bin/sh -> bash/dash >>&

Re: [pacman-dev] Alternatives system brainstorm

2019-10-19 Thread Allan McRae
On 19/10/19 9:57 pm, Daan van Rossum wrote: > * on Saturday, 2019-10-19 18:15 +1000, Allan McRae > wrote: > >> /bin/sh -> bash/dash >> /usr/bin/awk -> gawk/nawk >> /usr/bin/cc -> gcc/clang > > Can we provide alternatives by means of sets of mutually

Re: [pacman-dev] Alternatives system brainstorm

2019-10-19 Thread Allan McRae
On 19/10/19 5:56 pm, Daan van Rossum wrote: > * on Saturday, 2019-10-19 02:30 +0200, brainpower > wrote: > >> "first wins" feels more "KISS" to me, it's logic is less complex and I >> think it has the least "surprise potential". >> >> >> The only thing I'd feel strongly about some automatic

Re: [pacman-dev] Alternatives system brainstorm

2019-10-17 Thread Allan McRae
On 18/10/19 5:04 am, Giancarlo Razzolini wrote: > Em outubro 17, 2019 12:41 Eli Schwartz escreveu: >> >> If priorities are implemented they should be wherever the actual >> alternatives are, IMO. Less fragmentation. If pacman already needs to >> read an "alternatives" database to know what the

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-240-g9ddd0be0

2019-10-17 Thread Allan McRae
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via 9ddd0be02776f3b08cc3adc8a65f0630c05574f8 (commit)

[pacman-dev] Alternatives system brainstorm

2019-10-17 Thread Allan McRae
Hi all, Some further brainstorming on alternatives system. Last time, I suggested something like: alternatives=(python->python3) But as was pointed out, there may be many other things you want to bring along with the python binary. Some directly related: /usr/share/man/man1/python3.1.gz ->

[pacman-dev] [PATCH] Document changes between 5.1 and 5.2

2019-10-16 Thread Allan McRae
From: Eli Schwartz Signed-off-by: Eli Schwartz --- Allan: rearranged some of the entries to put more newsworthy stuff at the top. NEWS | 116 +++ 1 file changed, 116 insertions(+) diff --git a/NEWS b/NEWS index ce39e0c5..a55dac85

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-239-gb05a3c10

2019-10-15 Thread Allan McRae
ail; so we list those revisions in full, below. - Log - commit b05a3c10bff000a498e8f3dbfc161cce44776181 Author: Allan McRae Date: Tue Oct 15 21:29:22 2019 +1000 Update README for pacman 5.2.0 release This is the first maj

[pacman-dev] [PATCH] Update README for pacman 5.2.0 release

2019-10-15 Thread Allan McRae
This is the first major release without any additions to the libalpm API! Signed-off-by: Allan McRae --- README | 25 + 1 file changed, 25 insertions(+) diff --git a/README b/README index d96eae21..6818ef70 100644 --- a/README +++ b/README @@ -630,3 +630,28 @@ API

Re: [pacman-dev] [PATCH v2 2/2] libalpm: set errno in signing dummy functions

2019-10-15 Thread Allan McRae
On 15/10/19 7:30 pm, morganamilo wrote: > This allows pacman to print the correct error message when checking keys > and libalpm has been compiled without gpgme support. > --- Thanks, Both patches look good and will be pushed before release. Allan

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-236-g27ccd689

2019-10-13 Thread Allan McRae
--- commit 27ccd6897640f3dab76624825504a7ae02ddda26 Author: Allan McRae Date: Mon Oct 14 09:43:35 2019 +1000 Translation updates Pull all translations with >75% completion. Signed-off-by: Allan McRae --- Summa

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-235-g5e11d86c

2019-10-13 Thread Allan McRae
ew Gregory Signed-off-by: Allan McRae --- Summary of changes: src/pacman/remove.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- The official pacman repository

Re: [pacman-dev] [PATCH] pacman: return 1 when -F has no results

2019-10-12 Thread Allan McRae
On 13/10/19 5:12 am, morganamilo wrote: > --- > > This is basically my V2 for "pacman: better handle -F when file is not > found". > > With the freeze coming up and me not having that much time to do pacman > stuff, this is the best I've got right now. > Pulled - this is a nice minimal patch

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-234-gd4e667ee

2019-10-12 Thread Allan McRae
--- commit d4e667ee5eeb3139045d7333fcddf6ba449da7b2 Author: morganamilo Date: Sat Oct 12 20:12:03 2019 +0100 pacman: return 1 when -F has no results Signed-off-by: Allan McRae --- Summary of changes: src/pacman/files.c |

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-233-g808a4f15

2019-10-12 Thread Allan McRae
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via 808a4f15ce82d2ed7eeb06de73d0f313620558ee (commit)

Re: [pacman-dev] [PATCH v2 2/3] add arg_to_string helper

2019-10-12 Thread Allan McRae
On 12/10/19 8:20 pm, Ralph Corderoy wrote: > Hi Andrew, > >> -for(i = 0; i + 1 < argc; i++) { >> -strcpy(p, argv[i]); >> -p += strlen(argv[i]); >> -*p++ = ' '; >> -} > > stpcpy(3)? > This patch is just relocating that code block. A change to stpcpy

Re: [pacman-dev] [PATCH v2 3/3] run XferCommand via exec

2019-10-12 Thread Allan McRae
On 12/10/19 1:45 pm, Andrew Gregory wrote: > system() runs the provided command via a shell, which is subject to > command injection. Even though pacman already provides a mechanism to > sign and verify the databases containing the urls, certain distributions > have yet to get their act together

Re: [pacman-dev] [PATCH v2 3/3] run XferCommand via exec

2019-10-12 Thread Allan McRae
On 12/10/19 1:45 pm, Andrew Gregory wrote: > system() runs the provided command via a shell, which is subject to > command injection. Even though pacman already provides a mechanism to > sign and verify the databases containing the urls, certain distributions > have yet to get their act together

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-230-ga897599f

2019-10-08 Thread Allan McRae
Signed-off-by: Christian Hesse Signed-off-by: Allan McRae commit 379f7151056e804ba61caa6c72407ffa79c6649a Author: Christian Hesse Date: Mon Oct 7 16:00:56 2019 +0200 signing: modify question text with unknwon uid If the key's uid is unknown (for example with db signatures) the

Re: [pacman-dev] [PATCH] makepkg: do not save fflags when creating packages

2019-10-07 Thread Allan McRae
On 8/10/19 12:48 pm, Eli Schwartz wrote: > On 10/7/19 10:34 PM, Allan McRae wrote: >> On 8/10/19 7:18 am, Eli Schwartz wrote: >>> This breaks reproducible builds due to encoding information specific to >>> the filesystem which was used to build the package, informa

Re: [pacman-dev] [PATCH 1/2] signing: modify question text with unknwon uid

2019-10-07 Thread Allan McRae
On 7/10/19 11:35 pm, Christian Hesse wrote: > From: Christian Hesse > > If the key's uid is unknown (for example with db signatures) the > question was: > > :: Import PGP key 02FD1C7A934E614545849F19A6234074498E9CEE, "(null)"? [Y/n] > > Let's display a modified question for unknwon uid. Typo

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-227-gd5c3ed12

2019-10-07 Thread Allan McRae
/pipermail/gnupg-users/2019-July/062169.html Signed-off-by: Jonas Witschel Signed-off-by: Allan McRae --- Summary of changes: scripts/pacman-key.sh.in | 25 + 1 file changed, 17 insert

Re: [pacman-dev] [PATCH v3] pacman-key: receive keys from WKD with -r/--recv-keys

2019-10-07 Thread Allan McRae
On 7/10/19 8:56 pm, Jonas Witschel wrote: > If an email address is specified, we use --locate-key to look up the key > using WKD and keyserver as a fallback. If the key is specified as a key > ID, this doesn't work, so we use the normal keyserver-based --recv-keys. > > Note that --refresh-keys

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-226-g5d2e48d1

2019-10-07 Thread Allan McRae
--- commit 5d2e48d17f5a6268c8d290320da85da8dca19b85 Author: Allan McRae Date: Mon Oct 7 18:12:24 2019 +1000 Pull and push translation changes in preparation for 5.2 Signed-off-by: Allan McRae --- Summary of changes: lib/

Re: [pacman-dev] pacman-5.2 progress

2019-10-07 Thread Allan McRae
On 7/10/19 6:11 pm, Jonas Witschel wrote: > Hi Allan, > > On 2019-10-07 09:55, Allan McRae wrote: >> Now the WKD patches have landed [...] > Great, thanks for reviewing and merging these! > > During the latest iteration, I got confused with the number of patches &g

Re: [pacman-dev] [PATCH 5/5 v2] pacman-key: receive keys from WKD with -r/--recv-keys

2019-10-07 Thread Allan McRae
On 6/8/19 1:32 am, Jonas Witschel wrote: > If an email address is specified, we use --locate-key to look up the key > using WKD and keyserver as a fallback. If the key is specified as a key > ID, this doesn't work, so we use the normal keyserver-based --recv-keys. > > Note that --refresh-keys

[pacman-dev] pacman-5.2 progress

2019-10-07 Thread Allan McRae
Hi all, I attacked the patch queue today - I think everything that was ready to be committed was, and everything that was not has been commented on. Now the WKD patches have landed, the only thing on my radar is the exec XferCommand patch, but I am not worried if that does not make this release.

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-225-g7e79cf73

2019-10-07 Thread Allan McRae
R1 to the process group, with resulting exit code 138. In case remove_deps fails, this patch exits makepkg with E_REMOVE_DEPS if there was no previous error (that is, EXIT_CODE equals E_OK). Otherwise, makepkg exits with EXIT_CODE. Signed-off-by: Allan McRae commit 095d6332bea6cd44e

Re: [pacman-dev] [PATCH] makepkg: propagate E_REMOVE_BUILD_DEPS

2019-10-07 Thread Allan McRae
On 21/1/19 8:14 am, Alad Wenter wrote: > remove_deps is called once, at the end of clean_up() before makepkg > exit. If remove_deps returns >0 (e.g. when pressing "n" in the resulting > prompt), the error is caught by the ERR signal handler. This in turns > sends SIGUSR1 to the process group, with

Re: [pacman-dev] [pacman] [PATCH] makepkg: remove makedepends before installing built package

2019-10-07 Thread Allan McRae
On 12/9/19 11:22 pm, a...@eckner.net wrote: > From: Erich Eckner > > When running `makepkg -i` it may be necessary to first remove make- and > checkdepends before installing the built package - for example if they > conflict each other. This is the case for wireguard-arch which > makedepends and

[pacman-dev] [PATCH] makepkg: wait for process to finish

2019-10-07 Thread Allan McRae
Without the -f option to wait, we might move on and try to delete the logpipe before the process is completed. Signed-off-by: Allan McRae --- This is a follow-up to the logpipe discussion. Hopefully this prevents the need for rm -f on $logpipe, but we will have to wait and see if that issue

Re: [pacman-dev] [PATCH] makepkg: Only change debug prefix if making debug package

2019-10-06 Thread Allan McRae
On 29/7/19 2:52 pm, Austin Lund wrote: > Currently all debug builds will prefix /usr/src/build to the source > paths. If debugging symbols are stripped into a separate package then > these sources files are indeed in this path. But if the debug build is > not stripped then one is left with a

Re: [pacman-dev] [PATCH] pacman: new config to highlight testing packages

2019-10-06 Thread Allan McRae
On 10/9/19 8:42 pm, Jan Alexander Steffens wrote: > On Tue, Sep 10, 2019, 12:17 Morten Linderud wrote: > >> If you turn it around and add a list instead? >> >> HilightRepositories = testing community-testing >> > > You could give each [repo] a Color= setting. > An option per repo would be

Re: [pacman-dev] [PATCH] pacman/pacman-conf: -i/--is-set switch, returns 0 if option set

2019-10-06 Thread Allan McRae
On 11/9/19 10:29 am, Eli Schwartz wrote: > On 9/10/19 2:32 PM, Matthew Sexton wrote: >> Returns 1 if option not set. Returns 1 with error to stderr if >> flag does not exist. Case insensitive. > > As discussed on IRC, it seems like this may be easier and more reliable > to achieve by using exit

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-221-g8f89e509

2019-10-06 Thread Allan McRae
an -T zlib` Signed-off-by: Allan McRae commit f2442bc2e9d41a68b9965c272794600836c36b8b Author: morganamilo Date: Sun Sep 8 22:45:28 2019 +0100 libalpm: short circuit alpm_find_dbs_satisfier when a satisfying package is already installed, we always pick it instead of

Re: [pacman-dev] [PATCH 4/4] pacman: speed up deptest

2019-10-06 Thread Allan McRae
On 9/9/19 7:45 am, morganamilo wrote: > Try and find an exact match via pkgcache before iterating the entire > localdb. > > Gives a noticeable speed up for exact matches e.g. `pacman -T zlib` > Thanks. Applied. > --- > > Do note this fails for versioned exact matches. "zlib>1" will not take

Re: [pacman-dev] [PATCH 3/4] libalpm: short circuit alpm_find_dbs_satisfier

2019-10-06 Thread Allan McRae
On 9/9/19 7:45 am, morganamilo wrote: > when a satisfying package is already installed, we always pick it > instead of prompting the user. So we can return that package as soon as > we find it, instead of waiting until we've iterated through all the > databases. > --- Ack. > lib/libalpm/deps.c

Re: [pacman-dev] [PATCH 1/4] libalpm: fix incorrect documentation

2019-10-06 Thread Allan McRae
On 9/9/19 7:45 am, morganamilo wrote: > --- > lib/libalpm/deps.c | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) > Changes look fine. A > diff --git a/lib/libalpm/deps.c b/lib/libalpm/deps.c > index 71185c68..ce7869c3 100644 > --- a/lib/libalpm/deps.c > +++

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-215-gde6249ce

2019-10-06 Thread Allan McRae
ixes FS#58626 Signed-off-by: Eli Schwartz Signed-off-by: Allan McRae --- Summary of changes: RELEASE | 1 + build-aux/edit-script.sh.in | 1 + configure.ac

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-214-g2a792ac7

2019-10-06 Thread Allan McRae
i Schwartz Signed-off-by: Allan McRae commit f49233903521f19a1fcba6bf6c36abea71309a1e Author: Eli Schwartz Date: Sun Oct 6 23:11:19 2019 -0400 pacman-key: make sure we actually use the Web of Trust, which GnuPG doesn't. By default, the latest versions of GnuPG disable the We

Re: [pacman-dev] [PATCH 2/2] pacman-key: make sure we actually use the Web of Trust, which GnuPG doesn't.

2019-10-06 Thread Allan McRae
On 7/10/19 12:53 pm, Eli Schwartz wrote: > On 10/6/19 10:42 PM, Allan McRae wrote: >>> + if (( $(vercmp "$gpg_ver" 2.2.17) >= 0 )); then >>> + add_gpg_conf_option "$conffile" 'keyserver-options' >>> 'no-self-sigs-only,no-import-

Re: [pacman-dev] [PATCH 2/2] pacman-key: make sure we actually use the Web of Trust, which GnuPG doesn't.

2019-10-06 Thread Allan McRae
On 6/8/19 2:53 am, Eli Schwartz wrote: > By default, the latest versions of GnuPG disable the Web of Trust and > refuse to import signatures from public keyservers. This is to prevent > denial of service attacks, because refusing to import signatures only if > the key size is too big, is

Re: [pacman-dev] [PATCH 2/4] libalpm: resolvedep(): don't compare names twice

2019-10-06 Thread Allan McRae
On 9/9/19 7:45 am, morganamilo wrote: > If we failed to get the pkg from pkgcache then we know no satisfying > package exists by name. So only compare provides. > --- > lib/libalpm/deps.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Thanks. Applied. > diff --git

Re: [pacman-dev] [PATCH v2] libmakepkg: when stripping split debug symbols, warn on duplicate paths

2019-10-06 Thread Allan McRae
On 7/10/19 11:29 am, Eli Schwartz wrote: > Trying to strip multiple files installed to the same filepath (in > different components of a split package) can produce surprising results > if those files are built using different options. Per FS#63356 this is > not a supported PKGBUILD configuration.

Re: [pacman-dev] [PATCH v3] makepkg: add rust support for *FLAGS and debug-prefix-map

2019-10-06 Thread Allan McRae
On 7/10/19 11:33 am, Eli Schwartz wrote: > The rust language supports $RUSTFLAGS to be used automatically in all > rustc invocations. Allow setting this in makepkg.conf (e.g. for > optimization or debuginfo support), and teach debug+strip to pass the > rustc command line argument necessary to

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-207-g48752f1b

2019-10-06 Thread Allan McRae
d up using their fingerprint, but by email address. Since the email address of the signing key is usually not included in the signature, we will use the packager email address to perform the lookup. Also see FS#63171. Signed-off-by: Jonas Witschel Signed-off-by: Allan McRa

Re: [pacman-dev] [PATCH v3 2/3] signing: add ability to import keys using a WKD

2019-10-06 Thread Allan McRae
On 3/10/19 12:40 am, Jonas Witschel wrote: > Currently pacman relies on the SKS keyserver network to fetch unknown > PGP keys. These keyservers are vulnerable to signature spamming attacks, > potentionally making it impossible to import the required keys. An > alternative to keyservers is a

Re: [pacman-dev] [PATCH] dload: never return NULL from get_filename

2019-10-06 Thread Allan McRae
On 7/10/19 10:06 am, Dave Reisner wrote: > Downloads with a Content-Disposition header will typically not include > slashes. When they do, we should most certainly only take the basename, > but when they don't, we should treat the header value as the filename. > > Crash introduced in d197d8ab82cf

Re: [pacman-dev] [PATCH v3 3/3] libmakepkg: check if PACKAGER has the expected format for WKD lookup

2019-10-03 Thread Allan McRae
On 3/10/19 12:40 am, Jonas Witschel wrote: > pacman should be able to extract an email address from PACKAGER for WKD > lookup, so issue a warning if it is not of the form > "Example Name ". Neither the name nor the email > address must contain additional angle brackets. > Thanks. I have

[pacman-dev] [PATCH] makepkg.conf.5: Document PACKAGER format requirements

2019-10-03 Thread Allan McRae
Signed-off-by: Allan McRae --- doc/makepkg.conf.5.asciidoc | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/makepkg.conf.5.asciidoc b/doc/makepkg.conf.5.asciidoc index 9292b2a6..a8995a27 100644 --- a/doc/makepkg.conf.5.asciidoc +++ b/doc/makepkg.conf.5.asciidoc @@ -244,6 +244,7 @@ Options

Re: [pacman-dev] [PATCH 2/2] meson: generate the autotools distribution files

2019-10-03 Thread Allan McRae
On 16/8/19 9:55 am, Eli Schwartz wrote: > For cross-compatibility with autotools, a dist tarball created from > either meson or autotools should have everything needed to build with > either build system. This ensures that all the files which "make dist" > would make available, are available. > >

Re: [pacman-dev] [PATCH v2 1/2] pacman/pacman-conf: removed hputs macro for usage display

2019-09-10 Thread Allan McRae
On 10/9/19 7:33 pm, Matthew Sexton wrote: > Signed-off-by: Matthew Sexton > --- What changed in v2 apart from the disappearing commit message? > src/pacman/pacman-conf.c | 24 +++- > 1 file changed, 11 insertions(+), 13 deletions(-) > > diff --git

Re: [pacman-dev] [PATCH] makepkg: Delete logpipe when cleaning up

2019-08-26 Thread Allan McRae
On 26/8/19 9:29 pm, Austin Lund wrote: > There are a number of exit paths where the logpipe fifo remains in the > logging directory. Remove it if it exists when cleaning up at exit. Can you provide an example that is not caught by error_function()? A

Re: [pacman-dev] [PATCH] RFC: support file with seccomp enabled

2019-08-12 Thread Allan McRae
On 12/8/19 1:46 pm, Eli Schwartz wrote: > Not all compression types can be detected in the seccomp sandbox, so we > need to disable it. This requires either configuring makepkg to know the > sandbox is available, or checking for file >= 5.38 in which the sandbox > option is a no-op even when

[pacman-dev] Preparing for pacman-5.2

2019-08-11 Thread Allan McRae
Hi all, It is well beyond time I made another release, so here we go! There is still a few patches that will land. Mostly to do with WKD stuff - these still need a thorough review. Other patches I know of in the queue: - file -S - debug symbol conflicts - RUSTFLAGS Flag anything else with

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-200-g024fde97

2019-08-11 Thread Allan McRae
--- commit 024fde9748692c71f0d9e6c667439c912a78b6df Author: Allan McRae Date: Mon Aug 12 11:42:10 2019 +1000 Prepare translations for next release Signed-off-by: Allan McRae --- Summary of changes: lib/libalp

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-199-gf9f22fde

2019-08-11 Thread Allan McRae
ith memcpy(), without copying the terminating null character. Since fname is allocated with malloc(), subsequent strstr() calls will overrun the buffer's boundary. Signed-off-by: László Várady Signed-off-by: Allan McRae commit 18a64400617259b34ccf014682fd8022d551a036 Au

[pacman-dev] [GIT] The official pacman repository branch, release/5.1.x, updated. v5.1.3-1-gb4c7a06f

2019-08-11 Thread Allan McRae
--- commit b4c7a06f7983d9f43f54b0ded9cf5c0eb126246c Author: Allan McRae Date: Mon Aug 12 11:25:56 2019 +1000 Pull translation updates from Transifex Signed-off-by: Allan McRae --- Summary of changes: lib/libalp

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-197-g75837a27

2019-08-05 Thread Allan McRae
-off-by: Austin Lund Signed-off-by: Allan McRae commit 0318e84546cb368361b94412d0861f9d3971d6b2 Author: Dave Reisner Date: Sat Jun 29 12:58:28 2019 -0400 build-aux: detect build dir based on build.ninja .ninja.log is only present after building (successful or otherw

Re: [pacman-dev] [PATCH] fixup run XferCommand via exec

2019-08-05 Thread Allan McRae
On 10/6/19 6:50 am, Andrew Gregory wrote: > --- > > A few changes I omitted from the initial patch. > > Does anybody know what usepart was for? It was unset unless %o was > used in XferCommand, but I'm not sure what the use case for an > XferCommand without %o would be. > According to the man

Re: [pacman-dev] [PATCH] makepkg: add rust support for *FLAGS and debug-prefix-map

2019-08-05 Thread Allan McRae
On 4/7/19 7:40 am, Eli Schwartz wrote: > The rust language supports $RUSTFLAGS to be used automatically in all > rustc invocations. Allow setting this in makepkg.conf (e.g. for > optimization or debuginfo support), and teach debug+strip to pass the > rustc command line argument necessary to

Re: [pacman-dev] [RFC PATCH] makepkg: add support for SAMUFLAGS, comparable to MAKEFLAGS

2019-08-05 Thread Allan McRae
On 4/7/19 7:57 am, Eli Schwartz wrote: > SAMUFLAGS is recently added to the samurai build tool, an implementation > of the ninja build format (which is a competitor to Makefiles). > Currently, samurai implements support for -v (verbose) and -j > (configuring the number of parallel jobs) and

Re: [pacman-dev] [PATCH 5/5] pacman-key: receive keys from WKD with -r/--recv-keys

2019-08-05 Thread Allan McRae
On 18/7/19 6:06 am, Jonas Witschel wrote: > If an email address is specified, we use --locate-key to look up the key > using WKD and keyserver as a fallback. If the key is specified as a key > ID, this doesn't work, so we use the normal keyserver-based --recv-keys. > > Note that --refresh-keys

Re: [pacman-dev] [PATCH 3/5] sync: lookup missing keys in the WKD using the packager email

2019-08-05 Thread Allan McRae
On 18/7/19 6:06 am, Jonas Witschel wrote: > We assume that the packager is of the form > "Example Name " and that the key used to sign the > package can be resolved using WKD with this address. This means that the > package signing key should have one user ID with the given email > address, which

Re: [pacman-dev] [PATCH] tolerate broken logpipe

2019-08-05 Thread Allan McRae
On 10/7/19 12:52 pm, Eli Schwartz wrote: > On 7/9/19 9:57 PM, Yardena Cohen wrote: >> Sometimes makechrootpkg fails with: >> >>rm: cannot remove '/logdest/logpipe.': No such file or directory >> >> This shouldn't cause the whole script to fail, so let's tolerate a missing >> pipe > >

Re: [pacman-dev] [PATCH] makepkg: Ignore "" source files

2019-08-05 Thread Allan McRae
On 30/7/19 3:01 pm, Austin Lund wrote: > An artificial symbol can be produced when requesting debugging symbols > and the compiler has inlined a function. These symbols will give > spurious results when listing source files for inclusion in debug > packages. This will ignore these symbols and

Re: [pacman-dev] [PATCH 3/4] meson: remove tap-driver.py, use meson's TAP protocol

2019-08-05 Thread Allan McRae
On 30/6/19 2:58 am, Dave Reisner wrote: > This includes a patch from Andrew to fix pactest's TAP output for > subtests. Original TAP support in meson was added in 0.50, but 0.51 > contains a bugfix that ensures the test still work with the --verbose > flag passed to meson test, so let's depend on

Re: [pacman-dev] [PATCH 2/2] create coredump on segfault

2019-08-05 Thread Allan McRae
On 8/6/19 2:12 pm, Andrew Gregory wrote: > Overriding the segfault handler prevents the creation of core dumps by > the default handler, which makes debugging segfaults difficult. > > Signed-off-by: Andrew Gregory > --- This looks good to me. I did a double take at the underscore leading the

Re: [pacman-dev] [PATCH 1/2] sighandler: block signals while handling SIGSEGV

2019-08-05 Thread Allan McRae
On 8/6/19 2:12 pm, Andrew Gregory wrote: > If we get SIGSEGV we need to bail out quickly, leaving other signals > unblocked could lead to other signal handlers getting triggered. > > Signed-off-by: Andrew Gregory > --- > > Signals are hard. I'd appreciate if somebody could double check my >

Re: [pacman-dev] [PATCH] makepkg: Only change debug prefix if making debug package

2019-07-30 Thread Allan McRae
On 30/7/19 3:33 pm, Eli Schwartz wrote: > glibc is forcing !strip because it needs to manually strip and thereby > exclude a few files from being stripped. I have a better solution in > aur/glibc-git for this which could probably be used. The Arch glibc package does this because Arch still does

Re: [pacman-dev] [PATCH] Correctly report a download failiure for 404s

2019-06-27 Thread Allan McRae
On 12/6/19 2:43 am, morganamilo wrote: > Currently when caling alpm_trans_commit, if fetching a package restults > in a 404 (or other non 400 response code), the function returns -1 but > errno is never set. > > Thish patch sets errno to ALPM_ERR_RETRIEVE. > OK. Fixed typo in commit message.

Re: [pacman-dev] [PATCH] doc: Add a man page describing PKGINFO

2019-06-27 Thread Allan McRae
On 22/6/19 7:39 am, Jelle van der Waa wrote: > From: Jelle van der Waa > > Describe the PKGINFO format which resides in a package produced makepkg. > --- > doc/Makefile.am| 4 +- > doc/PKGINFO.5.asciidoc | 86 ++ > doc/meson.build| 1 + >

[pacman-dev] [PATCH] makepkg: do not exit immediately on dependency install failures

2019-06-25 Thread Allan McRae
Fixes FS#63000 Signed-off-by: Allan McRae --- scripts/makepkg.sh.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index aa03e9d9..43484db3 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -273,7 +273,7

Re: [pacman-dev] [PATCH] use consistent time notation for the log

2019-06-20 Thread Allan McRae
On 9/6/19 5:50 am, Andrew Gregory wrote: > %X is locale-dependent, making it impossible to reliably parse and > potentially overflowing the buffer. %T is consistent across locales. > > Also fixes some adjacent whitespace. > > Signed-off-by: Andrew Gregory > --- OK. Thanks, A

Re: [pacman-dev] [PATCH] pacman: correctly free lists

2019-06-20 Thread Allan McRae
On 14/6/19 11:50 am, morganamilo wrote: > > diff --git a/src/pacman/database.c b/src/pacman/database.c > index f3b890ce..7a792bad 100644 > --- a/src/pacman/database.c > +++ b/src/pacman/database.c > @@ -105,7 +105,8 @@ static int check_db_missing_deps(alpm_list_t *pkglist) >

[pacman-dev] [PATCH] Fix compiler warnings with gcc-9.1

2019-06-20 Thread Allan McRae
Signed-off-by: Allan McRae --- I think these are all legimite ways of fixing the warings... callback.c: filenamelen >= 50-33, so i is always positive. No need for that check pacman.c: this is the same condition, it just changes the compiler optimisation of the loop to avoid the warn

<    1   2   3   4   5   6   7   8   9   10   >