Re: [pacman-dev] [PATCH 06/11] makepkg: allow using GIT source URLs

2012-06-26 Thread Dave Reisner
On Wed, Jun 27, 2012 at 08:58:12AM +1000, Allan McRae wrote: Allow specifing GIT sources using the following syntax source=('folder::repo#fragment') This will download the git repo repo into folder (into $SRCDIR if set, otherwise $startdir). repo must start with git, but non-git protocols

Re: [pacman-dev] [PATCH 10/11] makepkg: provide mechanism for auto-updating pkgver

2012-06-26 Thread Dave Reisner
On Wed, Jun 27, 2012 at 09:18:53AM +1000, Allan McRae wrote: Now that VCS repos are provided in the source array, it becomes too complicated to have automatic updating pkgver as was the case with the old VCS PKGBUILDs (there can be multiple repos of different types in the source array, the VCS

Re: [pacman-dev] [PATCH 11/11] makepkg: add support for SVN urls

2012-06-26 Thread Dave Reisner
On Wed, Jun 27, 2012 at 09:18:54AM +1000, Allan McRae wrote: Allow SVN repo sources in the form: source=(folder::repo#fragment) where repo must start with svn (e.g svn+http://) and a fragment can specify a revision (e.g. revision=22). Signed-off-by: Allan McRae al...@archlinux.org ---

[pacman-dev] [PATCH] query: avoid false ownership matches for files in root

2012-06-20 Thread Dave Reisner
, query007.py. Fixes FS#30388. Signed-off-by: Dave Reisner dreis...@archlinux.org --- src/pacman/query.c| 7 +-- test/pacman/tests/query007.py | 11 +++ 2 files changed, 16 insertions(+), 2 deletions(-) create mode 100644 test/pacman/tests/query007.py diff --git a/src

Re: [pacman-dev] man page for pactree ?

2012-06-20 Thread Dave Reisner
Sure. There isn't much to document, but it'd be nice to have a manpage for pactree since its considered an official tool. We'd expect that it's asciidoc based, similar to the other pages in the doc/ subdir. Cheers, Dave On Wed, Jun 20, 2012 at 02:17:33PM -0700, Ram Bhamidipaty wrote: Hi, I

[pacman-dev] [PATCH 0/5] Random fixes from my working branch

2012-06-13 Thread Dave Reisner
Posting this random collection of patches before they grow hair and develop a personality more likeable than mine. Dave Reisner (5): add real_line_size to alpm_read_buffer add line length parameter to _alpm_strip_newline contrib: sed out @SCRIPTNAME@ in edit command updpkgsums: avoid

[pacman-dev] [PATCH 1/5] add real_line_size to alpm_read_buffer

2012-06-13 Thread Dave Reisner
We inevitably call strlen() or similar on the line returned from _alpm_archive_fgets(), so include the line size of the interesting line in the struct. Signed-off-by: Dave Reisner dreis...@archlinux.org --- lib/libalpm/util.c |4 ++-- lib/libalpm/util.h |3 ++- 2 files changed, 4

[pacman-dev] [PATCH 3/5] contrib: sed out @SCRIPTNAME@ in edit command

2012-06-13 Thread Dave Reisner
Signed-off-by: Dave Reisner dreis...@archlinux.org --- contrib/Makefile.am |1 + 1 file changed, 1 insertion(+) diff --git a/contrib/Makefile.am b/contrib/Makefile.am index 30a76df..3641a08 100644 --- a/contrib/Makefile.am +++ b/contrib/Makefile.am @@ -58,6 +58,7 @@ edit = sed \ -e

[pacman-dev] [PATCH 2/5] add line length parameter to _alpm_strip_newline

2012-06-13 Thread Dave Reisner
If known, callers can pass the line size to this function in order to avoid an strlen call. Otherwise, they simply pass 0 and _alpm_strip_newline will do the call instead. Signed-off-by: Dave Reisner dreis...@archlinux.org --- lib/libalpm/be_local.c | 14 +++--- lib/libalpm

[pacman-dev] [PATCH 4/5] updpkgsums: avoid fancy quoting in error message

2012-06-13 Thread Dave Reisner
m4 has a field day parsing escapes and actually vandalizes this string, causing the error to look like: == ERROR: \PKGBUILD\ not found or is not a file Avoid all quoting and just match up with how makepkg reports errors (no quoting at all). Signed-off-by: Dave Reisner dreis...@archlinux.org

[pacman-dev] [PATCH 5/5] diskspace: log errors when opening the mount table fails

2012-06-13 Thread Dave Reisner
Signed-off-by: Dave Reisner dreis...@archlinux.org --- lib/libalpm/diskspace.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/libalpm/diskspace.c b/lib/libalpm/diskspace.c index 1fc297e..df2bb71 100644 --- a/lib/libalpm/diskspace.c +++ b/lib/libalpm/diskspace.c @@ -82,6 +82,8

Re: [pacman-dev] [PATCH] pacman: print version information in debug output

2012-06-07 Thread Dave Reisner
On Thu, Jun 07, 2012 at 02:52:18PM +1000, Allan McRae wrote: Signed-off-by: Allan McRae al...@archlinux.org --- src/pacman/pacman.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c index 73d5be9..6226ee1 100644 --- a/src/pacman/pacman.c

Re: [pacman-dev] [PATCH][RFC] packages ignored based on provides w/ needed flag

2012-05-23 Thread Dave Reisner
On May 23, 2012 5:20 PM, Daniel Wallace daniel.wall...@gatech.edu wrote: for FS#29935 https://bugs.archlinux.org/task/29935 This patch will cause packages like notification-daemon to be ignored if something providing notification-daemon is installed, mostly useful for when installing groups

Re: [pacman-dev] [PATCH] makepkg: rework libdepends

2012-05-19 Thread Dave Reisner
On Sat, May 19, 2012 at 11:22:36PM +1000, Allan McRae wrote: Rewrite the handling of libdepends. The primary advantage are: - Moves functionality from write_pkginfo() to find_libdepends(). - The order of the depends array in the PKGBUILD is kept in the package. - An unneeded libdepends is

[pacman-dev] [PATCH] pacman-key: test for content in keyring files

2012-05-13 Thread Dave Reisner
-by: Dave Reisner dreis...@archlinux.org --- I figured I should call this out on the list since a few people ran into it on IRC. Currently, running 'pacman-key --populate archlinux' with the archlinux-keyring package exhibits this bug. scripts/pacman-key.sh.in |6 +++--- 1 file changed, 3

Re: [pacman-dev] [PATCH] makepkg: Add CPPFLAGS support

2012-05-08 Thread Dave Reisner
On Tue, May 08, 2012 at 09:11:55AM -0500, Dan McGee wrote: On Tue, May 8, 2012 at 1:05 AM, Allan McRae al...@archlinux.org wrote: Add CPPFLAGS support in addition to the current CFLAGS and CXXFLAGS. This keeps compiler flags split up in the same logical way done everywhere else. +1

Re: [pacman-dev] [PATCH] Allow makepkg to use busybox find

2012-05-03 Thread Dave Reisner
On Thu, May 03, 2012 at 03:29:08AM -0400, jhuntw...@lightcubesolutions.com wrote: From: Jeremy Huntwork jhuntw...@lightcubesolutions.com This is an updated version to the previous patch which had a misplaced -o option and a misformatted line. Allow makepkg to work correctly when used with

Re: [pacman-dev] [PATCH] Allow makepkg to use busybox find

2012-05-03 Thread Dave Reisner
On Thu, May 03, 2012 at 07:40:03PM -0400, Jeremy Huntwork wrote: On 5/3/12 7:34 PM, Allan McRae wrote: On 04/05/12 09:12, Jeremy Huntwork wrote: find . -mindepth 1 -depth -type d -exec rmdir {} + 2/dev/null || true Anything else is a lot more code and more cumbersome. If the || true in this

[pacman-dev] [PATCH 1/3] diskspace: dedupe code for loading FS usage

2012-05-02 Thread Dave Reisner
add mount_point_load_fsinfo() for platforms using getmntent(). Signed-off-by: Dave Reisner dreis...@archlinux.org --- This is just code movement for the following patches. lib/libalpm/diskspace.c | 52 --- 1 file changed, 27 insertions(+), 25

[pacman-dev] [PATCH 2/3] diskspace: only load filesystem info on demand

2012-05-02 Thread Dave Reisner
to write to 3 partitions when installing the kernel package. This change reduces the 60 syscalls down to the expected 3. A slight debug output change is added here to discern between a mountpoint added to our linked list versus when we actually load the fs info. Signed-off-by: Dave Reisner dreis

[pacman-dev] [PATCH 3/3] diskspace: canonicalize path to download dir

2012-05-02 Thread Dave Reisner
With lazy loading in place, it's now quite obvious that we aren't necessarily checking the right mountpoint for necessary download space. Signed-off-by: Dave Reisner dreis...@archlinux.org --- lib/libalpm/diskspace.c |8 1 file changed, 8 insertions(+) diff --git a/lib/libalpm

[pacman-dev] [PATCH] makepkg: remove subshelling from check_option and friends

2012-04-25 Thread Dave Reisner
to 3 subprocesses in total. Signed-off-by: Dave Reisner dreis...@archlinux.org --- I've looked over this enough times that I'm starting to go blind looking at the patch. It's passed my testing as well, but this is the sort of thing that's ripe for regressions, so another set of eyes/testing would

Re: [pacman-dev] Manual rankmirrors.

2012-04-25 Thread Dave Reisner
On Wed, Apr 25, 2012 at 08:49:48PM +0100, Kevin Chadwick wrote: I use rankmirrors and I notice on timeouts pacman automatically switches. Today, though most packages downloaded quickly from the mirror just selected by rankmirrors, one or two went very very slow. I guess differing routes by

[pacman-dev] [PATCH] pacman-key: lookup keys before receiving

2012-04-23 Thread Dave Reisner
Perform a search for keys that clearly aren't key IDs. This allows receiving keys by name or email address, but only if the key resolves unambiguously. Signed-off-by: Dave Reisner dreis...@archlinux.org --- scripts/pacman-key.sh.in | 41 - 1 file changed

Re: [pacman-dev] [PATCH] Mark already installed optional dependencies

2012-04-15 Thread Dave Reisner
On Sun, Apr 15, 2012 at 04:17:52PM +0200, Arokux B. wrote: On Fri, Apr 6, 2012 at 1:49 AM, Arokux B. aro...@gmail.com wrote: This patch adds [installed] prefix to already installed optional dependency. Signed-off-by: Arokux aro...@gmail.com ---  src/pacman/util.c |   43

Re: [pacman-dev] [PATCH 1/2] patch to add zsh completion to pacman-key

2012-04-15 Thread Dave Reisner
On Sun, Apr 15, 2012 at 01:16:43PM -0400, Daniel Wallace wrote: this patch adds a _pacman_key function to the _pacman zsh site function so that zsh users can have completion for pacman-key keyids and other files which may be used with pacman-key Signed-off-by: Daniel Wallace

Re: [pacman-dev] [PATCH 1/2] patch to add zsh completion to pacman-key

2012-04-15 Thread Dave Reisner
On Sun, Apr 15, 2012 at 09:02:05PM -0400, Dave Reisner wrote: On Sun, Apr 15, 2012 at 01:16:43PM -0400, Daniel Wallace wrote: this patch adds a _pacman_key function to the _pacman zsh site function so that zsh users can have completion for pacman-key keyids and other files which may be used

Re: [pacman-dev] [PATCH 6/8] pacman-key: allow verification of multiple sig files

2012-04-13 Thread Dave Reisner
On Thu, Apr 12, 2012 at 11:25 PM, Allan McRae al...@archlinux.org wrote: On 13/04/12 00:54, Dave Reisner wrote: Loop through arguments passed to verify_sig and treat each as a signature to be verified against a source file. Output each file as its checked to avoid ambiguity. Signed-off

Re: [pacman-dev] [PATCH 4/8] pacman-key: adopt parseopts for option parsing

2012-04-13 Thread Dave Reisner
On Thu, Apr 12, 2012 at 11:50 PM, Allan McRae al...@archlinux.org wrote: On 13/04/12 00:54, Dave Reisner wrote: This requires an ugly amount of reworking of how pacman-key handles options. The change simply to avoid passing keys, files, and directories as arguments to options, but to leave

Re: [pacman-dev] [PATCH 1/8] scripts/library: introduce parseopts

2012-04-13 Thread Dave Reisner
On Fri, Apr 13, 2012 at 12:46 AM, Allan McRae al...@archlinux.org wrote: On 13/04/12 00:54, Dave Reisner wrote: This will replace our current options parser used in pacman-key and makepkg. It follows heuristics closer to that of GNU getopt long (and thus pacman itself), with the exception

Re: [pacman-dev] [PATCH 4/8] pacman-key: adopt parseopts for option parsing

2012-04-13 Thread Dave Reisner
On Fri, Apr 13, 2012 at 8:39 AM, Allan McRae al...@archlinux.org wrote: On 13/04/12 22:31, Dave Reisner wrote: On Thu, Apr 12, 2012 at 11:50 PM, Allan McRae al...@archlinux.org wrote: On 13/04/12 00:54, Dave Reisner wrote: This requires an ugly amount of reworking of how pacman-key

[pacman-dev] [PATCH 3/8] makepkg: allow specifying --pkg multiple times

2012-04-12 Thread Dave Reisner
Make this option additive, so that the following two operations are equivalent: makepkg --pkg foo --pkg bar makepkg --pkg foo,bar --- doc/makepkg.8.txt |2 +- scripts/makepkg.sh.in |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/makepkg.8.txt

[pacman-dev] [PATCH 1/8] scripts/library: introduce parseopts

2012-04-12 Thread Dave Reisner
into the application. A new test harness for parseopts is added in test/scripts. Signed-off-by: Dave Reisner dreis...@archlinux.org --- Makefile.am|6 +- configure.ac |1 + scripts/Makefile.am|1 + scripts/library/README | 12

[pacman-dev] [PATCH 4/8] pacman-key: adopt parseopts for option parsing

2012-04-12 Thread Dave Reisner
is updated to reflect this, and uses similar verbiage as pacman, describing the non-option arguments now passed to pacman-key as targets. Similar to the doc, --help is reorganized to separate operations and options and remove argument tokens from operations. Signed-off-by: Dave Reisner dreis

[pacman-dev] [PATCH 5/8] scripts/library: remove parse_options

2012-04-12 Thread Dave Reisner
This is retired, as the two consumers of this function are now using the new parseopts instead. Signed-off-by: Dave Reisner dreis...@archlinux.org --- scripts/Makefile.am |3 +- scripts/library/README |6 --- scripts/library/parse_options.sh | 105

[pacman-dev] [PATCH 6/8] pacman-key: allow verification of multiple sig files

2012-04-12 Thread Dave Reisner
Loop through arguments passed to verify_sig and treat each as a signature to be verified against a source file. Output each file as its checked to avoid ambiguity. Signed-off-by: Dave Reisner dreis...@archlinux.org --- doc/pacman-key.8.txt |2 +- scripts/pacman-key.sh.in | 15

[pacman-dev] [PATCH 7/8] validate shell scripts with $(BASH_SHELL) on build

2012-04-12 Thread Dave Reisner
Pass $(OURSCRIPTS) through the bash parser in read only mode to validate syntax. Note that this doesn't actually catch all errors, but it might be useful for developers working on these scripts. Signed-off-by: Dave Reisner dreis...@archlinux.org --- contrib/Makefile.am |1 + scripts

[pacman-dev] [PATCH 1/2] pacman-key: verify TRUST_ULTIMATE keys as good

2012-04-08 Thread Dave Reisner
Extend our grep pattern to match TRUST_ULTIMATE, not just TRUST_FULLY, as these keys are to be trusted as well. Signed-off-by: Dave Reisner dreis...@archlinux.org --- pacman-key would exit with an error here, but still show the success message from gpg itself, e.g. if my key is TRUST_ULTIMATE

[pacman-dev] [PATCH 2/2] pacman-key: avoid use of tempfile in verify_sig

2012-04-08 Thread Dave Reisner
Use --status-fd rather than --status-file to keep this contained in a pipeline. Signed-off-by: Dave Reisner dreis...@archlinux.org --- scripts/pacman-key.sh.in |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/scripts/pacman-key.sh.in b/scripts/pacman-key.sh.in index

Re: [pacman-dev] [PATCH v4 5/5] pkgdelta/repo-add: quoting fixes

2012-04-07 Thread Dave Reisner
On Sat, Apr 07, 2012 at 02:28:49PM +0200, Florian Pritz wrote: This removes some unnecessary quotes and adds quotes in a few places to hopefully work correctly if the tempdir has spaces. Signed-off-by: Florian Pritz bluew...@xinu.at Ack from me excepting that I haven't checked too thoroughly

Re: [pacman-dev] [PATCH] repo-remove: remove deltas file is it becomes empty

2012-04-06 Thread Dave Reisner
On Fri, Apr 06, 2012 at 06:18:45PM +0200, Florian Pritz wrote: Signed-off-by: Florian Pritz bluew...@xinu.at --- scripts/repo-add.sh.in |5 + 1 file changed, 5 insertions(+) diff --git a/scripts/repo-add.sh.in b/scripts/repo-add.sh.in index 043a0b8..147da69 100644 ---

Re: [pacman-dev] [PATCH 1/2] pkgdelta: rework option/argument parser

2012-04-06 Thread Dave Reisner
On Fri, Apr 06, 2012 at 08:56:04PM +0200, Florian Pritz wrote: Signed-off-by: Florian Pritz bluew...@xinu.at --- scripts/pkgdelta.sh.in | 41 - 1 file changed, 24 insertions(+), 17 deletions(-) diff --git a/scripts/pkgdelta.sh.in

Re: [pacman-dev] [PATCH 2/2] pkgdelta: implement requirments for delta generation

2012-04-06 Thread Dave Reisner
On Fri, Apr 06, 2012 at 08:56:05PM +0200, Florian Pritz wrote: Big deltas or deltas for very small packages are not needed so we should check that and not generate any. Signed-off-by: Florian Pritz bluew...@xinu.at --- scripts/pkgdelta.sh.in | 33 ++--- 1

Re: [pacman-dev] Fwd: Re: Unable to compile pacman in ubuntu-11.10

2012-04-02 Thread Dave Reisner
On Mon, Apr 02, 2012 at 04:52:31AM -0700, Talespin Kit wrote: This new configure scripts reports that it needs  libarchive 3.0.0 . I am using libarchive1-2.8.4-1ubuntu-0.11.10.1 which is present in the repo. I am using the same build environment(same machine) which i have used

[pacman-dev] [PATCH 00/11] autofool cleanup

2012-04-02 Thread Dave Reisner
gleaned from some other autotools-based projects. That said, I think these changes all make sense, and the Ubuntu user was certainly happy that the configure script was doing a better job of library autodetection. Dave Reisner (11): buildsys: add pkg-config m4 macros buildsys: use pkg-config

[pacman-dev] [PATCH 01/11] buildsys: add pkg-config m4 macros

2012-04-02 Thread Dave Reisner
We'll need these for a small revamp to library detection. Signed-off-by: Dave Reisner dreis...@archlinux.org --- m4/pkg.m4 | 159 + 1 file changed, 159 insertions(+) create mode 100644 m4/pkg.m4 diff --git a/m4/pkg.m4 b/m4/pkg.m4 new

[pacman-dev] [PATCH 02/11] buildsys: use pkg-config for openssl detection

2012-04-02 Thread Dave Reisner
Signed-off-by: Dave Reisner dreis...@archlinux.org --- configure.ac| 21 + lib/libalpm/Makefile.am |9 - src/util/Makefile.am|2 +- 3 files changed, 18 insertions(+), 14 deletions(-) diff --git a/configure.ac b/configure.ac index 12a6e65

[pacman-dev] [PATCH 03/11] buildsys: use pkg-config for libarchive detection

2012-04-02 Thread Dave Reisner
This also introduces a versioned dependency of =3.0.0. Signed-off-by: Dave Reisner dreis...@archlinux.org --- configure.ac|6 +++--- lib/libalpm/Makefile.am |4 +++- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index 824241d

[pacman-dev] [PATCH 04/11] buildsys: use pkg-config for libcurl detection

2012-04-02 Thread Dave Reisner
Signed-off-by: Dave Reisner dreis...@archlinux.org --- configure.ac| 18 +++- lib/libalpm/Makefile.am |4 +- m4/libcurl.m4 | 250 --- 3 files changed, 18 insertions(+), 254 deletions(-) delete mode 100644 m4/libcurl.m4

[pacman-dev] [PATCH 05/11] buildsys: handle gpgme libs and cflags separately

2012-04-02 Thread Dave Reisner
We should not attempt to modify the CFLAGS or LDFLAGS passed into the environment. In the case of gpgme detection being wanted and successful, use the variables defined by gpgme's m4 macro. Signed-off-by: Dave Reisner dreis...@archlinux.org --- configure.ac| 10 +- lib

[pacman-dev] [PATCH 06/11] buildsys: use AC_DEFINE for CYGWIN macro

2012-04-02 Thread Dave Reisner
Instead of directly modifying CFLAGS, use config.h for its intended purpose. Signed-off-by: Dave Reisner dreis...@archlinux.org --- configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 1b95211..7590d9d 100644 --- a/configure.ac

[pacman-dev] [PATCH 07/11] buildsys: define warning CFLAGS in separate var

2012-04-02 Thread Dave Reisner
Continue the trend of not touching the environment CFLAGS, ensuring that the user always has the final say. Signed-off-by: Dave Reisner dreis...@archlinux.org --- configure.ac|4 ++-- lib/libalpm/Makefile.am |2 +- src/pacman/Makefile.am |2 +- src/util/Makefile.am

[pacman-dev] [PATCH 09/11] buildsys: move acinclude.m4 to m4/

2012-04-02 Thread Dave Reisner
Signed-off-by: Dave Reisner dreis...@archlinux.org --- acinclude.m4 = m4/acinclude.m4 |0 1 file changed, 0 insertions(+), 0 deletions(-) rename acinclude.m4 = m4/acinclude.m4 (100%) diff --git a/acinclude.m4 b/m4/acinclude.m4 similarity index 100% rename from acinclude.m4 rename to m4

[pacman-dev] [PATCH 10/11] buildsys: move autotools bloat to build-aux

2012-04-02 Thread Dave Reisner
Signed-off-by: Dave Reisner dreis...@archlinux.org --- config.guess = build-aux/config.guess |0 config.rpath = build-aux/config.rpath |0 config.sub = build-aux/config.sub |0 depcomp = build-aux/depcomp |0 install-sh = build-aux/install-sh |0

[pacman-dev] [PATCH 08/11] buildsys: cleanup libtool and autoconf initialization

2012-04-02 Thread Dave Reisner
for consistency with autogen.sh and Makefile.am ref: http://www.gnu.org/software/libtool/manual/html_node/LT_005fINIT.html Signed-off-by: Dave Reisner dreis...@archlinux.org --- configure.ac |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index

[pacman-dev] [PATCH 11/11] autoclean.sh: abide by POSIX shebang

2012-04-02 Thread Dave Reisner
Avoid non-POSIX brace expansion and rely on find to locate and destroy files outside the root. Signed-off-by: Dave Reisner dreis...@archlinux.org --- autoclean.sh | 24 +++- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/autoclean.sh b/autoclean.sh index

Re: [pacman-dev] Unable to compile pacman in ubuntu-11.10

2012-03-29 Thread Dave Reisner
On Thu, Mar 29, 2012 at 04:42:04AM -0700, Talespin Kit wrote: Some improvement over the build by providing --without-gpgme arg to ./configure script . The complete steps is mentioned below $ git clean -xfd; ./autogen.sh ./configure --without-gpgme make .. make[3]: Leaving

Re: [pacman-dev] Unable to compile pacman in ubuntu-11.10

2012-03-29 Thread Dave Reisner
On Thu, Mar 29, 2012 at 08:17:51AM -0400, Dave Reisner wrote: On Thu, Mar 29, 2012 at 04:42:04AM -0700, Talespin Kit wrote: Some improvement over the build by providing --without-gpgme arg to ./configure script . The complete steps is mentioned below $ git clean -xfd

[pacman-dev] [PATCH] signing: cope with gpg2's failure at life

2012-03-27 Thread Dave Reisner
For key searches only, gpg2 will fail to lookup any and all keys that are not prefixed with 0x. Signed-off-by: Dave Reisner dreis...@archlinux.org --- lib/libalpm/signing.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/lib/libalpm/signing.c b/lib

Re: [pacman-dev] [PATCH] Make selecting scriptlet shell work

2012-03-23 Thread Dave Reisner
? It needs to be an absolute path since we pass to execv, not execvp. Bug-found-by: Dave Reisner dreis...@archlinux.org Signed-off-by: Allan McRae al...@archlinux.org --- lib/libalpm/trans.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/libalpm/trans.c b/lib

[pacman-dev] [PATCH] libalpm: add pkg-config file

2012-03-19 Thread Dave Reisner
Borrowed heavily from libarchive. Signed-off-by: Dave Reisner dreis...@archlinux.org --- Throw a bone to the few projects who link against us... configure.ac |1 + lib/libalpm/Makefile.am |3 +++ lib/libalpm/libalpm.pc.in | 11 +++ 3 files changed, 15 insertions

[pacman-dev] [PATCH 1/2] Revert makepkg: calculate exact total file size

2012-03-14 Thread Dave Reisner
calling du. This reverts commit b264fb9e9ddcc31dc8782390309421965e507383. Signed-off-by: Dave Reisner dreis...@archlinux.org --- configure.ac |1 + scripts/Makefile.am |1 + scripts/makepkg.sh.in |7 ++- 3 files changed, 8 insertions(+), 1 deletion(-) diff --git

[pacman-dev] [PATCH 2/2] makepkg: avoid unnecessary local variable

2012-03-14 Thread Dave Reisner
Use a simple default value parameter expansion instead of using an intermediate local variable to write the packager name in write_pkginfo. Signed-off-by: Dave Reisner dreis...@archlinux.org --- scripts/makepkg.sh.in |7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git

Re: [pacman-dev] [PATCH 1/2] Revert makepkg: calculate exact total file size

2012-03-14 Thread Dave Reisner
On Thu, Mar 15, 2012 at 07:11:07AM +1000, Allan McRae wrote: On 15/03/12 06:41, Dave Reisner wrote: btrfs's cow snapshots seem to do very strange things, causing du to not count data still in filesystem buffers. Repackaging the same build of handbrake within a chroot on brynhild, I

Re: [pacman-dev] [PATCH 1/2] Revert makepkg: calculate exact total file size

2012-03-14 Thread Dave Reisner
On Wed, Mar 14, 2012 at 07:48:06PM -0400, Dave Reisner wrote: On Thu, Mar 15, 2012 at 07:11:07AM +1000, Allan McRae wrote: On 15/03/12 06:41, Dave Reisner wrote: btrfs's cow snapshots seem to do very strange things, causing du to not count data still in filesystem buffers. Repackaging

[pacman-dev] [PATCH 1/2] dload: reset payload filename members before download

2012-03-14 Thread Dave Reisner
To avoid conflicts on reusing a payload after a failed download, ensure that we reset the filename hints in the payload struct prior to the download operation. Signed-off-by: Dave Reisner dreis...@archlinux.org --- lib/libalpm/dload.c |5 + 1 file changed, 5 insertions(+) diff --git

[pacman-dev] [PATCH 2/2] lib/sync: avoid unwanted unlink after download fail

2012-03-14 Thread Dave Reisner
In case we have a mirror failure, unlink_on_fail would remain set, causing an interrupt in a successive download attempt to be wrongly unlinked. This also fixes a memory leak in the url member, as we would allocate over the previous, unfreed URL. Signed-off-by: Dave Reisner dreis

Re: [pacman-dev] [PATCH 3/6] makepkg: prevent issues with files starting with a hyphen

2012-03-12 Thread Dave Reisner
On Mon, Mar 12, 2012 at 04:40:38PM +0100, Thomas Bächler wrote: Am 09.03.2012 15:01, schrieb Dave Reisner: @@ -974,7 +974,7 @@ tidy_install() { if [[ $(check_option docs) = n -n ${DOC_DIRS[*]} ]]; then msg2 $(gettext Removing doc files...) - rm -rf ${DOC_DIRS

Re: [pacman-dev] [PATCH 2/6] makepkg: devel_check(): determine vcs

2012-03-12 Thread Dave Reisner
On Mon, Mar 12, 2012 at 12:53:11PM -0600, dgbale...@0x01b.net wrote: From: Matthew Monaco matthew.mon...@0x01b.net Rather than prioritizing an arbitrary VCS, collect all development directives. If there is more than one, use the package name as a hint. If that doesn't work, abort. --- I'm

Re: [pacman-dev] [PATCH 4/6] makepkg: devel_check(): set newpkgver (cleanup)

2012-03-12 Thread Dave Reisner
On Mon, Mar 12, 2012 at 12:53:13PM -0600, dgbale...@0x01b.net wrote: From: Matthew Monaco matthew.mon...@0x01b.net The case structure allows the syntax to focus on what's actually being done here. --- scripts/makepkg.sh.in | 61 +++-- 1 file

Re: [pacman-dev] [PATCH 5/6] makepkg: devel_check(): only work for -vcs pkgnames

2012-03-12 Thread Dave Reisner
On Mon, Mar 12, 2012 at 12:53:14PM -0600, dgbale...@0x01b.net wrote: From: Matthew Monaco matthew.mon...@0x01b.net If the package's name does not end in -git/svn/etc, then don't touch the pkgver or pkgrel. This changes the current semantics of makepkg, but it shouldn't be too mind blowing.

Re: [pacman-dev] [PATCH 5/6] makepkg: devel_check(): only work for -vcs pkgnames

2012-03-12 Thread Dave Reisner
On Mon, Mar 12, 2012 at 01:33:47PM -0600, Matthew Monaco wrote: On 03/12/2012 01:22 PM, Dave Reisner wrote: And in my opinion, these packages are wrong. So then I'm not sure where the disagreement is =) *rereads* I'm not sure either. I'm going to get some more coffee. Ignore my

Re: [pacman-dev] [PATCH 3/6] makepkg: prevent issues with files starting with a hyphen

2012-03-09 Thread Dave Reisner
On Fri, Mar 09, 2012 at 05:59:06PM +1000, Allan McRae wrote: Most places in makepkg deal with full file paths, but a few use the file name only. Protect from potential issues when a file name starts with a hyphen. How sure are we that these will always be relative paths and never ever

Re: [pacman-dev] [PATCH] Skip special files when cleaning package cache

2012-03-09 Thread Dave Reisner
On Fri, Mar 09, 2012 at 03:08:37PM +0100, Lukas Fleischer wrote: On Fri, Mar 09, 2012 at 11:20:03PM +1000, Allan McRae wrote: Ignore .sig, *.db*, and *.src.tar* when cleaning the package cache. Fixes FS#25166. Signed-off-by: Allan McRae al...@archlinux.org --- I am bad at

Re: [pacman-dev] [PATCH 1/6] makepkg: the rhs in string comparisons should be quoted

2012-03-09 Thread Dave Reisner
On Fri, Mar 09, 2012 at 05:59:04PM +1000, Allan McRae wrote: Signed-off-by: Allan McRae al...@archlinux.org --- ack. scripts/makepkg.sh.in | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index

Re: [pacman-dev] [PATCH 2/6] makepkg: use printf rather than echo to output variable

2012-03-09 Thread Dave Reisner
On Fri, Mar 09, 2012 at 05:59:05PM +1000, Allan McRae wrote: Signed-off-by: Allan McRae al...@archlinux.org --- scripts/makepkg.sh.in | 62 - 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/scripts/makepkg.sh.in

Re: [pacman-dev] [PATCH 4/6] makepkg: abort when failing to create BUILDDIR

2012-03-09 Thread Dave Reisner
On Fri, Mar 09, 2012 at 05:59:07PM +1000, Allan McRae wrote: Signed-off-by: Allan McRae al...@archlinux.org --- scripts/makepkg.sh.in |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 8dd2d39..9cd8af8 100644

Re: [pacman-dev] [PATCH 6/6] makepkg: safely change directories

2012-03-09 Thread Dave Reisner
On Fri, Mar 09, 2012 at 05:59:09PM +1000, Allan McRae wrote: In preparation for the removal of the global error trap we need a way to ensure changing directories succeeds. Add a cd_safe wrapper that performs the necessary check. Signed-off-by: Allan McRae al...@archlinux.org ---

Re: [pacman-dev] [PATCH] Extract a write_deps function from local database writing

2012-03-09 Thread Dave Reisner
On Fri, Mar 09, 2012 at 02:11:08PM -0600, Dan McGee wrote: This reduces a lot of code duplication in the write function, which cleans it up a bit. Signed-off-by: Dan McGee d...@archlinux.org --- lib/libalpm/be_local.c | 67 1 file

Re: [pacman-dev] [PATCH 3/3] makepkg: complain when the buildfile isn't writeable

2012-02-15 Thread Dave Reisner
On Wed, Feb 15, 2012 at 6:09 AM, Allan McRae al...@archlinux.org wrote: On 15/02/12 04:58, Dave Reisner wrote: If the PKGBUILD isn't writeable for devel_update, throw a warning instead of silently ignoring it. Some logical reordering is present in this patch to reduce the number of nested

Re: [pacman-dev] [PATCH 1/3] makepkg: restrict usage of errexit to user functions

2012-02-15 Thread Dave Reisner
On Wed, Feb 15, 2012 at 7:05 AM, Allan McRae al...@archlinux.org wrote: On 15/02/12 04:57, Dave Reisner wrote: It's expected that this will lead to unwanted behavior, and needs widespread testing. It's desirable to commit this for a few reasons: - there's no reason we can't do our own

[pacman-dev] [PATCH 1/3] makepkg: restrict usage of errexit to user functions

2012-02-14 Thread Dave Reisner
immune to upstream changes in exit codes (FS#28248) Signed-off-by: Dave Reisner dreis...@archlinux.org --- Allan, just making sure we're on the same page -- this _will_ cause breakage, and the next patch in this series addresses one specific case. I figure getting this patch in now gives us ample

[pacman-dev] [PATCH 3/3] makepkg: complain when the buildfile isn't writeable

2012-02-14 Thread Dave Reisner
If the PKGBUILD isn't writeable for devel_update, throw a warning instead of silently ignoring it. Some logical reordering is present in this patch to reduce the number of nested if's. Signed-off-by: Dave Reisner dreis...@archlinux.org --- scripts/makepkg.sh.in | 14 +++--- 1 files

Re: [pacman-dev] [PATCH] scripts: unset CDPATH if cd is used

2012-02-14 Thread Dave Reisner
On Tue, Feb 14, 2012 at 10:14:08AM -0600, Dan McGee wrote: This wonderful/awful little bash shell variable wrecks havoc on `cd` calls in shell scripts. Unset CDPATH in makepkg where we use `cd` quite heavily. In pacman-optimize, we can move the change directory logic into the bsdtar call so we

Re: [pacman-dev] [PATCH] Remove SyncFirst option

2012-02-14 Thread Dave Reisner
On Tue, Feb 14, 2012 at 02:30:06PM -0600, Dan McGee wrote: This has outlived its usefulness and causes more problems than it solves. Signed-off-by: Dan McGee d...@archlinux.org --- This is an RFC first of all, so please feel free to comment. Pros: 1. Removes complexity and a fair

[pacman-dev] [PATCH] lib/sync: use full delta size as max download size

2012-02-12 Thread Dave Reisner
The max filesize for a delta download must be the full size of the delta file, not just what's remaining. Fixes FS#28345 Signed-off-by: Dave Reisner dreis...@archlinux.org --- lib/libalpm/sync.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/libalpm/sync.c b/lib

Re: [pacman-dev] pacman -R default answer

2012-02-12 Thread Dave Reisner
On Mon, Feb 13, 2012 at 01:55:03AM +, Diogo Sousa wrote: Hello, when removing packages the default answer to Do you want to remove these packages? is Yes. Shouldn't we be conservative and provide no as the default? Diogo Sousa Presumably the user intends to do what they just typed

[pacman-dev] [PATCH 1/2] add library support for tuning TCP_KEEPALIVE

2012-01-23 Thread Dave Reisner
This adds three new options to control the behavior of TCP keepalives: - CURLOPT_TCP_KEEPALIVE: enable/disable probes - CURLOPT_TCP_KEEPIDLE: idle time before sending first probe - CURLOPT_TCP_KEEPINTVL: delay between successive probes While not all operating systems support the TCP_KEEPIDLE and

[pacman-dev] [PATCH 2/2] curl: use new library-side TCP_KEEPALIVE options

2012-01-23 Thread Dave Reisner
Use the new library CURLOPT_TCP_KEEPALIVE rather than disabling this via the sockopt callback. If --keepalive-time is used, apply the value to CURLOPT_TCP_KEEPIDLE and CURLOPT_TCP_KEEPINTVL. --- The matching changes for the front end to use the new options from the previous patch. docs/curl.1

Re: [pacman-dev] compiling pacman and python wrapper

2012-01-22 Thread Dave Reisner
On Sun, Jan 22, 2012 at 07:22:44PM +, Andrea Crotti wrote: On 01/22/2012 04:56 PM, Dan McGee wrote: ./autogen.sh if you are building from git and not a tarball. -Dan Ok thanks, the point was just that it was not written anywhere, maybe it would be good to add a section INSTALL FROM GIT.

[pacman-dev] [PATCH 1/2] lib/dload: enforce usage of TCP keepalives

2012-01-22 Thread Dave Reisner
This is particularly important in the case of FTP control connections, which may be closed by rogue NAT/firewall devices detecting idle connections on larger transfers which may take 5-10+ minutes. Signed-off-by: Dave Reisner dreis...@archlinux.org --- This is basically on the advice of Daniel

[pacman-dev] [PATCH 2/2] lib/dload: give uniform naming to curl CB functions

2012-01-22 Thread Dave Reisner
Signed-off-by: Dave Reisner dreis...@archlinux.org --- lib/libalpm/dload.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/libalpm/dload.c b/lib/libalpm/dload.c index 790080c..c1be528 100644 --- a/lib/libalpm/dload.c +++ b/lib/libalpm/dload.c @@ -90,7 +90,7

Re: [pacman-dev] [PATCH] makepkg: fix error on unnecessary -r

2012-01-22 Thread Dave Reisner
On Mon, Jan 23, 2012 at 12:08:14PM +1000, Allan McRae wrote: On 20/01/12 23:59, Dave Reisner wrote: On Fri, Jan 20, 2012 at 11:24:23PM +1000, Allan McRae wrote: The grep statement used to check for a difference between the installed package list before and after resolving dependencies

Re: [pacman-dev] [PATCH] makepkg: fix error on unnecessary -r

2012-01-22 Thread Dave Reisner
On Mon, Jan 23, 2012 at 12:48:37PM +1000, Allan McRae wrote: On 23/01/12 12:13, Dave Reisner wrote: On Mon, Jan 23, 2012 at 12:08:14PM +1000, Allan McRae wrote: On 20/01/12 23:59, Dave Reisner wrote: On Fri, Jan 20, 2012 at 11:24:23PM +1000, Allan McRae wrote: The grep statement used

Re: [pacman-dev] [PATCH] makepkg: fix error on unnecessary -r

2012-01-20 Thread Dave Reisner
On Fri, Jan 20, 2012 at 11:24:23PM +1000, Allan McRae wrote: The grep statement used to check for a difference between the installed package list before and after resolving dependencies returns 1 if there is no difference. This sets of the error trap when -r is used unnecessarily.

Re: [pacman-dev] XfreCommand curl option in pacman.conf and makepkg.conf

2012-01-18 Thread Dave Reisner
On Wed, Jan 18, 2012 at 04:13:29PM +0530, Keshav P R wrote: Hi, Using XferCommand = /usr/bin/curl -C - -f -o %o %u XferCommand = /usr/bin/curl -C - -f %u %o enables curl to resume downloads to %o , if it is supported. Using file redirection %o makes curl restart the (partial)

[pacman-dev] [mkinitcpio][PATCH 1/5] dsdt: remove hook. this has been defunct for years

2012-01-12 Thread Dave Reisner
Refer to commit 9a9e0d68555 in the kernel where Linus removes this and says to be revisited later. The only option (currently) is to built this into your kernel image. Suggested by FS#27906. Signed-off-by: Dave Reisner dreis...@archlinux.org --- install/dsdt | 14 -- 1 files

[pacman-dev] [mkinitcpio][PATCH 2/5] udev: update for udev 176

2012-01-12 Thread Dave Reisner
- firmware handling is now a udevd builtin - udevadm may move -- let a path lookup find it Signed-off-by: Dave Reisner dreis...@archlinux.org --- PKGBUILD |2 +- install/udev |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/PKGBUILD b/PKGBUILD index a6a083f

[pacman-dev] [mkinitcpio][PATCH 4/5] init: mount separate /usr

2012-01-12 Thread Dave Reisner
Use findmnt to detect the existance of a separate /usr partition existing in the real root. If it does exist, fetch the options for it and mount it. This currently makes a lot of assumptions and won't be very friendly towards something such as a dm-crypt device. Signed-off-by: Dave Reisner dreis

[pacman-dev] [mkinitcpio][PATCH 3/5] base: add findmnt as a part of the base layout

2012-01-12 Thread Dave Reisner
This is required for mounting a separate /usr. While the shutdown hook is essentially a soft requirement for a separate /usr, we shouldn't break init. Signed-off-by: Dave Reisner dreis...@archlinux.org --- install/base |1 + install/shutdown |2 +- 2 files changed, 2 insertions(+), 1

<    1   2   3   4   5   6   7   8   9   >