On Fri, Apr 06, 2012 at 08:56:04PM +0200, Florian Pritz wrote:
> Signed-off-by: Florian Pritz
> ---
> scripts/pkgdelta.sh.in | 41 -
> 1 file changed, 24 insertions(+), 17 deletions(-)
>
> diff --git a/scripts/pkgdelta.sh.in b/scripts/pkgdelta.sh.in
> in
On Fri, Apr 06, 2012 at 06:18:45PM +0200, Florian Pritz wrote:
> Signed-off-by: Florian Pritz
> ---
> scripts/repo-add.sh.in |5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/scripts/repo-add.sh.in b/scripts/repo-add.sh.in
> index 043a0b8..147da69 100644
> --- a/scripts/repo-add.s
Avoid non-POSIX brace expansion and rely on find to locate and destroy
files outside the root.
Signed-off-by: Dave Reisner
---
autoclean.sh | 24 +++-
1 file changed, 7 insertions(+), 17 deletions(-)
diff --git a/autoclean.sh b/autoclean.sh
index 8f45d56..900f353 100755
Signed-off-by: Dave Reisner
---
config.guess => build-aux/config.guess |0
config.rpath => build-aux/config.rpath |0
config.sub => build-aux/config.sub |0
depcomp => build-aux/depcomp |0
install-sh => build-aux/install-sh |0
ltm
Signed-off-by: Dave Reisner
---
acinclude.m4 => m4/acinclude.m4 |0
1 file changed, 0 insertions(+), 0 deletions(-)
rename acinclude.m4 => m4/acinclude.m4 (100%)
diff --git a/acinclude.m4 b/m4/acinclude.m4
similarity index 100%
rename from acinclude.m4
rename to m4/acinclude.m4
--
1.7.9.5
d for
consistency with autogen.sh and Makefile.am
ref: http://www.gnu.org/software/libtool/manual/html_node/LT_005fINIT.html
Signed-off-by: Dave Reisner
---
configure.ac |7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/configure.ac b/configure.ac
index 9725ba0..3c01966 1
Continue the trend of not touching the environment CFLAGS, ensuring that
the user always has the final say.
Signed-off-by: Dave Reisner
---
configure.ac|4 ++--
lib/libalpm/Makefile.am |2 +-
src/pacman/Makefile.am |2 +-
src/util/Makefile.am|2 +-
4 files
Instead of directly modifying CFLAGS, use config.h for its intended
purpose.
Signed-off-by: Dave Reisner
---
configure.ac |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 1b95211..7590d9d 100644
--- a/configure.ac
+++ b/configure.ac
We should not attempt to modify the CFLAGS or LDFLAGS passed into the
environment. In the case of gpgme detection being wanted and successful,
use the variables defined by gpgme's m4 macro.
Signed-off-by: Dave Reisner
---
configure.ac| 10 +-
lib/libalpm/Makefile.am |
Signed-off-by: Dave Reisner
---
configure.ac| 18 +++-
lib/libalpm/Makefile.am |4 +-
m4/libcurl.m4 | 250 ---
3 files changed, 18 insertions(+), 254 deletions(-)
delete mode 100644 m4/libcurl.m4
diff --git a/configure.ac
This also introduces a versioned dependency of >=3.0.0.
Signed-off-by: Dave Reisner
---
configure.ac|6 +++---
lib/libalpm/Makefile.am |4 +++-
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/configure.ac b/configure.ac
index 824241d..30a20f7 100644
--
Signed-off-by: Dave Reisner
---
configure.ac| 21 +
lib/libalpm/Makefile.am |9 -
src/util/Makefile.am|2 +-
3 files changed, 18 insertions(+), 14 deletions(-)
diff --git a/configure.ac b/configure.ac
index 12a6e65..824241d 100644
--- a
We'll need these for a small revamp to library detection.
Signed-off-by: Dave Reisner
---
m4/pkg.m4 | 159 +
1 file changed, 159 insertions(+)
create mode 100644 m4/pkg.m4
diff --git a/m4/pkg.m4 b/m4/pkg.m4
new file mode 1
s based on what I've gleaned from some other autotools-based
projects. That said, I think these changes all make sense, and the Ubuntu user
was certainly happy that the configure script was doing a better job of
library autodetection.
Dave Reisner (11):
buildsys: add pkg-config m4 macros
bui
On Mon, Apr 02, 2012 at 05:29:53AM -0700, Talespin Kit wrote:
> >I guess that's a bit of a lie -- we only need 2.8.0. Can you fetch from
> >that branch again, please?
> Cool. compiles without problem (commit
> 01150291779e4d4aa61f4495014c9f214bbb5eb6).
>
Awesome. Thanks for testing, and for polit
On Mon, Apr 02, 2012 at 04:52:31AM -0700, Talespin Kit wrote:
>
>
> This new configure scripts reports that it needs libarchive > 3.0.0 .
>
> I am using libarchive1-2.8.4-1ubuntu-0.11.10.1 which is present in the repo.
>
> I am using the same build environment(same machine) which i have used
- Forwarded message from Dave Reisner -
> Date: Fri, 30 Mar 2012 14:44:05 -0400
> From: Dave Reisner
> To: Talespin Kit
> Subject: Re: [pacman-dev] Unable to compile pacman in ubuntu-11.10
>
> On Fri, Mar 30, 2012 at 05:12:11AM -0700, Talespin Kit wrote:
> > Fi
On Thu, Mar 29, 2012 at 08:17:51AM -0400, Dave Reisner wrote:
> On Thu, Mar 29, 2012 at 04:42:04AM -0700, Talespin Kit wrote:
> > Some improvement over the build by providing --without-gpgme arg to
> > ./configure script .
> >
> > The complete steps is mentioned belo
On Thu, Mar 29, 2012 at 04:42:04AM -0700, Talespin Kit wrote:
> Some improvement over the build by providing --without-gpgme arg to
> ./configure script .
>
> The complete steps is mentioned below
>
>
> $ git clean -xfd; ./autogen.sh && ./configure --without-gpgme && make
>
> ..
> make[
For key searches only, gpg2 will fail to lookup any and all keys that
are not prefixed with 0x.
Signed-off-by: Dave Reisner
---
lib/libalpm/signing.c | 17 ++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/lib/libalpm/signing.c b/lib/libalpm/signing.c
index
fault value
as well? It needs to be an absolute path since we pass to execv, not
execvp.
> Bug-found-by: Dave Reisner
> Signed-off-by: Allan McRae
> ---
> lib/libalpm/trans.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/libalpm/trans.c b/
Borrowed heavily from libarchive.
Signed-off-by: Dave Reisner
---
Throw a bone to the few projects who link against us...
configure.ac |1 +
lib/libalpm/Makefile.am |3 +++
lib/libalpm/libalpm.pc.in | 11 +++
3 files changed, 15 insertions(+)
create mode
In case we have a mirror failure, unlink_on_fail would remain set,
causing an interrupt in a successive download attempt to be wrongly
unlinked.
This also fixes a memory leak in the url member, as we would allocate
over the previous, unfreed URL.
Signed-off-by: Dave Reisner
---
lib/libalpm
To avoid conflicts on reusing a payload after a failed download, ensure
that we reset the filename hints in the payload struct prior to the
download operation.
Signed-off-by: Dave Reisner
---
lib/libalpm/dload.c |5 +
1 file changed, 5 insertions(+)
diff --git a/lib/libalpm/dload.c b
On Wed, Mar 14, 2012 at 07:48:06PM -0400, Dave Reisner wrote:
> On Thu, Mar 15, 2012 at 07:11:07AM +1000, Allan McRae wrote:
> > On 15/03/12 06:41, Dave Reisner wrote:
> > > btrfs's cow snapshots seem to do very strange things, causing du to not
> > > count
On Thu, Mar 15, 2012 at 07:11:07AM +1000, Allan McRae wrote:
> On 15/03/12 06:41, Dave Reisner wrote:
> > btrfs's cow snapshots seem to do very strange things, causing du to not
> > count data still in filesystem buffers. Repackaging the same build of
> > handbrake with
Use a simple default value parameter expansion instead of using an
intermediate local variable to write the packager name in write_pkginfo.
Signed-off-by: Dave Reisner
---
scripts/makepkg.sh.in |7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/scripts/makepkg.sh.in b
efore calling du.
This reverts commit b264fb9e9ddcc31dc8782390309421965e507383.
Signed-off-by: Dave Reisner
---
configure.ac |1 +
scripts/Makefile.am |1 +
scripts/makepkg.sh.in |7 ++-
3 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configu
On Mon, Mar 12, 2012 at 01:33:47PM -0600, Matthew Monaco wrote:
> On 03/12/2012 01:22 PM, Dave Reisner wrote:
> >
> > And in my opinion, these packages are wrong.
> >
>
> So then I'm not sure where the disagreement is =)
>
*rereads*
I'm not sure e
On Mon, Mar 12, 2012 at 12:53:14PM -0600, dgbale...@0x01b.net wrote:
> From: Matthew Monaco
>
> If the package's name does not end in -git/svn/etc, then don't touch
> the pkgver or pkgrel. This changes the current semantics of makepkg, but
> it shouldn't be too mind blowing.
And I strongly disa
On Mon, Mar 12, 2012 at 12:53:13PM -0600, dgbale...@0x01b.net wrote:
> From: Matthew Monaco
>
> The case structure allows the syntax to focus on what's actually being
> done here.
> ---
> scripts/makepkg.sh.in | 61
> +++--
> 1 file changed, 34 inse
On Mon, Mar 12, 2012 at 12:53:11PM -0600, dgbale...@0x01b.net wrote:
> From: Matthew Monaco
>
> Rather than prioritizing an arbitrary VCS, collect all development
> directives. If there is more than one, use the package name as a hint.
> If that doesn't work, abort.
> ---
I'm not really sure I u
On Mon, Mar 12, 2012 at 04:40:38PM +0100, Thomas Bächler wrote:
> Am 09.03.2012 15:01, schrieb Dave Reisner:
> >> @@ -974,7 +974,7 @@ tidy_install() {
> >>
> >>if [[ $(check_option docs) = "n" && -n ${DOC_DIRS[*]} ]]; then
>
On Fri, Mar 09, 2012 at 02:11:08PM -0600, Dan McGee wrote:
> This reduces a lot of code duplication in the write function, which
> cleans it up a bit.
>
> Signed-off-by: Dan McGee
> ---
> lib/libalpm/be_local.c | 67
>
> 1 file changed, 22 inse
On Fri, Mar 09, 2012 at 05:59:09PM +1000, Allan McRae wrote:
> In preparation for the removal of the global error trap we need a
> way to ensure changing directories succeeds. Add a "cd_safe"
> wrapper that performs the necessary check.
>
> Signed-off-by: Allan McRae
> ---
> scripts/makepkg.sh.
On Fri, Mar 09, 2012 at 05:59:07PM +1000, Allan McRae wrote:
> Signed-off-by: Allan McRae
> ---
> scripts/makepkg.sh.in |7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
> index 8dd2d39..9cd8af8 100644
> --- a/scripts
On Fri, Mar 09, 2012 at 05:59:05PM +1000, Allan McRae wrote:
> Signed-off-by: Allan McRae
> ---
> scripts/makepkg.sh.in | 62
> -
> 1 file changed, 31 insertions(+), 31 deletions(-)
>
> diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
On Fri, Mar 09, 2012 at 05:59:04PM +1000, Allan McRae wrote:
> Signed-off-by: Allan McRae
> ---
ack.
> scripts/makepkg.sh.in | 24
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
> index 8763ffb..601c
On Fri, Mar 09, 2012 at 03:08:37PM +0100, Lukas Fleischer wrote:
> On Fri, Mar 09, 2012 at 11:20:03PM +1000, Allan McRae wrote:
> > Ignore .sig, *.db*, and *.src.tar* when cleaning the package cache.
> >
> > Fixes FS#25166.
> >
> > Signed-off-by: Allan McRae
> > ---
> >
> > I am bad at regex...
On Fri, Mar 09, 2012 at 05:59:06PM +1000, Allan McRae wrote:
> Most places in makepkg deal with full file paths, but a few use the
> file name only. Protect from potential issues when a file name
> starts with a hyphen.
How sure are we that these will always be relative paths and never ever
absol
On Wed, Feb 15, 2012 at 7:05 AM, Allan McRae wrote:
> On 15/02/12 04:57, Dave Reisner wrote:
> > It's expected that this will lead to unwanted behavior, and needs
> > widespread testing. It's desirable to commit this for a few reasons:
> >
> > - there&
On Wed, Feb 15, 2012 at 6:09 AM, Allan McRae wrote:
> On 15/02/12 04:58, Dave Reisner wrote:
> > If the PKGBUILD isn't writeable for devel_update, throw a warning
> > instead of silently ignoring it. Some logical reordering is present in
> > this patch to reduce
On Tue, Feb 14, 2012 at 02:30:06PM -0600, Dan McGee wrote:
> This has outlived its usefulness and causes more problems than it
> solves.
>
> Signed-off-by: Dan McGee
> ---
>
> This is an RFC first of all, so please feel free to comment.
>
> Pros:
> 1. Removes complexity and a fair amount of cod
On Tue, Feb 14, 2012 at 10:14:08AM -0600, Dan McGee wrote:
> This wonderful/awful little bash shell variable wrecks havoc on `cd`
> calls in shell scripts. Unset CDPATH in makepkg where we use `cd` quite
> heavily. In pacman-optimize, we can move the change directory logic into
> the bsdtar call so
If the PKGBUILD isn't writeable for devel_update, throw a warning
instead of silently ignoring it. Some logical reordering is present in
this patch to reduce the number of nested if's.
Signed-off-by: Dave Reisner
---
scripts/makepkg.sh.in | 14 +++---
1 files changed, 7
create source_safe() function which temporarily disables extglob and
exits on error.
Signed-off-by: Dave Reisner
---
scripts/makepkg.sh.in | 23 ++-
1 files changed, 14 insertions(+), 9 deletions(-)
diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
index 61c95af
code.
- it makes us immune to upstream changes in exit codes (FS#28248)
Signed-off-by: Dave Reisner
---
Allan, just making sure we're on the same page -- this _will_ cause breakage,
and the next patch in this series addresses one specific case. I figure getting
this patch in now gives us &q
On Mon, Feb 13, 2012 at 01:55:03AM +, Diogo Sousa wrote:
> Hello,
>
> when removing packages the default answer to "Do you want to remove
> these packages?" is Yes. Shouldn't we be conservative and provide "no"
> as the default?
>
> Diogo Sousa
>
Presumably the user intends to do what they
The max filesize for a delta download must be the full size of the delta
file, not just what's remaining.
Fixes FS#28345
Signed-off-by: Dave Reisner
---
lib/libalpm/sync.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/libalpm/sync.c b/lib/libalpm/sync.c
Use the new library CURLOPT_TCP_KEEPALIVE rather than disabling this via
the sockopt callback. If --keepalive-time is used, apply the value to
CURLOPT_TCP_KEEPIDLE and CURLOPT_TCP_KEEPINTVL.
---
The matching changes for the front end to use the new options from the previous
patch.
docs/curl.1
This adds three new options to control the behavior of TCP keepalives:
- CURLOPT_TCP_KEEPALIVE: enable/disable probes
- CURLOPT_TCP_KEEPIDLE: idle time before sending first probe
- CURLOPT_TCP_KEEPINTVL: delay between successive probes
While not all operating systems support the TCP_KEEPIDLE and
On Mon, Jan 23, 2012 at 09:25:18AM -0600, Dan McGee wrote:
> On Sun, Jan 22, 2012 at 7:31 PM, Dave Reisner wrote:
> > Signed-off-by: Dave Reisner
> > ---
> > lib/libalpm/dload.c | 8
> > 1 files changed, 4 insertions(+), 4 deletions(-)
> >
> >
On Mon, Jan 23, 2012 at 12:48:37PM +1000, Allan McRae wrote:
> On 23/01/12 12:13, Dave Reisner wrote:
> > On Mon, Jan 23, 2012 at 12:08:14PM +1000, Allan McRae wrote:
> >> On 20/01/12 23:59, Dave Reisner wrote:
> >>> On Fri, Jan 20, 2012 at 11:24:23PM +1000, Alla
On Mon, Jan 23, 2012 at 12:08:14PM +1000, Allan McRae wrote:
> On 20/01/12 23:59, Dave Reisner wrote:
> > On Fri, Jan 20, 2012 at 11:24:23PM +1000, Allan McRae wrote:
> >> The grep statement used to check for a difference between the
> >> installed package list
Signed-off-by: Dave Reisner
---
lib/libalpm/dload.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/libalpm/dload.c b/lib/libalpm/dload.c
index 790080c..c1be528 100644
--- a/lib/libalpm/dload.c
+++ b/lib/libalpm/dload.c
@@ -90,7 +90,7 @@ static void inthandler
This is particularly important in the case of FTP control connections,
which may be closed by rogue NAT/firewall devices detecting idle
connections on larger transfers which may take 5-10+ minutes.
Signed-off-by: Dave Reisner
---
This is basically on the advice of Daniel Stenberg, who mentions
On Sun, Jan 22, 2012 at 07:22:44PM +, Andrea Crotti wrote:
> On 01/22/2012 04:56 PM, Dan McGee wrote:
> >./autogen.sh if you are building from git and not a tarball. -Dan
>
> Ok thanks, the point was just that it was not written anywhere, maybe
> it would be good to add a section INSTALL FROM
On Fri, Jan 20, 2012 at 11:24:23PM +1000, Allan McRae wrote:
> The grep statement used to check for a difference between the
> installed package list before and after resolving dependencies
> returns 1 if there is no difference. This sets of the error
> trap when "-r" is used "unnecessarily".
>
>
On Wed, Jan 18, 2012 at 04:13:29PM +0530, Keshav P R wrote:
> Hi,
> Using
>
> XferCommand = /usr/bin/curl -C - -f -o %o %u
>
> XferCommand = /usr/bin/curl -C - -f %u > %o
>
> enables curl to resume downloads to %o , if it is supported. Using
> file redirection "> %o" makes curl restart the (
We lost this logic somewhere between the libfetch and libcurl
transition, as it existed in the internal downloader, but was pulled
back only into the sync workflow. Add a helper function that will let us
check for existance in the filecache prior to calling the downloader.
Signed-off-by: Dave
Signed-off-by: Dave Reisner
---
install/autodetect | 13 +++--
1 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/install/autodetect b/install/autodetect
index abc0fa0..7f40b9c 100644
--- a/install/autodetect
+++ b/install/autodetect
@@ -3,6 +3,12 @@
build
This is required for mounting a separate /usr. While the shutdown hook
is essentially a soft requirement for a separate /usr, we shouldn't
break init.
Signed-off-by: Dave Reisner
---
install/base |1 +
install/shutdown |2 +-
2 files changed, 2 insertions(+), 1 deletions(-)
Use findmnt to detect the existance of a separate /usr partition
existing in the real root. If it does exist, fetch the options for it
and mount it. This currently makes a lot of assumptions and won't be
very friendly towards something such as a dm-crypt device.
Signed-off-by: Dave Re
- firmware handling is now a udevd builtin
- udevadm may move -- let a path lookup find it
Signed-off-by: Dave Reisner
---
PKGBUILD |2 +-
install/udev |4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/PKGBUILD b/PKGBUILD
index a6a083f..fc6b398 100644
--- a
Refer to commit 9a9e0d68555 in the kernel where Linus removes this and
says "to be revisited later". The only option (currently) is to built
this into your kernel image.
Suggested by FS#27906.
Signed-off-by: Dave Reisner
---
install/dsdt | 14 --
1 files changed, 0
On Mon, Jan 09, 2012 at 08:51:57PM -0500, Dave Reisner wrote:
> updpkgsums updates checksums in a PKGBUILD "in place"
> ---
> This is really a whole lot of sanity checking and very little actual noise,
> but given what this script does (deleting a file), I chose to err on
n-place in PKGBUILDs
+#
+# Copyright (C) 2012 Dave Reisner
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any lat
On Mon, Jan 09, 2012 at 12:47:29PM -0600, Dan McGee wrote:
> On Mon, Jan 9, 2012 at 12:41 PM, jjacky wrote:
> >
> > On 01/09/12 19:28, Dave Reisner wrote:
> >>
> >> On Mon, Jan 09, 2012 at 07:09:12PM +0100, jjacky wrote:
> >>>
> >>> He
On Mon, Jan 09, 2012 at 07:09:12PM +0100, jjacky wrote:
> Hey there,
>
> So I've been working on a little app using libalpm, and I have a
> couple of questions. Hopefully it's okay to ask this here.
>
> First off, a quick question regarding the doc. Looking at the source
> code i see functions ar
On Sun, Jan 08, 2012 at 10:04:20PM +1000, Allan McRae wrote:
> Declaring the variable as local on the same line as the assignment
> results in result of the assignment being returned rather than the
> result of the function on the righthand side of the assignment.
>
> Declaring the variable as loc
On Sun, Jan 08, 2012 at 10:16:49PM +1000, Allan McRae wrote:
> On 08/01/12 04:27, Dave Reisner wrote:
> > Signed-off-by: Dave Reisner
> > ---
> > scripts/makepkg.sh.in | 16 ++--
> > 1 files changed, 10 insertions(+), 6 deletions(-)
> >
> &g
Signed-off-by: Dave Reisner
---
scripts/makepkg.sh.in |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
index eada195..89681ea 100644
--- a/scripts/makepkg.sh.in
+++ b/scripts/makepkg.sh.in
@@ -1336,6 +1336,8
Signed-off-by: Dave Reisner
---
scripts/makepkg.sh.in | 16 ++--
1 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
index 13185ee..eada195 100644
--- a/scripts/makepkg.sh.in
+++ b/scripts/makepkg.sh.in
@@ -1102,6 +1102,15
Add 1 failing for the -Su case, and the same case using -S (and
passing).
This is based on a real (current) issue of upgrading staging chroots
with the new pacman in staging for a libarchive build, and a new
toolchain in testing.
Signed-off-by: Dave Reisner
---
Longest. pactest. ever. And its
On Sat, Dec 31, 2011 at 09:07:12PM -0600, Dan McGee wrote:
> Signed-off-by: Dan McGee
> ---
>
> If anyone has any exotic builds that this breaks in, let me know, but since we
> now install everything else we should probably do these too. This vastly
> simplifies the pacman-contrib PKGBUILD to say
On Sun, Dec 25, 2011 at 11:50:57PM +0100, Florian Pritz wrote:
> On 25.12.2011 23:09, Allan McRae wrote:
> > On 26/12/11 03:27, Dave Reisner wrote:
> >> On Sun, Dec 25, 2011 at 06:20:27PM +0100, Florian Pritz wrote:
> >>> On 25.12.2011 16:06, Dave Reisner wrote:
&g
On Sun, Dec 25, 2011 at 06:20:27PM +0100, Florian Pritz wrote:
> On 25.12.2011 16:06, Dave Reisner wrote:
> > On Sun, Dec 25, 2011 at 08:37:24PM +1000, Allan McRae wrote:
> >> The current calculation of the total file size for a package using "du"
> >> s
On Sun, Dec 25, 2011 at 08:37:24PM +1000, Allan McRae wrote:
> The current calculation of the total file size for a package using "du"
> suffers from issues in portability and correctness. Especially on btrfs,
> this can result in clearly wrong package information such as:
>
> Download Size : 14
- take advantage of the new strtrim return value
- tighten scope on line pointer
Signed-off-by: Dave Reisner
---
src/util/pactree.c | 15 +--
1 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/src/util/pactree.c b/src/util/pactree.c
index 77ee75e..0adc2ea 100644
--- a
Signed-off-by: Dave Reisner
---
src/util/pactree.c | 18 +-
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/src/util/pactree.c b/src/util/pactree.c
index 55d63d7..77ee75e 100644
--- a/src/util/pactree.c
+++ b/src/util/pactree.c
@@ -117,13 +117,13 @@ char *strndup
Instead of returning the same value as the parameter to this function,
return the length of the string, which can be useful to the caller when
its non-zero (e.g. to find the end of the string).
Signed-off-by: Dave Reisner
---
This should make an earlier email from dan make a bit more sense
when
On Fri, Dec 23, 2011 at 03:15:12PM +0100, Timothy Redaelli wrote:
> From: Timothy Redaelli
>
> Signed-off-by: Timothy Redaelli
> ---
> scripts/pacman-key.sh.in |8
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/pacman-key.sh.in b/scripts/pacman-key.sh.
On Thu, Dec 22, 2011 at 05:49:47PM +1000, Allan McRae wrote:
> Pacman assumes that the final character of a line specifing a repo
> in pacman.conf is a "]". But it did not clean whitespace from the
> line after removing any comments. So lines like:
>
> [allanbrokeit] # could break system
>
> c
igned-off-by: Dave Reisner
---
Note that when I say "portable", I mean gcc, clang, and icc all support the
option. I think that covers most of our bases.
lib/libalpm/Makefile.am |3 +++
lib/libalpm/add.c|2 --
lib/libalpm/alpm.c |2 --
lib/libalpm/backup.c
Allows renamed .asc/.sig files to be still discovered by makepkg. This
is needed for a package such as PuTTY, which provides abnormally named
sig files (.DSA and .RSA) which are valid input for gpg --verify.
Signed-off-by: Dave Reisner
---
Related: do we want to natively support .SIG and .ASC as
On Wed, Dec 07, 2011 at 12:33:41PM -0600, Dan McGee wrote:
> This converts our script generation to use the built-in AM_V_GEN macro,
> which honors the V= setting passed to make and allows one to see the
> full command if they truly desire. The AM_V_at macro is also used in
> place of an explicit @
On Wed, Dec 07, 2011 at 10:11:18AM -0600, Dan McGee wrote:
> On Wed, Dec 7, 2011 at 10:08 AM, Dave Reisner wrote:
> > On Wed, Dec 07, 2011 at 09:58:49AM -0600, Dan McGee wrote:
> >> This is awesome, and I don't know why we haven't already done this. It
> >>
On Wed, Dec 07, 2011 at 09:58:49AM -0600, Dan McGee wrote:
> This is awesome, and I don't know why we haven't already done this. It
> gives us the much more less verbose make output in a few different ways:
>
> * If you run `make V=0`, you will get the quiet output.
> * If you run `./configure --e
On Mon, Dec 05, 2011 at 10:09:45AM -0600, Dan McGee wrote:
> This prevents user error in adding a file generated via `gpg --sign`
> rather than `--detach-sign`, for example. The same 16KiB limit is used
> we use in our pacman download code.
>
> The section is moved above the checksum generation to
On Mon, Dec 05, 2011 at 09:11:28AM -0600, Dan McGee wrote:
> On Sun, Dec 4, 2011 at 10:21 AM, Lukas Fleischer
> wrote:
> > On Sat, Dec 03, 2011 at 11:56:09AM -0600, Dan McGee wrote:
> >> On Fri, Dec 2, 2011 at 6:44 PM, Lukas Fleischer
> >> wrote:
> >> > On Fri, Dec 02, 2011 at 10:10:14AM -0600, D
On Fri, Nov 25, 2011 at 04:17:12PM +0100, Nagy Gabor wrote:
> > Scratches my own itch from FS#25667
> >
> > Signed-off-by: Dave Reisner
> > ---
> > lib/libalpm/sync.c |2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff
Scratches my own itch from FS#25667
Signed-off-by: Dave Reisner
---
lib/libalpm/sync.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/libalpm/sync.c b/lib/libalpm/sync.c
index 3817ec8..534499a 100644
--- a/lib/libalpm/sync.c
+++ b/lib/libalpm/sync.c
@@ -1160,7
Signed-off-by: Dave Reisner
---
doc/makepkg.conf.5.txt |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/doc/makepkg.conf.5.txt b/doc/makepkg.conf.5.txt
index 2778361..db1e6d5 100644
--- a/doc/makepkg.conf.5.txt
+++ b/doc/makepkg.conf.5.txt
@@ -215,7 +215,7 @@ Options
Whereas comm will check inputs to see if they're sorted (and warn when
they aren't), grep doesn't even care about ordering. In this particular
instance -- neither do we. We're only interested that the two lists are
equivalent.
Fixes FS#26580.
Signed-off-by: Dave R
ignore this garbage...
On Mon, Nov 21, 2011 at 11:46:05PM -0500, Dave Reisner wrote:
> Whereas comm will check inputs to see if they're sorted (and warn when
> they aren't), grep doesn't even care about ordering. In this particular
> instance -- neither do we. We're
Whereas comm will check inputs to see if they're sorted (and warn when
they aren't), grep doesn't even care about ordering. In this particular
instance -- neither do we. We're only interested that the two lists are
equivalent.
Fixes FS#26580.
Signed-off-by: Dave R
On Sun, Nov 20, 2011 at 01:07:14PM -0500, Andrew Gregory wrote:
> On Sun, 20 Nov 2011 12:39:11 -0500
> Dave Reisner wrote:
>
> > On Sun, Nov 20, 2011 at 12:18:59PM -0500, andrew.gregor...@gmail.com
> > wrote:
> > > From: Andrew Gregory
> > >
&
On Sun, Nov 20, 2011 at 12:18:59PM -0500, andrew.gregor...@gmail.com wrote:
> From: Andrew Gregory
>
> Not allowing fileowner queries for directories was an unnecessary
> limitation. Queries for directories have poor performance due to
> having to call real_path on every directory listed in ever
error, or fail validation.
Signed-off-by: Dave Reisner
---
scripts/makepkg.sh.in |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
index 085fbb9..f39e9d1 100644
--- a/scripts/makepkg.sh.in
+++ b/scripts/makepkg.sh.in
@@ -1
.
NB: We don't need to worry about leading whitespace because it will cause a
syntax error (when unquoted), or fail validation (when quoted).
Signed-off-by: Dave Reisner
---
Too late to squeeze this into maint?
scripts/makepkg.sh.in |4 ++--
1 files changed, 2 insertions(+), 2 dele
601 - 700 of 985 matches
Mail list logo
