Re: [pacman-dev] [PATCH] libalpm: fix alpm_option_set_assumeinstalled

2020-01-23 Thread Allan McRae
On 23/1/20 4:38 pm, morganamilo wrote: > It looks like this function has never actually worked. The current list > is never set to NULL after being freed. So the new deps were just > appended to the already freed list, leading to a segfault. Good spotting. Patch is good. A

[pacman-dev] [PATCH] libalpm: fix alpm_option_set_assumeinstalled

2020-01-22 Thread morganamilo
It looks like this function has never actually worked. The current list is never set to NULL after being freed. So the new deps were just appended to the already freed list, leading to a segfault. diff --git a/lib/libalpm/handle.c b/lib/libalpm/handle.c index e3193f40..23464045 100644 ---