Re: [pacman-dev] [PATCH] libmakepkg: fix linting arrays of empty strings

2018-10-21 Thread Morgan Adamiec
On Sun, 21 Oct 2018 at 13:10, Allan McRae wrote: > > On 21/10/18 9:56 pm, Morgan Adamiec wrote: > > On Sun, 21 Oct 2018 at 10:16, Allan McRae wrote: > >> The error this gives is: > >> ==> ERROR: depends is not allowed to be empty. > > > > Where so you get this error? > > > > pkgname=foo > >

Re: [pacman-dev] [PATCH] libmakepkg: fix linting arrays of empty strings

2018-10-21 Thread Morgan Adamiec
On Sun, 21 Oct 2018 at 10:16, Allan McRae wrote: > The error this gives is: > ==> ERROR: depends is not allowed to be empty. Where so you get this error? pkgname=foo pkgver=1 pkgrel=1 arch=(any) depends=('') This pkgbuild manages to pass linting for me without this patch. (resend,

Re: [pacman-dev] [PATCH] libmakepkg: fix linting arrays of empty strings

2018-10-21 Thread Allan McRae
On 17/10/18 3:49 am, morganamilo wrote: > [[ ${array[@]} ]] will resolve to false if array only contains empty > strings. This means that values such as "depends=('')" can be inserted > into a pkgbuild and bypass the linting. > > This causes makepkg to successfully build the package while pacman

[pacman-dev] [PATCH] libmakepkg: fix linting arrays of empty strings

2018-10-16 Thread morganamilo
[[ ${array[@]} ]] will resolve to false if array only contains empty strings. This means that values such as "depends=('')" can be inserted into a pkgbuild and bypass the linting. This causes makepkg to successfully build the package while pacman refuses to install it because of the unmet