Re: [pacman-dev] [PATCH 2/3] libmakepkg: implement extendable source protocols

2018-06-04 Thread Allan McRae
On 29/05/18 14:30, Eli Schwartz wrote: > Lookup the existence of matching functions for each protocol, and > fallback on the generic file handler. New source protocols can then be > added via thirdparty libmakepkg drop-ins without requiring modifications > to source.sh > > Fixes FS#49076 > >

Re: [pacman-dev] [PATCH] pacman-key: just accept one file to verify, and enforce detached sigs

2018-06-04 Thread Allan McRae
On 30/05/18 03:00, Eli Schwartz wrote: > Simply pass options on to gpg the same way gpg uses them -- no looping > through and checking lots of signatures. > > This prevents a situation where the signature file to be verified is > manipulated to contain a complete signature which is valid, but not

Re: [pacman-dev] [PATCH] Add lz4 compression support to makepkg

2018-06-04 Thread Allan McRae
On 31/05/18 23:31, Alex Butler wrote: > Adds opt-in lz4 compression of *pkg.tar files with makepkg. > This is nice to have as an option for very fast compression > and is already installed with libarchive. > > Signed-off-by: Alex Butler > --- This patch is fine in principle. But I think we need

[pacman-dev] [PATCH] PKGBUILD.5: document restriction on pkgrel

2018-06-04 Thread Allan McRae
The format of pkgrel was much more retrictive than described in the man page. Update the documentation to reflect this. Signed-off-by: Allan McRae --- Is this explanation clear? We also need to update the error message from lint_pkgrel to be more accurate. doc/PKGBUILD.5.asciidoc | 6 --

Re: [pacman-dev] [PATCH] makepkg: fix regression which broke split pkgbase-debug package metadata

2018-06-04 Thread Allan McRae
On 01/06/18 10:31, Eli Schwartz wrote: > In commit 9e52a36794552b77ecf26f7f34b226d096978f1e the split package > metadata backup/restore was refactored to use declare, which actually > declares variables in a local scope when in a function. This did not > play nicely with debug packages, which

Re: [pacman-dev] [PATCH] pacman.conf: Fixup the XferCommand example for curl

2018-06-04 Thread Allan McRae
On 04/06/18 06:01, Luke Shumaker wrote: > From: Luke Shumaker > > 1. Without `-L`, curl doesn't follow redirects. This is different than > both the default behavior of pacman, and from the wget example. So add > `-L`. > > 2. It uses `-C -` to supposedly allow resuming partial

Re: [pacman-dev] [PATCH 02/10] makepkg: Simplify SPLITPKG check

2018-06-04 Thread Allan McRae
On 01/06/18 07:01, Eli Schwartz wrote: > On 05/31/2018 12:24 PM, Jan Alexander Steffens (heftig) wrote: >> This causes package_$pkgname() to be preferred over package() in the >> non-split case, but the behavior if both functions exist was >> undocumented anyway. > > We don't document the

Re: [pacman-dev] [PATCH] makepkg: Treat pkgrel more similarly to pkgver

2018-06-04 Thread Allan McRae
On 04/06/18 06:01, Luke Shumaker wrote: > From: Luke Shumaker > > This is perfectly fine with libalpm; it was only makepkg that was more > strict with pkgrel than pkgver. > > Further, the former error message about invalid pkgrel formats claimed that > pkgrel was a "decimal", which would mean

[pacman-dev] [PATCH] makepkg: fix erroneous $BUILDDIR when $startdir is not an absolute path

2018-06-04 Thread Eli Schwartz
When comparing the $BUILDDIR to the $startdir, we used string equality instead of testing whether they are the same location, and ended up appending $pkgbase even though there's no reason to use it here. In some cases, this could result in makepkg erroring when trying to create $srcdir/$pkgdir,

Re: [pacman-dev] [PATCH] Strip leading "/" from arguments to --overwrite

2018-06-04 Thread Allan McRae
On 02/06/18 09:01, Joey Pabalinas wrote: > On Fri, Jun 01, 2018 at 06:56:13PM -0400, Andrew Gregory wrote: >> Sort of. The current --root option is a confusing mess that nobody >> actually understands, so it will go away at some point. The >> underlying libalpm rootdir setting isn't going

Re: [pacman-dev] [PATCH 09/10] makepkg: Clear ERR trap before trying to restore it

2018-06-04 Thread Jan Alexander Steffens
On Mon, Jun 4, 2018 at 1:05 PM Allan McRae wrote: > On 04/06/18 18:47, Jan Alexander Steffens wrote: > > The ERR trap is not inherited by functions unless the "errtrace" option > > is set. So in the current situation, makepkg's internal functions are > > supposed to do manual error checking. Bad

Re: [pacman-dev] [PATCH 09/10] makepkg: Clear ERR trap before trying to restore it

2018-06-04 Thread Allan McRae
On 04/06/18 18:47, Jan Alexander Steffens wrote: > The ERR trap is not inherited by functions unless the "errtrace" option > is set. So in the current situation, makepkg's internal functions are > supposed to do manual error checking. Bad returns from function calls at > the top level will trigger

Re: [pacman-dev] [PATCH] Add lz4 compression support to makepkg

2018-06-04 Thread Alex Butler
On 4 June 2018 at 08:48, Allan McRae wrote: > On 31/05/18 23:31, Alex Butler wrote: > > Adds opt-in lz4 compression of *pkg.tar files with makepkg. > > This is nice to have as an option for very fast compression > > and is already installed with libarchive. > > > > Signed-off-by: Alex Butler > >

Re: [pacman-dev] [PATCH 09/10] makepkg: Clear ERR trap before trying to restore it

2018-06-04 Thread Jan Alexander Steffens
The ERR trap is not inherited by functions unless the "errtrace" option is set. So in the current situation, makepkg's internal functions are supposed to do manual error checking. Bad returns from function calls at the top level will trigger the trap, though. On Mon, Jun 4, 2018 at 9:59 AM Allan

Re: [pacman-dev] [PATCH 2/3] libmakepkg: implement extendable source protocols

2018-06-04 Thread Eli Schwartz
On 06/04/2018 02:56 AM, Allan McRae wrote: >> +bzr|git|hg|svn) >> +(( get_vcs )) || continue >> ;; > > Should this be moved into the download_$proto functions? I'd guess most > of the dropins would be for other vcs

Re: [pacman-dev] [PATCH 09/10] makepkg: Clear ERR trap before trying to restore it

2018-06-04 Thread Allan McRae
On 01/06/18 02:24, Jan Alexander Steffens (heftig) wrote: > $restoretrap is empty if the trap was not set. This caused the trap > handler to remain and override later exit codes. How is this ever unset? We set the error trap early in makepkg: trap 'trap_exit USR1 "$(gettext "An unknown error has

Re: [pacman-dev] pacman user+group support without mtree

2018-06-04 Thread Andrew Gregory
On 06/04/18 at 05:01pm, Eli Schwartz wrote: > On 06/04/2018 04:55 PM, pacman-dev via pacman-dev wrote: > > > > Hello Pacman Dev, The basic question first, is there a way to create > > a tarball with .PKGINFO and use that tarball as a pacman package to > > install files with particular permissions

[pacman-dev] pacman user+group support without mtree

2018-06-04 Thread pacman-dev via pacman-dev
Hello Pacman Dev, The basic question first, is there a way to create a tarball with .PKGINFO and use that tarball as a pacman package to install files with particular permissions without also adding a .MTREE file to that tarball? More context, currently we install files into our servers using

Re: [pacman-dev] pacman user+group support without mtree

2018-06-04 Thread Eli Schwartz
On 06/04/2018 04:55 PM, pacman-dev via pacman-dev wrote: > > Hello Pacman Dev, The basic question first, is there a way to create > a tarball with .PKGINFO and use that tarball as a pacman package to > install files with particular permissions without also adding a > .MTREE file to that tarball?

Re: [pacman-dev] pacman-dev Digest, Vol 153, Issue 9

2018-06-04 Thread pacman-dev via pacman-dev
ding to their desired location > > on the filesystem.So my idea was that it would be relatively easy > > for me to add the appropriate .PKGINFO into the tarball and switch > > from using my bash script to using pacman itself. This all worked > > great, except f