Re: [pacman-dev] [PATCH] makepkg: use builtin globbing to print files in package

2018-08-21 Thread Eli Schwartz
On 8/21/18 11:53 AM, Andrew Gregory wrote: > On 08/21/18 at 10:15am, Eli Schwartz wrote: >> - dotfiles can be automatically printed *and the C locale sorts them first* >> with a single ** glob > > The glob will sort dotfiles before alphanumeric names, but there are several > characters that

Re: [pacman-dev] [PATCH] makepkg: use builtin globbing to print files in package

2018-08-21 Thread Eli Schwartz
On 8/21/18 11:41 AM, Luke Shumaker wrote: > On Tue, 21 Aug 2018 10:15:12 -0400, > Eli Schwartz wrote: >> diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in >> index ae1ef01b..1325b019 100644 >> --- a/scripts/makepkg.sh.in >> +++ b/scripts/makepkg.sh.in >> @@ -711,10 +711,14 @@

Re: [pacman-dev] [PATCH] makepkg: use builtin globbing to print files in package

2018-08-21 Thread Andrew Gregory
On 08/21/18 at 10:15am, Eli Schwartz wrote: > - dotfiles can be automatically printed *and the C locale sorts them first* > with a single ** glob The glob will sort dotfiles before alphanumeric names, but there are several characters that will still sort before a period.

[pacman-dev] [PATCH] makepkg: use builtin globbing to print files in package

2018-08-21 Thread Eli Schwartz
- it comes with free collation when moving the LC_ALL declaration up a bit; this fixes a bug where the .FILES were not being properly sorted and their order depended on directory creation order, which broke reproducible builds in the wild. - it handles sorting null-delimited output