Re: [pacman-dev] [PATCH] libmakepkg/source/git: Use --bare with a refspec instead of --mirror

2019-01-23 Thread Allan McRae
On 23/1/19 3:39 am, Johannes Löthberg wrote: > I distinctly remember having cases where there were old PRs from before > a rebase that ended up pulling in multiple gigabytes of data, but I > cannot seem to figure out which repos they were anymore. > > Of the larger repos I've looked at quickly

Re: [pacman-dev] [PATCH] libmakepkg/source/git: Use --bare with a refspec instead of --mirror

2019-01-22 Thread Johannes Löthberg
Excerpts from Allan McRae's message of January 20, 2019 22:30: > On 21/1/19 2:30 am, Eli Schwartz wrote: >> On 1/20/19 9:13 AM, Johannes Löthberg wrote: >>> This pulls in all of the branches in the same way as --mirror, but won't >>> also pull in all of the non-branch references. >>> >>> For

Re: [pacman-dev] [PATCH] libmakepkg/source/git: Use --bare with a refspec instead of --mirror

2019-01-20 Thread Allan McRae
On 21/1/19 2:30 am, Eli Schwartz wrote: > On 1/20/19 9:13 AM, Johannes Löthberg wrote: >> This pulls in all of the branches in the same way as --mirror, but won't >> also pull in all of the non-branch references. >> >> For example the refs/pull/*/{head,merge} references that GitHub creates >> for

Re: [pacman-dev] [PATCH] libmakepkg/source/git: Use --bare with a refspec instead of --mirror

2019-01-20 Thread Eli Schwartz
On 1/20/19 12:40 PM, Versus via pacman-dev wrote: > On 01/20/2019 07:30:21 PM, Eli Schwartz wrote: >> It's entirely possible that people use this to cherry-pick a patch from >> a PR branch. That being said, I do consider it reasonable to not fetch >> this by default and pull in the patchfile via

Re: [pacman-dev] [PATCH] libmakepkg/source/git: Use --bare with a refspec instead of --mirror

2019-01-20 Thread Earnestly via pacman-dev
On Sun, Jan 20, 2019 at 08:40:40PM +0300, Versus via pacman-dev wrote: > e.g. qgis from git but have no plans to hack it, clone with '--depth 1' How would the pkgver() work?

Re: [pacman-dev] [PATCH] libmakepkg/source/git: Use --bare with a refspec instead of --mirror

2019-01-20 Thread Versus via pacman-dev
On 01/20/2019 07:30:21 PM, Eli Schwartz wrote: It's entirely possible that people use this to cherry-pick a patch from a PR branch. That being said, I do consider it reasonable to not fetch this by default and pull in the patchfile via source=() if you do need it... but I wonder how often

Re: [pacman-dev] [PATCH] libmakepkg/source/git: Use --bare with a refspec instead of --mirror

2019-01-20 Thread Eli Schwartz
On 1/20/19 9:13 AM, Johannes Löthberg wrote: > This pulls in all of the branches in the same way as --mirror, but won't > also pull in all of the non-branch references. > > For example the refs/pull/*/{head,merge} references that GitHub creates > for every PR that has ever been opened against the

[pacman-dev] [PATCH] libmakepkg/source/git: Use --bare with a refspec instead of --mirror

2019-01-20 Thread Johannes Löthberg
This pulls in all of the branches in the same way as --mirror, but won't also pull in all of the non-branch references. For example the refs/pull/*/{head,merge} references that GitHub creates for every PR that has ever been opened against the repo can pull in a very large amount of objects that