Re: [pacman-dev] [PATCH] Strip leading "/" from arguments to --overwrite

2018-06-01 Thread Andrew Gregory
On 06/01/18 at 11:41am, Joey Pabalinas wrote: > On Fri, Jun 01, 2018 at 05:13:37PM -0400, Andrew Gregory wrote: > > If we're going to allow absolute paths, should we not be removing the > > full root, not just '/'? > > Did you mean strip out the sysroot in the event it happens to not be "/"? In >

Re: [pacman-dev] [PATCH] Strip leading "/" from arguments to --overwrite

2018-06-01 Thread Andrew Gregory
On 06/01/18 at 12:44pm, Joey Pabalinas wrote: > On Fri, Jun 01, 2018 at 05:45:11PM -0400, Andrew Gregory wrote: > > Not the sysroot, rootdir. I don't see how that would be overly > > complex, we do it in other places already. > > Isn't --root deprecated in favor of --sysroot though? (according

Re: [pacman-dev] [PATCH] Strip leading "/" from arguments to --overwrite

2018-06-01 Thread Joey Pabalinas
On Fri, Jun 01, 2018 at 06:56:13PM -0400, Andrew Gregory wrote: > Sort of. The current --root option is a confusing mess that nobody > actually understands, so it will go away at some point. The > underlying libalpm rootdir setting isn't going anywhere though, and, > in the future, will be

Re: [pacman-dev] [PATCH] Strip leading "/" from arguments to --overwrite

2018-06-01 Thread Joey Pabalinas
On Fri, Jun 01, 2018 at 05:13:37PM -0400, Andrew Gregory wrote: > If we're going to allow absolute paths, should we not be removing the > full root, not just '/'? Did you mean strip out the sysroot in the event it happens to not be "/"? In my opinion, although doable, the logic you'd need to add

Re: [pacman-dev] [PATCH] Strip leading "/" from arguments to --overwrite

2018-06-01 Thread Joey Pabalinas
On Fri, Jun 01, 2018 at 05:45:11PM -0400, Andrew Gregory wrote: > Not the sysroot, rootdir. I don't see how that would be overly > complex, we do it in other places already. Isn't --root deprecated in favor of --sysroot though? (according to the manpage at least). -- Cheers, Joey Pabalinas

Re: [pacman-dev] [PATCH] Strip leading "/" from arguments to --overwrite

2018-06-01 Thread Andrew Gregory
On 05/29/18 at 02:28pm, Allan McRae wrote: > The arguments for the --overwrite option requried the user to strip the > leading "/" from the path. It is more intuative to provide the whole > path and have pacman strip the leading "/" before passing to the > backend. > > Signed-off-by: Allan McRae

Re: [pacman-dev] [PATCH] src/pacman: strip any leading / in --overwrite arguments

2018-06-01 Thread Eli Schwartz
On 06/01/2018 05:50 AM, Joey Pabalinas wrote: > Allow both `pacman -S foo --overwrite /usr/lib/foo.sh` and > `pacman -S foo --overwrite usr/lib/foo.sh` (with any number > of leading / ignored) to semantically mean the same thing. Already done in

Re: [pacman-dev] [PATCH] Strip leading "/" from arguments to --overwrite

2018-06-01 Thread Joey Pabalinas
On Tue May 29 04:28:28 UTC 2018, Allan McRae wrote: > The arguments for the --overwrite option requried the user to strip the > leading "/" from the path. It is more intuative to provide the whole > path and have pacman strip the leading "/" before passing to the > backend. > > ... > > +