On 06/08/2018 11:56 AM, Florian Pritz via pacman-dev wrote:
> That subject is way too long. Please keep it around 50 chars if at all
> possible and put the more detailed explanation in the commit body. In
> this case it's probably best to simply end the subject at the first comma.
This was
That subject is way too long. Please keep it around 50 chars if at all
possible and put the more detailed explanation in the commit body. In
this case it's probably best to simply end the subject at the first comma.
Florian
signature.asc
Description: OpenPGP digital signature
From: Erich Eckner
Signed-off-by: Erich Eckner
---
scripts/makepkg.sh.in | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
index e9080a70..625b89a2 100644
--- a/scripts/makepkg.sh.in
+++ b/scripts/makepkg.sh.in
@@
On 06/08/2018 02:18 PM, morganamilo wrote:
> Error if the arch array contains any and any other values. This also
> fixes a bug where the check for `$arch == 'any'` which only evaluated
> the first value in the array, meaning the rest of the values would not
> be linted.
>
> Signed-off-by:
On 06/08/2018 02:18 PM, morganamilo wrote:
> When a split package overriddes an array using += and the array does not
> exist globally, makepkg --printsrcinfo will print the field with an
> empty vlaue before printing the acual values.
>
> For exampple: having `depends+=(foo bar)` will generate:
On 06/08/2018 02:18 PM, morganamilo wrote:
> We already ensure arch is an array but if arch is never defined
> this error never triggers. Add an explicit check for a missing arch.
Good catch! We'd usually abort with
==> ERROR: foo is not available for the 'x86_64' architecture.
but not if we're
On Fri, 8 Jun 2018 at 20:33, Eli Schwartz wrote:
>
> On 06/08/2018 02:18 PM, morganamilo wrote:
> > When a split package overriddes an array using += and the array does not
> > exist globally, makepkg --printsrcinfo will print the field with an
> > empty vlaue before printing the acual values.
>
When a split package overriddes an array using += and the array does not
exist globally, makepkg --printsrcinfo will print the field with an
empty vlaue before printing the acual values.
For exampple: having `depends+=(foo bar)` will generate:
depends =
depends = foo
Signed-off-by: morganamilo
---
scripts/libmakepkg/lint_pkgbuild/variable.sh.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/libmakepkg/lint_pkgbuild/variable.sh.in
b/scripts/libmakepkg/lint_pkgbuild/variable.sh.in
index 6b7da4a2..bdb70774 100644
---
Error if the arch array contains any and any other values. This also
fixes a bug where the check for `$arch == 'any'` which only evaluated
the first value in the array, meaning the rest of the values would not
be linted.
Signed-off-by: morganamilo
---
scripts/libmakepkg/lint_pkgbuild/arch.sh.in
Variables such as 'pkgdesc_x86_64' are invalid, instead of ignoring them
raise an error.
Signed-off-by: morganamilo
---
.../libmakepkg/lint_pkgbuild/variable.sh.in | 24 ++-
1 file changed, 23 insertions(+), 1 deletion(-)
diff --git
Signed-off-by: morganamilo
---
scripts/libmakepkg/lint_pkgbuild/variable.sh.in | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/scripts/libmakepkg/lint_pkgbuild/variable.sh.in
b/scripts/libmakepkg/lint_pkgbuild/variable.sh.in
index b9264768..6b7da4a2 100644
---
makepkpg will now error if disallowed variables are overridden inside of
the package function.
Signed-off-by: morganamilo
---
.../libmakepkg/lint_pkgbuild/variable.sh.in | 36 +++
1 file changed, 36 insertions(+)
diff --git a/scripts/libmakepkg/lint_pkgbuild/variable.sh.in
I recently did some data crunshing on AUR packages, trying to find ones that
are formatted incorrectly, catching mistakes makepkg did not.
I wrote up on the results here
https://github.com/Morganamilo/go-srcinfo/issues/1.
This patch should cover all the mistakes found and make is so that makepkg
We already ensure arch is an array but if arch is never defined
this error never triggers. Add an explicit check for a missing arch.
Signed-off-by: morganamilo
---
scripts/libmakepkg/lint_pkgbuild/arch.sh.in | 5 +
1 file changed, 5 insertions(+)
diff --git
On Fri, 8 Jun 2018 at 20:33, Eli Schwartz wrote:
>
> On 06/08/2018 02:18 PM, morganamilo wrote:
> > Error if the arch array contains any and any other values. This also
> > fixes a bug where the check for `$arch == 'any'` which only evaluated
> > the first value in the array, meaning the rest of
On Fri, Jun 08, 2018 at 08:42:11PM +0100, Morgan Adamiec wrote:
> On Fri, 8 Jun 2018 at 20:33, Eli Schwartz wrote:
> >
> > On 06/08/2018 02:18 PM, morganamilo wrote:
> > > When a split package overriddes an array using += and the array does not
> > > exist globally, makepkg --printsrcinfo will
> Please don't change this to paper over bad PKGBUILDs.
the thing is foo= is never declared in the pkgbuild
A pkgbuild like this:
pkgname=foo
pkgver=1
pkgrel=1
arch=('any')
package() {
depends+=("bar")
}
Generates a srcinfo like this:
pkgbase = foo
pkgver = 1
pkgrel = 1
arch = any
pkgname =
18 matches
Mail list logo
