Re: [pacman-dev] List packages from a given repo

2008-05-08 Thread Allan McRae
Dan McGee wrote: The magic: pkglist=$(mktemp) pacman -Sl $1 $pkglist pacman -Q | while read pkg; do ret=0 grep -q $pkg $pkglist || ret=$? if [ $ret -eq 0 ]; then echo $pkg fi done rm $pkglist Nice! I will submit the patch which adds this script to contrib later today.

Re: [pacman-dev] Libraries for makepkg

2008-05-10 Thread Allan McRae
Sebastian Nowicki wrote: I'm not sure that I like the idea very much. We should keep away from anything that makes PKGBUILDs more like Gentoo ebuilds. I love the simplicity and, I suppose, explicitness of PKGBUILDs because they are very easy to follow for anyone a bit familiar with

Re: [pacman-dev] [PATCH] Tidy up missing changelog error message

2008-05-10 Thread Allan McRae
Dan McGee wrote: On Sat, May 10, 2008 at 11:31 AM, Allan McRae [EMAIL PROTECTED] wrote: if((fp = alpm_pkg_changelog_open(pkg)) == NULL) { - /* TODO after string freeze use pm_fprintf */ - fprintf(stderr, _(error: no changelog available for '%s'.\n

Re: [pacman-dev] [PATCH] Tidy up missing changelog error message

2008-05-10 Thread Allan McRae
Dan McGee wrote: On Sat, May 10, 2008 at 11:31 AM, Allan McRae [EMAIL PROTECTED] wrote: if((fp = alpm_pkg_changelog_open(pkg)) == NULL) { - /* TODO after string freeze use pm_fprintf */ - fprintf(stderr, _(error: no changelog available for '%s'.\n

Re: [pacman-dev] [PATCH] makepkg - add check for valid options in PKGBUILD

2008-05-12 Thread Allan McRae
Xavier wrote: On Mon, May 12, 2008 at 4:35 PM, Allan McRae [EMAIL PROTECTED] wrote: Unknown and depreciated options are upgraded to error conditions. +known_options=('strip' 'docs' 'libtool' 'emptydirs' 'ccache' 'distcc' 'makeflags' 'force') +valid_options=0 +for opt in [EMAIL

Re: [pacman-dev] [PATCH] Refactor pkg_load/parse_descfile into a new backend file

2008-05-13 Thread Allan McRae
Dan McGee wrote: On Tue, May 13, 2008 at 7:24 AM, Xavier [EMAIL PROTECTED] wrote: But ok, that explains it. It might be that this error.h just stayed there on my other box. No, Linux or gcc 4.3 apparently doesn't blow up on a missing header file. I don't have it here and

[pacman-dev] libarchive version check

2008-05-14 Thread Allan McRae
Can we add a check on the libarchive version number when configuring pacman. You can run configure without a problem with a libarchive 1.x version but not actually complete the build. See http://bbs.archlinux.org/viewtopic.php?pid=367593 I know next to nothing about libarchive so I am giving

Re: [pacman-dev] [PATCH] A variety of small changes

2008-05-19 Thread Allan McRae
Roman Kyrylych wrote: 2008/5/19 Allan McRae [EMAIL PROTECTED]: Xavier wrote: But I think the current behavior is fine, just print an error in any cases. Are there really situations where you only want to generate md5sums, but not build the package or simply fix the pkgbuild so

Re: [pacman-dev] Fix command line argument parsing in makepkg

2008-05-28 Thread Allan McRae
Mark Constable wrote: On 2008-05-28, Xavier wrote: --source= -S --noconfirm= -n --noprogressbar = -N --holdver= -H --forcever = ? --asroot = ? Someone else suggested -0 and -F. The only extra I would suggest is an

Re: [pacman-dev] bacman

2008-05-29 Thread Allan McRae
Here is an inline version. Slightly changed from the version carlocci posted to fix a minor bug. Allan #!/bin/bash # # bacman: recreate a package from a running system # This script rebuilds an already installed package using metadata # stored into the pacman database and system files #

Re: [pacman-dev] [PATCH] makepkg: add --allsource option

2008-05-31 Thread Allan McRae
Miklos Vajna wrote: On Sat, May 31, 2008 at 04:32:15PM -0500, Dan McGee [EMAIL PROTECTED] wrote: Yes there is use for this- to help people using makepkg comply with the GPL and providing source and the necessary tools to build it when they provide binary packages. I didn't remove the

Re: [pacman-dev] [PATCH] Don't bother if a package has already been built when using the --nobuild option

2008-06-01 Thread Allan McRae
Dan McGee wrote: On Sun, Jun 1, 2008 at 11:41 PM, Anton Fiuman [EMAIL PROTECTED] wrote: makepkg should not abort with error when a user uses the --nobuild option to extract sources if a package has already been built. Signed-off-by: Anton Fiuman [EMAIL PROTECTED] Seems logical to

Re: [pacman-dev] #10530: checksum verification does not work on BSD

2008-06-02 Thread Allan McRae
Antonio Huete Jimenez wrote: And there comes the idea I was talking about. I think that scripts should behave according to the operating from where they are running on. I'm doing some changes to scripts for doing so, but it will take me few days to have something useable. I also think

Re: [pacman-dev] [PATCH] makepkg: add --allsource option

2008-06-02 Thread Allan McRae
Miklos Vajna wrote: On Mon, Jun 02, 2008 at 06:47:36AM -0500, Dan McGee [EMAIL PROTECTED] wrote: So what are you saying, did anyone actually look at the patch? I didn't change the existing --source option one bit, that *still* only includes local source files. yes, i read that

Re: [pacman-dev] [PATCH] makepkg: add --allsource option

2008-06-02 Thread Allan McRae
Dan McGee wrote: snip + local netfile + for netfile in [EMAIL PROTECTED]; do + local file=$(strip_url $netfile) + if [ -f $netfile ]; then + msg2 $(gettext Adding %s...) $netfile + comp_files=$comp_files $netfile +

Re: [pacman-dev] [PATCH] makepkg : switch from getopt to getopts builtin

2008-06-02 Thread Allan McRae
Alessio Bolognino wrote: On Mon 2008-06-02 11:54, Xavier wrote: From f5c5a277e2df14650ae441f32950aa6d4deee50f Mon Sep 17 00:00:00 2001 From: Xavier Chantry [EMAIL PROTECTED] Date: Wed, 28 May 2008 21:57:28 +0200 Subject: [PATCH] makepkg : switch from getopt to getopts builtin getopt is

Re: [pacman-dev] Configure --prefix in PKGBUILD scripts

2008-06-04 Thread Allan McRae
Antonio Huete Jimenez wrote: I was thinking a way of changing --prefix= used in configure. I think it's desirable to have a chance to change this to another directory, specially in BSD where a lot of userland applications should not be replaced with packages. pkgsrc does that by

[pacman-dev] [PATCH] bacman - regenerate package from system

2008-06-06 Thread Allan McRae
Original work by Carlo carlocci Bersani with additions by Xavier Chantry and Allan McRae This script rebuilds an already installed package using metadata stored into the pacman database and system files. Replaces the outdated re-pacman script Signed-off-by: Allan McRae [EMAIL PROTECTED

[pacman-dev] [PATCH] makepkg: add --allsource option

2008-06-06 Thread Allan McRae
This supplements the --source option and does nearly the same thing, except downloaded source files are included in the archive as well. The sources are now packages with a pkgname/ prefix. Original work by: Dan McGee [EMAIL PROTECTED] Signed-off-by: Allan McRae [EMAIL PROTECTED] --- scripts

Re: [pacman-dev] [PATCH] Fix warning messages when syncing installed package

2008-06-09 Thread Allan McRae
Xavier wrote: On Sat, Jun 7, 2008 at 6:05 PM, Allan McRae [EMAIL PROTECTED] wrote: The patch fixes the warning messages when syncing a package where the local version is newer that the db version. Also, all messages are suppressed when using --print-uris and messages about upgrading

Re: [pacman-dev] [PATCH] Fix warning messages when syncing installed package

2008-06-10 Thread Allan McRae
Xavier wrote: On Mon, Jun 9, 2008 at 10:48 AM, Allan McRae [EMAIL PROTECTED] wrote: Um, no I missed that completely. I think your version is the much cleaner way to do this. However, it still prints the warning messages (forcing upgrade is newer than) in _alpm_pkg_compare_versions

Re: [pacman-dev] [PATCH] makepkg.sh.in is prepared for building of splittet packages

2008-06-15 Thread Allan McRae
[EMAIL PROTECTED] wrote: snip + backup_o=$backup + conflicts_o=$conflicts + depends_o=$depends + groups_o=$groups + install_o=$install + license_o=$license + pkgdesc_o=$pkgdesc +

[pacman-dev] pactest coverage

2008-06-20 Thread Allan McRae
Hi all, I discovered gcov so was testing out the coverage of the pactests. During searching for more info about gcov I saw Dan already had written something on it (http://toofishes.net/blog/using-gcov-code-coverage-testing/) so not as novel as I thought... Anyway, as an FYI, here is a list

[pacman-dev] [PATCH] Additional path quoting and srcdir/pkgdir usage

2008-06-22 Thread Allan McRae
Removes the remaining $startdir/{src,pkg} usage and adds quoting around (hopefully) all remaining path variables Signed-off-by: Allan McRae [EMAIL PROTECTED] --- scripts/makepkg.sh.in | 17 - 1 files changed, 8 insertions(+), 9 deletions(-) diff --git a/scripts/makepkg.sh.in b

[pacman-dev] Git cheat-sheet for pacman - Was: [PATCH] links problem in bacman

2008-06-22 Thread Allan McRae
Carlo Bersani wrote: Sorry, I had to study how git works with coming exams Hope this is fine: Here is the cheat-sheet I made when first starting pacman development. It should be all you need to know for everyday git usage with the pacman repo. # Clone git repo - only needed once git

Re: [pacman-dev] Git cheat-sheet for pacman - Was: [PATCH] links problem in bacman

2008-06-23 Thread Allan McRae
Dan McGee wrote: On Sun, Jun 22, 2008 at 10:46 PM, Allan McRae [EMAIL PROTECTED] wrote: Carlo Bersani wrote: Sorry, I had to study how git works with coming exams Hope this is fine: Good work Allan. I've quickly thrown it into a wiki article along with some helpful links

Re: [pacman-dev] pac-file utility script

2008-06-25 Thread Allan McRae
Hi Pete, Can you post the script inline so it would be easier for us to comment on. Thanks, Allan ___ pacman-dev mailing list pacman-dev@archlinux.org http://archlinux.org/mailman/listinfo/pacman-dev

[pacman-dev] Dangling symlink to libtool file - Was: Re: [arch-dev-public] signoff: xfsprogs 2.9.8-1 for i686

2008-06-26 Thread Allan McRae
Eric Belanger wrote: Although the '!libtool' option is used, there is a libtool file in the package: lib/libhandle.la I'm guessing that makepkg doesn't search /lib for libtool files so it needs to be manually removed. Of course, I assume that it's not needed. That is actually a dangling

Re: [pacman-dev] Dangling symlink to libtool file - Was: Re: [arch-dev-public] signoff: xfsprogs 2.9.8-1 for i686

2008-06-26 Thread Allan McRae
Allan McRae wrote: Eric Belanger wrote: Although the '!libtool' option is used, there is a libtool file in the package: lib/libhandle.la I'm guessing that makepkg doesn't search /lib for libtool files so it needs to be manually removed. Of course, I assume that it's not needed

Re: [pacman-dev] [PATCH] Add rundepends keyword to makepkg

2008-07-01 Thread Allan McRae
Dan McGee wrote: I do see the use in this because I build regularly where I need to use the -d option, which unfortunately prevents a single dependency from being checked. Two years is a long time, so there has been plenty of time to reconsider, and I find the reasons in the bug report just

Re: [pacman-dev] [PATCH] Use $PKGEXT (from /etc/makepkg.conf) in bacman

2008-07-01 Thread Allan McRae
Nagy Gabor wrote: -bsdtar -czf $pkg_dest/$pkg_namver-$pkg_arch.tar.gz $(ls -A) || ret=$? +bsdtar -czf $pkg_dest/$pkg_namver-$pkg_arch$pkg_ext $(ls -A) || ret=$? Wow. I tested this script many, many times and I can't believe I missed that!

Re: [pacman-dev] [PATCH] Introduce destarch keyword into makepkg

2008-07-01 Thread Allan McRae
Dan McGee wrote: On Tue, Jul 1, 2008 at 8:58 PM, Allan McRae [EMAIL PROTECTED] wrote: Thomas Bächler wrote: If destarch is added to a PKGBUILD, I read that as de-starch and was confused for a while... :) makepkg sets the architecture of the resulting package

Re: [pacman-dev] [PATCH] ABS - Specify repo or package to download on command-line

2008-07-11 Thread Allan McRae
Dan McGee wrote: On Fri, Jul 11, 2008 at 6:54 AM, Allan McRae [EMAIL PROTECTED] wrote: Hi all, I figured I could still send patches for ABS here for people to look at since this is the address listed in --help output... Anyway, I mainly wanted a comment on this line: INCLUDE=$(echo

Re: [pacman-dev] [PATCH] ABS - Specify repo or package to download on command-line

2008-07-11 Thread Allan McRae
Dan McGee wrote: On Fri, Jul 11, 2008 at 7:23 AM, Allan McRae [EMAIL PROTECTED] wrote: Dan McGee wrote: On Fri, Jul 11, 2008 at 6:54 AM, Allan McRae [EMAIL PROTECTED] wrote: Hi all, I figured I could still send patches for ABS here for people to look at since

Re: [pacman-dev] [PATCH] Remove pacman.static build from build files

2008-07-15 Thread Allan McRae
Dan McGee wrote: This presents plenty of problems on OSes besides Linux, and even on Linux when the libtool file for libarchive isn't present. The static build isn't all that useful anyway as missing something such as glibc will still leave you unable to run the pacman.static binary. Remove it

Re: [pacman-dev] [PATCH] makepkg: speed up svn revision check for large repositories

2008-07-16 Thread Allan McRae
Dan McGee wrote: On Wed, Jul 16, 2008 at 1:45 AM, Xavier [EMAIL PROTECTED] wrote: Allan McRae wrote: Dan McGee wrote: On Tue, Jul 15, 2008 at 7:15 PM, Dan McGee [EMAIL PROTECTED] wrote: Using the suggestion from FS#10905, use 'svn info' rather than 'svn log

Re: [pacman-dev] String freeze for 3.2 release

2008-07-16 Thread Allan McRae
Nagy Gabor wrote: 2. Xav said, that deltas are broken. Couldn't we move this out from alpm code, and using it XferCommand or whatever (or implement new external helper, if needed)? How broken are they? More specifically, does this code need some minor fixes or a complete overhaul? BTW,

Re: [pacman-dev] [PATCH] makepkg: speed up svn revision check for large repositories

2008-07-17 Thread Allan McRae
Dan McGee wrote: On Wed, Jul 16, 2008 at 7:14 AM, Xavier [EMAIL PROTECTED] wrote: On Wed, Jul 16, 2008 at 1:47 PM, Allan McRae [EMAIL PROTECTED] wrote: More google searching on this and requiring to correct my previous assertions... LC_ALL=C is equivalent to LC_ALL=POSIX. Just

Re: [pacman-dev] [PATCH] Allow translation of makepkg y/n question

2008-07-18 Thread Allan McRae
Aaron Griffin wrote: On Fri, Jul 18, 2008 at 1:41 AM, Allan McRae [EMAIL PROTECTED] wrote: answer=$(echo $answer | tr '[:upper:]' '[:lower:]') Random unrelated point - can this line possibly cause issues similar to the Turkish I/i thing? Maybe, what

[pacman-dev] [PATCH] makepkg: add packages to pkgdeps list only after successful install

2008-07-23 Thread Allan McRae
in remove_deps is due to an obscure bug where local varaibles from the handle_deps function seem stay in scope because we never formally exited it. Signed-off-by: Allan McRae [EMAIL PROTECTED] --- scripts/makepkg.sh.in |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts

Re: [pacman-dev] [PATCH] makepkg: add packages to pkgdeps list only after successful install

2008-07-23 Thread Allan McRae
Allan McRae wrote: This fixed FS#9403. With this you can use makepkg -sr, install the dependencies, Ctrl+c during the makedepends installation and have makepkg remove the installed packages on the exit. Previously makepkg tried to also remove the makedepends which were not installed

Re: [pacman-dev] [PATCH] added pactree

2008-07-23 Thread Allan McRae
Carlo Bersani wrote: Pactree is a dependency tree viewer for installed packages. It features both textual and graphic (through graphviz) output. Thanks for this Carlo. Dan - I have been following the progress of this script and I am happy that it is working well. It would be great if

Re: [pacman-dev] [PATCH] added pactree

2008-07-23 Thread Allan McRae
Dan McGee wrote: On Wed, Jul 23, 2008 at 11:09 AM, Carlo Bersani [EMAIL PROTECTED] wrote: I fixed the ugly comments layout as well as the awk long long line Still need a license header or permission from you to add one of my choosing. It is there under the colour configuration

[pacman-dev] [PATCH] Update NEWS file for 3.2.0 release

2008-07-24 Thread Allan McRae
Signed-off-by: Allan McRae [EMAIL PROTECTED] --- NEWS | 76 ++ 1 files changed, 76 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 5a9157a..6429695 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,81 @@ VERSION

[pacman-dev] [PATCH] makepkg: Add used options to PKGINFO file

2008-07-24 Thread Allan McRae
Adds defined options to the PKGINFO file in the form of makepkgopt =. It may be useful to be able to add these to the pacman DB at some point as that would allow (e.g.) checking which packages have had their docs striped (FS#7092). Signed-off-by: Allan McRae [EMAIL PROTECTED] --- scripts

Re: [pacman-dev] [PATCH] makepkg: Add used options to PKGINFO file

2008-07-24 Thread Allan McRae
Allan McRae wrote: Adds defined options to the PKGINFO file in the form of makepkgopt =. It may be useful to be able to add these to the pacman DB at some point as that would allow (e.g.) checking which packages have had their docs striped (FS#7092). This is more of a might be a good idea

Re: [pacman-dev] [PATCH] makepkg: Add used options to PKGINFO file

2008-07-24 Thread Allan McRae
Xavier wrote: On Thu, Jul 24, 2008 at 2:41 PM, Allan McRae [EMAIL PROTECTED] wrote: Allan McRae wrote: Adds defined options to the PKGINFO file in the form of makepkgopt =. It may be useful to be able to add these to the pacman DB at some point as that would allow (e.g.) checking

Re: [pacman-dev] [PATCH] Readd some symlink checking in file conflict code

2008-07-24 Thread Allan McRae
Dan McGee wrote: On Wed, Jul 23, 2008 at 8:14 AM, Xavier [EMAIL PROTECTED] wrote: On Wed, Jul 23, 2008 at 2:53 PM, Dan McGee [EMAIL PROTECTED] wrote: I think we should just put some jury-rigged, hopefully passes both 003 and 004 code in here and really attempt to fix this on the

Re: [pacman-dev] [PATCH] makepkg: Add used options to PKGINFO file

2008-07-25 Thread Allan McRae
Xavier wrote: On Fri, Jul 25, 2008 at 3:08 AM, Allan McRae [EMAIL PROTECTED] wrote: Good point about the build options being useless. But I think all other options should go in so if/when we add further options we would know they are not used in the package. If we always put all

Re: [pacman-dev] Git cheat-sheet for pacman - Was: [PATCH] links problem in bacman

2008-07-27 Thread Allan McRae
Xavier wrote: On Mon, Jun 23, 2008 at 9:29 AM, Allan McRae [EMAIL PROTECTED] wrote: You may want to add a line about checking out other peoples branches (e.g. the pgp branch). I would be interested in that too... Please have a look at these two wiki pages : http

Re: [pacman-dev] Git cheat-sheet for pacman - Was: [PATCH] links problem in bacman

2008-07-27 Thread Allan McRae
Xavier wrote: On Sun, Jul 27, 2008 at 6:12 PM, Allan McRae [EMAIL PROTECTED] wrote: I had figured that out a while ago. That is why it is in the first link you gave! :D What, where? I didn't see anything, so I added this : http://wiki.archlinux.org/index.php?title

Re: [pacman-dev] [PATCH] Make strip paths configurable

2008-07-28 Thread Allan McRae
Aaron Griffin wrote: On Mon, Jul 28, 2008 at 4:12 PM, Xavier [EMAIL PROTECTED] wrote: What about handling it just like a normal variable ? [EMAIL PROTECTED] ~]$ array=({foo,bar,baz}) [EMAIL PROTECTED] ~]$ [ -z $array ] || echo array not empty array not empty [EMAIL PROTECTED] ~]$ unset

Re: [pacman-dev] [PATCH] makepkg: Clarify usage instructions for --allsource/--source

2008-07-30 Thread Allan McRae
Dan McGee wrote: Signed-off-by: Dan McGee [EMAIL PROTECTED] --- A release is never perfect. Just a documentation issue here though. Allan, you wrote the final patch so feel free to chime in on the descriptions I made. Wow, that was a fast release to bug turn around...

Re: [pacman-dev] [arch-dev-public] [signoff] pacman 3.2.0

2008-07-31 Thread Allan McRae
Roman Kyrylych wrote: 2008/7/31 Dan McGee [EMAIL PROTECTED]: On Thu, Jul 31, 2008 at 2:01 AM, Eric Belanger [EMAIL PROTECTED] wrote: On Wed, 30 Jul 2008, Dan McGee wrote: Pacman 3.2.0 is in testing for i686. Please signoff. Changes outlined here:

Re: [pacman-dev] [arch-dev-public] [signoff] pacman 3.2.0

2008-07-31 Thread Allan McRae
Roman Kyrylych wrote: 2008/7/31 Dan McGee [EMAIL PROTECTED]: On Thu, Jul 31, 2008 at 2:01 AM, Eric Belanger [EMAIL PROTECTED] wrote: On Wed, 30 Jul 2008, Dan McGee wrote: Pacman 3.2.0 is in testing for i686. Please signoff. Changes outlined here:

Re: [pacman-dev] makepkg download fails with special chars in URL (was: [signoff] pacman 3.2.0)

2008-07-31 Thread Allan McRae
Dan McGee wrote: On Thu, Jul 31, 2008 at 8:15 AM, Xavier [EMAIL PROTECTED] wrote: On Thu, Jul 31, 2008 at 2:50 PM, Allan McRae [EMAIL PROTECTED] wrote: Indeed, that is the first problem, netfile should be quoted here. local proto=$(echo $netfile | sed 's

Re: [pacman-dev] makepkg download fails with special chars in URL (was: [signoff] pacman 3.2.0)

2008-07-31 Thread Allan McRae
Allan McRae wrote: Dan McGee wrote: Subject change...and can someone open a bug and get this information in there, please? I'd rather track it there before 10 other people complain too. Filing bug report now. http://bugs.archlinux.org/task/11076

Re: [pacman-dev] makepkg download fails with special chars in URL (was: [signoff] pacman 3.2.0)

2008-07-31 Thread Allan McRae
This is where I have got up to in searching for the solution: 1) Fix sed statement to extract protocol in get_downloadclient() local proto=$(echo $url | sed 's|://.*||') 2) escape ampersands in netfile in get_downloadcmd() local netfile=$(echo $2 | sed s|\|\\\|g) Then $dlcmd get created

Re: [pacman-dev] [arch-dev-public] info pages

2008-08-08 Thread Allan McRae
Allan McRae wrote: We should also automatically compress the info files like we do the man pages. Would there be any objects to extending the zipman option to cover the compressing of info pages too? Also, I can see two options for doing this. 1) Just add the info directories

Re: [pacman-dev] [PATCH] Fix segfault on x86_64 when using UseSyslog

2008-08-08 Thread Allan McRae
Dan McGee wrote: Due to differences in handling va_list between i686 and x86_64, this bug can only be seen on x86_64. va_list usage is not allowed but we had been getting away with it. See http://lists.opensuse.org/opensuse-programming/2008-02/msg5.html for details and explanation. This

[pacman-dev] [PATCH] Fix creation of source package with local source files

2008-08-08 Thread Allan McRae
Fixes FS#11149. Signed-off-by: Allan McRae [EMAIL PROTECTED] --- scripts/makepkg.sh.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 3604d10..c5dbed9 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in

[pacman-dev] sourcing /etc/profile and set -e bug in makepkg

2008-08-11 Thread Allan McRae
So, despite me assuring Dan that nothing could possibly go wrong, the commit to source /etc/profile rather than individual files in /etc/profile.d (http://projects.archlinux.org/?p=pacman.git;a=commitdiff;h=0e0a8461) has caused a problem. See FS#11179 (http://bugs.archlinux.org/task/11179)

Re: [pacman-dev] sourcing /etc/profile and set -e bug in makepkg

2008-08-11 Thread Allan McRae
Xavier wrote: On Mon, Aug 11, 2008 at 5:24 PM, Allan McRae [EMAIL PROTECTED] wrote: So, despite me assuring Dan that nothing could possibly go wrong, the commit to source /etc/profile rather than individual files in /etc/profile.d (http://projects.archlinux.org/?p=pacman.git;a=commitdiff;h

[pacman-dev] [PATCH] Treat info pages like man pages

2008-08-12 Thread Allan McRae
As far a package building is concerned, info pages need to be treated in the same fashion as man pages in that they both can be compressed. This separates them from other forms of documentation and so it makes sense to make that distinction within makepkg. Signed-off-by: Allan McRae [EMAIL

[pacman-dev] Splitting packages with makepkg

2008-08-14 Thread Allan McRae
Hi all, Now that pacman 3.2 is out the door and the initial bug fixes appear done, I am going to work on adding the package splitting feature to makepkg. So the time has come for some input on the prototype PKGBUILD for splitting packages again. We discussed this a couple of months ago on

Re: [pacman-dev] package file hooks

2008-08-21 Thread Allan McRae
Xavier wrote: I was recently considering to implement package file hooks. snip But today I felt on this : http://www.linux.com/feature/144666 And this looks great, this feature might not even need to be implemented in pacman. But well, I don't know how well it would work in practice. It is just

Re: [pacman-dev] package file hooks

2008-08-21 Thread Allan McRae
Allan McRae wrote: Xavier wrote: I was recently considering to implement package file hooks. snip But today I felt on this : http://www.linux.com/feature/144666 And this looks great, this feature might not even need to be implemented in pacman. But well, I don't know how well it would work

Re: [pacman-dev] [aur-general] makepkg 3.2.1 testing

2008-08-24 Thread Allan McRae
G_Syme wrote: On Sunday 24 August 2008 03:42:05 Xavier wrote: [...] For FS#11292 (handling multiple source files which have the same name), a new feature had to be introduced. it is now possible to use the filename of your choice for remote sources, like this :

Re: [pacman-dev] [PATCH] makepkg : allow to specify a download filename

2008-08-24 Thread Allan McRae
Xavier Chantry wrote: A source entry can now have the following form, to specify a different filename : filename::http://path/to/file; Of course, the old syntax is still supported : http://path/to/file; And as before, in the second case, the filename used is simply file. This fixes FS#11292,

Re: [pacman-dev] handling info files

2008-09-21 Thread Allan McRae
Roman Kyrylych wrote: 2008/9/17 Andreas Radke [EMAIL PROTECTED]: Now that we decided that we want to ship info documentation we should decide how to package such files: info files could be gzipped by makepkg or stay uncompressed. On my system they already take quiet a lot of space compared

[pacman-dev] [PATCH] makepkg: Add used options to PKGINFO file

2008-09-26 Thread Allan McRae
Adds defined options to the PKGINFO file in the form of makepkgopt =. It may be useful to be able to add these to the pacman DB at some point as that would allow (e.g.) checking which packages have had their docs striped (FS#7092). Signed-off-by: Allan McRae [EMAIL PROTECTED] --- scripts

Re: [pacman-dev] [PATCH] makepkg: Add used options to PKGINFO file

2008-09-27 Thread Allan McRae
Allan McRae wrote: Adds defined options to the PKGINFO file in the form of makepkgopt =. It may be useful to be able to add these to the pacman DB at some point as that would allow (e.g.) checking which packages have had their docs striped (FS#7092). Signed-off-by: Allan McRae [EMAIL PROTECTED

Re: [pacman-dev] [PATCH] Provides a MAN_DIRS variable much like DOC/STRIP_DIRS. I need that for a package that install manpages in a non-standard place (/opt/devkitpro/devkitPPC/man/...).

2008-10-10 Thread Allan McRae
This seems a good idea to me and the patch looks good. One small comment below. Tiago Pierezan Camargo wrote: Signed-off-by: Tiago Pierezan Camargo [EMAIL PROTECTED] --- doc/makepkg.conf.5.txt |7 +++ etc/makepkg.conf.in|2 ++ scripts/makepkg.sh.in |9 - 3 files

Re: [pacman-dev] explicit dependencies, a compromise between explicit and deps

2008-10-12 Thread Allan McRae
Dieter Plaetinck wrote: Hi, pacman has an option --asdeps so the user can install packages as if it were deps. In fact, such packages will be treated exactly the same as normal dependencies: blah What are your ideas? Thanks, Dieter That explanation made my head hurt So to put it

[pacman-dev] [ABS PATCH] Allow syncing the ABS tree using tarballs

2008-10-26 Thread Allan McRae
-by: Allan McRae [EMAIL PROTECTED] --- abs | 56 conf/abs.conf |7 ++- 2 files changed, 58 insertions(+), 5 deletions(-) diff --git a/abs b/abs index bd1191d..a369482 100755 --- a/abs +++ b/abs @@ -80,6 +80,7 @@ usage

Re: [pacman-dev] [ABS PATCH] Allow syncing the ABS tree using tarballs

2008-10-26 Thread Allan McRae
Dieter Plaetinck wrote: +if [ ! $(type -p rsync) ]; then +error missing wget download utility. Install wget. +exit $_E_MISSING_PROGRAM +fi You probably meant 'type -p wget' here? Good catch! A bit too much copy/paste here... You can also just check the exit status

Re: [pacman-dev] [PATCH] makepkg: fix updating PKGBUILD when building SCM packages

2008-10-28 Thread Allan McRae
Allan McRae wrote: Fixes a bug and resets pkgrel to 1 when bumping pkgver Signed-off-by: Allan McRae [EMAIL PROTECTED] --- scripts/makepkg.sh.in |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 5735891..e8add36

[pacman-dev] [PATCH] makepkg: enable passing PKGBUILD from pipe

2008-10-28 Thread Allan McRae
Do not attemp to update pkgver/pkgrel when reading a SCM based PKGBUILD from a pipe. Fixes FS#9187. Signed-off-by: Allan McRae [EMAIL PROTECTED] --- scripts/makepkg.sh.in | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/scripts/makepkg.sh.in b/scripts

Re: [pacman-dev] [PATCH] makepkg: enable passing PKGBUILD from pipe

2008-10-28 Thread Allan McRae
Dan McGee wrote: On Tue, Oct 28, 2008 at 7:07 AM, Allan McRae [EMAIL PROTECTED] wrote: Do not attemp to update pkgver/pkgrel when reading a SCM based PKGBUILD from a pipe. Fixes FS#9187. So the patch makes sense, but I'm not quite seeing that it is this easy. [EMAIL PROTECTED] /tmp

Re: [pacman-dev] [PATCH] -Qu rework

2008-11-01 Thread Allan McRae
Dan McGee wrote: On Fri, Oct 31, 2008 at 10:31 AM, Nagy Gabor [EMAIL PROTECTED] wrote: On Fri, Oct 24, 2008 at 12:53 AM, Xavier [EMAIL PROTECTED] wrote: On Fri, Oct 24, 2008 at 2:09 AM, Nagy Gabor [EMAIL PROTECTED] wrote: See:

[pacman-dev] [PATCH] libalpm: add PID to db.lck

2008-11-02 Thread Allan McRae
This is the first step in being able to automatically remove phantom lock files. Signed-off-by: Allan McRae [EMAIL PROTECTED] --- lib/libalpm/util.c | 15 +-- 1 files changed, 13 insertions(+), 2 deletions(-) diff --git a/lib/libalpm/util.c b/lib/libalpm/util.c index da3463b

Re: [pacman-dev] [PATCH] libalpm: add PID to db.lck

2008-11-02 Thread Allan McRae
Allan McRae wrote: This is the first step in being able to automatically remove phantom lock files. Signed-off-by: Allan McRae [EMAIL PROTECTED] snip I should point out that this is my first attempt at writing to a file at such a low level (I'm a C++ streams kkinda guy). I'm not sure if I

Re: [pacman-dev] [PATCH] libalpm: add PID to db.lck

2008-11-03 Thread Allan McRae
Dan McGee wrote: On Sun, Nov 2, 2008 at 8:22 PM, Allan McRae [EMAIL PROTECTED] wrote: This is the first step in being able to automatically remove phantom lock files. Signed-off-by: Allan McRae [EMAIL PROTECTED] --- lib/libalpm/util.c | 15 +-- 1 files changed, 13 insertions

Re: [pacman-dev] [PATCH] FS#8798 - Allow -Qo to perform a functional 'which'

2008-11-06 Thread Allan McRae
Jatheendra wrote: Hi all, This is a simple patch to add a which like functionality to pacman -Qo[Bug FS#8798]. This is my first patch ,so any constructive criticism is most welcome. Thanks, Shankar Nice work. This is a really nice feature to implement. --- src/pacman/query.c | 62

Re: [pacman-dev] delta support in libalpm

2008-11-10 Thread Allan McRae
Henning Garus wrote: On Sat, Nov 8, 2008 at 1:38 PM, Nagy Gabor [EMAIL PROTECTED] wrote: Hi, I have been looking through the current delta implementation in libalpm and have put some thought into changing makepkg/repo-add to support delta creation. However, I'm running into some problems,

Re: [pacman-dev] Status of Splitting packages with makepkg

2008-11-13 Thread Allan McRae
Jakub Schmidtke wrote: Hi. I guess this is the right place to ask :) What is the status of this feature? I have read discussions from June and August, and some of the ideas look very interesting. Is there anything going on with this? Is there a way to help (as non dev/TU though)? :) Jakub

[pacman-dev] [PATCH] makepkg: several small bits of tidying

2008-11-13 Thread Allan McRae
test condition Signed-off-by: Allan McRae [EMAIL PROTECTED] --- scripts/makepkg.sh.in | 31 +-- 1 files changed, 9 insertions(+), 22 deletions(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index b0d1dad..f5cdd90 100644 --- a/scripts/makepkg.sh.in +++ b

Re: [pacman-dev] [PATCH] makepkg: several small bits of tidying

2008-11-13 Thread Allan McRae
Allan McRae wrote: 1. Do not warn people about missing arch if they are using --ignorearch. 2. Remove unneed reference to bug report about using fakeroot as little as possible. We want to do that, bug report of not. 3. Removes superfluous warning given when building as root. The user

Re: [pacman-dev] Status of Splitting packages with makepkg

2008-11-13 Thread Allan McRae
Allan McRae wrote: Marc - A. Dahlhaus [ Administration | Westermann GmbH ] wrote: Hello Allen, the prototype has a little problem in case you give -L option to makepkg as it is now: As makepkg pipes the output of the build-function into tee, the build-function gets executed in a sub-shell

Re: [pacman-dev] [PATCH] Added the function parse_options to replace getopt

2008-11-18 Thread Allan McRae
Yun Zheng Hu wrote: This will make makepkg work properly on systems like Mac OS X, where the default installed getopt does not handle long options. see also: http://www.archlinux.org/pipermail/pacman-dev/2008-May/011830.html Signed-off-by: Yun Zheng Hu [EMAIL PROTECTED] ---

Re: [pacman-dev] [PATCH] Added the function parse_options to replace getopt

2008-11-27 Thread Allan McRae
Yun Zheng Hu wrote: This will make makepkg work properly on systems like Mac OS X, where the default installed getopt does not handle long options. The new parse_options function tries to behave like the original getopt command as much as possible. see also:

[pacman-dev] [PATCH] Add optdepends to PKGBUILD.proto

2008-12-01 Thread Allan McRae
Signed-off-by: Allan McRae [EMAIL PROTECTED] --- PKGBUILD.proto |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/PKGBUILD.proto b/PKGBUILD.proto index 3265530..eddcf75 100644 --- a/PKGBUILD.proto +++ b/PKGBUILD.proto @@ -14,6 +14,7 @@ license=('GPL') groups=() depends

[pacman-dev] [PATCH] contirb/pactree: fix option parsing

2008-12-04 Thread Allan McRae
The option parsing was catching any -d in an arguement so packages with this in their name did not work. Also removed commented code line that appears to be inserted during testing Signed-off-by: Allan McRae [EMAIL PROTECTED] --- contrib/pactree |3 +-- 1 files changed, 1 insertions(+), 2

Re: [pacman-dev] Dan's pacman tree buildtest

2008-12-04 Thread Allan McRae
Gerhard Brauer wrote: Hi Dan, git clone http://code.toofishes.net/gitprojects/pacman.git (branch is master) 1. if have to install asciidox (for a2x), that's current not a (build)depend of pacman make stops with an error make[2]: Entering directory `/home/gerhard/al-de/pac-git/pacman/doc' a2x

Re: [pacman-dev] [PATCH] makepkg: save and restore shell options before and after build()

2008-12-04 Thread Allan McRae
Dan McGee wrote: On Thu, Dec 4, 2008 at 8:48 PM, Dan McGee [EMAIL PROTECTED] wrote: Fix the issue uncovered by FS#12344. In this instance, the dotglob shopt was being set in the build() function but never cleared, causing issues in the remaining parts of the makepkg script. Signed-off-by:

Re: [pacman-dev] [PATCH] makepkg: save and restore shell options before and after build()

2008-12-04 Thread Allan McRae
Aaron Griffin wrote: On Thu, Dec 4, 2008 at 9:00 PM, Allan McRae [EMAIL PROTECTED] wrote: Dan McGee wrote: On Thu, Dec 4, 2008 at 8:48 PM, Dan McGee [EMAIL PROTECTED] wrote: Fix the issue uncovered by FS#12344. In this instance, the dotglob shopt was being set in the build

Re: [pacman-dev] PKGBUILD.proto

2008-12-05 Thread Allan McRae
Jud wrote: Hi, Dan suggested I send this to the pacman-dev list. After completing some research and asking alot of questions I present some minor changes to PKGBUILD.proto supplied as a .diff to be merged after your approval. I believe it helps the intended audience create a better PKGBUILD in

[pacman-dev] [Fwd: [arch-general] PKGBUILD and DOS line endings]

2008-12-06 Thread Allan McRae
Should we be handling this issue? Allan Original Message Subject:[arch-general] PKGBUILD and DOS line endings Date: Sat, 6 Dec 2008 15:32:26 +0100 From: Alessandro Doro [EMAIL PROTECTED] Reply-To: General Discusson about Arch Linux [EMAIL PROTECTED] To:

Re: [pacman-dev] PKGBUILD.proto - Take2

2008-12-06 Thread Allan McRae
Jud wrote: Hi, Edit: Take2, changed the install line Dan suggested I send this to the pacman-dev list. After completing some research and asking alot of questions I present some minor changes to PKGBUILD.proto supplied as a .diff to be merged after your approval. I believe it helps the

[pacman-dev] makepkg: package splitting

2008-12-07 Thread Allan McRae
PKGBUILD.2 - Splitting the packaging step from build step. Limits fakeroot usage PKGBUILD.3 - Package splitting # $Id: PKGBUILD 366 2008-04-19 13:01:23Z travis $ # Maintainer: Allan McRae [EMAIL PROTECTED] pkgname=abs pkgver=2.3 pkgrel=1 pkgdesc=Utilities to download and work with the Arch Build

  1   2   3   4   5   6   7   8   9   10   >