Re: [pacman-dev] [PATCH] Strip leading "/" from arguments to --overwrite

2018-06-01 Thread Joey Pabalinas
ich would strip the rootdir and then the leading "/". Although I am not 100% certain config->rootdir would be NULL if no argument is passed; could you confirm that part? -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [pacman-dev] [PATCH] Strip leading "/" from arguments to --overwrite

2018-06-01 Thread Joey Pabalinas
ou'd need to add would make this far more complex than just stripping out leading "/", and how scarce that particular situation is in reality make this not really seem like a worthwhile trade-off to me. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [pacman-dev] [PATCH] Strip leading "/" from arguments to --overwrite

2018-06-01 Thread Joey Pabalinas
On Fri, Jun 01, 2018 at 05:45:11PM -0400, Andrew Gregory wrote: > Not the sysroot, rootdir. I don't see how that would be overly > complex, we do it in other places already. Isn't --root deprecated in favor of --sysroot though? (according to the manpage at least). -- Cheers, Joey Pab

Re: [pacman-dev] [PATCH] Strip leading "/" from arguments to --overwrite

2018-06-01 Thread Joey Pabalinas
ike: > i += strspn(i, "/") would be much simpler (and maintain equivalent semantics) in place of that loop. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature