[pacman-dev] [PATCH 0/4] Smatch warning fixes

a pointer dereference which should be the correct place to put it. Cheers, Silvan [1] http://smatch.sourceforge.net/ Silvan Jegen (4): Remove unneeded NULL check Another unneeded NULL check removed Another NULL check removed Move NULL check before dereference src/pacman/pacman.c | 16

[pacman-dev] [PATCH 4/4] Move NULL check before dereference

Signed-off-by: Silvan Jegen s.je...@gmail.com --- src/pacman/pacman.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c index 7329f0f..1d821ef 100644 --- a/src/pacman/pacman.c +++ b/src/pacman/pacman.c @@ -262,13 +262,13

[pacman-dev] [PATCH 3/4] Another NULL check removed

Signed-off-by: Silvan Jegen s.je...@gmail.com --- src/util/pacsort.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/util/pacsort.c b/src/util/pacsort.c index 443e822..df3e809 100644 --- a/src/util/pacsort.c +++ b/src/util/pacsort.c @@ -97,10 +97,7 @@ static void

[pacman-dev] [PATCH 2/4] Another unneeded NULL check removed

Signed-off-by: Silvan Jegen s.je...@gmail.com --- src/pacman/util.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/pacman/util.c b/src/pacman/util.c index 58b0cec..4aaa98f 100644 --- a/src/pacman/util.c +++ b/src/pacman/util.c @@ -206,12 +206,10 @@ int rmrf

Re: [pacman-dev] [PATCH 2/4] Another unneeded NULL check removed

On Tue, Jan 28, 2014 at 10:58:30AM -0600, Dan McGee wrote: On Tue, Jan 28, 2014 at 10:50 AM, Silvan Jegen s.je...@gmail.com wrote: Signed-off-by: Silvan Jegen s.je...@gmail.com --- src/pacman/util.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src

Re: [pacman-dev] [PATCH 4/4] Move NULL check before dereference

On Tue, Jan 28, 2014 at 12:32:13PM -0500, Andrew Gregory wrote: On 01/28/14 at 05:50pm, Silvan Jegen wrote: Signed-off-by: Silvan Jegen s.je...@gmail.com --- src/pacman/pacman.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/pacman/pacman.c b/src

[pacman-dev] [PATCH] Remove unneeded header inclusions

I checked only a few files but if you think cleaning up the includes is worth the hassle I could continue to check further files. (see: http://sillymon.ch/data/diskspace_8c__incl.png for example) -- 8 -- These headers are included transitively and can be removed. Signed-off-by: Silvan Jegen

[pacman-dev] [PATCH] pacman: Correct signal handler behavior

). Additionally, it changes the exit message to reflect the fact that the signal received was either a SIGHUP or a SIGTERM. Signed-off-by: Silvan Jegen s.je...@gmail.com --- src/pacman/pacman.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/pacman/pacman.c b/src

Re: [pacman-dev] [PATCH] pacman: Correct signal handler behavior

On Fri, Jun 20, 2014 at 05:12:10PM -0400, Andrew Gregory wrote: On 06/20/14 at 10:00pm, Silvan Jegen wrote: One of the comments for this function is out of sync with the code. If a SIGHUP is received the code calls the release function only if there is no transaction in flight (contrary

Re: [pacman-dev] [PATCH v2] pacman: Correct signal handler comment and refactor

Hi On Mon, Jun 23, 2014 at 9:39 AM, Allan McRae al...@archlinux.org wrote: On 21/06/14 18:18, Silvan Jegen wrote: One of the comments for this function is out of sync with the code. Since the code exhibits the more sane behavior of treating SIGINT and SIGHUB the same way (by not exiting

Re: [pacman-dev] [PATCH 1/4] Revert refactoring in fa0c1e14

On Sat, Jun 28, 2014 at 09:45:05PM -0400, Dave Reisner wrote: On Sun, Jun 29, 2014 at 11:27:31AM +1000, Allan McRae wrote: This will cause the code to break as soon as we handle another signal such as SIGWINCH... Signed-off-by: Allan McRae al...@archlinux.org --- Well... that

[pacman-dev] [PATCH] Refactor strtrim function

Signed-off-by: Silvan Jegen <s.je...@gmail.com> --- src/common/util-common.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/src/common/util-common.c b/src/common/util-common.c index 542dcfd..0b67d85 100644 --- a/src/common/util-common.c +++ b/src/commo

Re: [pacman-dev] [PATCH v2 1/7] move strtim to util-common

Hi On Sat, Sep 19, 2015 at 03:10:50PM +1000, Allan McRae wrote: > On 19/09/15 03:17, Silvan Jegen wrote: > > On Mon, Sep 14, 2015 at 06:37:38PM -0400, Andrew Gregory wrote: > >> Signed-off-by: Andrew Gregory <andrew.gregor...@gmail.com> > >> +/* Trim whit

Re: [pacman-dev] [PATCH v2 1/7] move strtim to util-common

Hi There is a typo in the commit message. [pacman-dev] [PATCH v2 1/7] move strtim to util-common vs. [pacman-dev] [PATCH v2 1/7] move strt*r*im to util-common one other thing below. On Mon, Sep 14, 2015 at 06:37:38PM -0400, Andrew Gregory wrote: > Signed-off-by: Andrew Gregory

Re: [pacman-dev] [PATCH] Handle bad .part files when encountered

Heyho Just two suggestions below. On Fri, Apr 15, 2016 at 1:54 PM, Allan McRae wrote: > We can end up with .part files downloaded that are unable to be used by pacman > in two ways: 1) a well timed ctrl+c right at the rename of the download file > can leave a complete

Re: [pacman-dev] [PATCH] Give a "success!" message on database check

On Thu, Sep 29, 2016 at 6:25 AM, Allan McRae wrote: > On 29/09/16 05:29, Patrick Eigensatz wrote: >> Ps: Is it possible to tell git send-email to reply to the message with >> this ID? >> > > --in-reply-to= > > (although I am fairly sure no-one does that...) I have used it

Re: [pacman-dev] [PATCH] hooks: warn if reassignment overwrites previous setting

Hi On Mon, Jan 2, 2017 at 4:19 PM, Stefan Klinger wrote: > In hook definition files, repeated assignment to Description, Exec, > Type, and When silently overwrote previous settings. This yields a > warning now. > > Signed-off-by: Stefan Klinger >

Re: [pacman-dev] [PATCH] makepkg: use localized date strings

Hi On Wed, Mar 7, 2018 at 5:03 AM, Chih-Hsuan Yen wrote: > Does this patch requires more work? Or I was doing something wrong in > submitting patches? I'll be grateful for any further feedback. It seems like a reasonable change to me but I am a little bit worried about it

Re: [pacman-dev] [PATCH] makepkg: use localized date strings

On Wed, Mar 7, 2018 at 11:09 AM, Allan McRae <al...@archlinux.org> wrote: > On 07/03/18 17:56, Silvan Jegen wrote: >> On FreeBSD that option does seem to be >> supported: https://www.freebsd.org/cgi/man.cgi?date > > Right on the page you linked... >

Re: [pacman-dev] [PATCH] makepkg: use localized date strings

On Wed, Mar 7, 2018 at 2:50 PM, Andrew Gregory <andrew.gregor...@gmail.com> wrote: > On 03/07/18 at 02:30pm, Silvan Jegen wrote: >> On Wed, Mar 7, 2018 at 11:09 AM, Allan McRae <al...@archlinux.org> wrote: >> > On 07/03/18 17:56, Silvan Jegen wrote: >>