On Sun, 24 Jun 2018 at 02:31, Allan McRae wrote:
>
> On 24/06/18 11:24, Morgan Adamiec wrote:
> >> Please append a version of you patch in the subject line. e.g.
> >> [PATCH 7/7 v3]
> >
> > Eli gave me a little walk through on the best practises for patches,
> > next patches will include this.
>
On 24/06/18 11:24, Morgan Adamiec wrote:
>> Please append a version of you patch in the subject line. e.g.
>> [PATCH 7/7 v3]
>
> Eli gave me a little walk through on the best practises for patches,
> next patches will include this.
>
>> I'm still not happy with this patch. Why not just
> Please append a version of you patch in the subject line. e.g.
> [PATCH 7/7 v3]
Eli gave me a little walk through on the best practises for patches,
next patches will include this.
> I'm still not happy with this patch. Why not just explicitly check that
> "any" is specified on its own,
On 13/06/18 11:40, morganamilo wrote:
> Error if the arch array contains any and any other values. This also
> fixes a bug where the check for `$arch == 'any'` which only evaluated
> the first value in the array, meaning the rest of the values would not
> be linted.
>
> Signed-off-by: morganamilo
On Wed, 13 Jun 2018 at 02:31, Eli Schwartz wrote:
>
> On 06/11/2018 06:57 PM, Morgan Adamiec wrote:
> > On Mon, 11 Jun 2018 at 22:27, Eli Schwartz wrote:
> >>
> >> On 06/11/2018 04:53 PM, morganamilo wrote:
> >>> Error if the arch array contains any and any other values. This also
> >>> fixes a
On 06/11/2018 06:57 PM, Morgan Adamiec wrote:
> On Mon, 11 Jun 2018 at 22:27, Eli Schwartz wrote:
>>
>> On 06/11/2018 04:53 PM, morganamilo wrote:
>>> Error if the arch array contains any and any other values. This also
>>> fixes a bug where the check for `$arch == 'any'` which only evaluated
>>>
On Mon, 11 Jun 2018 at 22:27, Eli Schwartz wrote:
>
> On 06/11/2018 04:53 PM, morganamilo wrote:
> > Error if the arch array contains any and any other values. This also
> > fixes a bug where the check for `$arch == 'any'` which only evaluated
> > the first value in the array, meaning the rest of
On 06/11/2018 04:53 PM, morganamilo wrote:
> Error if the arch array contains any and any other values. This also
> fixes a bug where the check for `$arch == 'any'` which only evaluated
> the first value in the array, meaning the rest of the values would not
> be linted.
>
> Signed-off-by:
On Fri, 8 Jun 2018 at 20:33, Eli Schwartz wrote:
>
> On 06/08/2018 02:18 PM, morganamilo wrote:
> > Error if the arch array contains any and any other values. This also
> > fixes a bug where the check for `$arch == 'any'` which only evaluated
> > the first value in the array, meaning the rest of
On 06/08/2018 02:18 PM, morganamilo wrote:
> Error if the arch array contains any and any other values. This also
> fixes a bug where the check for `$arch == 'any'` which only evaluated
> the first value in the array, meaning the rest of the values would not
> be linted.
>
> Signed-off-by:
10 matches
Mail list logo