Re: [pacman-dev] Add --nolist option for transactions
On 07/09/2018 07:03 PM, Dmitry Kudriavtsev wrote: >> Though honestly, if you're scripting this it boggles my mind that you >> don't want to preserve standard output in logs that you aren't looking >> at unless something bad happens, in which case you want as much >> information as possible... >> > > Don't the transactions still get logged in the system locs if the > UseSyslog preference is enabled? It does get logged to pacman.log, but those logs record transactions and not e.g. runtime warnings for ignored packages, inconsistent/missing files, prompts to replace one package with another via conflicts or replaces, etc. I guess you could stitch together a proper view of what happened, if you really needed to... just logging output seems wiser though. -- Eli Schwartz Bug Wrangler and Trusted User signature.asc Description: OpenPGP digital signature
Re: [pacman-dev] Add --nolist option for transactions
On 07/09/2018 05:58 PM, Dmitry Kudriavtsev wrote:
> On Mon, Jul 09, 2018 at 06:10:41AM -0400, Andrew Gregory wrote:
>> On 07/09/18 at 01:47am, Dmitry Kudriavtsev wrote:
>>> On Sat, Jul 07, 2018 at 05:17:32PM +1000, Allan McRae wrote:
On 07/07/18 10:32, m...@dk0.us wrote:
> From: Dmitry Kudriavtsev
>
> Adds a --nolist option for package transactions. This option removes the
> list
> display of packages to be installed or removed.
>
> Signed-off-by: Dmitry Kudriavtsev
> ---
I don't think this is a good option to include.
>>>
>>> Why not?
>>
>> Blindly installing/removing packages without knowing what they are is
>> generally a bad idea. What is the use case for this feature?
>
> Installing a list of packages that are already known, mostly for use in
> scripting or with -d.
I don't see why we should encourage people to do that, at all.
If you desperately dislike standard output, nothing is stopping you from
using:
yes y | pacman -S --noconfirm "${packagelist[@]}" > /dev/null 2>&1
Which also gets rid of the list, but with more honesty.
Though honestly, if you're scripting this it boggles my mind that you
don't want to preserve standard output in logs that you aren't looking
at unless something bad happens, in which case you want as much
information as possible...
--
Eli Schwartz
Bug Wrangler and Trusted User
signature.asc
Description: OpenPGP digital signature
Re: [pacman-dev] Add --nolist option for transactions
On Mon, Jul 09, 2018 at 06:10:41AM -0400, Andrew Gregory wrote: > On 07/09/18 at 01:47am, Dmitry Kudriavtsev wrote: > > On Sat, Jul 07, 2018 at 05:17:32PM +1000, Allan McRae wrote: > > > On 07/07/18 10:32, m...@dk0.us wrote: > > > > From: Dmitry Kudriavtsev > > > > > > > > Adds a --nolist option for package transactions. This option removes > > > > the list > > > > display of packages to be installed or removed. > > > > > > > > Signed-off-by: Dmitry Kudriavtsev > > > > --- > > > > > > I don't think this is a good option to include. > > > > Why not? > > Blindly installing/removing packages without knowing what they are is > generally a bad idea. What is the use case for this feature? Installing a list of packages that are already known, mostly for use in scripting or with -d.
Re: [pacman-dev] Add --nolist option for transactions
On 07/09/18 at 01:47am, Dmitry Kudriavtsev wrote: > On Sat, Jul 07, 2018 at 05:17:32PM +1000, Allan McRae wrote: > > On 07/07/18 10:32, m...@dk0.us wrote: > > > From: Dmitry Kudriavtsev > > > > > > Adds a --nolist option for package transactions. This option removes the > > > list > > > display of packages to be installed or removed. > > > > > > Signed-off-by: Dmitry Kudriavtsev > > > --- > > > > I don't think this is a good option to include. > > Why not? Blindly installing/removing packages without knowing what they are is generally a bad idea. What is the use case for this feature?
Re: [pacman-dev] Add --nolist option for transactions
On Sat, Jul 07, 2018 at 05:17:32PM +1000, Allan McRae wrote:
> On 07/07/18 10:32, m...@dk0.us wrote:
> > From: Dmitry Kudriavtsev
> >
> > Adds a --nolist option for package transactions. This option removes the
> > list
> > display of packages to be installed or removed.
> >
> > Signed-off-by: Dmitry Kudriavtsev
> > ---
>
> I don't think this is a good option to include.
Why not?
>
> > diff --git a/src/pacman/remove.c b/src/pacman/remove.c
> > index a2269ed8..5df45c69 100644
> > --- a/src/pacman/remove.c
> > +++ b/src/pacman/remove.c
> > @@ -164,8 +164,11 @@ int pacman_remove(alpm_list_t *targets)
> > }
> >
> > /* print targets and ask user confirmation */
> > - display_targets();
> > - printf("\n");
> > + if(!config->nolist) {
> > + display_targets();
> > + printf("\n");
> > + }
> > +
>
> Here pacman would print nothing then ask if it is OK to remove those
> packages.
Should --nolist imply --noconfirm?
>
> > if(yesno(_("Do you want to remove these packages?")) == 0) {
>
>
>
> > retval = 1;
> > goto cleanup;
> > diff --git a/src/pacman/sync.c b/src/pacman/sync.c
> > index 3c6be89d..1e0c6c91 100644
> > --- a/src/pacman/sync.c
> > +++ b/src/pacman/sync.c
> > @@ -793,8 +793,10 @@ int sync_prepare_execute(void)
> > goto cleanup;
> > }
> >
> > - display_targets();
> > - printf("\n");
> > + if(!config->nolist) {
> > + display_targets();
> > + printf("\n");
> > + }
> >
> > int confirm;
> > if(config->op_s_downloadonly) {
> >
Re: [pacman-dev] Add --nolist option for transactions
On 07/07/18 10:32, m...@dk0.us wrote:
> From: Dmitry Kudriavtsev
>
> Adds a --nolist option for package transactions. This option removes the list
> display of packages to be installed or removed.
>
> Signed-off-by: Dmitry Kudriavtsev
> ---
I don't think this is a good option to include.
> diff --git a/src/pacman/remove.c b/src/pacman/remove.c
> index a2269ed8..5df45c69 100644
> --- a/src/pacman/remove.c
> +++ b/src/pacman/remove.c
> @@ -164,8 +164,11 @@ int pacman_remove(alpm_list_t *targets)
> }
>
> /* print targets and ask user confirmation */
> - display_targets();
> - printf("\n");
> + if(!config->nolist) {
> + display_targets();
> + printf("\n");
> + }
> +
Here pacman would print nothing then ask if it is OK to remove those
packages.
> if(yesno(_("Do you want to remove these packages?")) == 0) {
> retval = 1;
> goto cleanup;
> diff --git a/src/pacman/sync.c b/src/pacman/sync.c
> index 3c6be89d..1e0c6c91 100644
> --- a/src/pacman/sync.c
> +++ b/src/pacman/sync.c
> @@ -793,8 +793,10 @@ int sync_prepare_execute(void)
> goto cleanup;
> }
>
> - display_targets();
> - printf("\n");
> + if(!config->nolist) {
> + display_targets();
> + printf("\n");
> + }
>
> int confirm;
> if(config->op_s_downloadonly) {
>
