Re: pass generates very weak passwords with busybox's tr

2019-07-17 Thread Daniel Janus
On Tue, Jul 16, 2019 at 09:44:30PM +0200, Allan Odgaard wrote: > Btw: Since they support both alnum and punct, I think you can use this: > > read -r -n 12 pass < <(LC_ALL=C tr -dc '[:punct:][:alnum:]' < > /dev/urandom); echo $pass That does indeed work. > Maybe submit a PR and see what

Re: pass generates very weak passwords with busybox's tr

2019-07-16 Thread Allan Odgaard
On 16 Jul 2019, at 21:09, Daniel Janus wrote: Clearly, Busybox's `tr` doesn't support the `[:graph:]` character class. Instead, it's taking those 9 characters (8 distinct) as a character set. This gave me a chuckle :) Given that Busybox's focus is on size and essential features, and

Re: pass generates very weak passwords with busybox's tr

2019-07-16 Thread Tobias Girstmair
On Tue, Jul 16, 2019 at 09:18:30PM +0200, Tobias Girstmair wrote: I don't know which sed(1) Alpine packages, but you might be able to use sed 's/[^[:graph:]]//g' instead of tr(1). But I think requiring a greater-than-busybox is fine for pass. Oh, as an addendum: busybox' tr just

pass generates very weak passwords with busybox's tr

2019-07-16 Thread Daniel Janus
Hi, I'm using pass 1.7.3 (on Alpine 3.10) and I've recently noticed that `pass generate` seems to generate very weak passwords on a default installation. Here are a few random passwords generated by `pass generate -c 12`: ]hhgh][[]r[g ph[:::hpp:p[ hg]:aaaghp]] Needless to say, I'm