Re: [PATCH v2 06/13] REST: Stop using ViewSets

2016-11-23 Thread Andrew Donnellan
On 20/11/16 03:51, Stephen Finucane wrote: +class ProjectMixin(object): + permission_classes = (PatchworkPermission,) serializer_class = ProjectSerializer -def _handle_linkname(self, pk): -'''Make it easy for users to list by project-id or linkname''' -qs =

Re: [PATCH] views: don't duplicate tags in patch message when generating mbox

2016-11-23 Thread Daniel Axtens
> Would it be helpful to add a test that compares full mbox output to > catch stuff like this? IMO, the answer to "would it be helpful to have a test for this thing we just discovered was broken?" is always "yes". Anyway, I'm happy if that's a follow-up patch. Reviewed-by: Daniel Axtens