Re: [PATCH] REST: Show 'comments' in '/patches', '/comments'

2018-04-27 Thread Stephen Finucane
On Fri, 2018-04-27 at 11:58 -0400, Veronika Kabatova wrote: > - Original Message - > > From: "Stephen Finucane" > > To: patchwork@lists.ozlabs.org > > Cc: "Stephen Finucane" , "Veronika Kabatova" > aba...@redhat.com> > > Sent: Friday, April 27, 2018

Re: [PATCH v4] api: Add comments to patch and cover endpoints

2018-04-27 Thread Veronika Kabatova
- Original Message - > From: "Stephen Finucane" > To: vkaba...@redhat.com, patchwork@lists.ozlabs.org > Sent: Friday, April 27, 2018 5:37:57 PM > Subject: Re: [PATCH v4] api: Add comments to patch and cover endpoints > > On Wed, 2018-04-25 at 19:33 +0200,

Re: [PATCH v4] api: Add comments to patch and cover endpoints

2018-04-27 Thread Stephen Finucane
On Wed, 2018-04-25 at 19:33 +0200, vkaba...@redhat.com wrote: > From: Veronika Kabatova > > Signed-off-by: Veronika Kabatova Two comments below. I've actually addressed these already with my own patch. Assuming you're happy with said patch, I can

[PATCH] REST: Show 'comments' in '/patches', '/comments'

2018-04-27 Thread Stephen Finucane
This link is only shown for individual resources at the moment. Modify this behavior. Signed-off-by: Stephen Finucane Cc: Veronika Kabatova --- patchwork/api/cover.py | 20 +--- patchwork/api/patch.py | 37

Re: [PATCH 3/6] docker: Remove bash aliases

2018-04-27 Thread Stephen Finucane
On Sat, 2018-04-28 at 01:24 +1000, Daniel Axtens wrote: > I use createsu but not runserver, and I guess I could learn to just > invoke manage.py > > FWIW I don't think Wednesday to Friday is really long enough on the list > to merge patches that drop stuff. Yeah, that's fair. I probably should

Re: [PATCH 2/6] tests: Remove Selenium tests

2018-04-27 Thread Stephen Finucane
On Sat, 2018-04-28 at 01:16 +1000, Daniel Axtens wrote: > It looks like you might have merged this already - sorry for the delay > as I've been on holiday - but, I still use these, still test with these > and have (had?) plans to extend these as I update jQuery and Bootstrap > to more recent

Re: [PATCH 3/6] docker: Remove bash aliases

2018-04-27 Thread Daniel Axtens
I use createsu but not runserver, and I guess I could learn to just invoke manage.py FWIW I don't think Wednesday to Friday is really long enough on the list to merge patches that drop stuff. Anyway I will now return to the remainder of my holidays. Regards, Daniel Stephen Finucane

Re: [PATCH 2/6] tests: Remove Selenium tests

2018-04-27 Thread Daniel Axtens
It looks like you might have merged this already - sorry for the delay as I've been on holiday - but, I still use these, still test with these and have (had?) plans to extend these as I update jQuery and Bootstrap to more recent versions. Stephen Finucane writes: > These were