Re: [PATCH 01/11] Improve patch listing performance (~3x)

2018-08-29 Thread Stewart Smith
Stephen Finucane writes: > On Sat, 2018-08-11 at 04:28 +1000, Daniel Axtens wrote: >> Stewart Smith writes: >> So, further to our conversation with Konstantin, I tested this against >> Django 2.0. It still saves us some time - it means we no longer load the >> following fields: >> >>

Re: [PATCH] Find patches, cover letters and comments by msgid

2018-08-29 Thread Don Zickus
On Wed, Aug 29, 2018 at 01:50:11PM +0100, Stephen Finucane wrote: > On Mon, 2018-08-27 at 00:14 +1000, Daniel Axtens wrote: > > Add /message/ and /project//message/ URLs. > > > > /project//message/ finds the patch, cover-letter or > > comment in that matches and redirects you to it. > > This is

Re: [PATCH] docker: Use heredocs where possible

2018-08-29 Thread Petr Vorel
Hi Stephen, > This was suggested in a recent review [1]. Make it happen. > [1] http://patchwork.ozlabs.org/patch/933979/#1941584 > Signed-off-by: Stephen Finucane > Suggested-by: Petr Vorel Reviewed-by: Petr Vorel > --- LGTM, thanks for taking care for it. Next step could be to remove

Re: git-pw v1.1.0 available

2018-08-29 Thread Stephen Finucane
On Tue, 2018-06-19 at 23:05 +0100, Stephen Finucane wrote: > We're delighted to announce the release of git-pw v1.1.0: > > https://github.com/getpatchwork/git-pw/releases/tag/1.1.0 > > This is the first minor release of git-pw. This version adds support > for REST API v1.1 added in Patchwork

git-pw v1.3.0 available

2018-08-29 Thread Stephen Finucane
We're delighted to announce the release of git-pw v1.3.0: https://github.com/getpatchwork/git-pw/releases/tag/1.3.0 This is the third minor release of git-pw. This version allows passthrough of 'git-am' options to the various 'apply' commands without the need to escape the options. In

Re: [PATCH 01/11] Improve patch listing performance (~3x)

2018-08-29 Thread Stephen Finucane
On Sat, 2018-08-11 at 04:28 +1000, Daniel Axtens wrote: > Stewart Smith writes: > > > There's two main bits that are really expensive when composing the list > > of patches for a project: the query getting the list, and the query > > finding the series for each patch. > > > > If we look at the

Re: title tag in a series list

2018-08-29 Thread Stephen Finucane
On Mon, 2018-07-23 at 11:47 +, Ali Alnubani wrote: > Hi, > > I’m trying to set the HTML title tag in a series filtered list as the series > title instead of the project name. > I did something like the following, but it’s not working (obviously): I genuinely have no idea what's going on

Re: Postmortem upgrading patchwork.kernel.org 1.0->2.1

2018-08-29 Thread Stephen Finucane
On Thu, 2018-08-02 at 03:03 +1000, Daniel Axtens wrote: > Hi Konstantin, > > > Hello, patchwork list! > > > > About a week ago I performed the upgrade of patchwork.kernel.org from > > version 1.0 to version 2.1. This is my war story, since it didn't go > > nearly as smooth as I was hoping. >

Re: [PATCH] Find patches, cover letters and comments by msgid

2018-08-29 Thread Stephen Finucane
On Mon, 2018-08-27 at 00:14 +1000, Daniel Axtens wrote: > Add /message/ and /project//message/ URLs. > > /project//message/ finds the patch, cover-letter or > comment in that matches and redirects you to it. > This is guaranteed to be unique. > > /message/ does not require a project, but

Re: [PATCH] Add stricter checks when parsing incoming patches

2018-08-29 Thread Stephen Finucane
On Fri, 2018-07-13 at 14:46 -0400, Don Zickus wrote: > The patch parser has a multi-stage if-then-else statement that tries to > determine which part of a patch is the comment and what piece is the > patch itself. > > Unfortunately there is a gap in between state 1 and state 2 where chunks > of

Re: Database consistency issues

2018-08-29 Thread Stephen Finucane
On Wed, 2018-08-08 at 12:27 -0400, Konstantin Ryabitsev wrote: > On Thu, Aug 09, 2018 at 02:01:11AM +1000, Daniel Axtens wrote: > > In the case of Patchwork 1.1.3, I am more confused - the Comment model > > has a foreign key to Patch here. So if you try to delete Patch you > > should have got a

Re: Database consistency issues

2018-08-29 Thread Stephen Finucane
On Thu, 2018-08-09 at 02:01 +1000, Daniel Axtens wrote: > > > > I will prepare a patch that adds the foreign keys. > > Further to this: > > Patchwork 2.1 has that Comment has a foreign key relationship to > submission, not patch. > > Patch *inherits* from Submission. This was, in hindsight,

Re: [PATCH 10/11] tox: Rework warning infrastructure

2018-08-29 Thread Stephen Finucane
On Sat, 2018-08-25 at 13:09 +1000, Daniel Axtens wrote: > Hi Stephen, > > So I had a look at the warnings. We see some import warnings that we saw > before, but most of them are ResourceWarnings out of xmlrpc. We can fix > all but one of them with this snippet in XMLRPCTest: > > def

[PATCH v2] requirements: Start using fixed versions

2018-08-29 Thread Stephen Finucane
Given that 'tox' doesn't actually read any of these, there's no reason to use ranges of requirements. Instead, use the latest and greatest for live instances and rely on tox to validate behavior with older versions. The selenium dependency, which is no longer required since commit bab2895f, is

Re: [PATCH 08/11] requirements: Start using fixed versions

2018-08-29 Thread Stephen Finucane
On Sat, 2018-08-11 at 04:08 +1000, Daniel Axtens wrote: > Stephen Finucane writes: > > > Given that 'tox' doesn't actually read any of these, there's no reason > > to use ranges of requirements. Instead, use the latest and greatest for > > live instances and rely on tox to validate behavior with

Re: [PATCH 01/11] REST: Check.user is not read-only

2018-08-29 Thread Stephen Finucane
On Sun, 2018-08-26 at 17:10 +1000, Daniel Axtens wrote: > Hi Stephen, > > Super keen to have Django 2.0 support! I dropped patch 8 because I > couldn't get it to work, and applied the small changes I suggested. > > I have applied and pushed the remainder. Cheers :) Now for Django 2.1. This

[PATCH] docker: Use heredocs where possible

2018-08-29 Thread Stephen Finucane
This was suggested in a recent review [1]. Make it happen. [1] http://patchwork.ozlabs.org/patch/933979/#1941584 Signed-off-by: Stephen Finucane Suggested-by: Petr Vorel --- tools/docker/entrypoint.sh | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git