Re: [PATCH 10/11] Be sensible computing project patch counts

2018-09-09 Thread Stewart Smith
Stephen Finucane writes: > On Fri, 2018-08-31 at 15:16 +0100, Stephen Finucane wrote: >> On Fri, 2018-08-10 at 18:01 +1000, Stewart Smith wrote: >> > Django actively fights constructing a query that isn't insane. >> > >> > So, let's go and just execute a raw one. This is all very standard >> >

Re: [PATCH 10/11] Be sensible computing project patch counts

2018-09-09 Thread Stewart Smith
Stephen Finucane writes: > On Fri, 2018-08-10 at 18:01 +1000, Stewart Smith wrote: >> Django actively fights constructing a query that isn't insane. >> >> So, let's go and just execute a raw one. This is all very standard >> SQL so should execute everywhere without a problem. >> >> With the

Re: [PATCH 05/11] Add covering index for /list/ query

2018-09-09 Thread Stewart Smith
Stephen Finucane writes: > On Fri, 2018-08-10 at 18:01 +1000, Stewart Smith wrote: >> In constructing the list of patches for a project, there are two >> main queries that are executed: >> 1) get a count() of how many patches there are >> 2) Get the page of results being displayed >> >> In a

Re: [PATCH 03/11] Add index for patchwork_comment (submission_id, date)

2018-09-09 Thread Stewart Smith
Stephen Finucane writes: > On Fri, 2018-08-10 at 18:00 +1000, Stewart Smith wrote: >> This (at least theoretically) should speed up displaying comments >> on patches/cover letters. It's an index that will return rows >> in-order for the query that we always do ("give me the comments >> on this

Re: [PATCH 02/11] 4x performance improvement for viewing patch with many comments

2018-09-09 Thread Stewart Smith
Stephen Finucane writes: > On Fri, 2018-08-10 at 18:00 +1000, Stewart Smith wrote: >> Using the example of id:20180720035941.6844-1-khand...@linux.vnet.ibm.com >> with my test dataset of a chunk of a variety of mailing lists, has >> this cover letter have 67 comments from a variety of people.

Re: [PATCH 01/11] Improve patch listing performance (~3x)

2018-09-09 Thread Stewart Smith
Stephen Finucane writes: > On Fri, 2018-08-10 at 18:00 +1000, Stewart Smith wrote: >> There's two main bits that are really expensive when composing the list >> of patches for a project: the query getting the list, and the query >> finding the series for each patch. >> >> If we look at the query