Re: hacked

Andrew -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork

Re: [PATCH] models: Validate Project.linkname does not contain forward slash

gth=255, unique=True, +validators=[validate_project_linkname]) name = models.CharField(max_length=255, unique=True) listid = models.CharField(max_length=255) listemail = models.CharField(max_length=200) -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com

[PATCH 1/5] templates: Replace ifequal and ifnotequal with if

Django 3.1 deprecates the ifequal and ifnotequal tags, for removal in 4.0. Replace all occurrences of ifequal and ifnotequal with if. Signed-off-by: Andrew Donnellan --- .../patchwork/partials/pagination.html| 8 .../patchwork/partials/patch-list.html| 20

[PATCH 2/5] urls: Update url pattern functions

Django 3.1 deprecates django.conf.urls.url() as an alias for django.urls.re_path(). Also switch to using django.urls.include() rather than django.conf.urls.include(). Signed-off-by: Andrew Donnellan --- patchwork/urls.py | 331 +++--- 1 file changed, 167

[PATCH 3/5] settings: Add context processor django.template.context_processors.request

Django 3.1 adds a new admin sidebar feature that requires the django.template.context_processors.request context processor to be enabled in the settings. Signed-off-by: Andrew Donnellan --- patchwork/settings/base.py | 1 + 1 file changed, 1 insertion(+) diff --git a/patchwork/settings/base.py

[PATCH 5/5] Add support for Django 3.1

Signed-off-by: Andrew Donnellan --- releasenotes/notes/django-3-1-support-f0450ed3e7983fe2.yaml | 5 + requirements-dev.txt| 2 +- requirements-prod.txt | 2 +- tox.ini

[PATCH 4/5] requirements: Update django-filter

Update django-filter dependency to a version that's compatible with Django 3.1. Signed-off-by: Andrew Donnellan --- requirements-dev.txt | 2 +- requirements-prod.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/requirements-dev.txt b/requirements-dev.txt index

[PATCH] parser: Don't crash when From: is list email but has weird mangle format

get_original_sender() tries to demangle DMARC-mangled From headers, in the case where the email's From address is the list address. It knows how to handle Google Groups and Mailman style mangling, where the original submitter's name will be turned into e.g. "Andrew Donnellan via linuxpp

Re: [PATCH 2/2] api: allow filtering patches and covers by msgid

in the API now that we support lookup by message ID for the web. Reviewed-by: Andrew Donnellan --- docs/api/schemas/latest/patchwork.yaml | 16 docs/api/schemas/patchwork.j2 | 18 ++ docs/api/schemas/v1.2/patchwork.yaml | 16

Re: [PATCH 3/5] Revert "Be sensible computing project patch counts"

(stephenfin): Conflicts are due to commit 880ec8c5 ("Fetch maintainer information in one query") which changed nearby lines. Signed-off-by: Stephen Finucane Cc: Daniel Axtens Looks fine Reviewed-by: Andrew Donnellan --- patchwork/views/project.py | 29 - 1 fi

Re: [PATCH 2/5] Remove unnecessary references to Submission model

On 4/3/20 10:54 pm, Stephen Finucane wrote: We want to drop this in future changes. Start by removing any unnecessary references. this = Submission model I assume Signed-off-by: Stephen Finucane This patch needs a trivial rebasing. Other than that Reviewed-by: Andrew Donnellan

Re: [PATCH 1/5] trivial: Rename 'CoverLetter' references to 'Cover'

that have "CoverLetter" in the name... Anyway, this does appear to remove any references to "CoverLetter" other than CoverLetter and CoverLetterAdmin. Reviewed-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com I

Re: Feature request: Patch tracking in custom lists for logged users

o at least some of what you'd be looking for? -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork

Re: [PATCH] models: Add State.slug field

the uniqueness check itself is overkill and could probably be removed. Agreed, though if we're gonna do it I want it done thoroughly ;) -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited ___ Patchwork mailing

Re: [PATCH] models: Add State.slug field

n. This migration must be done ' +'by hand. If you need assistance, please contact ' +'patchw...@ozlabs.org') I think the migration can still fail without printing a helpful exception message if two states have names that are different but still slugify to the same thing? -- Andrew Donn

Re: [PATCH] Disable i18n machinery, use correct locale

where the difference would matter, I'd be much happer to consider changing it. I don't suppose there's a plain "en" language code? There is a plain en language code, and I strongly ACK its use over the incorrect so-called English, en_US. -- Andrew Donnellan OzLabs, AD

Re: [PATCH v2] Improve pull request URL matching regex

/ This change properly parses URLs both with and without newlines. Signed-off-by: Konstantin Ryabitsev Thanks! Reviewed-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

Re: DB-murdering API query (index suggestions needed)

better? 2. Is there a way to disable anonymous API access? Not currently, but it would be fairly easy to do... https://github.com/getpatchwork/patchwork/issues/325 -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

Re: [PATCH v3 2/3] Include the responsible actor in applicable events

triggered events as not every sender has a Patchwork account. Andrew -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org

Re: [PATCH] templates: Override page title based on set filters

ied_filters %} +document.title = "{{ filters.applied_filters.submitter.condition }}"; +{% endif %} -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork

Re: [PATCH v3 3/3] /api/events: Add 'actor' field to generated JSON

On 17/10/19 9:44 am, Johan Herland wrote: Cc: Mauro Carvalho Chehab Signed-off-by: Johan Herland Acked-by: Daniel Axtens Looks alright Reviewed-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

Re: [PATCH v3 2/3] Include the responsible actor in applicable events

by incoming emails, hence have no real actor as such, so we simply leave the actor as None/NULL. How is cover-created different from patch-created? The rest of this seems reasonable. -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

Re: [PATCH v3 1/3] models.Event: Add the user responsible for the event

On 17/10/19 9:44 am, Johan Herland wrote: This allows using the events as a kind of audit log, to see how a patch came to its current state/delegate. Cc: Mauro Carvalho Chehab Signed-off-by: Johan Herland Reviewed-by: Stephen Finucane Reviewed-by: Andrew Donnellan --- patchwork

Re: [PATCH] Python 3.8 support

On 5/11/19 2:18 pm, Stephen Finucane wrote: On Thu, 2019-10-24 at 14:10 +1100, Andrew Donnellan wrote: Enable Python 3.8 in our tests and list it as a supported version. Signed-off-by: Andrew Donnellan LGTM, but let's hold off on this until 2.2 is out. Given there are no code changes

[PATCH 1/2] templates: Get rid of type attribute in script tags

In HTML5, the type attribute of a script tag is optional if it's JavaScript. Remove all occurrences. The only real gain is slightly smaller page output, but it also shuts up validators that like to be noisy about this. Signed-off-by: Andrew Donnellan --- patchwork/templates/patchwork

[PATCH 2/2] templates: Specify language

Specifying language in the tag is recommended in HTML5. Signed-off-by: Andrew Donnellan --- templates/base.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/base.html b/templates/base.html index 01b0d6b5e598..40b6cda65350 100644 --- a/templates/base.html +++ b

[PATCH v2] templates: Move download buttons outside h1 tag

It's not valid to put a inside an . Move the download buttons in the submission template outside the tag. Signed-off-by: Andrew Donnellan --- v1->v2 - make it look the same as before (Daniel) --- patchwork/templates/patchwork/submission.html | 16 1 file changed

[PATCH v2 1/2] [PW3] tests: Fix escaping in bundle tests on Django 3.0

escaping no matter which Django version.. Signed-off-by: Andrew Donnellan --- patchwork/tests/test_bundles.py | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/patchwork/tests/test_bundles.py b/patchwork/tests/test_bundles.py index 63f943c033d6..c5e7ee62f435 100644

[PATCH v2 2/2] [PW3] Add Django 3.0 support

Now that we've dropped Python 2, we can get ready for Django 3.0, which is still in beta. Add Django 3.0b1 as a tox environment. Add a release note for Django 3.0 support, as it will be released by the time Patchwork 3.0 is out. Closes: #311 ("Django 3.0 support") Signed-off-by: Andrew

[PATCH v2] Python 3.8 support

Enable Python 3.8 in our tests and list it as a supported version. Signed-off-by: Andrew Donnellan --- v1->v2: - Add release note that I forgot to git add --- README.rst | 2 +- releasenotes/notes/python-3-8-support-59150fb6391f9b73.yaml

[PATCH] Python 3.8 support

Enable Python 3.8 in our tests and list it as a supported version. Signed-off-by: Andrew Donnellan --- README.rst | 2 +- tools/docker/Dockerfile | 3 ++- tox.ini | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/README.rst b/README.rst index

Re: [PATCH] parser: extend SERIES_DELAY_INTERVAL

On 21/10/19 4:44 pm, Daniel Axtens wrote: There was a series on linuxppc today that was spread over ~13 mins, so the last two patches were put into a new series. Extend the time window to 20 mins, and attempt to document it. Signed-off-by: Daniel Axtens Reviewed-by: Andrew Donnellan

[PATCH 1/2] [PW3] tests: Fix escaping in bundle tests on Django 3.0

escaping no matter which Django version.. Signed-off-by: Andrew Donnellan --- patchwork/tests/test_bundles.py | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/patchwork/tests/test_bundles.py b/patchwork/tests/test_bundles.py index 63f943c033d6..c5e7ee62f435 100644

[PATCH 2/2] [PW3] tox: Add Django 3.0b1

Now that we've dropped Python 2, we can get ready for Django 3.0. Add Django 3.0b1 as a tox environment. Closes: #311 ("Django 3.0 support") Signed-off-by: Andrew Donnellan --- Not adding upper bounds on the version numbers until 3.0 actually drops. I'm considering this as closing

[PATCH 1/2] templates: Move download buttons outside h1 tag

It's not valid to put a inside an . Move the download buttons in the submission template outside the tag. Signed-off-by: Andrew Donnellan --- patchwork/templates/patchwork/submission.html | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/patchwork/templates

[PATCH 2/2] templates: Fix mismatched close tags

There's a rather than in the bundle list. Fix it. Signed-off-by: Andrew Donnellan --- patchwork/templates/patchwork/bundles.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/patchwork/templates/patchwork/bundles.html b/patchwork/templates/patchwork/bundles.html index

Re: [PATCH v2] parser: Unmangle From: headers that have been mangled for DMARC purposes

leave previous patches as-is, it seems like a fair bit of extra code for fairly small gain. -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited ___ Patchwork mailing list Patchwork@lists.ozlabs.org

Re: [PATCH] tests: Rename inaccurately named test_patchwork_from_header

On 18/10/19 3:02 pm, Daniel Axtens wrote: Andrew Donnellan writes: The test_patchwork_from_header test claims to test for the presence of the X-Patchwork-From header, when we actually call it X-Patchwork-Sender. X-Patchwork-Submitter, surely? Wow, the irony of me getting this wrong

[PATCH] tests: Rename inaccurately named test_patchwork_from_header

The test_patchwork_from_header test claims to test for the presence of the X-Patchwork-From header, when we actually call it X-Patchwork-Sender. Fix it. Signed-off-by: Andrew Donnellan --- patchwork/tests/test_mboxviews.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v2] parser: Unmangle From: headers that have been mangled for DMARC purposes

. Closes: #64 ("Incorrect submitter when using googlegroups") Reported-by: Alexandre Belloni Reported-by: Stephen Rothwell Signed-off-by: Andrew Donnellan --- v1->v2: - use X-Original-From rather than X-Original-Sender - unmangle From header when downloading mbox rewrite from heade

Re: [PATCH] parser: Unmangle From: headers that have been mangled for DMARC purposes

, the problem is getting the patch into a git repo with the right author name. But patchwork may want to make the distinction between author and sender. Yes, I was referring to the git am case, not the Patchwork case. -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM

Re: [PATCH] parser: Unmangle From: headers that have been mangled for DMARC purposes

On 11/10/19 3:36 pm, Andrew Donnellan wrote: It would be nice if Mailman could adopt X-Original-Sender too. As it is, (which I have gone ahead and reported as https://gitlab.com/mailman/mailman/issues/641) -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com

Re: [PATCH] parser: Unmangle From: headers that have been mangled for DMARC purposes

.) For the Patchwork use case, I'm quite okay with accepting the risk of using Reply-To, as the alternative is worse, the corner cases are rare, and ultimately a maintainer can still fix the odd stuff-up before applying the patch. -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com

Re: [PATCH] parser: Unmangle From: headers that have been mangled for DMARC purposes

there's always a long tail of users stuck on old versions of git for whatever reason and having some logic to detect DMARC munging may thus still be useful. -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

Re: [PATCH] parser: Unmangle From: headers that have been mangled for DMARC purposes

ust change it? -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork

[PATCH] parser: Unmangle From: headers that have been mangled for DMARC purposes

Signed-off-by: Andrew Donnellan --- patchwork/parser.py| 75 ++ patchwork/tests/test_parser.py | 68 -- 2 files changed, 130 insertions(+), 13 deletions(-) diff --git a/patchwork/parser.py b/patchwork/parser.py index 7d

Re: [RFC PATCH] docker: Add support for using eatmydata in the database

we need to be seriously concerned about dataloss? We don't need to worry about dataloss in a development environment, though perhaps some people are borrowing our dockerfiles for a production deployment? -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM

Re: [PATCH] templates: Use 'static' rather than 'statictags' library

e... I must have had the phrase "template tags" running around in my head when I wrote the commit message. -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited ___ Patchwork mailing list Pa

Re: [PATCH] templates: Use 'static' rather than 'statictags' library

On 13/9/19 10:25 pm, Stephen Finucane wrote: On Fri, 2019-09-13 at 12:19 +0100, Andrew Donnellan wrote: statictags is being renamed to static, use of {% load statictags %} is deprecated and will break in Django 3. Signed-off-by: Andrew Donnellan I was trying to figure out if this was okay

[PATCH] templates: Use 'static' rather than 'statictags' library

statictags is being renamed to static, use of {% load statictags %} is deprecated and will break in Django 3. Signed-off-by: Andrew Donnellan --- templates/base.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/base.html b/templates/base.html index 501208f01e59

Fwd: New list for people to share maintainer workflows

For everyone's information. Forwarded Message Subject: New list for people to share maintainer workflows Date: Fri, 13 Sep 2019 03:38:49 -0400 From: Theodore Y. Ts'o To: ksummit-disc...@lists.linuxfoundation.org CC: linux-ker...@vger.kernel.org, workfl...@vger.kernel.org At

Re: [PATCH] docker: pyenv: build at make -j$(nproc)

On 12/9/19 4:41 pm, Daniel Axtens wrote: This speeds up builds. I haven't measured by how much, but I have observed 8 threads being complied rather than 1 on my laptop. Signed-off-by: Daniel Axtens Reviewed-by: Andrew Donnellan --- tools/docker/Dockerfile | 3 ++- 1 file changed, 2

[PATCH v2 5/7] docs: Add API v1.2

Add API v1.2, including the new fields for list archive URLs. Signed-off-by: Andrew Donnellan --- v1->v2: - switch to using format string (Daniel) --- docs/api/rest/index.rst| 11 +- docs/api/rest/schemas/v1.1.rst |4 +- docs/api/rest/schemas/v1.2.

[PATCH v2 4/7] api: Add list archive fields

Add the new list archive fields to the API. As this is a backwards-compatible change, this requires only a minor version increment to v1.2. Signed-off-by: Andrew Donnellan --- v1->v2: - switch to using format string (Daniel) --- patchwork/api/comment.py | 5 +++-- patchwork/api/cover

[PATCH v2 7/7] fixtures: Update Patchwork list ID

The patchwork list uses patchwork.lists.ozlabs.org as its list ID nowadays. Fix it in the example fixture. Signed-off-by: Andrew Donnellan --- patchwork/fixtures/default_projects.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/patchwork/fixtures/default_projects.xml b

[PATCH v2 6/7] releasenotes: Add release note for new list archive fields

Signed-off-by: Andrew Donnellan --- v1->v2: - switch to using format string (Daniel) --- .../list-archive-urls-604e69cd92c6b943.yaml| 18 ++ 1 file changed, 18 insertions(+) create mode 100644 releasenotes/notes/list-archive-urls-604e69cd92c6b943.yaml diff --

[PATCH v2 1/7] models, templates: Add project list archive URL field

Add a field to link to a project's mailing list archive, and display it on the project info page. Add the new field to the patchwork project in the supplied example fixture. Signed-off-by: Andrew Donnellan --- v1->v2: - add field to fixtures (Daniel) --- patchwork/fixtu

[PATCH v2 3/7] templates: Add mailing list archive link to patch detail page

Add a link to the mailing list archive link to the patch detail page. Suggested-by: Takashi Iwai Signed-off-by: Andrew Donnellan --- patchwork/templates/patchwork/submission.html | 4 1 file changed, 4 insertions(+) diff --git a/patchwork/templates/patchwork/submission.html b/patchwork

[PATCH v2 2/7] models: Add list archive lookup

links to mailing list archives. Also add the new field to the default patchwork project fixture. Suggested-by: Takashi Iwai Signed-off-by: Andrew Donnellan --- v1->v2: - add to default fixture (Daniel) - switch to using format string (Daniel) --- patchwork/fixtures/default_projects.xml

Re: [PATCH] models: Add commit_url_format to Project

) in an escape. -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork

Re: [PATCH 2/6] models: Add list archive lookup

is going to be rather rare. -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork

Re: [PATCH 3/6] templates: Add mailing list archive link to patch detail page

on lists.ozlabs.org, but I can use the mail-archive.com service which does index the patchwork list. Andrew Regards, Daniel Suggested-by: Takashi Iwai Signed-off-by: Andrew Donnellan --- patchwork/templates/patchwork/submission.html | 4 1 file changed, 4 insertions(+) diff --git

Re: [PATCH 1/6] models, templates: Add project list archive URL field

, Daniel Signed-off-by: Andrew Donnellan --- .../0034_project_list_archive_url.py | 20 +++ patchwork/models.py | 1 + patchwork/templates/patchwork/project.html| 6 ++ 3 files changed, 27 insertions(+) create mode 100644 patchwork

Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] Patch version changes in commit logs?

On 1/7/19 11:35 am, Andrew Donnellan wrote: On 1/7/19 2:01 am, Mauro Carvalho Chehab wrote: Em Sat, 29 Jun 2019 12:20:55 +0100 Mark Brown escreveu: On Sat, Jun 29, 2019 at 09:18:28AM +0200, Takashi Iwai wrote: BTW, can the URL be reached from patchwork?  That'd be really handy. Even

[PATCH 5/6] docs: Add API v1.2

Add API v1.2, including the new fields for list archive URLs. Signed-off-by: Andrew Donnellan --- docs/api/rest/index.rst| 11 +- docs/api/rest/schemas/v1.1.rst |4 +- docs/api/rest/schemas/v1.2.rst |5 + docs/api/schemas/generate_schema.py|4

Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] Patch version changes in commit logs?

. Regarding adding it to downloaded mboxes, if we do that I'd like it to be a separate option. A single patch can also land in patchwork multiple times via various lists, so the URL will depend on which project you're looking at. -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com

Re: Patchwork Registration

is this? patchwork.ozlabs.org or somewhere else? Andrew -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork

Re: [RFC PATCH] docker: Add support for using eatmydata in the database

in it, what to call the Dockerfile, etc. I think it's a good thing to have in the repo, though. Signed-off-by: Russell Currey Reviewed-by: Andrew Donnellan --- docker-compose-eatmydata.yml | 32 +++ tools/docker/Dockerfile.eatmydata | 9 + 2 files

[PATCH 3/6] templates: Add mailing list archive link to patch detail page

Add a link to the mailing list archive link to the patch detail page. Suggested-by: Takashi Iwai Signed-off-by: Andrew Donnellan --- patchwork/templates/patchwork/submission.html | 4 1 file changed, 4 insertions(+) diff --git a/patchwork/templates/patchwork/submission.html b/patchwork

[PATCH 2/6] models: Add list archive lookup

links to mailing list archives. Suggested-by: Takashi Iwai Signed-off-by: Andrew Donnellan --- ...0035_project_list_archive_lookup_prefix.py | 20 patchwork/models.py | 23 +++ 2 files changed, 43 insertions(+) create mode 100644 patc

[PATCH 6/6] releasenotes: Add release note for new list archive fields

Signed-off-by: Andrew Donnellan --- .../list-archive-urls-604e69cd92c6b943.yaml| 18 ++ 1 file changed, 18 insertions(+) create mode 100644 releasenotes/notes/list-archive-urls-604e69cd92c6b943.yaml diff --git a/releasenotes/notes/list-archive-urls-604e69cd92c6b943.yaml b

[PATCH 4/6] api: Add list archive fields

Add the new list archive fields to the API. As this is a backwards-compatible change, this requires only a minor version increment to v1.2. Signed-off-by: Andrew Donnellan --- patchwork/api/comment.py | 5 +++-- patchwork/api/cover.py| 6 -- patchwork/api/embedded.py | 14

[PATCH 1/6] models, templates: Add project list archive URL field

Add a field to link to a project's mailing list archive, and display it on the project info page. Signed-off-by: Andrew Donnellan --- .../0034_project_list_archive_url.py | 20 +++ patchwork/models.py | 1 + patchwork/templates/patchwork

Re: OpenAPI schema

On 7/8/19 7:41 pm, Stephen Finucane wrote: On Wed, 2019-08-07 at 17:10 +1000, Andrew Donnellan wrote: Currently working on some patches that add some extra fields to the API. Updating the OpenAPI schema, especially with the jinja2 templating that we use for versioning, is difficult, especially

OpenAPI schema

aps with a custom schema generator to handle API versioning. -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listi

Re: [PATCH] models: Add commit_url_format to Project

On 7/8/19 9:22 am, Andrew Donnellan wrote: On 6/8/19 10:20 pm, Michael Ellerman wrote: Add a new field to Project, commit_url_format, which specifies a format string that can be used to generate a link to a particular commit for a project. This is used in the display of a patch, to render

Re: [PATCH] models: Add commit_url_format to Project

ly be set by an administrator. +return mark_safe('%s' % ( +patch.project.commit_url_format.format(commit=commit), commit)) -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited ___

[PATCH] filters: Escape State names when generating selector HTML

States with names containing special characters are not correctly escaped when generating the select list. Use escape() to fix this. Signed-off-by: Andrew Donnellan --- patchwork/filters.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/patchwork/filters.py b/patchwork

[PATCH] about: Display admin contact details

Display the list of admins on the about page. Add an ADMINS_HIDE option if you don't want the details displayed publicly. Closes: #282 ("Display contact details for patchwork instance admins") Signed-off-by: Andrew Donnellan --- docs/deployment/configuration.rst

Re: [PATCH v2 0/5] Update REST API: Add 'project patches as mbox' field

Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork -- Andrew Donnellan OzLabs, AD

Re: [PATCH 2/2] docs: Mention Postgres for Docker development install

in production on ozlabs.org, idk about other instances, so we should definitely mention this actively. Reviewed-by: Andrew Donnellan --- docs/development/installation.rst | 4 1 file changed, 4 insertions(+) diff --git a/docs/development/installation.rst b/docs/development/installation.rst

Re: [PATCH 1/2] docker: Use Ubuntu ports repositories on non-x86 architectures

s. One day ppc64le will graduate to being mirrored like a real architecture... Reviewed-by: Andrew Donnellan --- tools/docker/Dockerfile| 14 -- tools/docker/trusty-ports.list | 3 +++ tools/docker/xenial-ports.list | 3 +++ 3 files changed, 18 insertions(+), 2

Re: [PATCH] docker: Install libpq-dev to fix psycopg2-binary build

ibpq-dev # User RUN useradd --uid=$UID --create-home patchwork -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/

Re: [PATCH] README: add .env file to installation instructions

Reviewed-by: Andrew Donnellan On 1/5/19 1:16 pm, Russell Currey wrote: Creating the .env file is mentioned in the installation documentation but not in the README, so following only the steps mentioned there will fail. Add this and add a `cd patchwork` in there for good measure so you could

Re: [PATCH] parser: recognise git commit consisting only of empty new file

usually send patches like that but sometimes you do, especially if you're a snowpatch dev :) Closes: #256 Reported-by: Andrew Donnellan Signed-off-by: Daniel Axtens LGTM, thanks for fixing this Reviewed-by: Andrew Donnellan --- Apologies for the long radio silence. I'm now in a job where P

Re: HTTP not redirecting to HTTPS on patchwork.ozlabs.org

into it. Thanks for pointing this out :) -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork

[PATCH] docs: Fix documentation of REST_RESULTS_PER_PAGE setting

In 8fe11180a1a5 ("REST: Add new setting for maximum API page size") I accidentally deleted the versionadded information for REST_RESULTS_PER_PAGE. Restore it. Fixes: 8fe11180a1a5 ("REST: Add new setting for maximum API page size") Signed-off-by: Andrew Donnellan

Re: ozlabs.org down?

possible that we've just hit that again. -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork

Re: [PATCH 00/11] Add labels support

ouched on this issue of the orthogonality of the RFC classification when we were chatting about snowpatch things the other day? -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited ___ Patchwork ma

Re: [RFC PATCH] REST: Add new setting for maximum API page size

with that. -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork

Re: [RFC PATCH] REST: Add new setting for maximum API page size

On 26/07/18 23:24, Daniel Axtens wrote: Andrew Donnellan writes: On 24/07/18 15:10, Andrew Donnellan wrote: In 41790caf59ad ("REST: Limit max page size") we limited the maximum page size to the default page size in the settings. This turns out to be rather restrictive, as we us

Re: [RFC PATCH] REST: Add new setting for maximum API page size

On 24/07/18 15:10, Andrew Donnellan wrote: In 41790caf59ad ("REST: Limit max page size") we limited the maximum page size to the default page size in the settings. This turns out to be rather restrictive, as we usually want to keep the default page size low, but an administrato

Re: [RFC PATCH] REST: Add new setting for maximum API page size

On 24/07/18 15:10, Andrew Donnellan wrote: diff --git a/docs/deployment/configuration.rst b/docs/deployment/configuration.rst index 347485636d47..e599522a412b 100644 --- a/docs/deployment/configuration.rst +++ b/docs/deployment/configuration.rst @@ -88,7 +88,13 @@ Enable the :doc:`REST API

[RFC PATCH] REST: Add new setting for maximum API page size

n that per request. Add a new setting, MAX_REST_RESULTS_PER_PAGE, to set the maximum page size. Closes: #202 ("Separate max API page size and default API page size into different settings") Suggested-by: Stewart Smith Suggested-by: Joel Stanley Signed-off-by: Andrew Donnellan ---

Re: title tag in a series list

deliberate. There's enough people who for some reason send their patches without using git-send-email. Also not all projects that are monitored in patchwork are necessarily git projects, so patchwork will look for anything that matches a diff. -- Andrew Donnellan OzLabs, ADL Canberra

Re: [PATCH] [RFC] tools: drop vagrant

On 24/02/18 12:22, Daniel Axtens wrote: It served us well, but it's now outdated (Trusty, Python 3.4, etc) There is no indication that anyone uses it or keeps it up to date. Signed-off-by: Daniel Axtens <d...@axtens.net> Vagrant is dead, long live Docker! Reviewed-by: Andrew Don

Re: [PATCH 7/9] parser: avoid an unnecessary UPDATE of Person

=email) -if name: # use the latest provided name +if name and name != person.name: # use the latest provided name person.name = name person.save() -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH 9/9] parser: don't fail on multiple SeriesReferences

en bug with a FIXME for searchability? Logging it is a great idea. Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> --- patchwork/parser.py | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/patchwork/parser.py b/patchwork/parser.py index

Re: [PATCH 8/9] parser: use Patch.objects.create instead of save()

definitely think we should commit the patch to the database before Series... Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> --- patchwork/parser.py | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/patchwork/parse

Re: [PATCH 7/9] parser: avoid an unnecessary UPDATE of Person

name: # use the latest provided name person.name = name person.save() -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited ___ Patchwork mailing list Patchwork@lists.ozla

  1   2   3   >