Re: [PATCH v4] api: Add comments to patch and cover endpoints

2018-05-02 Thread Daniel Axtens
Veronika Kabatova writes: > - Original Message - >> From: "Daniel Axtens" >> To: "Veronika Kabatova" >> Cc: patchwork@lists.ozlabs.org >> Sent: Wednesday, May 2, 2018 6:22:34 PM >> Subject: Re: [PATCH v4] api: Add comments to patch

Re: [PATCH v4] api: Add comments to patch and cover endpoints

2018-05-02 Thread Veronika Kabatova
- Original Message - > From: "Daniel Axtens" > To: "Veronika Kabatova" > Cc: patchwork@lists.ozlabs.org > Sent: Wednesday, May 2, 2018 6:22:34 PM > Subject: Re: [PATCH v4] api: Add comments to patch and cover endpoints > > >> Notice

Re: [PATCH v4] api: Add comments to patch and cover endpoints

2018-05-02 Thread Daniel Axtens
>> Notice that it's /patch/1/ for mbox, checks, etc, but /covers/1/ for >> comments. >> >> Is this intentional - am I missing something? - or is this supposed to >> be /patch/1/ like the others? >> > > Ookay, this is pretty embarrassing. reverse() looks to be confused when > you have multiple mat

Re: [PATCH v4] api: Add comments to patch and cover endpoints

2018-04-30 Thread Veronika Kabatova
- Original Message - > From: "Daniel Axtens" > To: vkaba...@redhat.com, patchwork@lists.ozlabs.org > Sent: Monday, April 30, 2018 6:55:11 PM > Subject: Re: [PATCH v4] api: Add comments to patch and cover endpoints > > Apologies if this is a silly question,

Re: [PATCH v4] api: Add comments to patch and cover endpoints

2018-04-30 Thread Daniel Axtens
Apologies if this is a silly question, but I was looking at this to check the perfomance, and I noticed that in the patch list endpoint (/api/patches/), it seems to be linking to the 'covers' comments endpoint rather than the 'patches' api endpoint: ... "delegate": null, "mbox": "h

Re: [PATCH v4] api: Add comments to patch and cover endpoints

2018-04-27 Thread Veronika Kabatova
- Original Message - > From: "Stephen Finucane" > To: vkaba...@redhat.com, patchwork@lists.ozlabs.org > Sent: Friday, April 27, 2018 5:37:57 PM > Subject: Re: [PATCH v4] api: Add comments to patch and cover endpoints > > On Wed, 2018-04-25 at 19:33 +020

Re: [PATCH v4] api: Add comments to patch and cover endpoints

2018-04-27 Thread Stephen Finucane
On Wed, 2018-04-25 at 19:33 +0200, vkaba...@redhat.com wrote: > From: Veronika Kabatova > > Signed-off-by: Veronika Kabatova Two comments below. I've actually addressed these already with my own patch. Assuming you're happy with said patch, I can squash it with this one and merge them. Cheers,

[PATCH v4] api: Add comments to patch and cover endpoints

2018-04-25 Thread vkabatov
From: Veronika Kabatova Signed-off-by: Veronika Kabatova --- patchwork/api/comment.py | 75 ++ patchwork/api/cover.py | 13 ++- patchwork/api/patch.py | 16 ++- patchwork/models.py