Re: [PATCH 1/7] pagination: Fix quirks

2018-01-26 Thread Stephen Finucane
icate page numbers > > Fiddle with the pagination algorithm to get it to pass - required > tweaking a display parameter and a couple of comparison operators, > so all pretty minor. > > Now, if there are 10 pages, the displayed page numbers for a given > page are as f

[PATCH 1/7] pagination: Fix quirks

2018-01-24 Thread Daniel Axtens
There are a couple of pages where the clickable list of pages would include missing or duplicate pages. Write a test that ensures: - you always have a link to the next/prev numbered page - there are no duplicate page numbers Fiddle with the pagination algorithm to get it to pass - required

[RFC] REST: Use cursor-based pagination for '/events'

2017-06-21 Thread Stephen Finucane
Given the high-volume, time-based nature of this API, cursor-based pagination provides some important usability improvements over page number-based pagination, most notably in going back through historical pages. Signed-off-by: Stephen Finucane <step...@that.guru> Cc: Aaron Conole

Re: Pagination

2017-01-06 Thread Stephen Finucane
On Fri, 2017-01-06 at 18:19 +1100, Andrew Donnellan wrote: > On 12/12/16 23:34, Stephen Finucane wrote: > > I don't think we support this yet but it would be easily added. I'm > > not > > sure how well cursor pagination would map to of our endpoints, > > seeing > >

Re: Pagination

2017-01-05 Thread Andrew Donnellan
On 12/12/16 23:34, Stephen Finucane wrote: I don't think we support this yet but it would be easily added. I'm not sure how well cursor pagination would map to of our endpoints, seeing as we use simple, integer-based indexing for all ID fields. My personal preference would be a 'direction=(asc

Re: Pagination (was: Re: [PATCH 1/3] REST: Integrate django-filter support)

2016-12-12 Thread Stephen Finucane
a way to do this at > > > present, > > > or is that > > > something that could be made available with filters? > > > > I'd be kinda tempted to consider using cursor pagination for this, > > which > > Django REST Framework supports. > > &g

Pagination (was: Re: [PATCH 1/3] REST: Integrate django-filter support)

2016-12-11 Thread Andrew Donnellan
this isn't as nice as a reverse ordering of ids or dates. Do you know if there's a way to do this at present, or is that something that could be made available with filters? I'd be kinda tempted to consider using cursor pagination for this, which Django REST Framework supports. That's not a filt

[PATCH 1/5] tests: Add rudimentary pagination tests

2016-11-19 Thread Stephen Finucane
This should improve coverage and prevent regressions. The 'ppp' header is removed as this is a non-standard header and not accessible from a browser. Signed-off-by: Stephen Finucane --- patchwork/paginator.py| 7 ---

[PATCH 12/19] ui: Redesign the pagination widgets

2016-02-03 Thread Stephen Finucane
l | 8 2 files changed, 9 insertions(+), 12 deletions(-) diff --git a/htdocs/css/style.css b/htdocs/css/style.css index 46c0051..3e9a49d 100644 --- a/htdocs/css/style.css +++ b/htdocs/css/style.css @@ -129,21 +129,18 @@ input#reorder-change { /* list pagination */ .paginator {

[PATCH 26/51] dynatable: Allow the user to have pre-defined pagination links

2015-09-11 Thread Damien Lespiau
We want two things to have the layout generated by dynatable look like the existing design: - Have two pagination widgets. For that we need to make dynatable-pagination-links + element.id a class and not an id. This is to allow multiple widgets - The second part is to re-use elements