Re: 2.2.5 release api-1.1 500 errors

2021-08-20 Thread Daniel Axtens
Hi Konstantin, Thanks for your bug reports. Fixes to both for upstream are on the list. Fixes for the first (v1.1 errors) should apply directly to stable/2.2; the second one will require a minor backport. It's now very late so I'm going to leave this for now. Stephen feel free to take the wheel,

Re: 2.2.5 release api-1.1 500 errors

2021-08-20 Thread Daniel Axtens
> Some of the others returning 500 errors are: > > GET /api/patches/{msgid}/comments/ > > I'd be happy to provide tracebacks if I can figure out how to get them. yeah msgid is not a valid argument there, it needs to be a number. If you got a traceback it would look like this: File "/opt/py

Re: 2.2.5 release api-1.1 500 errors

2021-08-20 Thread Daniel Axtens
> Here's the PATCH traceback: It's broken upstream too - we don't have a test for PATCH of a patch with APIv1.1. I can't figure out why 2.2.5 would have exposed it but I don't pretend to understand the fine detail of the patch that went in between 2.2.4 and 2.2.5. I'll send a patch for this then

Re: 2.2.5 release api-1.1 500 errors

2021-08-20 Thread Daniel Axtens
Konstantin Ryabitsev writes: > Hello: > > After the 2.2.2->2.2.5 upgrade, we seem to be getting lots of /api/1.1/ errors > for PATCH calls: > > PATCH /api/1.1/patches/{id}/ > > switching to /api/1.2/ seems to fix it, but requires other client app fixes > for API incompatibility. > > Some of t