Re: [PATCH 1/5] models: Make use of aggregates

2016-10-13 Thread Stephen Finucane
On 2016-10-12 23:13, Daniel Axtens wrote: Hi Stephen, -if len(orders) > 0: -max_order = orders[0]['order'] +if orders and orders['order__max']: +max_order = orders['order__max'] + 1 else: -max_order = 0 +max_order = 1 I'

Re: [PATCH v5 2/7] models: Add 'Series' model and related models

2016-10-13 Thread Stephen Finucane
On 2016-10-12 23:26, Daniel Axtens wrote: Hi Stephen, This doesn't have my fix for reducing DB queries: http://patchwork.ozlabs.org/patch/670292/ Oh, is it needed here? We're not modifying the view code quite yet so I didn't think it was. I'll test this evening. I do include a variant of it

Re: [PATCH 4/5] models: Remove 'refresh_tag_counts' from Submission

2016-10-13 Thread Stephen Finucane
On 2016-10-12 23:30, Daniel Axtens wrote: Stephen Finucane writes: Turns out 'Submission' has a 'patch' field when it's subclassed as 'Patch'. Use this field to call 'refresh_tag_counts' on the subclass only. Signed-off-by: Stephen Finucane --- patchwork/models.py | 9 - 1 file chan

Re: [PATCH v5 0/7] Add series support

2016-10-13 Thread Stephen Finucane
On 2016-10-12 23:41, Daniel Axtens wrote: Daniel Axtens writes: - "untitled series #420" is certainly better than having every series named "untitled series", but I still think it's worse than "series starting with '[1/10] add foo to bar'" Should be trivial enough change. I wonder if we s