Re: [PATCH v3 1/5] parser: Remove unused parameter

On Fri, 2016-12-02 at 12:13 +1100, Daniel Axtens wrote: > Looks good to me. > > Happily this should make the tests a little faster, which is always > nice :) > > > diff --git a/patchwork/tests/test_parser.py > > b/patchwork/tests/test_parser.py > > index 96166ad..e4a379d 100644 > > ---

Re: [PATCH v3 3/5] hasher: Create hasher module

On Fri, 2016-12-02 at 15:49 +1100, Daniel Axtens wrote: > Hi Stephen, > > AFAICT this is mostly a code move, Correct. > not changing the functionality of the > hasher. On that basis, and seeing how you're using it later on in the > series: > > Reviewed-by: Daniel Axtens

Re: [PATCH v3 4/5] tools: Trivial formatting fixes

On Fri, 2016-12-02 at 15:44 +1100, Daniel Axtens wrote: > Hi Stephen, > > While you're on a cleaning fix, may I suggest shellcheck.net? No > pressure :) Again, merged as is just to fix the bug, but shellcheck looks good an I'll submit a patch shortly to finish the cleanup here. Good call on the