On Fri, 2016-12-02 at 16:11 +1100, Daniel Axtens wrote:
> Stephen Finucane writes:
>
> > There are two scripts provided in tools that reference the removed
> > hash function of the 'parser' script. Move this hash function back
> > into
> > its own module and update these scripts to use said modul
On Fri, 2016-12-02 at 13:49 +1100, Daniel Axtens wrote:
> > -delegate = find_delegate(mail)
> > +delegate = find_delegate_by_header(mail)
> > if not delegate and diff:
> > filenames = find_filenames(diff)
> > -delegate = auto_delegate(project, filen
On Fri, 2016-12-02 at 12:13 +1100, Daniel Axtens wrote:
> Looks good to me.
>
> Happily this should make the tests a little faster, which is always
> nice :)
>
> > diff --git a/patchwork/tests/test_parser.py
> > b/patchwork/tests/test_parser.py
> > index 96166ad..e4a379d 100644
> > --- a/patchwor
On Fri, 2016-12-02 at 15:42 +1100, Daniel Axtens wrote:
> Hi,
>
> > local hash
> > -hash=$(git show -C $1 | python $PWDIR/parser.py --hash)
> > +hash=$(git diff "$1~..$1" | python $pwpath/hasher.py)
That's a good point - I don't think the existing code handled merge
commits and neith
On Fri, 2016-12-02 at 15:44 +1100, Daniel Axtens wrote:
> Hi Stephen,
>
> While you're on a cleaning fix, may I suggest shellcheck.net? No
> pressure :)
Again, merged as is just to fix the bug, but shellcheck looks good an
I'll submit a patch shortly to finish the cleanup here. Good call on
the t
On Fri, 2016-12-02 at 15:49 +1100, Daniel Axtens wrote:
> Hi Stephen,
>
> AFAICT this is mostly a code move,
Correct.
> not changing the functionality of the
> hasher. On that basis, and seeing how you're using it later on in the
> series:
>
> Reviewed-by: Daniel Axtens
Cheers. Applied.
Ste
