On Mon, Jan 29, 2018 at 11:36:36PM +1100, Daniel Axtens wrote:
> Hi Don,
>
> >> I suppose to put a finer point on it - what is your usecase here? What
> >> are you trying to achieve, and can we help you do that in a way that
> >> requires smaller changes to Patchwork, and is less fragile? (For exa
Currently we render a tag from a comment into a message if it is
'^(whatever)-by: .*'
We found a patch that had a UTF-8 non-breaking space after the colon,
and this was breaking the regex. So just remove the requirement for
a space entirely.
Closes: #124
Signed-off-by: Daniel Axtens
---
patch
We see some emails with e.g. "[PATCH1/8]" - no space between H and 1.
This is poor behaviour but we can accept it anyway.
Fixes: #126
Signed-off-by: Daniel Axtens
---
patchwork/parser.py| 7 ++-
patchwork/tests/test_parser.py | 10 ++
2 files changed, 16 insertions(+),
I realised when I misspelled the name of an input to a test case
that mailbox will happily create an mbox or maildir if it doesn't
exist.
Don't do that, set create=False.
Signed-off-by: Daniel Axtens
---
patchwork/management/commands/parsearchive.py | 4 ++--
patchwork/tests/test_series.py
There's a FIXME asking for some generated SQL that uses string
interpolation to be investigated.
I investigated.
It's safe - it only interpolates table/column names, not
user-controlled data.
Replace the FIXME with an explanatory statement.
Signed-off-by: Daniel Axtens
---
patchwork/views/use
Don Zickus writes:
> On Mon, Jan 29, 2018 at 11:36:36PM +1100, Daniel Axtens wrote:
>> Hi Don,
>>
>> >> I suppose to put a finer point on it - what is your usecase here? What
>> >> are you trying to achieve, and can we help you do that in a way that
>> >> requires smaller changes to Patchwork, a