Re: [PATCH] Implement list filtering

2018-01-30 Thread Don Zickus
On Mon, Jan 29, 2018 at 11:36:36PM +1100, Daniel Axtens wrote: > Hi Don, > > >> I suppose to put a finer point on it - what is your usecase here? What > >> are you trying to achieve, and can we help you do that in a way that > >> requires smaller changes to Patchwork, and is less fragile? (For exa

[PATCH 1/4] tags: be a bit more permissive in what we render to a message

2018-01-30 Thread Daniel Axtens
Currently we render a tag from a comment into a message if it is '^(whatever)-by: .*' We found a patch that had a UTF-8 non-breaking space after the colon, and this was breaking the regex. So just remove the requirement for a space entirely. Closes: #124 Signed-off-by: Daniel Axtens --- patch

[PATCH 2/4] parser: allow series numbers at end of another prefix

2018-01-30 Thread Daniel Axtens
We see some emails with e.g. "[PATCH1/8]" - no space between H and 1. This is poor behaviour but we can accept it anyway. Fixes: #126 Signed-off-by: Daniel Axtens --- patchwork/parser.py| 7 ++- patchwork/tests/test_parser.py | 10 ++ 2 files changed, 16 insertions(+),

[PATCH 3/4] Don't create mailboxes/maildirs if not present

2018-01-30 Thread Daniel Axtens
I realised when I misspelled the name of an input to a test case that mailbox will happily create an mbox or maildir if it doesn't exist. Don't do that, set create=False. Signed-off-by: Daniel Axtens --- patchwork/management/commands/parsearchive.py | 4 ++-- patchwork/tests/test_series.py

[PATCH 4/4] views/user: string interpolation in raw SQL is safe here

2018-01-30 Thread Daniel Axtens
There's a FIXME asking for some generated SQL that uses string interpolation to be investigated. I investigated. It's safe - it only interpolates table/column names, not user-controlled data. Replace the FIXME with an explanatory statement. Signed-off-by: Daniel Axtens --- patchwork/views/use

Re: [PATCH] Implement list filtering

2018-01-30 Thread Daniel Axtens
Don Zickus writes: > On Mon, Jan 29, 2018 at 11:36:36PM +1100, Daniel Axtens wrote: >> Hi Don, >> >> >> I suppose to put a finer point on it - what is your usecase here? What >> >> are you trying to achieve, and can we help you do that in a way that >> >> requires smaller changes to Patchwork, a