Re: [PATCH 1/2] templates: Move download buttons outside h1 tag

2019-10-28 Thread Daniel Axtens
Andrew Donnellan writes: > It's not valid to put a inside an . Move the download buttons in > the submission template outside the tag. Two things: 1) This makes the buttons float up out of line with the title. The floating up isn't the end of the world as there's probably too much white

Re: [PATCH] docs: Fix note about the required Postfix rights

2019-10-28 Thread Daniel Axtens
Hi Ali, > The permissions for the user running the postfix process are > not the ones used for external file or command delivery by default. > The ones defined by default_privs are (in case the aliases(5) file > that is owned by root was being used). A privileged user or the > postfix owner should

RE: [PATCH] sql: Fix table lists

2019-10-28 Thread Daniel Axtens
>> > > Subject: Re: [PATCH] sql: Fix table lists >> > > >> > > On Wed, 2019-09-04 at 13:40 +, Ali Alnubani wrote: >> > > > The patch adds missing commas in the table lists where missing, >> > > > and removes where unnecessary. >> > > > This fixes errors such as the following when feeding the sc

Re: [PATCH] parser: extend SERIES_DELAY_INTERVAL

2019-10-28 Thread Daniel Axtens
Applied, thanks for the review Andrew. > On 21/10/19 4:44 pm, Daniel Axtens wrote: >> There was a series on linuxppc today that was spread over ~13 mins, >> so the last two patches were put into a new series. >> >> Extend the time window to 20 mins, and attempt to document it. >> >> Signed-off-

Re: [PATCH 2/2] templates: Fix mismatched close tags

2019-10-28 Thread Daniel Axtens
Applied, thanks Andrew. > There's a rather than in the bundle list. Fix it. > > Signed-off-by: Andrew Donnellan > --- > patchwork/templates/patchwork/bundles.html | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/patchwork/templates/patchwork/bundles.html > b/patchwork/

Re: [PATCH] travis: fix codecov

2019-10-28 Thread Daniel Axtens
Applied. Daniel Axtens writes: > In e017f69376da ("travis: run pep8/flake8 tests"), codecov > was removed from the install step, on the basis that tox-travis > would pull it in automatically. > > This, it turns out, isn't entirely true: it is pulled in to the > tox environment, but the data is ac

Re: [PATCH] docs: Fix link to deployment guide

2019-10-28 Thread Daniel Axtens
Applied, thanks Ali. > The old format redirects to a nonexistent page when > there are multiple versions of the docs. > > Signed-off-by: Ali Alnubani > --- > docs/development/installation.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/docs/development/installati

Re: [PATCH] README: remove dead landscape.io badge

2019-10-28 Thread Daniel Axtens
Applied. Daniel Axtens writes: > landsape.io is down and seems to have been for some time. > The issue tracker [1] doesn't seem to have anything since April. > > Pull out the broken badge. If landscape.io returns we can add it > back later. > > [1] > https://github.com/landscapeio/landscape-iss

Re: [PATCH v2] docker: Specify GID for docker-compose-pg.yml too

2019-10-28 Thread Daniel Axtens
Applied. Daniel Axtens writes: > We just need to mirror the change in the MySQL/default > docker-compose.yml file. > > Fixes: b4f4c8554c11 ("docker: Require GID also") > Signed-off-by: Daniel Axtens > > --- > > v2: an object lesson in why you should test before emailing > --- > docker-compose-

Re: [PATCH] travis, tox: only do coverage testing in py27

2019-10-28 Thread Daniel Axtens
Applied. Daniel Axtens writes: > Currently Travis calls `tox -e coverage` unconditionally. However, > the environment has py27 basepython, so all the runs only generate > py27 coverage! > > Rather than try to untangle that, just run the coverage when run > in a py27 travis environment. This mak

[PATCH] Remove Django 2.0 support

2019-10-28 Thread Daniel Axtens
It's no longer supported upstream, per https://www.djangoproject.com/download/#supported-versions Signed-off-by: Daniel Axtens --- README.rst | 2 +- .../notes/remove-django-2-0-support-623b936d377a8e56.yaml | 5 + tox.ini