Re: Check API - permissions/authorisation

2017-06-14 Thread Andrew Donnellan
On 07/06/17 02:28, Stephen Finucane wrote: On Tue, 2017-06-06 at 21:10 +1000, Daniel Axtens wrote: Hi, One thing that has come up in discussions around CI and Patchwork is permissions for the checks API. What permissions are required for a user to create a check? I can't find anything in the

Re: [PATCH RFC] events-api: allow filtering by date

2017-06-14 Thread Andrew Donnellan
On 15/06/17 09:59, Daniel Axtens wrote: Aaron Conole writes: Aaron Conole writes: This commit allows users of the REST API to query for events based on the date field. This will allow utility writers to select a smaller subset of events when

Re: [PATCH RFC] events-api: allow filtering by date

2017-06-14 Thread Daniel Axtens
Aaron Conole writes: > Aaron Conole writes: > >> This commit allows users of the REST API to query for events based on >> the date field. This will allow utility writers to select a smaller >> subset of events when polling. >> >> Signed-off-by: Aaron

Re: Server Error (500) starting with 02f8c2818bfd

2017-06-14 Thread Daniel Axtens
Hi Aaron, I saw a 500 when I added the token auth stuff; I forgot to run manage.py migrate. Have you tried that? I also forgot to run collectstatic after adding clipboard.js; don't get bitten by that :) > Server is running: > httpd-2.4.6-45.el7.centos.4.x86_64, Django (1.11.2), mod-wsgi

Re: [PATCH RFC] events-api: allow filtering by date

2017-06-14 Thread Aaron Conole
Aaron Conole writes: > This commit allows users of the REST API to query for events based on > the date field. This will allow utility writers to select a smaller > subset of events when polling. > > Signed-off-by: Aaron Conole > --- It should be noted

[PATCH RFC] events-api: allow filtering by date

2017-06-14 Thread Aaron Conole
This commit allows users of the REST API to query for events based on the date field. This will allow utility writers to select a smaller subset of events when polling. Signed-off-by: Aaron Conole --- patchwork/api/filters.py | 2 +- 1 file changed, 1 insertion(+), 1

Re: Server Error (500) starting with 02f8c2818bfd

2017-06-14 Thread Stephen Finucane
On Wed, 2017-06-14 at 10:08 -0400, Aaron Conole wrote: > Commit 02f8c2818bfd ("htdocs: Add clipboard.js") has caused my patchwork > instance to start throwing server error.  I am not sure which logs to > look at (because /var/log/httpd/error_log doesn't seem to get updated > right now). Did you

Server Error (500) starting with 02f8c2818bfd

2017-06-14 Thread Aaron Conole
Commit 02f8c2818bfd ("htdocs: Add clipboard.js") has caused my patchwork instance to start throwing server error. I am not sure which logs to look at (because /var/log/httpd/error_log doesn't seem to get updated right now). I'm using Firefox 53.0.3 to access the server. Server is running:

Re: [PATCH 1/5] docs: Document the various htdocs supported

2017-06-14 Thread Stephen Finucane
On Fri, 2017-06-09 at 18:25 +0100, Stephen Finucane wrote: > Signed-off-by: Stephen Finucane Applied. Stephen ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork

Re: [PATCH 2/5] htdocs: Add clipboard.js

2017-06-14 Thread Stephen Finucane
On Tue, 2017-06-13 at 21:35 +1000, Andrew Donnellan wrote: > On 10/06/17 03:25, Stephen Finucane wrote: > > We provide our own, much smaller implementation of this currently. > > However, we want to be able to implement slightly different variants of > > this elsewhere and using an existing

Re: [PATCH 3/5] REST: Enable token auth support

2017-06-14 Thread Stephen Finucane
On Tue, 2017-06-13 at 21:38 +1000, Andrew Donnellan wrote: > On 10/06/17 03:25, Stephen Finucane wrote: > > Token authentication is generally viewed as a more secure option for API > > authentication than storing a username and password. > > > > Django REST Framework gives us a

Patchwork v2.0.0-rc4 Available

2017-06-14 Thread Stephen Finucane
The fourth and final release candidate of the upcoming Patchwork v2.0.0 release is now available: https://github.com/getpatchwork/patchwork/releases/tag/v2.0.0-rc4 This release introduces a number of fixes on top of rc3 that were found during testing of same: - The REST API now supports

Re: [PATCH 4/5] views: Provide a way to view, (re)generate tokens

2017-06-14 Thread Stephen Finucane
On Wed, 2017-06-14 at 17:57 +1000, Daniel Axtens wrote: > Daniel Axtens writes: > > > Hi Stephen and Andrew, > > > > I've installed this on py[23].patchwork.dja.id.au > > > > > diff --git a/htdocs/css/style.css b/htdocs/css/style.css > > > index 5218f6d..af2f073 100644 > > >

Re: [PATCH 4/5] views: Provide a way to view, (re)generate tokens

2017-06-14 Thread Daniel Axtens
Daniel Axtens writes: > Hi Stephen and Andrew, > > I've installed this on py[23].patchwork.dja.id.au > >> diff --git a/htdocs/css/style.css b/htdocs/css/style.css >> index 5218f6d..af2f073 100644 >> --- a/htdocs/css/style.css >> +++ b/htdocs/css/style.css >> @@ -369,7 +369,6 @@

Re: [PATCH 4/5] views: Provide a way to view, (re)generate tokens

2017-06-14 Thread Daniel Axtens
Hi Stephen and Andrew, I've installed this on py[23].patchwork.dja.id.au > diff --git a/htdocs/css/style.css b/htdocs/css/style.css > index 5218f6d..af2f073 100644 > --- a/htdocs/css/style.css > +++ b/htdocs/css/style.css > @@ -369,7 +369,6 @@ table.form th.headerrow { > } > > table.form th