Re: [PATCH v2 2/2] docs: Note new requirement to include a SPDX line

2018-09-17 Thread Stephen Finucane
On Mon, 2018-09-17 at 13:34 -0400, Veronika Kabatova wrote: > > - Original Message - > > From: "Stephen Finucane" > > To: patchwork@lists.ozlabs.org > > Sent: Monday, September 17, 2018 7:19:45 PM > > Subject: Re: [PATCH v2 2/2] docs: Note new requirement to include a SPDX > > line > >

Re: [PATCH v2 2/2] docs: Note new requirement to include a SPDX line

2018-09-17 Thread Veronika Kabatova
- Original Message - > From: "Stephen Finucane" > To: patchwork@lists.ozlabs.org > Sent: Monday, September 17, 2018 7:19:45 PM > Subject: Re: [PATCH v2 2/2] docs: Note new requirement to include a SPDX line > > On Mon, 2018-09-17 at 18:17 +0100, Stephen Finucane wrote: > > Add some

Re: [PATCH v2 2/2] docs: Note new requirement to include a SPDX line

2018-09-17 Thread Stephen Finucane
On Mon, 2018-09-17 at 18:17 +0100, Stephen Finucane wrote: > Add some wording around the requirement to include this line instead > of > the license header. Also note the requirement that all code be > GPLv2-licensed and add a CONTRIBUTING document, which GitHub likes. > > Signed-off-by: Stephen

[PATCH v2 2/2] docs: Note new requirement to include a SPDX line

2018-09-17 Thread Stephen Finucane
Add some wording around the requirement to include this line instead of the license header. Also note the requirement that all code be GPLv2-licensed and add a CONTRIBUTING document, which GitHub likes. Signed-off-by: Stephen Finucane Cc: Daniel Axtens --- CONTRIBUTING.rst |

[PATCH v2 2/4] tagging: add tags and related filters to REST API

2018-09-17 Thread vkabatov
From: Veronika Kabatova Signed-off-by: Veronika Kabatova --- patchwork/api/comment.py | 12 +- patchwork/api/cover.py| 14 ++- patchwork/api/filters.py | 42 ++- patchwork/api/patch.py

[PATCH v2 4/4] tagging: change wording in documentation

2018-09-17 Thread vkabatov
From: Veronika Kabatova All submissions can have tags associated with them now and the documentation text should reflect it. Signed-off-by: Veronika Kabatova --- docs/usage/overview.rst | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/docs/usage/overview.rst

[PATCH v2 3/4] tagging: use tag infrastructure to create tags in mboxes

2018-09-17 Thread vkabatov
From: Veronika Kabatova Signed-off-by: Veronika Kabatova --- patchwork/models.py | 12 patchwork/tests/test_mboxviews.py | 19 --- patchwork/views/utils.py | 9 ++---

[PATCH v2 1/4] Rework tagging infrastructure

2018-09-17 Thread vkabatov
From: Veronika Kabatova Solve #113 and #57 GitHub issues, keep track of tag origin to be able to add tags to comments in the API later. Use relations Tag-Patch and Tag-CoverLetter to avoid duplication of tags for each patch in series, and use `series` attribute of SubmissionTag as a notion of a

[PATCH v2 1/4] Rework tagging infrastructure

2018-09-17 Thread vkabatov
From: Veronika Kabatova Solve #113 and #57 GitHub issues, keep track of tag origin to be able to add tags to comments in the API later. Use relations Tag-Patch and Tag-CoverLetter to avoid duplication of tags for each patch in series, and use `series` attribute of SubmissionTag as a notion of a

[PATCH v2 1/4] Rework tagging infrastructure

2018-09-17 Thread vkabatov
From: Veronika Kabatova Solve #113 and #57 GitHub issues, keep track of tag origin to be able to add tags to comments in the API later. Use relations Tag-Patch and Tag-CoverLetter to avoid duplication of tags for each patch in series, and use `series` attribute of SubmissionTag as a notion of a

[PATCH 6/6] views: Add error handling for user registration

2018-09-17 Thread Stephen Finucane
This was already present for registration confirmation but missing for initial registration. Resolve this. Signed-off-by: Stephen Finucane --- patchwork/views/user.py | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/patchwork/views/user.py

[PATCH 5/6] templates: Remove 'email_sent' attribute

2018-09-17 Thread Stephen Finucane
Further normalization to ensure all related code paths use similar code. Signed-off-by: Stephen Finucane --- patchwork/templates/patchwork/optin-request.html | 2 +- patchwork/templates/patchwork/optout-request.html | 2 +- patchwork/tests/test_mail_settings.py | 8

[PATCH 4/6] templates: Move additional email subjects to templates

2018-09-17 Thread Stephen Finucane
Use a uniform pattern for this stuff. Signed-off-by: Stephen Finucane --- .../patchwork/mails/optin-request-subject.txt | 1 + .../mails/optout-request-subject.txt | 1 + .../patchwork/mails/user-link-subject.txt | 1 + patchwork/views/mail.py | 19

[PATCH 2/6] templates: Rename additional templates

2018-09-17 Thread Stephen Finucane
Make ALL the things consistent. Signed-off-by: Stephen Finucane --- .../{download_buttons.html => download-buttons.html} | 0 patchwork/templates/patchwork/{mail-form.html => mail.html} | 0 .../patchwork/{registration_form.html => registration.html} | 0

[PATCH 3/6] templates: Keep only whole templates in the top-level

2018-09-17 Thread Stephen Finucane
Again, this should make this a little more understandable as it ensures a rough mapping exists between views and template names. Signed-off-by: Stephen Finucane --- patchwork/templates/patchwork/bundle.html | 2 +- patchwork/templates/patchwork/list.html |

[PATCH 1/6] templates: Move mails to separate directory

2018-09-17 Thread Stephen Finucane
This makes things a little easier to parse. A couple of templates are renamed and the 'register.mail' template, which appears to be unused since commit f1e089f7, is removed. Signed-off-by: Stephen Finucane --- patchwork/notifications.py | 7 ---

[PATCH] Remove '__future__.absolute_import' imports

2018-09-17 Thread Stephen Finucane
These were added as part of the Python 3 support series but are not required and can be safely removed. Signed-off-by: Stephen Finucane --- patchwork/admin.py | 2 -- patchwork/fields.py | 2 -- patchwork/filters.py | 2 --