Re: todo lists on patchwork.kernel.org are really slow
On Wed, 2016-09-14 at 08:51 +0200, Johannes Berg wrote: > > Once I know more, I'll come back here with that info and check the > code again as well. > So it's running v1.0.0 (*), which as a notable difference doesn't actually generate a browser redirect but just generates the list inline, which explains why we were talking about two different things before :) Other than that though, I don't really see a real difference to master in this particular code. More interesting, perhaps, is the difference between views.patch.list and views.user.todo_list. Does the latter really filter twice? user.profile.todo_patches() already does a filter on the delegate, but it gets applied again in views.user.todo_list? Could that cause a problem? johannes (*) though I heard some UI changes were reverted ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
Re: todo lists on patchwork.kernel.org are really slow
On Wed, 2016-09-14 at 16:47 +1000, Andrew Donnellan wrote: > On 14/09/16 16:38, Johannes Berg wrote: > > > > That would be before the redirect though, no? Also, every page > > (while > > Yes it would be. Ok. > > > > logged in) loads the n_todo_pages(), and that takes virtually no > > time at all. > > Good point... I've asked Konstantin (the kernel.org admin) what precise version he runs. I know it's not the latest git, so maybe there was a fix in this area recently. Once I know more, I'll come back here with that info and check the code again as well. Thanks for the help! johannes ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
Re: todo lists on patchwork.kernel.org are really slow
On 14/09/16 16:38, Johannes Berg wrote: That would be before the redirect though, no? Also, every page (while Yes it would be. logged in) loads the n_todo_pages(), and that takes virtually no time at all. Good point... -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
Re: todo lists on patchwork.kernel.org are really slow
On 14/09/16 04:53, Johannes Berg wrote: I'm not sure exactly what version is deployed there right now, but was there, by any chance, a recent bug fix regarding the speed of todo list(s)? I only have a single project there with TODO items, so going to https://patchwork.kernel.org/user/todo/ immediately pulls up the todo list for the linux-wireless project, but it takes >40 seconds to render that page. Is most of that time before or after it 302s from https://patchwork.kernel.org/user/todo/ to https://patchwork.kernel.org/user/todo/linux-wireless? The comparable/equivalent https://patchwork.kernel.org/project/linux-wireless/list/?delegate=90 takes a fraction of a second for showing the exact same list of patches to me. If there wasn't a recent fix in this area I guess this is a bug report? I tried looking at the code, but couldn't really see an immediate difference. A quick look at the code says that the todo list views call .todo_patches() on every single project, which could be a bit slow. -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
