Re: [PATCH V2] parser: fix wrong parsing of diff comments

Hi, Stephen I think you missed this patch. But I saw you have already merged it, maybe it can give you some reference:) 2016-09-05 22:31 GMT+08:00 Pingbo Wen : > From: WEN Pingbo > > If the subject of a submission is prefixed by 'Re:', then it can't

Re: [PATCH 2/6] parsemail-batch.sh: pass command-line options to parsemail

Hi Stephen, > > I think this does the same thing as parsearchive? I don't know if this > is still necessary, if so, but as it doesn't cost anything to keep > around for now: If I understand correctly, parsearchive parses a single file containing a bunch of mail, and parsemail parses a directory

[PATCH] Add support for comment permalink

Signed-off-by: Stephen Finucane Closes-bug: #39 --- patchwork/templates/patchwork/submission.html | 4 ++- patchwork/tests/test_detail.py| 38 +++-- patchwork/urls.py | 5 patchwork/views/comment.py

[PATCH] Update mailmap with new email

Hotmail is unfortunately not standards compliant and has a bad habit of rewriting message-ids. This breaks threading for both Mailman and Patchwork. Clearly it's time to switch to another email address. Signed-off-by: Stephen Finucane --- .mailmap | 3 ++- 1 file changed, 2

[PATCH] Update mailmap with new email

Hotmail is unfortunately not standards compliant and has a bad habit of rewriting message-ids. This breaks threading for both Mailman and Patchwork. Clearly it's time to switch to another email address. Signed-off-by: Stephen Finucane --- .mailmap | 3 ++- 1 file changed, 2

Re: [PATCH 6/6] parsemail tests: add test for mail with utf-8

> I think this can be squashed into the previous patch, but otherwise: > > Reviewed-by: Stephen Finucane Fair point. Will squash it for v2. Regards, Daniel > >> patchwork/tests/test_management.py | 29 + >> 1 file changed, 29

[PATCH] bin/pwclient: fix spurious except catch

The 'with' statement does not start an exception block like 'try' would, so we get an error executing pwclient: File "/home/ymorin/bin/pwclient", line 300 except IOError: ^ SyntaxError: invalid syntax Instead, don't try to catch any exception: any failure will be

Re: [PATCH] bin/pwclient: fix spurious except catch

On 25 Sep 12:48, Yann E. MORIN wrote: > The 'with' statement does not start an exception block like 'try' would, > so we get an error executing pwclient: > > File "/home/ymorin/bin/pwclient", line 300 > except IOError: > ^ > SyntaxError: invalid syntax > > Instead,

Re: [PATCH 5/6] parsemail: Convert to a management command

On 23 Sep 10:06, Daniel Axtens wrote: > Management comands allow applications to register their own actions with > 'manage.py'. This provides some advantages, like automatically > configuring Django (removing the need for 'django.setup' calls) and > removing the need to set the PYTHON_PATH. The

Re: [PATCH 6/6] parsemail tests: add test for mail with utf-8

On 23 Sep 10:06, Daniel Axtens wrote: > This is designed to ensure we don't have any more hiccups with > decoding UTF-8 under arbitrary locales, which can occur under > Python 3. > > Signed-off-by: Daniel Axtens I think this can be squashed into the previous patch, but