Re: [PATCH v6 6/8] templates: Generate and use a "handle"

2016-10-26 Thread Stephen Finucane
On 2016-10-26 09:39, Daniel Axtens wrote: Stephen Finucane writes: In the absence of a name, the email is currently used. Some emails are long and rather unreadable. The likelihood of someone's localpart (i.e. the bit before the '@') conflicting with that of someone else

Re: [PATCH v6 3/8] parser: Add series parsing

2016-10-26 Thread Daniel Axtens
Hi Stephen, >> Hopefully I've understood what's going on here: >> - first, check for a Series that directly matches this message's >>message id (hence the True to find_references) >> - then, check for a series that matches an In-Reply-To >> - then, check for a series that matches the

Re: [PATCH v6 8/8] templates: Integrate series view into patches

2016-10-26 Thread Daniel Axtens
Hi Stephen, I haven't gone through this with a fine toothed comb, but on the basis of how it looks when rendered: Reviewed-by: Daniel Axtens Regards, Daniel Stephen Finucane writes: > Patches for related series are listed on the patch page - this >

Re: [PATCH v6 7/8] templates: Integrate series support

2016-10-26 Thread Daniel Axtens
Daniel Axtens writes: Forgot to send to the list, sorry. > Hi Stephen, > >> +def _set_key(self, key): >> +self.series = None >> +series_id = None >> + >> +key = key.strip() >> +if not key: >> +return >> + >> +try: >> +