Re: [PATCH] Fix stuff around mbox header changes

On Tue, 2018-04-10 at 16:30 +0200, vkaba...@redhat.com wrote: > From: Veronika Kabatova > > Bundle tests got broken after the subject in mbox was changed from the > parsed version to the original one because the tests checked for the > presence of patch's name in the response. Fixing this turned

Re: [PATCH 1/2] trivial: Remove additional Django < 1.8 code

On Mon, 2018-04-09 at 17:37 +0100, Stephen Finucane wrote: > Yet more stuff that was missed in the previous changes. > > Signed-off-by: Stephen Finucane > --- > patchwork/management/commands/parsearchive.py | 26 - > patchwork/management/commands/parsemail.py| 33 ++--

Re: [PATCH 0/2] Patchwork 2.1.0-rc1: Extra Special OzLabs Edition

On Fri, 2018-04-06 at 03:02 +1000, Daniel Axtens wrote: > TL;DR: I want to spin a new version of patchwork for OzLabs so they can > do the migration that speeds up patch listing. I've pushed it to > https://github.com/daxtens/patchwork as I'm not sufficiently confident > in my release-fu to push it

Re: [PATCH 1/2] docs: Prepare for 2.1.0-rc1

On Fri, 2018-04-06 at 03:03 +1000, Daniel Axtens wrote: > Explain why we want an extra special ozlabs edition. (I can't find > any good fabrics starting with E and I also want to emphasise that > this is a special case.) Fine with the name but I don't see why we should think of this as a special c

[PATCH 3/7] REST: Use ModelMultipleChoiceField

We use a modified version of this that allows us to query on multiple fields. Signed-off-by: Stephen Finucane Fixes: #156 --- patchwork/api/filters.py | 103 - patchwork/tests/api/test_patch.py | 15 ++- .../improved-rest-filtering-

[PATCH 0/7] Add support for multiple filters

When writing git-pw, it was assumed that one could specify a filter multiple times and it would be applied that way. This turned out to be a false assumption and only the latest filter is applied. This is confusing and prevents a number of possible usecases. Fix this. Stephen Finucane (7): REST:

[PATCH 4/7] REST: Remove ProjectFilterMixin

Whatever benefits this was giving us in the past are no more and it simply confuses matters now. Signed-off-by: Stephen Finucane --- patchwork/api/filters.py | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/patchwork/api/filters.py b/patchwork/api/filte

[PATCH 5/7] REST: Rename Filter -> FilterSet

This was confusing and will conflict with some forthcoming changes. Signed-off-by: Stephen Finucane --- patchwork/api/bundle.py | 4 ++-- patchwork/api/check.py | 4 ++-- patchwork/api/cover.py | 4 ++-- patchwork/api/event.py | 4 ++-- patchwork/api/filters.py | 12 ++-- patc

[PATCH 6/7] REST: Use ModelMultipleChoiceField for other fields

There's benefit to being able to do stuff like select multiple patches. Let's do that. Signed-off-by: Stephen Finucane --- patchwork/api/filters.py | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/patchwork/api/filters.py b/patchwork/api/filters.py

[PATCH 7/7] REST: Use DRF-specific filterset

Better error handling, yo. Signed-off-by: Stephen Finucane --- patchwork/api/filters.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/patchwork/api/filters.py b/patchwork/api/filters.py index 4d8d504d..f6fff792 100644 --- a/patchwork/api/filters.py +++ b/patchwork/api/filte

[PATCH 2/7] REST: Simplify ModelMultiChoiceField

We're actually going to remove this shortly but the new technique works for both. Signed-off-by: Stephen Finucane --- patchwork/api/filters.py | 23 +++ 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/patchwork/api/filters.py b/patchwork/api/filters.py index 25

[PATCH 1/7] REST: Use UserFilter for patch delegates

Signed-off-by: Stephen Finucane --- patchwork/api/filters.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/patchwork/api/filters.py b/patchwork/api/filters.py index eed7995d..25956e98 100644 --- a/patchwork/api/filters.py +++ b/patchwork/api/filters.py @@ -158,8 +158,9 @@

Re: [PATCH v2 4/6] models: Migrate event fields to JSON field

Stephen Finucane writes: > On Wed, 2018-04-11 at 02:23 +1000, Daniel Axtens wrote: >> > diff --git >> > a/patchwork/migrations/0027_migrate_data_from_event_fields_to_payload.py >> > b/patchwork/migrations/0027_migrate_data_from_event_fields_to_payload.py >> > new file mode 100644 >> > index 000

[PATCH 2/4] docs: Fix a release note issue

You can't have a space before the closing double backticks of a literal block. This was generating the following (unhelpful) error message: patchwork/docs/releases/unreleased.rst:82:Inline literal start-string without end-string. reno should have better error messages but that's a problem for

[PATCH 1/4] docs: Read version from 'patchwork.VERSION'

Because this isn't an installable package we need to do some path hackery. Not the end of the world though. Signed-off-by: Stephen Finucane --- docs/conf.py | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/docs/conf.py b/docs/conf.py index f692cf91..4fd3a04f 1

[PATCH 3/4] tox: Add 'docs' to default environments

I'd simply run 'tox' (via docker) to validate some previous patches. Sadly that didn't catch a release note issue. Make sure this doesn't happen again by always running 'docs'. Signed-off-by: Stephen Finucane --- tox.ini | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tox.ini

[PATCH 4/4] gitignore: Ignore '.venv'

I use this to validate stuff quite frequently. Ignore it so it's not polluting my git-status. Signed-off-by: Stephen Finucane --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index d88ba748..04b66702 100644 --- a/.gitignore +++ b/.gitignore @@ -35,6 +35,

Re: [PATCH 2/2] Patchwork v2.1.0-rc1

On Fri, 2018-04-06 at 03:03 +1000, Daniel Axtens wrote: > Signed-off-by: Daniel Axtens I'd squash the doc/conf.py change (just that one) from the previous patch into this, personally. That way we've bumped every version at once. Alternatively you could fix the docs to read version from the below

Re: [RFC 0/2] Rework tagging infrastructure

On Fri, 2018-03-16 at 15:38 +0100, vkaba...@redhat.com wrote: > From: Veronika Kabatova I'm going to review this this week. However, this doesn't apply cleanly to head of master any more (sorry :(). Any chance you could send updated versions of these? Stephen > (TL;DR at the end) > > This RFC

[PATCH v2 1/2] api: Add comments to patch and cover endpoints

From: Veronika Kabatova Signed-off-by: Veronika Kabatova --- patchwork/api/cover.py | 14 ++-- patchwork/api/embedded.py | 38 ++ patchwork/api/patch.py | 15 ++--- patchwork/models.py

[PATCH v2 2/2] tests/api: Test comments

From: Veronika Kabatova Check that comments field is added to patch / cover letter details with API version 1.1. This required minor change to api_url() method to avoid errors in case both the 'item' and 'version' parameters are passed (can't use both *args and **kwargs with reverse()). Signed-o

Re: [RFC 0/2] Rework tagging infrastructure

- Original Message - > From: "Stephen Finucane" > To: vkaba...@redhat.com, patchwork@lists.ozlabs.org > Sent: Wednesday, April 11, 2018 6:43:25 PM > Subject: Re: [RFC 0/2] Rework tagging infrastructure > > On Fri, 2018-03-16 at 15:38 +0100, vkaba...@redhat.com wrote: > > From: Veronika K

Re: [PATCH v2 4/6] models: Migrate event fields to JSON field

Daniel Axtens writes: > Stephen Finucane writes: > >> On Wed, 2018-04-11 at 02:23 +1000, Daniel Axtens wrote: >>> > diff --git >>> > a/patchwork/migrations/0027_migrate_data_from_event_fields_to_payload.py >>> > b/patchwork/migrations/0027_migrate_data_from_event_fields_to_payload.py >>> > new