[PATCH 4/6] models: Remove 'SeriesMixin'

2018-09-06 Thread Stephen Finucane
The property this provides, 'latest_series', is now a no-op and can be removed along with the mixin itself. Signed-off-by: Stephen Finucane --- patchwork/models.py | 22 ++--- .../templates/patchwork/download_buttons.html | 2 +-

[PATCH 1/6] tests: Add more tests for series-ified mbox views

2018-09-06 Thread Stephen Finucane
Cover some testing gaps identified during the migration from a M:N to a 1:N series-patch relationship, namely: - Downloading a patch's mbox with dependencies using a numerical series ID - Downloading a series' mbox Signed-off-by: Stephen Finucane --- patchwork/tests/test_mboxviews.py | 40

[PATCH 3/6] models: Convert Series-Patch relationship to 1:N

2018-09-06 Thread Stephen Finucane
Late in the development of the series feature, it was decided that there were advantages to allowing an N:M relationship between series and patches would be desirable. This would allow us to do things like create complete series where a sole vN patch was sent to a list rather than the full series.

[PATCH 0/6] Convert Series-Patch relationship to 1:N

2018-09-06 Thread Stephen Finucane
This is mostly a tech debt reduction exercise. As noted in the main patch, the M:N relationship between series and patches was, in hindsight, a design decision made for the wrong reasons. It's one of the things holding us back on the improved tagging series and it makes a lot of things more

[PATCH 2/6] tests: Hardcode expected values

2018-09-06 Thread Stephen Finucane
Compare against known values to ensure bugs introduced in the function are caught. Signed-off-by: Stephen Finucane --- patchwork/tests/test_series.py | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/patchwork/tests/test_series.py b/patchwork/tests/test_series.py index

[PATCH 5/6] tests: Remove 'create_series_patch'

2018-09-06 Thread Stephen Finucane
The 'SeriesPatch' object was recently removed, but the 'create_series_patch' was retained in order to minimize the changes necessary. This can now be removed and the logic moved to the 'create_patch' and 'create_cover' functions instead. Signed-off-by: Stephen Finucane ---

[PATCH 6/6] views: Add support for boolean 'series' parameters

2018-09-06 Thread Stephen Finucane
Previously, we allowed users to download patch mboxes with dependencies included using a 'series' parameter. This accepted either a numeric ID, corresponding to the ID of the patch series that dependencies should be included from, or a wildcard value ('*'). /patch/{patchID}/mbox/?series=123