Re: Annotating superseded/accepted patches

Carl-Daniel, is there some way to store by which patch an existing patch was superseded, preferably with a link to the newer instance? The web interface only lets me change the state to Superseded, but there is no text field (or dropdown box) where I could enter a patch number or patch name.

Re: Newer pwclient breaks with older server

Carl-Daniel, commit 7bcba313da27b7230b14a7ea41d50e76cd03e9a5 breaks hash lookups with older patchwork servers. I get the following traceback: Hm, I was worried about old pwclients with new servers (which this should be OK with), but not the other way around. Here's a fix:

Re: Different hashes for the same patch

Hi Carl-Daniel, Any ideas how to solve this? The correct fix would be to specify the ordering in the hash calculation algorithm (ie, reorder the diff, sorting by filename, then calculate the hash). However, this will break the calculated hashes in exsisting patchwork databases. There's a

Re: scripts interaction of Patchwork and Git

Paul, Before I send other question in a separate threads I was wondering if you could share your scripts you all wrote to make your life easier as for example Git hooks. OK, in the interests of writing stuff down, this is what I have: * A hook in .git/hooks/post-applypatch: #!/bin/bash

Re: Merging patches

Hi Mauro, However, assuming we could identify a patch series, wouldn't it make sense to automatically create a bundle? I'd prefer to have the 'relations' different from bundles. The way I see this implemented: * Add a table of (from_patch_id, to_patch_id, relation_type) * relation types

Re: PatchWork feature request

Carl-Daniel, How about X-Patchwork-Hint: ignore:linux-ext4 I'd prefer project:action, as the project defines the 'scope' of what to do, and the action defines what to do. But really, either way is good. Cheers, Jeremy ___ Patchwork mailing list

Re: Multiple bundles with the same name

Hi Ralf, Yes, it definitely should. Thanks for letting me know - I'll get a fix done soon. Ok, change committed: http://git.ozlabs.org/?p=patchwork;a=commitdiff;h=d2da1d19f82462bf0b357772bbab174281fc788a Thanks for the report! John: you may want to update to the latest master branch - IIRC,

Re: [PATCH 1/2 v3]Update broken web addresses.

Hi Ralf, On Tue, Sep 21, 2010 at 06:29:16PM -0700, Justin P. Mattock wrote: Date: Tue, 21 Sep 2010 18:29:16 -0700 From: Justin P. Mattock justinmatt...@gmail.com To: triv...@kernel.org Cc: linux-arm-ker...@lists.infradead.org, linux-ker...@vger.kernel.org,

Re: Patchwork Update Errors

Hi Jeff, Any more idea's Jeremy? Sorry about the delay, I've just been travelling to the US. I have tried adding the follwing: export PYTHONPATH='/srv/pathwork/apps';'/srv/parthwork':'/srv/patchwork/apps/patc hwork' I'm guessing this isn't the exact 'export' statement, as there are a

Re: TypeError at /accounts/register/ register() got an unexpected keyword argument 'profile_callback'

Hi Sabuj, Exception Type: TypeError at /accounts/register/ Exception Value: register() got an unexpected keyword argument 'profile_callback' The django-registration module has changed its interface since I included it in patchwork; it looks like this change breaks the patchwork setup. If

Re: Recommended installation environment?

Hi Wolfgang, Sorry for asking a propbably stupid beginner's question: Is there a recommended installation envrionment for patchwork? I mean a combination of Linux distribution and set of packages that is known give the least problems (or that should better be avoided)? There is no official

Re: AttributeError 'LegacyFallbackStorage' object has no attribute 'append'

Hi Ross, The original issue occurs when I try to set a patch to RFC. I am wondering if Django 1.2.3 is not the correct version to use. I've tested with 1.2.3, so that should be fine. I did run all of the migration scripts in patchwork/lib/sql/migration. Environment: Request Method:

Re: [PATCH v2] Recognize mail headers for delegate and state

Hi Wolfgang, Any chance that this (or something similar) gets activated on patchwork.ozlabs.org ? I'd _really_ like to have such a feature. Yep, that should be fine. I've got a lot of other (ie, non-patchwork) stuff on at the moment, but will take a look at it soon. Cheers, Jeremy

Re: [PATCH] Manually encode utf-8 patch in testcase

Dirk, Otherwise there will be a UnicodeDecodeError. Where are you getting this UnicodeDecodeError? With 7fd7d0bbe reverted, I see all the testcases pass. Cheers, Jeremy ___ Patchwork mailing list Patchwork@lists.ozlabs.org

Re: [PATCH 0/4] Some small fixes

Hi Dirk, Dirk Wallenstein (4): docs: Fix link creation example Spelling fix Replace tab in indentation with space Fix pwclient no-match messages Thanks, applied. Cheers, Jeremy ___ Patchwork mailing list Patchwork@lists.ozlabs.org

Re: [PATCH] Implement __unicode__ in models instead of __str__

Hi Dirk, According to the Django documentation at [1] it is recommended to implement __unicode__ and not __str__. Django's model base class provides a __str__ method that will use the __unicode__ method and convert to utf-8. Also, every text value returned from the DB through the model is

Re: [PATCH v2] Don't require optional model fields in forms

Hi Dirk, The keyword 'blank' concerns only validation and does not change what will be stored in the database. mostly applied: -hash = HashField(null = True, db_index = True) +hash = HashField(db_index=True ,null=True, blank=True) Trying to sneak an index in, eh? :) Although this

Re: Guessing project based on email address

Hi Guilherme, We're going to use Patchwork to track Linaro patches, but instead of subscribing to all mailing lists to which patches may be sent, we're asking all Linaro developers to CC a common email address whenever they send a patch upstream, and we'll then feed all mail delivered to that

Re: Code cleanups/refactorings

Hi Guilherme, However, I didn't get any feedback on them, and although I hope this is because people are just busy with other stuff, I'm left wondering if there's any interest in such changes. There's definitely interest in this stuff, and your patches look good in general, but the day job

Re: [PATCH 1/2] adapt patchwork-update-commits to pwclient changes

Hi Sascha, pwclient requires the action (update) and the project name. It shouldn't *require* the project; that should be specified in .pwclientrc. However, I'm assuming you'd like to override the project setting here - in that case, it'd be better to add an optional -p project argument to

Re: [PATCH 2/2] patchwork-update-commits: autodetect patchwork install directory

Hi Sascha, Make patchwork-update-commits work from outside the Patchwork git repository so it can be used for other projects. Looks good, thanks. Jeremy ___ Patchwork mailing list Patchwork@lists.ozlabs.org

Re: [PATCH] Support execution of single tests

Hi Dirk, Django does not use suite() when executing single tests. Importing all tests directly into __init__.py has the same effect as the replaced version of suite(). Oh awesome, been meaning to do this for ages. Applied. Jeremy ___ Patchwork

Re: [PATCH v2] Make sure the diffs of pull requests are stored in the Patch object.

Hi Guilherme, Looks good, could I have a Signed-off-by line for this patch? Cheers, Jeremy ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork

Re: [PATCH v2] Get rid of some code duplication in parsemail-batch.sh.

Hi Guilherme, It now uses parsemail.sh instead of parsemail.py as the former sets the required environment variables that were being set in parsemail-batch.sh. Could I have a signoff for this one too? Also, all of your other patches seem to be missing the Signed-off-by line too. Otherwise,

Re: [PATCH] Remove unused templates and some code for processing them.

Hi Guilherme, These seem to be what was used in the past to archive/unarchive and delete patches. IIRC, we still need the code (in set_patches) for archive/unarchive - but the deletion (and ack) stuff should be fine. Cheers, Jeremy ___ Patchwork

Re: [PATCH] Remove unused templates and some code for processing them.

Hi Guilherme, I don't see how those could be used as the new templates no longer have archive/unarchive form actions -- now there's just a checkbox labeled 'Archived' which is supposedly handled by PatchForm/MultiplePatchForm. Ah yep, the reference I was looking at was from an unused template

Re: Guessing project based on email address

Hi Guilherme, all different projects that Linaro engineers may contribute to (we don't have a list of all these projects beforehand and we expect it to grow all the time). You'll still have the same problem here; patchwork needs to know about the project before it will parse patches for that

Re: [PATCH] Fix archiving/unarchiving of patches on patch lists.

Hi Guilherme, It was broken because MultipleBooleanField() was leaking string values instead of boolens as expected by MultiplePatchForm. Thanks for finding and fixing this one - and for the good testcase too. I've applied the patch, with some minor style changes: +def

Re: [PATCH] Refactor the generic_list() view to make it less complicated.

Hi Guilherme, @@ -205,7 +206,30 @@ class MultiplePatchForm(forms.Form): self.fields['delegate'] = OptionalDelegateField(project = project, required = False) -def save(self, instance, commit = True): +def process(self, user, action, patches, context): +

Re: Using the From: address specified in the body

Hi Guilherme, I see that some emails with patches have a From: field in the body[1], That's generated by git-format-patch, when the patch author is not the user generating the patch files. git-am will use these From: lines to correctly set the author when the patch is applied to the

Re: `pwclient` and multiple Patchwork instances

Hi Paul, Is that still valid? If yes, how do you folks deal with multiple patchwork instances? Yes, it's still valid. I tend to be mainly using one project at a time, so just edit .pwclientrc when switching. I haven't had to do this often, so it hasn't been too much trouble (yet). In the

Re: Fully automating patch state updates

Hi Guilherme, I've seen the tools/patchwork-update-commits script and I'm planning to work on making a fully automated version of it, which fetches the master branch, scans the commits on it and updates the state of patches. I think this would be a nice addition to Patchwork. For that to

Re: patchwork: loses Acks if they arrive before the patchmail

Hi Peter, I suspect patchwork has got confused because the Ack email arrived an hour or so before the patch email (slow mailing list and the patch was cc'd to a highly responsive subsystem maintainer :-)). Yeah, it'll do that. If patchwork sees an email that doesn't contain a patch, or that

Patchwork development: notification branch

Hi all, I've just pushed a new branch ('notifications') to the patchwork git repository: http://git.ozlabs.org/?p=patchwork;a=shortlog;h=refs/heads/notifications This is a topic branch to implement a feature that has been requested by patchwork maintainers: to notify patch submitters when

Re: [PATCH] Add a source_tree field to Project.

Hi Guilherme, apps/patchwork/models.py |1 + lib/sql/migration/008-project-source-tree.sql |3 +++ 2 files changed, 4 insertions(+), 0 deletions(-) create mode 100644 lib/sql/migration/008-project-source-tree.sql Looks good. I'd like to wait until there is a

Re: patchwork: loses Acks if they arrive before the patchmail

Hi Peter, Well, you wouldn't have to keep them indefinitely, and you only need to keep emails which have references/in-reply-to pointing to an email you haven't seen yet, so that's not very much data. If you can't trust patchwork to actually retain all the relevant traffic about a patch, I

Re: [PATCH] Get rid of hard-coded absolute paths.

Hi Guilherme, This is so that you don't have to change a dozen variables when you deploy an instance somewhere other than on /srv/patchwork. [snip] +# If you deploy somewhere other than /srv/patchwork you need to change the +# settings below, preferably on local_settings.py instead of here.

Re: [PATCH] Refactor the generic_list() view to make it less complicated.

Hi Guilherme, You've covered some of the points in a subsequent email, so just responding to the outstanding issues here. In general, do you mind if we leave this refactoring until we have the notification branch stable and merged? It'll mean we have to do less to merge the branches together.

Re: [PATCH] Add a source_tree field to Project.

Hi Janne, I would like to use it for patches.libav.org to link the commit hash to that commit in gitweb. see http://patches.libav.org/patch/1927/ for an example. Hm, good idea. It probably needs another field to construct the full URL from source tree and commit_ref. I think this could be

Re: [PATCH] Get rid of some code duplication in parsemail-batch.sh.

Hi Guilherme, It now uses parsemail.sh instead of parsemail.py as the former sets the required environment variables that were being set in parsemail-batch.sh. Thanks, applied. Jeremy ___ Patchwork mailing list Patchwork@lists.ozlabs.org

Re: [PATCH] Use the 'in' operator instead of dict.has_key(), which has been deprecated.

Hi Guilherme, Signed-off-by: Guilherme Salgado guilherme.salg...@linaro.org Thanks, applied Jeremy ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork

Re: [PATCH] Remove a bunch of unused variables.

Hi Guilherme, Signed-off-by: Guilherme Salgado guilherme.salg...@linaro.org Thanks, applied. Jeremy ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork

Re: Patchwork user permissions

Hi Mauro, 1) I'm using kernel.org facilities for Patchwork. As a project owner, I cannot give anyone else any extra permission. I'm forced to contact kernel.org manager, if I want do do it; This is what I'm planning to address: allow 'lead' maintainers to add/remove other maintainers from a

Re: [RFC] filter function for submaintainers

Hi Uwe, The problem (admittedly only from a quick glance at patchwork.ozlabs.org) I see is that it's not possible to reliably filter patches by directory name. (Or maybe I'm just to stupid to find the right knob, I tried searching for drivers/net/ehea in the netdev project, got a few hits,

Re: [RFC] A new page listing the user's patches that are waiting for feedback

Hi Guilherme, Another thing I've just noticed we'll have to keep in mind is that in these per-project lists, users won't be able to do mass-state-changes unless they're the maintainers of the project in question. We could change generic_list() to behave differently and always include the

Re: [PATCH] Make MultipleBooleanField.to_python work when the field value is missing

Hi Guilherme, If you write a test for, say, the bundle form of a patch list, you'd still have to specify the 'no change' value to other form (e.g. the multiple update one) fields using MultipleBooleanField or else it'd raise a ValueError when field.clean() is called as part of

Re: [PATCH] Streamline admin model registration

Hi Dirk, Use autodiscover and the new way to hook AdminSite into the URLconf. AdminSite.root() will be removed in Django-1.3 as noted here: http://docs.djangoproject.com/en/dev/internals/deprecation/ Thanks, applied. Jeremy ___ Patchwork mailing

Re: [PATCH v2] Ensure consecutive patch header lines

Hi Dirk, Drop the parse buffer if the start of a new diff is encountered in state 1. Looks good, applied. No problem about the holdup :) Cheers, Jeremy ___ Patchwork mailing list Patchwork@lists.ozlabs.org

Re: Compute hash for mailbox file?

Hi Wolfgang, I'm trying to find a way to match a given mailbox file to an entry in patchwork so that I can modify it using pwclient. It appears the best way would be to compute the has of the mailbox file and use this with the -h hash option. Is there an easy way to do that? There is a

Re: [PATCH] Make it possible, via a config setting, to use OpenID for authentication

Hi Guilherme, This basically just adds instructions for people who may want to have their patchwork instance as an OpenID relying party. The only code changes are the addition of the login_url() context processor, so that we always use the LOGIN_URL defined in the settings, Looks good, just

Re: [PATCH V2] New factory class to create arbitrary model objects, to be used in tests

- automated patch tracking system +# Copyright (C) 2011 Jeremy Kerr j...@ozlabs.org Probably best to add your name here :) + +def __init__(self): +# Initialise the unique identifier. +self.integer = count(randint(0, 100)) As a general rule, I'm averse to using random data

Re: [RFC] Store patch authors in the new Patch.author field

Hi Mauro, For ubuntu-kernel, when proposing an update patch, we forward the entire commit (possibly with comments before it, like why we're proposing the patch for that ubuntu kernel version). In this case, it'd be correct to parse the *last* From: line before the patch itself. This

Re: [PATCH] A new page that displays the patches for which the user is waiting feedback

Hi Guilherme, This patch is marked on patchwork.ozlabs.org as having changes requested, but I didn't get a reply from you about it. Is that because of the test changes to use the factory singleton rather than creating a new instance? Yes, that's exactly it - this will need to be altered to

Re: patch tracking issue

Hi Albert, (and I'll post an UTF-8-to-ISO-8859 fixup patch at the next merge window) Now, that's where it gets tricky - the patch you send will have *both* encodings in it. I'd suggest checking patchwork after sending it. Or even sending as a pull-request. Cheers, Jeremy

Re: pwclient: update delegate

[resend to include patchwork list] Hi Wolfgang, It appears that only you could change the ok_params settings - I understand that that needs to be done for the xmlrpc.py running on the ozlabs server, right? Yes, that code runs on the server. But if you send me a patch, I'd be quite likely to

Re: [PATCH] patchwork: new pwclient git-am action

Hi David, This commit adds a new pwclient git-am action which applies given patch ID on the current git branch using git am. It's convenient to keep track and authorship of patches applied locally from a patchwork server. Signed-off-by: David Decotigny david.decoti...@google.com Thanks!

Re: statistics from patchworks?

Hi Stephen David, So, I've done a couple of queries on the netdev patchset that I think might be useful for you: First, a breakdown by current state: state | count ---+--- Not Applicable| 7588 Changes Requested | 6364 Awaiting Upstream | 705 Under

Re: [PATCH] fix postgres grant script

Hi Simo, Current script fails with a rollback because one of the recently added sequences does not exist in the db. Ops sorry, attached correct patch without trailing , that makes psql balk Awesome, thank you for the patch. Could you send a Signed-off-by: line too? also I noticed that you

Re: Enhancements to mangeability of patches

Hi Simo, I recently installed patchwork and we are testing it for 3 separate upstream projects. I have the need to make it a bit more flexible in the way users can be configured to access and change patches status yet not give them actual admin rights as I do not want to let users from one

Re: [PATCH] Allow to download public bundle as mbox

Hi Simo, Downloading single patches anonimously is allowed, we may as well allow downloading public bundles as mboxes. Sounds good, but: diff --git a/apps/patchwork/urls.py b/apps/patchwork/urls.py index 10fc3b9..034fbb3 100644 --- a/apps/patchwork/urls.py +++ b/apps/patchwork/urls.py @@

Re: [PATCH] Allow to download public bundle as mbox

Hi Simo, Downloading single patches anonimously is allowed, we may as well allow downloading public bundles as mboxes. Looks good. This does raise one question for everyone though: +def mbox_response(bundle, name): response = HttpResponse(mimetype='text/plain') -

Re: [PATCH v2] pwclient: Add heuristics to find a whole series of patches

Hi Doug, Add a new filter option '-r' that attempts to list all patches in a series. Since there's no built-in way in patman to do this, we use some heuristics to try to find the series. Interesting idea, something I'm sure would be useful for many patchwork users. Do you think it would

Re: [PATCH v2] pwclient: Add heuristics to find a whole series of patches

Hi Doug, I will git it a shot. I'll need to get a local patchwork server setup for testing (so far I'm just using patchwork.kernel.org for my development on the client), so there might be a bit of a lag before I post a patch for that. Should just be a matter of: createdb patchwork git clone

Re: [PATCH v2 1/3] pwclient: Add command for printing patch info

Hi Doug, This command prints raw information that patchwork has about a patch. This can be useful for debugging problems with patchwork. Looks good, applied. Cheers, Jeremy ___ Patchwork mailing list Patchwork@lists.ozlabs.org

Re: [PATCH] xmlrpc: Avoid trying to marshall None for people with no name

Hi Doug, This is the server side fix to the pwclient workaround I send out titled pwclient: Handle servers that barf on users with no name So we won't need the pwclient workaround with this fix applied, right? Cheers, Jeremy ___ Patchwork

Re: [PATCH 0/3] Add basic support for series of patches

Hi Doug, This series of patches replaces the old patch pwclient: Add heuristics to find a whole series of patches and moves the concept of a patch series over to the server side. I'd like to propose a different way of achieving this: rather than try to piece-together the patch series at

Re: [PATCH] models: Don't munge the 'From' field of patches

Hi Doug, At the moment patchwork always uses the official submitter name (as patchwork understands it) as the From for patches that you receive. This isn't quite what users expect and has some unfortunate consequences. Agreed. The biggest problem is that patchwork saves the official name

Re: pwclient can not filter by delegate

Hi Andreas, pwclient provides a '-d' switch to filter by delegate but this doesn't work. It seems pwclient does a rpc.person_list() which unfortunately does not contain the correct user id's. For example the id for my 'delegate' user seems to be 6342, but the rpc.person_list() contains some

Re: [PATCH 3.8-stable] net: count hw_addr syncs so that unsync works properly.

Hi all, This patch looks like it should be in the 3.8-stable tree, should we apply it? I queue up networking patches as needed and that queue is visible at: http://patchwork.ozlabs.org/user/bundle/2566/?state=* Actually, this bundle is not visible via that link. It appears to be a

Re: adding glibc to the tracked list ?

Hi Mike, would it be possible to have http://patchwork.ozlabs.org/ track glibc ? Yep, no problem at all. I can merge the two lists into the one project, but I figure you'd need to distinguish the patches somehow, right? we'd like to try things out and see how well it works. I've found that

Re: [git pull] Please pull powerpc.git merge branch

Hi Linus, No. The date from the email was Date: Fri, 7 Jun 2013 15:42:54 +1000 and we want *that* date. Ah, gotchya. So, we now use the original date header (if present) in the mbox views: $ wget -qO - http://patchwork.ozlabs.org/patch/249598/mbox/ | grep ^Date Date: Fri, 7 Jun 2013

Re: [PATCH] INSTALL: update jquery.tablednd URL

Hi Andreas, The old URL gives a 404, just use the old stable version in git repo. I've decided to just include these in the git repo; makes for a simpler install. Cheers, Jeremy ___ Patchwork mailing list Patchwork@lists.ozlabs.org

Re: Adding uclibc to tracked lists for patches

Hi Khem, Would it be possible to add ucl...@uclibc.org to tracked projects on patchwork.ozlab.org ? The developers are very interested to have a patchwork instance which could track the patches sent to the list. Sure thing! I'll just need the following information: * The list address

Re: [PATCH] models: Don't munge the 'From' field of patches

Hi all, In which part of the web UI? I played with this and the Headers still shows the proper (un-munged) From address. Certainly the Submitter at the top still shows the official patchwork idea of what the person's name is but I'm not convinced that's a bad thing. Overall patchwork has

Re: [PATCH] models: Don't munge the 'From' field of patches

Hi Doug, I can put it on my list of things and try to get to it over the next few weeks. If we can come up with a simple solution then it will be easier to find time. ;) So I think that the two simple solutions I can think of are one of these two: 1. Just add a From field in the

Re: [PATCH] Django 1.5 compatibility fixes

Hi Ralf, Django 1.5 wants plenty of quotes scattered over the templates. Looks good, but any ideas if we can get this to work with 1.4? The testsuite now seems to barf on not being able to find matching views (as it's doing lookups *with* the single quotes)... If not, I'll do some digging next

Re: [PATCH] Django 1.5 compatibility fixes

Hi Ralf, The single quotes seem to be what is officially recommended. There seems to be a way to make older Django versions require the quotes as well by doing {% load url from future %}, see also http://django.readthedocs.org/en/latest/releases/1.5.html: Okay, I've applied your patches;

Re: Patches with only renames are missing in patchwork

Hi all, Ah, yep, patchwork won't recognise this as a patch as it doesn't have any hunks in the @@-style format. I'll add this support to the parser over the weekend. Okay, this should work now: http://git.ozlabs.org/?p=patchwork;a=commitdiff;h=3dbec78 Let me know if you have any problems.

Re: [PATCH] Add a config option to FORCE_HTTPS_LINKS

Hi Konstantin, In situations where SSL is terminated at the load-balancer, we cannot rely on guessing the scheme based on whether patchwork itself was accessed via http or https, since the last-leg is always going to be done over http. Unfortunately, wrongly using http:// URLs results in

Re: filtering email?

Hi Kumar, However, was wondering if there was (or could easily be added) the ability to only have a patchworks project filter email based on some regex. For example, we'd like to setup a patchworks project for device tree bindings so we want the project only to track patches that touch

Re: filtering email?

Hi Kumar, Yes, that would be great. OK, I'll get it set up. It might be next week before I can get it done though. Where is the arm setup hosted ? The IMX folks have their patchwork instance at: http://patchwork.ozlabs.org/project/linux-imx/list/ Cheers, Jeremy

Re: Make Acked/Reviewd/Tested-by tags visible

Hi Yann, We would like to suggest that the web GUI and the pwclient CLI both display such tags besides each patch, a bit like (hypotetical output of pwclient): ID Tags State Subject 123456 ART New Wonderfull patch to apply quickly I've been looking to implement

Re: [U-Boot] patchwork does not pick my patch

Hi all, On 11/21/2013 12:14 PM, Masahiro Yamada wrote: Hi. I posted a patch to change a file permission. This: http://lists.denx.de/pipermail/u-boot/2013-November/167573.html and again: http://lists.denx.de/pipermail/u-boot/2013-November/167608.html But my patch would not appear on

Re: [PATCH 1/3] Fix post-receive hook to not update the previously pushed commit

Hi Carl, Previously, the post-receive hook would always examine one commit that had been previously pushed, (when the purpose of the hook is only to example newly-pushed commits). We fix this by simply dropping the '^' in the commit-range specification. Thanks for the series; I've applied it

Re: [RFC] parsemail.py: Don't search for patches in replies

Hi Markus, Make sure we don't attempt to search for a patch in a reply e-mail. There are MUAs out there who leave the quoted e-mail intact without prepending quote characters such as at the beginning of each line. D'oh! When that happens, parse_patch() thinks the quoted patch is new. The

Re: Bug tracker?

Hi Gary, Does patchwork have a bug tracker somewhere? This mailing list has been sufficient so far; we don't have the bug report volume to justify a bug tracker at this stage. I'm experimenting with it and I found what is probably a bug (in that bundle URLs don't work if a bundle name

Re: ordering by submitter, then date

Hi Bjorn, I use the order-by-submitter view, e.g., http://patchwork.ozlabs.org/project/linux-pci/list/?order=submitter, to weed out superseded patches. This would be easier if I could use two sort keys: first by submitter, then by date. Right now, they are ordered by submitter, but

Re: Bug tracker?

Hi Albert, git clone git://ozlabs.org/~jk/patchwork This command won't work. I believe that the right git clone command should use another URI: Sorry about that! I've fixed the issue, the original URL should work now. Cheers, Jeremy ___

Re: Using From to start commit message

Hi Thierry, I've noticed something strange happening when a commit message starts with the word From. When downloading the commit as mbox, I see that the line is escaped using a '' character, which causes git am to ignore the line. This can be seen in the following patch for example:

Re: Prevent anonymous users from viewing patchwork

Hi Joon, We are currently testing patchwork for internal company use. We would like anonymous users not to be able to view the patchwork site at all. However, I cannot seem to find how to do this. Any help would be appreciated. There's no facility in the patchwork code itself to do this, but

Re: Patches spontaneously changing ownership

Hi Ralf, Earlier today I submitted a patch to my own patchwork which did show up as submitted by user root - but my email address. Turned out the root account which I'm only using for django and my normal patchwork account ralf where both using the same email address and I think that

Re: Make Acked/Reviewd/Tested-by tags visible

Hi Yann, How's this look? http://ozlabs.org/~jk/tmp/patchwork-ART.png Just a little reminder on this... When are you planning on deploying that? Will it also show up in the output of pwclient? I've just rolled out the initial code to patchwork.ozlabs.org. The tag counts are all at

Re: Make Acked/Reviewd/Tested-by tags visible

Hi all, I've just rolled out the initial code to patchwork.ozlabs.org. The tag counts are all at zero to start with; I've triggered a re-parse of all of the existing comments, so the counts should reflect reality when that process finishes. On second thoughts, I've disabled the display of

Re: Make Acked/Reviewd/Tested-by tags visible

Hi Yann, How and when are the tags parsed? They should be parsed when the original patch is received, and when any follow-ups are appended to the patch. However: I noticed that (in the Buildroot patchwork [0]) some tags were not accounted for: http://patchwork.ozlabs.org/patch/354654/

Re: [pull request] Pull request for branch yem/pwclient

Hi Yann, As I previosuly explained [0], it is not really convenient to use pwclient when dealing with different projects hosted on different servers. Here is an attempt to change the format of pwclientrc so it is easier to manage such scatered-around projects. Oh awesome, I've always

Re: [PATCH] Fallback to common charsets when charset is None or x-unknown

Hi Siddesh, We recently encountered a case in our glibc patchwork instance on sourceware, where a patch was dropped because it had x-unknown charset. I used the following patch to fix this in our instance. The fix I used was to fall back on a set of encodings (instead of just utf-8) when the

Re: [PATCH] post-receive: exclude commits from the patch update step

Hi Brian, When merging upstream work related to other projects into your own project repository, you probably don't want to check for (and try to update) the status on every change-set in the merge. So add a list of references (branches, tags, commits, etc.) whose commits should be ignored in

Re: [pull request v2] Pull request for branch yem/pwclient

Hi Yann, On 2014-07-01 20:14 +0200, Yann E. MORIN spake thusly: Here is an attempt to change the format of ~/.pwclientrc so it is easier to manage such scatered-around projects. Does this new series address your concerns about the previous one? Do you have additional comments? This looks

Re: [PATCH] Fallback to common charsets when charset is None or x-unknown

Hi Siddesh, We recently encountered a case in our glibc patchwork instance on sourceware, where a patch was dropped because it had x-unknown charset. I used the following patch to fix this in our instance. The fix I used was to fall back on a set of encodings (instead of just utf-8) when

[PATCH] parsemail: Fallback to common charsets when charset is None or x-unknown

or if it is set as x-unknown. Minor changes and testcase by Jeremy Kerr j...@ozlabs.org Signed-off-by: Siddhesh Poyarekar siddh...@redhat.com Signed-off-by: Jeremy Kerr j...@ozlabs.org --- apps/patchwork/bin/parsemail.py | 40 - apps/patchwork/tests/mail/0010-invalid

  1   2   >