Re: [PATCH 04/10] models: Add 'status' model

2015-07-29 Thread Thomas Monjalon
Hi Stephen, Thanks for your good work. 2015-07-29 09:58, Stephen Finucane: +class Status(models.Model): +Status for a patch. + +Statuses define a state for patches. This is useful, for example, +when using a continuous integration (CI) system to test patches. + There is

Re: [PATCH 00/10] Add support for tests statuses

2015-07-29 Thread Thomas Monjalon
Hi Thomas, 2015-07-29 11:53, Thomas Petazzoni: On Wed, 29 Jul 2015 09:58:38 +0100, Stephen Finucane wrote: This series introduces support for patch statuses. These are results of tests and other automated checks executed on any given patch. Such tests and checks can range from unit tests

Re: [PATCH 04/10] models: Add 'status' model

2015-07-29 Thread Thomas Monjalon
2015-07-29 13:33, Finucane, Stephen: Having State and Status is confusing. What about getting rid of State? :) I haven't found any public patchwork project that modifies the default list of states, so I think a static choices field on 'Patch' would be a better option. I actually have a

Re: distributed tests of a patch

2015-07-23 Thread Thomas Monjalon
Hi, Thanks Thomas Herbert and Stephen Finucane for the help and the previous offline discussions. 2015-07-23 10:13, Thomas F Herbert: Second: We will add a column to the main page showing test status for each patch ID with three counts for Success/Warning/Error Third: We will be updating

Re: Feature request: delegating patches to others than maintainers

2015-07-20 Thread Thomas Monjalon
2015-07-20 15:27, Thomas Petazzoni: Currently, Patchwork only allows to delegate patches to developers who are registered as maintainers of the project in Patchwork. This is a bit annoying as maintainers in the Patchwork sense have the power to change the state of *any* patch. In the

Re: distributed tests of a patch

2015-10-28 Thread Thomas Monjalon
2015-09-24 13:57, Damien Lespiau: > On Thu, Sep 24, 2015 at 02:34:10PM +0200, Thomas Monjalon wrote: > > 2015-09-24 12:01, Damien Lespiau: > > > On Thu, Jul 23, 2015 at 01:26:22AM +0200, Thomas Monjalon wrote: > > > > When refreshing one of these views,

Re: distributed tests of a patch

2015-08-25 Thread Thomas Monjalon
2015-08-19 11:33, Damien Lespiau: patchwork know about series first though, otherwise I don't think it makes much sense to test patches in isolation. I think it makes sense to test every patches in a series. Though I agree we need a simple method to apply previous patches of the series. A

Re: [PATCH 00/51] Series aware patchwork

2015-09-14 Thread Thomas Monjalon
Hi, 2015-09-11 16:54, Damien Lespiau: > Here a few initial patches to make patchwork understand series instead of just > patches. This is not the end of the story, but a minimal-ish start to build > upon. What the series does: > > - Parse mails and creates Series objects (what you would expect

[PATCH] models: Allow to unselect maintainer projects in user profile

2016-01-30 Thread Thomas Monjalon
The admin page for user profiles have a field "Maintainer projects" to grant maintainer rights to an user. It is a list of available projects. When a project was selected, it was impossible to revoke. It is now possible to unselect by clicking while holding the "Ctrl" key. S

Re: Feedback on recent Patchwork update

2016-04-26 Thread Thomas Monjalon
2016-03-29 11:22, Finucane, Stephen: > I think the recently merged "shift-select" patch will help [4]. To > summarise, this lets you use the shift key to select a range of > patches and is, to me, a clear usability boost. As for the general > spacing, let's see if we can compress this further

Re: [PATCH] Improve documentation of delegation rules

2017-02-08 Thread Thomas Monjalon
nd both 'a' and 'b' are valid folder names. The risk of false > positives might be small, but it's enough to discourage us from doing > this. > > Signed-off-by: Stephen Finucane <step...@that.guru> > Cc: Thomas Monjalon <thomas.monja...@6wind.co

[PATCH] lib: Refresh nginx/uwsgi configuration

2016-09-06 Thread Thomas Monjalon
cally [...] ancient uWSGI versions used to support the so called “uwsgi_modifier1 30” approach. Do not do it. it is a really ugly hack " Replacing the uwsgi_modifier1 hack by a mount point seems to work. Signed-off-by: Thomas Monjalon <thomas.monja...@6wind.com> --- lib/nginx/patchwork

Re: [PATCH 01/10] stick django version to 1.8

2016-09-06 Thread Thomas Monjalon
Hi, 2016-08-28 15:06, Daniel Axtens: > Hi, > > WEN Pingbo writes: > > > Avoiding below error: > > django.db.utils.ProgrammingError: relation "patchwork_state" does not exist > > LINE 1: ...dering", "patchwork_state"."action_required" FROM "patchwork... > > Interesting.

filter not delegated patches

2016-09-14 Thread Thomas Monjalon
Hi, I was using a very convenient feature in the old patchwork that I cannot find in the version 1.1: In the filter box, the delegate field can be filled on completion only. It would be more convenient to list the possible values in the drop-down (i.e. people who had some patches delegated to

Re: manual delegation to any user as an option

2016-09-10 Thread Thomas Monjalon
2016-09-09 20:39, Stephen Finucane: > On 08 Sep 17:41, Thomas Monjalon wrote: > > Hi, > > > > I would like to talk about the following commit: > > Allow assigning of any user as delegate > > https://github.com/getpatchwork/patchwork/commit/e0fd7cd91a5

[PATCH 4/4] ui: Reduce size of quoted comments

2016-09-08 Thread Thomas Monjalon
The quoted comments are already written in the previous comment. Being smaller (in addition to be green) makes them easier to visually skip. Signed-off-by: Thomas Monjalon <thomas.monja...@6wind.com> --- htdocs/css/style.css | 2 ++ 1 file changed, 2 insertions(+) diff --git a/htdo

[PATCH 3/4] ui: Shrink vertical space

2016-09-08 Thread Thomas Monjalon
Reduce some vertical padding/margin and remove some useless titles in list.html and patch.html. Signed-off-by: Thomas Monjalon <thomas.monja...@6wind.com> --- htdocs/css/style.css | 10 +- patchwork/templates/patchwork/list.html | 2 -- patchwork/tem

[PATCH 0/4] small UI improvements

2016-09-08 Thread Thomas Monjalon
the third one "Shrink vertical space". Don't worry, it's just a UI proposal ;) Thomas Monjalon (4): ui: Align patch row with checkbox vertically ui: Align patch form with above metadata ui: Shrink vertical space ui: Reduce size of quoted comments htdocs/css

encoding error when parsing email

2016-09-15 Thread Thomas Monjalon
Hi, Sometimes we receive some patches with a strange character in a header "Received:" so the patch is not parsed in patchwork. I have not yet investigated where the script is failing, but I just want to ask first if there is a work in progress about this issue? And could it be fixed by removing

Re: [PATCH v6 1/2] parsemail: Convert to a management command

2016-09-21 Thread Thomas Monjalon
Hi, 2016-09-20 00:08, Stephen Finucane: > On 20 Sep 01:22, Daniel Axtens wrote: > > So, umm, I went ahead and had a crack at this. > > > > It turns out this is hideously difficult to get right. But this plus my > > other patch to fix Thomas' problem should have things working on Py2 and > > Py3

Re: [PATCH 01/10] stick django version to 1.8

2016-09-07 Thread Thomas Monjalon
2016-09-07 10:42, Daniel Axtens: > >> > --- a/requirements-prod.txt > >> > +++ b/requirements-prod.txt > >> > @@ -1,2 +1,2 @@ > >> > -Django>=1.8,<1.10 > >> > +Django>=1.8,<1.9 > > > > Unfortunately, the requirement <1.9 does not download Django 1.8 > > but a release candidate of the version 1.9.

Re: [PATCH 5/5] docs: Add delegation guide

2016-11-28 Thread Thomas Monjalon
Hi, 2016-10-11 19:01, Stephen Finucane: > We do autodelegation - let's tell people all about it. I am reading this documentation at https://patchwork.readthedocs.io/en/latest/usage/delegation/ I have two questions about this feature. Is the path starting with a slash? What happens if a file

[PATCH 2/3] pwclient: Support proxy configuration

2016-12-09 Thread Thomas Monjalon
clib has a different signature and behaviour in Python 2 and 3. Fixes #47 Signed-off-by: Thomas Monjalon <thomas.monja...@6wind.com> --- patchwork/bin/pwclient | 24 1 file changed, 24 insertions(+) diff --git a/patchwork/bin/pwclient b/patchwork/bin/pwclient ind

[PATCH 3/3] pwclient: Fix Python 3 encoding of received strings

2016-12-09 Thread Thomas Monjalon
The conversion encode("utf-8") makes a byte stream which is poorly printed with Python 3. However this encoding is required for Popen.communicate() but must be done after str.join() which applies to a real string. Signed-off-by: Thomas Monjalon <thomas.monja...@6wind.com> --

[PATCH 0/3] pwclient: python 3 and proxy support

2016-12-09 Thread Thomas Monjalon
but it works for me. These patches were tested with patchwork 1.1 and ported to the master branch. If they are accepted, a backport on 1.1 would be greatly appreciated. Thanks Thomas Monjalon (3): pwclient: Rework HTTP authentication pwclient: Support proxy configuration pwclient: Fix

[PATCH] views: Add List-Id to mbox

2016-12-11 Thread Thomas Monjalon
The List-Id header is retrieved from the Project object. Fixes #53 Signed-off-by: Thomas Monjalon <thomas.monja...@6wind.com> --- patchwork/views/__init__.py | 1 + 1 file changed, 1 insertion(+) diff --git a/patchwork/views/__init__.py b/patchwork/views/__init__.py index 58fb29f..d

Re: [PATCH] pwclient: Fix encoding problems

2016-12-15 Thread Thomas Monjalon
HONIOENCODING > environment variable. If no encoding is defined, assume 'utf-8' as > output encoding. > > Signed-off-by: Robin Jarry <robin.ja...@6wind.com> It works with Python 2 and 3 on my machine. Thanks Robin. Tested-by: Thomas Monjalon <thomas.monja...@6wind.co

[PATCH v2 0/3] pwclient: python 3 and proxy support

2016-12-13 Thread Thomas Monjalon
but it works for me. These patches were tested with patchwork 1.1 and ported to the master branch. If they are accepted, a backport on 1.1 would be greatly appreciated. Thanks Thomas Monjalon (3): pwclient: Rework HTTP authentication pwclient: Support proxy configuration pwclient: Fix

[PATCH v2 3/3] pwclient: Fix Python 3 encoding of received strings

2016-12-13 Thread Thomas Monjalon
The conversion encode("utf-8") makes a byte stream which is poorly printed with Python 3. However this encoding is required for Popen.communicate() but must be done after str.join() which applies to a real string. Signed-off-by: Thomas Monjalon <thomas.monja...@6wind.com> Revi

[PATCH v2 2/3] pwclient: Support proxy configuration

2016-12-13 Thread Thomas Monjalon
clib has a different signature and behaviour in Python 2 and 3. Fixes #47 Signed-off-by: Thomas Monjalon <thomas.monja...@6wind.com> Reviewed-by: Stephen Finucane <step...@that.guru> --- patchwork/bin/pwclient | 24 1 file changed, 24 insertions(+) diff

Re: [PATCH] views: Add List-Id to mbox

2016-12-12 Thread Thomas Monjalon
2016-12-12 11:12, Stephen Finucane: > On Sun, 2016-12-11 at 12:39 +0100, Thomas Monjalon wrote: > > The List-Id header is retrieved from the Project object. > > > > Fixes #53 > > > > Signed-off-by: Thomas Monjalon <thomas.monja...@6wind.com> >

Re: [PATCH v2 3/3] pwclient: Fix Python 3 encoding of received strings

2016-12-15 Thread Thomas Monjalon
2016-12-13 11:37, Thomas Monjalon: > The conversion encode("utf-8") makes a byte stream which is > poorly printed with Python 3. [...] > for patch_id in non_empty(h, patch_ids): > s = rpc.patch_get_mbox(patch_id) >

Re: [PATCH] docs: Document the various management commands available

2017-05-30 Thread Thomas Monjalon
30/05/2017 17:15, Stephen Finucane: > As requested. > > Signed-off-by: Stephen Finucane <step...@that.guru> > Reported-by: Thomas Monjalon <thomas.monja...@6wind.com> > Closes-bug: #77 Thanks Stephen > + ./manage.py cron > + > +Run periodic Patchwork func