Re: [PATCH v4] api: Add comments to patch and cover endpoints

2018-04-27 Thread Veronika Kabatova
, 2018-04-25 at 19:33 +0200, vkaba...@redhat.com wrote: > > From: Veronika Kabatova <vkaba...@redhat.com> > > > > Signed-off-by: Veronika Kabatova <vkaba...@redhat.com> > > Two comments below. I've actually addressed these already with my own > patch. Assuming you

Re: [PATCH] skip original Content-Transfer-Encoding for mbox

2018-05-07 Thread Veronika Kabatova
since the Content-Transfer-Encoding header is added based on the charset (which we pass on message creation), skipping the original header is both the easiest and correct way to solve this problem. Acked-by: Veronika Kabatova <vkaba...@redhat.com> > --- > patchwork/views/utils.py | 2 +

Re: [PATCH v4] api: Add comments to patch and cover endpoints

2018-05-02 Thread Veronika Kabatova
- Original Message - > From: "Daniel Axtens" <d...@axtens.net> > To: "Veronika Kabatova" <vkaba...@redhat.com> > Cc: patchwork@lists.ozlabs.org > Sent: Wednesday, May 2, 2018 6:22:34 PM > Subject: Re: [PATCH v4] api: Add comments to pat

Re: [PATCH v4] api: Add comments to patch and cover endpoints

2018-04-30 Thread Veronika Kabatova
nging "pk" to unique identifiers fixes it for me. Can you verify it does so on your instance as well? I'll send a patch if it does. Thanks, Veronika > Regards, > Daniel > > vkaba...@redhat.com writes: > > > From: Veronika Kabatova <vkaba...@redhat.com>

Re: [PATCH] Avoid timezone confusion

2018-01-15 Thread Veronika Kabatova
Hi! - Original Message - > From: "Daniel Axtens" <d...@axtens.net> > To: vkaba...@redhat.com, patchwork@lists.ozlabs.org > Sent: Monday, January 15, 2018 1:52:33 AM > Subject: Re: [PATCH] Avoid timezone confusion > > vkaba...@redhat.com writes: >

Re: [PATCH v2] Avoid timezone confusion

2018-01-18 Thread Veronika Kabatova
9:18 +, Stephen Finucane wrote: > > On Tue, 2018-01-16 at 18:58 +0100, vkaba...@redhat.com wrote: > > > From: Veronika Kabatova <vkaba...@redhat.com> > > > > > > Patchwork saves patches, comments etc with UTC timezone and reports > > > this time w

Re: [PATCH] Implement list filtering

2018-01-31 Thread Veronika Kabatova
- Original Message - > From: "Stephen Finucane" > To: "Daniel Axtens" , "Don Zickus" > Cc: patchwork@lists.ozlabs.org > Sent: Wednesday, January 31, 2018 11:25:03 AM > Subject: Re: [PATCH] Implement list filtering > > On Wed,

Re: [PATCH] Implement list filtering

2018-02-05 Thread Veronika Kabatova
- Original Message - > From: "Daniel Axtens" > To: vkaba...@redhat.com, patchwork@lists.ozlabs.org > Sent: Monday, February 5, 2018 4:24:21 PM > Subject: Re: [PATCH] Implement list filtering > > Hi Veronika, > > So, having been convinced of the merits of this approach,

Re: [PATCH v2] Avoid timezone confusion

2018-02-13 Thread Veronika Kabatova
- Original Message - > From: "Daniel Axtens" <d...@axtens.net> > To: "Veronika Kabatova" <vkaba...@redhat.com>, "Stephen Finucane" > <step...@that.guru> > Cc: patchwork@lists.ozlabs.org > Sent: Tuesday, February 13, 2018

Re: [PATCH] Fix CRLF newlines upon submission changes

2018-02-07 Thread Veronika Kabatova
; commit message would be fine. > Hi, I'll add it and resend v2 later today. > Would you like this queued up for the 2.0.2 stable release? > Sure, the more issues fixed for stable releases, the better. Veronika > Regards, > Daniel > > > Signed-off-by: Veronika Kaba

Re: [PATCH v3] Avoid timezone confusion

2018-02-23 Thread Veronika Kabatova
- Original Message - > From: "Daniel Axtens" > To: vkaba...@redhat.com, patchwork@lists.ozlabs.org > Sent: Friday, February 23, 2018 3:44:25 PM > Subject: Re: [PATCH v3] Avoid timezone confusion > > Hi Veronika, > > I have become briefly sidetracked by Docker's default

Re: Subject match filtering - followup patch request

2018-03-08 Thread Veronika Kabatova
- Original Message - > From: "Daniel Axtens" > To: vkaba...@redhat.com, patchwork@lists.ozlabs.org > Sent: Thursday, March 8, 2018 12:38:22 PM > Subject: Subject match filtering - followup patch request > > Hi Veronika, > Hi, > I tried to use the subject match filter

Re: [PATCH v3] Avoid timezone confusion

2018-03-07 Thread Veronika Kabatova
e9c6f8 > Awesome, thanks! I think you missed Stephen's Reviewed-by [1] in the commit. It doesn't matter too much to me, just wanted to bring it up in case he'd like it there :) [1] https://patchwork.ozlabs.org/patch/876744/#1864659 Thanks again, Veronika > Thanks again for your contributions to patchwork!

Re: [PATCH 0/2] Patchwork 2.1.0-rc1: Extra Special OzLabs Edition

2018-04-06 Thread Veronika Kabatova
- Original Message - > From: "Daniel Axtens" > To: patchwork@lists.ozlabs.org > Sent: Thursday, April 5, 2018 7:02:59 PM > Subject: [PATCH 0/2] Patchwork 2.1.0-rc1: Extra Special OzLabs Edition > > TL;DR: I want to spin a new version of patchwork for OzLabs so they can

Re: [PATCH] Use parsed subject for mboxes

2018-04-10 Thread Veronika Kabatova
- Original Message - > From: "Stephen Finucane" <step...@that.guru> > To: "Veronika Kabatova" <vkaba...@redhat.com>, "Daniel Axtens" > <d...@axtens.net> > Cc: patchwork@lists.ozlabs.org > Sent: Monday, April 9, 2018

Re: [PATCH] Add comments REST API

2018-04-10 Thread Veronika Kabatova
- Original Message - > From: "Daniel Axtens" <d...@axtens.net> > To: "Stephen Finucane" <step...@that.guru>, "Veronika Kabatova" > <vkaba...@redhat.com> > Cc: patchwork@lists.ozlabs.org > Sent: Tuesday, April 10, 2018 4:56:

Re: [PATCH] Include all email headers in mboxes

2018-04-05 Thread Veronika Kabatova
- Original Message - > From: "Daniel Axtens" <d...@axtens.net> > To: vkaba...@redhat.com, patchwork@lists.ozlabs.org > Sent: Thursday, April 5, 2018 11:58:15 AM > Subject: Re: [PATCH] Include all email headers in mboxes > > vkaba...@redhat.com writ

Re: [PATCH] Include all email headers in mboxes

2018-04-05 Thread Veronika Kabatova
all email headers in mboxes > > Johannes Berg <johan...@sipsolutions.net> writes: > > > On Thu, 2018-04-05 at 19:58 +1000, Daniel Axtens wrote: > >> vkaba...@redhat.com writes: > >> > >> > From: Veronika Kabatova <vkaba...@redhat.com> >

Re: [RFC 0/2] Rework tagging infrastructure

2018-04-11 Thread Veronika Kabatova
8 +0100, vkaba...@redhat.com wrote: > > From: Veronika Kabatova <vkaba...@redhat.com> > > I'm going to review this this week. However, this doesn't apply cleanly > to head of master any more (sorry :(). Any chance you could send > updated versions of these? > Will

Re: [PATCH] Use parsed subject for mboxes

2018-04-09 Thread Veronika Kabatova
- Original Message - > From: "Daniel Axtens" > To: "Stephen Finucane" , patchwork@lists.ozlabs.org > Sent: Sunday, April 8, 2018 5:21:48 AM > Subject: Re: [PATCH] Use parsed subject for mboxes > > Stephen Finucane writes: > > >

Re: [PATCH] Add comments REST API

2018-04-09 Thread Veronika Kabatova
kaba...@redhat.com wrote: > > From: Veronika Kabatova <vkaba...@redhat.com> > > > > Signed-off-by: Veronika Kabatova <vkaba...@redhat.com> > Thanks for feedback! > Looks pretty good. As you note, it does need some tests. I'm also > curious about the idea of nesti

Re: [PATCH] tests: Replace incorrect tests

2018-04-17 Thread Veronika Kabatova
Replace incorrect tests > > In commit 683792d1, the 'test_api.py' was split into multiple > 'api/test_xyz.py' files. As part of this change, the tests for cover > letter were mistakenly included in place of tests for checks. Correct > this oversight. > > Signed-off-by: Stephen

Re: [PATCH] tests: Replace incorrect tests

2018-04-17 Thread Veronika Kabatova
- Original Message - > From: "Stephen Finucane" <step...@that.guru> > To: "Veronika Kabatova" <vkaba...@redhat.com> > Cc: patchwork@lists.ozlabs.org > Sent: Tuesday, April 17, 2018 11:51:24 AM > Subject: Re: [PATCH] tests: Replace incorre

Re: [RFC 0/2 REBASE] Rework tagging infrastructure

2018-04-17 Thread Veronika Kabatova
- Original Message - > From: "Veronika Kabatova" <vkaba...@redhat.com> > To: "Stephen Finucane" <step...@that.guru> > Cc: patchwork@lists.ozlabs.org > Sent: Monday, April 16, 2018 3:06:34 PM > Subject: Re: [RFC 0/2 REBASE] Rework tag

Re: [RFC 0/2 REBASE] Rework tagging infrastructure

2018-04-17 Thread Veronika Kabatova
- Original Message - > From: "Stephen Finucane" <step...@that.guru> > To: "Veronika Kabatova" <vkaba...@redhat.com> > Cc: patchwork@lists.ozlabs.org > Sent: Tuesday, April 17, 2018 5:46:12 PM > Subject: Re: [RFC 0/2 REBASE] Rework tagging

Re: [RFC 0/2 REBASE] Rework tagging infrastructure

2018-04-17 Thread Veronika Kabatova
- Original Message - > From: "Stephen Finucane" <step...@that.guru> > To: "Veronika Kabatova" <vkaba...@redhat.com> > Cc: patchwork@lists.ozlabs.org > Sent: Tuesday, April 17, 2018 5:17:19 PM > Subject: Re: [RFC 0/2 REBASE] Rework tagging

Re: [PATCH 0/5] Random API improvements

2018-04-16 Thread Veronika Kabatova
- Original Message - > From: "Stephen Finucane" <step...@that.guru> > To: "Veronika Kabatova" <vkaba...@redhat.com> > Cc: patchwork@lists.ozlabs.org > Sent: Saturday, April 7, 2018 6:55:10 PM > Subject: Re: [PATCH 0/5] Random API impr

Re: [RFC 0/2 REBASE] Rework tagging infrastructure

2018-04-16 Thread Veronika Kabatova
t 17:24 +0200, vkaba...@redhat.com wrote: > > From: Veronika Kabatova <vkaba...@redhat.com> > > > > (TL;DR at the end) > > > > This RFC describes an approach to rework tagging. It attempts to solve > > GitHub > > issues #57 [1] and #113 [2] as well as

Re: [PATCH v2 1/2] api: Add comments to patch and cover endpoints

2018-04-16 Thread Veronika Kabatova
, 2018-04-11 at 19:45 +0200, vkaba...@redhat.com wrote: > > From: Veronika Kabatova <vkaba...@redhat.com> > > > > Signed-off-by: Veronika Kabatova <vkaba...@redhat.com> > > I thought I'd replied to this already but I clearly didn't. This all > looks pretty goo

Re: [RFC v2 1/1] Rework tagging infrastructure

2018-04-25 Thread Veronika Kabatova
t 18:36 +0200, vkaba...@redhat.com wrote: > > From: Veronika Kabatova <vkaba...@redhat.com> > > > > Solve #113 and #57 GitHub issues, fix up returning tags in the API, > > keep track of tag origin to later be able to add tags to comments in > > the API. >

Re: [PATCH v3] api: Add comments to patch and cover endpoints

2018-04-25 Thread Veronika Kabatova
, 2018-04-17 at 12:50 +0200, vkaba...@redhat.com wrote: > > From: Veronika Kabatova <vkaba...@redhat.com> > > > > Signed-off-by: Veronika Kabatova <vkaba...@redhat.com> > > --- > > New changes: move things under /patches|covers/ID/comments > > Almo

Re: [PATCH] Add comments REST API

2018-03-26 Thread Veronika Kabatova
- Original Message - > From: vkaba...@redhat.com > To: patchwork@lists.ozlabs.org > Cc: "Veronika Kabatova" <vkaba...@redhat.com> > Sent: Friday, March 23, 2018 1:33:38 PM > Subject: [PATCH] Add comments REST API > > From: Veronika Kabatova

Re: Patchwork 3: potential feature removals

2018-03-23 Thread Veronika Kabatova
- Original Message - > From: "Daniel Axtens" > To: patchwork@lists.ozlabs.org > Sent: Thursday, March 22, 2018 12:17:20 AM > Subject: Patchwork 3: potential feature removals > > Hi all, > Hi, > Patchwork is currently quite complex. This is adding to the bug surface >

Re: [PATCH v3] Avoid timezone confusion

2018-02-26 Thread Veronika Kabatova
s and > I will apply both at the same time. > I'll send an additional patch with releasnote changes and cc you so you can find it easily. > Regards, > Daniel > > vkaba...@redhat.com writes: > > > From: Veronika Kabatova <vkaba...@redhat.com> > > >

Re: [PATCH RESEND 1/2] Rework tagging infrastructure

2018-09-21 Thread Veronika Kabatova
- Original Message - > From: "Stephen Finucane" > To: "Veronika Kabatova" > Cc: patchwork@lists.ozlabs.org > Sent: Wednesday, September 19, 2018 11:38:32 PM > Subject: Re: [PATCH RESEND 1/2] Rework tagging infrastructure > > On Wed, 2018-09-1

Re: [PATCH] REST: Only list checks for the given patch

2018-09-19 Thread Veronika Kabatova
blem with the filter addition either. Reviewed-by: Veronika Kabatova > Signed-off-by: Stephen Finucane > Cc: Michael Ellerman > Closes: #203 > --- > patchwork/api/check.py| 3 ++- > patchwork/tests/api/test_check.py | 5 +++-- > 2 files changed, 5 insertions(+), 3 d

Re: [PATCH RESEND 2/2] Rework tagging infrastructure

2018-09-12 Thread Veronika Kabatova
0, vkaba...@redhat.com wrote: > > From: Veronika Kabatova > > > > Solve #113 and #57 GitHub issues, fix up returning tags in the API, > > keep track of tag origin to be able to add tags to comments in the API. > > > > Use relations Tag-Patch and Tag-CoverLetter to

Re: [PATCH v2 2/2] docs: Note new requirement to include a SPDX line

2018-09-17 Thread Veronika Kabatova
- Original Message - > From: "Stephen Finucane" > To: patchwork@lists.ozlabs.org > Sent: Monday, September 17, 2018 7:19:45 PM > Subject: Re: [PATCH v2 2/2] docs: Note new requirement to include a SPDX line > > On Mon, 2018-09-17 at 18:17 +0100, Stephen Finucane wrote: > > Add some

Re: [PATCH v3 2/2] docs: Note new requirement to include a SPDX line

2018-09-18 Thread Veronika Kabatova
- Original Message - > From: "Stephen Finucane" > To: patchwork@lists.ozlabs.org > Cc: "Stephen Finucane" , "Daniel Axtens" > , "Veronika Kabatova" > > Sent: Tuesday, September 18, 2018 5:46:16 PM > Subject: [PATCH v3 2/

Re: [PATCH RESEND 1/2] Rework tagging infrastructure

2018-09-12 Thread Veronika Kabatova
0, vkaba...@redhat.com wrote: > > From: Veronika Kabatova > > > > Solve #113 and #57 GitHub issues, fix up returning tags in the API, > > keep track of tag origin to be able to add tags to comments in the API. > > > > Use relations Tag-Patch and Tag-CoverLetter to

Re: [PATCH v2 2/2] docs: Note new requirement to include a SPDX line

2018-09-18 Thread Veronika Kabatova
- Original Message - > From: "Stephen Finucane" > To: "Veronika Kabatova" > Cc: patchwork@lists.ozlabs.org > Sent: Monday, September 17, 2018 11:24:11 PM > Subject: Re: [PATCH v2 2/2] docs: Note new requirement to include a SPDX line > > On

Re: [PATCH] Add help text to project and patch_project fields

2018-10-01 Thread Veronika Kabatova
; > On Sat, 2018-09-29 at 01:24 +1000, Daniel Axtens wrote: > > vkaba...@redhat.com writes: > > > > > From: Veronika Kabatova > > > > > > Duplication of the field to avoid performance issues caused some > > > unexpected results when moving patch

Re: [PATCH] Add help text to project and patch_project fields

2018-10-01 Thread Veronika Kabatova
- Original Message - > From: "Stephen Finucane" > To: "Veronika Kabatova" > Cc: "Daniel Axtens" , patchwork@lists.ozlabs.org > Sent: Monday, October 1, 2018 11:57:09 AM > Subject: Re: [PATCH] Add help text to project and patch_project